kata-irc-bot | <marcel> @fidencio re- ci-for-release/stable branches: wouldn't help if we move the test repository into the kata-containers one? I know there were discussion about that, do you know maybe the status today? | 12:09 |
---|---|---|
kata-irc-bot | <fidencio> Personally speaking I think I'd prefer having everything in a single place, and I'm more than willing to take the lead on this and have it merged there (preserving all the history and whatnot). | 12:11 |
kata-irc-bot | <fidencio> However, we have to start working on changing the scripts we use (all of those rely on having tests as a different repo) and, sincerely, I don't think this is the best we can do with our time right now. | 12:12 |
kata-irc-bot | <marcel> How much effort do you think it is? | 12:13 |
kata-irc-bot | <fidencio> Because it will help, but it won't help *that* much, mainly if we don't get used to actually do the backports of the things we work on ... or at least do backports once a week. | 12:13 |
kata-irc-bot | <marcel> we will then require the CI patches in the same PR with kata - like transactions | 12:13 |
kata-irc-bot | <fidencio> > How much effort do you think it is? I think I can pull that work on next week, working only on that (and I'd be happy to do so) | 12:14 |
kata-irc-bot | <fidencio> So, let me raise this as part of the AC meeting and take advantage that I have some free time before I go for vacation and bootstrap this work | 12:15 |
kata-irc-bot | <marcel> I can also contribute 3 days next week | 12:15 |
kata-irc-bot | <marcel> great, let's bring it up | 12:15 |
kata-irc-bot | <marcel> thanks! | 12:16 |
kata-irc-bot | <fidencio> no problemo! | 12:16 |
kata-irc-bot | <fidencio> @marcel, taking advantage you're around, have you seen https://github.com/kata-containers/govmm/issues/196? | 12:44 |
kata-irc-bot | <fidencio> As we're going to skip the CI checks when we end up merging the govmm repo into the kata-containers one, we should do as much as possible to mitigate known breakages that will happen | 12:44 |
kata-irc-bot | <fidencio> and the issue raised is one of the, at least IMHO, *must* actions | 12:45 |
kata-irc-bot | <marcel> No, I haven't, looking now | 12:52 |
kata-irc-bot | <marcel> Aha, so on top of David's PR? | 12:54 |
kata-irc-bot | <fidencio> No, before we do any work on David's PR we should enable those tests on the govmm | 12:56 |
kata-irc-bot | <fidencio> Ensure they pass there | 12:56 |
kata-irc-bot | <fidencio> And only after they pass on the govmm, then we do the import on kata-containers side | 12:57 |
kata-irc-bot | <fidencio> Otherwise those will break for the next PR opened after David's PR is merged :slightly_smiling_face: | 12:57 |
kata-irc-bot | <marcel> I meant - get David's PR and add a patch on top - same PR | 12:59 |
kata-irc-bot | <marcel> The reason is I don't know how much time David worked on the current PR | 13:00 |
kata-irc-bot | <fidencio> yeah, exactly, but the only way to test that for now is on the govmm repo itself | 13:01 |
kata-irc-bot | <fidencio> I don't know either, but we shouldn't rush a decision / a merge based on that | 13:02 |
kata-irc-bot | <marcel> :+1: | 13:02 |
kata-irc-bot | <jakob.naucke> Hey, do we have a process for editing the Community wiki? | 13:57 |
kata-irc-bot | <fidencio> Not that I'm aware of. | 13:59 |
kata-irc-bot | <jakob.naucke> So what, if I think something should be changed, I just…edit it? | 14:00 |
kata-irc-bot | <fidencio> Yep, what do you need to change? | 14:01 |
kata-irc-bot | <jakob.naucke> https://github.com/kata-containers/community/wiki/Controlling-the-CI, we now have `/(re)test-s390x` | 14:11 |
kata-irc-bot | <fidencio> Ah, just add :slightly_smiling_face: | 14:27 |
jimbob123 | Does kata 1.x no longer accept PRs? | 22:23 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!