*** egernst has joined #kata-dev | 01:02 | |
*** egernst has quit IRC | 01:08 | |
*** egernst has joined #kata-dev | 01:21 | |
*** egernst has quit IRC | 01:28 | |
*** egernst has joined #kata-dev | 01:29 | |
*** egernst_ has joined #kata-dev | 01:30 | |
*** egernst has quit IRC | 01:33 | |
*** egernst has joined #kata-dev | 01:34 | |
*** egernst__ has joined #kata-dev | 01:36 | |
*** egernst_ has quit IRC | 01:38 | |
*** egernst_ has joined #kata-dev | 01:38 | |
*** egernst has quit IRC | 01:40 | |
*** egernst__ has quit IRC | 01:41 | |
kata-irc-bot | <bergwolf> which action are you referring to? katsa-deploy test does run for each pushed 2.x tags. | 01:52 |
---|---|---|
*** egernst_ has quit IRC | 02:04 | |
*** egernst has joined #kata-dev | 02:13 | |
kata-irc-bot | <eric.ernst> Aren't we talking about :latest here Fabiano, @gmmaharaj? | 02:15 |
kata-irc-bot | <eric.ernst> I think latest was still getting up dated to include 1.x, but if you are explicit on the version you pull in your yaml, you'll get what you ask for. We should ensure 2.x stable is what is tagged for latest imo. | 02:16 |
kata-irc-bot | <eric.ernst> (sorry if i'm misremembering here) | 02:16 |
*** egernst has quit IRC | 02:46 | |
*** egernst has joined #kata-dev | 02:54 | |
*** egernst has quit IRC | 03:27 | |
*** egernst has joined #kata-dev | 03:27 | |
*** egernst has quit IRC | 03:47 | |
*** egernst has joined #kata-dev | 03:48 | |
*** egernst has quit IRC | 04:34 | |
*** sameo has joined #kata-dev | 05:15 | |
*** egernst has joined #kata-dev | 05:35 | |
*** egernst has quit IRC | 05:40 | |
*** fgiudici has joined #kata-dev | 06:32 | |
*** dklyle has quit IRC | 06:45 | |
*** pcaruana has joined #kata-dev | 06:57 | |
kata-irc-bot | <fidencio> @eric.ernst, yep, our 2.x releases didn't have a :tag, which means they were using :latest by default, and then users were using 1.x by default. Of course, you can go ahead and change that, but that's **not** documented, and that's the reason that pushed me to add the right tag before the release. | 07:23 |
*** jodh has joined #kata-dev | 07:33 | |
*** egernst has joined #kata-dev | 07:36 | |
*** egernst has quit IRC | 07:42 | |
*** davidgiluk has joined #kata-dev | 08:03 | |
kata-irc-bot | <fidencio> Folks, in order to move forward with the kata-deploy fixes, may I bother you with a review on https://github.com/kata-containers/kata-containers/pull/1641 ? | 08:11 |
*** snir_ has joined #kata-dev | 08:33 | |
kata-irc-bot | <fidencio> @james.o.hunt that's a massive amount of emails coming in. | 09:08 |
kata-irc-bot | <james.o.hunt> @fidencio - sorry about that. There isn't a way to stop it afaik. The good news is "I've finished" the mass operation: https://github.com/orgs/kata-containers/projects/23 :) | 09:11 |
kata-irc-bot | <fidencio> Now it'll be the next few days replying when the issue was closed, for those who're not part of the kata-dev ML. I wonder if, for the next time we do that, whether we can add a message pointing to the ML thread that has the explanation of the "whys" | 09:43 |
kata-irc-bot | <fidencio> Eric, by the way, one thing that I didn't understand Yesterday was that "issue_comment" and "pull_request" had different targets (the current content on the repo vs the PR being opened). | 10:40 |
*** khyr0n has quit IRC | 11:00 | |
*** khyr0n has joined #kata-dev | 11:01 | |
kata-irc-bot | <fidencio> Okay, with https://github.com/kata-containers/kata-containers/pull/1641 we're back at the point where we were a few months ago. The test does *not* work, and everyone who adds any comment will be get an email saying whether the comment did or did not match with what's expected. | 11:23 |
*** egernst has joined #kata-dev | 11:39 | |
*** egernst has quit IRC | 11:44 | |
*** devimc has joined #kata-dev | 12:28 | |
*** fuentess has joined #kata-dev | 12:59 | |
*** amorenoz has joined #kata-dev | 13:13 | |
*** crobinso has joined #kata-dev | 13:22 | |
*** dklyle has joined #kata-dev | 14:52 | |
*** sameo has quit IRC | 15:15 | |
kata-irc-bot | <fidencio> @eric.ernst: https://github.com/kata-containers/kata-containers/pull/1633#issuecomment-815004046 | 15:24 |
*** sameo has joined #kata-dev | 15:30 | |
*** sameo has quit IRC | 16:05 | |
*** th0din has quit IRC | 16:07 | |
*** th0din has joined #kata-dev | 16:13 | |
*** sameo has joined #kata-dev | 16:22 | |
*** fgiudici has quit IRC | 16:51 | |
kata-irc-bot | <fidencio> @gmmaharaj, you hit an issue on 2.0.1 or 2.0.2 because a patch was not backported, was that it? If so, do you happen to have the link for the PR? | 16:58 |
kata-irc-bot | <fidencio> @james.o.hunt, IIRC you commented in the PR, not sure if that rings a bell | 16:58 |
kata-irc-bot | <james.o.hunt> https://github.com/kata-containers/kata-containers/issues/1558, https://github.com/kata-containers/kata-containers/pull/1472. | 17:00 |
*** jodh has quit IRC | 17:02 | |
kata-irc-bot | <fidencio> @james.o.hunt, I'll backport the patch, thanks! | 17:04 |
*** sameo has quit IRC | 18:35 | |
kata-irc-bot | <gmmaharaj> @eric.ernst @bergwolf in my case atleast, I am referring to the fact that i was not able to find 2.0.2 tag in katadocker/kata-deploy. I assumed that part gets auto-triggered after we create a github tag | 18:38 |
kata-irc-bot | <fidencio> @gmmaharaj, okay, you were not able to find the 2.0.2 tag because the release was not finished due to an error that will be fixed as soon as I can get https://github.com/kata-containers/kata-containers/pull/1633 merged and backported | 18:55 |
kata-irc-bot | <fidencio> I think we tan try to simply roll a 2.0.3 and 2.1.0-alpha2 in Friday | 18:55 |
kata-irc-bot | <gmmaharaj> awesome. thanks @fidencio | 19:02 |
*** davidgiluk has quit IRC | 19:23 | |
*** devimc has quit IRC | 21:13 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!