| kata-irc-bot | <archana.m.shinde> Can we get another ack on this one : https://github.com/kata-containers/tests/pull/3122 | 00:04 |
|---|---|---|
| *** yyyeer has joined #kata-dev | 00:43 | |
| kata-irc-bot | <eric.ernst> the 'ol wait statement. | 01:03 |
| kata-irc-bot | <eric.ernst> well, timeout :slightly_smiling_face: | 01:03 |
| kata-irc-bot | <eric.ernst> lgtm | 01:03 |
| *** amorenoz has quit IRC | 01:03 | |
| *** amorenoz has joined #kata-dev | 01:04 | |
| *** jbryce has quit IRC | 01:24 | |
| *** ebb has quit IRC | 01:24 | |
| *** jbryce has joined #kata-dev | 01:30 | |
| *** ebb has joined #kata-dev | 01:30 | |
| *** sameo has joined #kata-dev | 08:04 | |
| *** sgarzare has joined #kata-dev | 08:05 | |
| *** jodh has joined #kata-dev | 08:05 | |
| *** fgiudici has joined #kata-dev | 08:26 | |
| *** davidgiluk has joined #kata-dev | 09:14 | |
| kata-irc-bot | <christophe> Waiting for a second ack on https://github.com/kata-containers/community/pull/192. Easy one, doc only. | 10:06 |
| *** yyyeer has quit IRC | 10:49 | |
| fidencio | jodh: ^^ can you take a look at that, please? | 11:12 |
| kata-irc-bot | <leevn2011> *@egernst Thanks! I can see the principle of Defense in depth is applied in this case.* | 11:18 |
| *** snir_ has joined #kata-dev | 12:36 | |
| *** snir has quit IRC | 12:40 | |
| *** crobinso has joined #kata-dev | 13:50 | |
| *** jodh has quit IRC | 13:55 | |
| *** fuentess has joined #kata-dev | 14:09 | |
| *** dklyle has quit IRC | 14:19 | |
| *** th0din has quit IRC | 15:36 | |
| *** dklyle has joined #kata-dev | 15:56 | |
| kata-irc-bot | <fidencio> @jose.carlos.venegas.m, @archana.m.shinde, @salvador.fuentes: can we go ahead and have this one pushed? https://github.com/kata-containers/tests/pull/3126 | 16:23 |
| kata-irc-bot | <jose.carlos.venegas.m> yes | 16:25 |
| kata-irc-bot | <jose.carlos.venegas.m> let me merge it | 16:25 |
| kata-irc-bot | <salvador.fuentes> with that merged, should we now have a stable CI ? or is anyone else seeing any other issue? | 16:31 |
| kata-irc-bot | <fidencio> @salvador.fuentes semi stable CI. I still could see: 1. https://github.com/kata-containers/tests/pull/3126#issuecomment-747305359 failing with containerd 2. Some random failures about the PV / PVC not being created on time on Fedora (Wainer submitted a patch, but I guess we failed after that already, at least once) 3. Maybe we'll need to change the disks to ephemeral to all k8s related jobs, as I saw some issues this morning as well | 16:34 |
| kata-irc-bot | <salvador.fuentes> thanks for the summary @fidencio, for 3) I have changed to ephemeral on all flavor configurations ~2h ago... let's see if that helps | 16:45 |
| kata-irc-bot | <fidencio> Then it's just a matter of us monitoring the PRs. Thanks a lot for the changes and help, @salvador.fuentes! | 16:46 |
| kata-irc-bot | <salvador.fuentes> yeah, let's continue monitoring the PRs, I'll have some time in the afternoon, so will check if I can reproduce 1) | 16:47 |
| kata-irc-bot | <fidencio> I've opened https://github.com/kata-containers/tests/issues/3061 for 1), some time ago. | 17:07 |
| kata-irc-bot | <salvador.fuentes> thanks for the pointer @fidencio | 17:28 |
| *** th0din has joined #kata-dev | 17:30 | |
| kata-irc-bot | <wmoschet> @salvador.fuentes @gabriela.cervantes.te Hi! I'm working on https://github.com/kata-containers/tests/issues/3119 , and I realized just now that maybe you guys have other plans for caching the artifacts...so should I keep going? | 17:58 |
| *** fgiudici has quit IRC | 18:00 | |
| kata-irc-bot | <gabriela.cervantes.te> @wmoschet no I do not have plans right now for caching the artifacts thanks | 18:02 |
| kata-irc-bot | <salvador.fuentes> hey @wmoschet, yeah, we haven't been able to take a loot at this, but as you said it is more complex to implement comparing to the 1.x artifacts. What is the approach that you have in mind | 18:04 |
| *** sgarzare has quit IRC | 18:04 | |
| kata-irc-bot | <wmoschet> @salvador.fuentes I just started so I kind still of investigating how it works. I believe it will be hard to check if the cache is dirty | 18:06 |
| kata-irc-bot | <salvador.fuentes> @wmoschet I was thinking in having latest commit of 2.0-dev cached, and then on every PR we'll need to check which parts of the code are being touched. If nothing that is cached is being touched, we can use them. but if it was touched, we'll need to build it. E.g. if the osbuilder/agent code is not touched, we can use the cached image. | 18:14 |
| kata-irc-bot | <wmoschet> @salvador.fuentes it seems a good idea | 18:17 |
| kata-irc-bot | <wmoschet> @salvador.fuentes I will start with qemu and kernel. Since they are versioned it is easier to compare | 18:25 |
| kata-irc-bot | <wmoschet> makes sense? | 18:25 |
| kata-irc-bot | <salvador.fuentes> yes, make sense, thanks @wmoschet | 18:49 |
| kata-irc-bot | <wmoschet> @salvador.fuentes could you give user "cpmeadors" access to add/remove labels and assign to himself on tests and kata-containers repos? | 20:04 |
| kata-irc-bot | <wmoschet> ^ @cmeadors | 20:04 |
| kata-irc-bot | <salvador.fuentes> sure | 20:04 |
| kata-irc-bot | <salvador.fuentes> @wmoschet @cmeadors done | 20:11 |
| kata-irc-bot | <cmeadors> @salvador.fuentes thanks | 20:11 |
| kata-irc-bot | <wmoschet> thanks @salvador.fuentes | 20:13 |
| *** davidgiluk has quit IRC | 20:35 | |
| kata-irc-bot | <fidencio> @archana.m.shinde, @eric.ernst, @salvador.fuentes, how do we produce the release artifacts? I was imagining we would have a `make dist` target in our Makefile, but that's not the case | 21:10 |
| kata-irc-bot | <eric.ernst> https://github.com/kata-containers/documentation/blob/master/Release-Process.md | 21:11 |
| kata-irc-bot | <fidencio> Does github generate you a tarball just by adding a new tag? | 21:13 |
| kata-irc-bot | <archana.m.shinde> new tag triggers this github action workflow: https://github.com/kata-containers/kata-containers/blob/master/.github/workflows/main.yaml | 21:15 |
| kata-irc-bot | <archana.m.shinde> which generates the tarball | 21:15 |
| kata-irc-bot | <fidencio> Ack! `build-kata-components` is the part of my interest, I guess, if I want to change something related to the kata-containers-2.x tarball, | 21:20 |
| kata-irc-bot | <archana.m.shinde> for 2.x. ptal at https://github.com/kata-containers/kata-containers/blob/2.0-dev/.github/workflows/release.yaml | 21:22 |
| kata-irc-bot | <fidencio> This is complex! | 21:28 |
| kata-irc-bot | <fidencio> Thanks a lot for the pointers, @eric.ernstand @archana.m.shinde. | 21:28 |
| kata-irc-bot | <fidencio> So, sorry if I'm too dense to understand this, but the bit you mentioned @archana.m.shinde, produces the tarball with our built binaries and whatnot. I'm wondering only about tarball containing the source code | 21:41 |
| kata-irc-bot | <archana.m.shinde> we dont have anything in place for the source code | 21:42 |
| kata-irc-bot | <fidencio> so, taking a step back. what does generate the tarball containing the source code? Is it automatically generated by github itself when a new tag is added? | 21:44 |
| kata-irc-bot | <fidencio> Basically I just pondering whether adding a `make dist` to vendor the code inside the tarball containing the release is worth it or not. | 22:15 |
| kata-irc-bot | <eric.ernst> i think github does this automagically when a tag is applied. | 22:17 |
| kata-irc-bot | <eric.ernst> we don't do this. | 22:18 |
| *** sameo has quit IRC | 23:08 | |
| *** crobinso has quit IRC | 23:23 | |
| *** fuentess has quit IRC | 23:53 | |
| *** fuentess1 has joined #kata-dev | 23:54 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!