Tuesday, 2020-02-18

*** igordc has quit IRC02:17
*** EricRen has joined #kata-dev02:25
*** EricRen has quit IRC04:46
*** EricRen has joined #kata-dev05:20
*** EricRen has quit IRC05:24
*** EricRen has joined #kata-dev06:16
*** dklyle has quit IRC07:15
*** dklyle has joined #kata-dev07:16
*** lpetrut has joined #kata-dev07:20
*** sameo has joined #kata-dev07:22
kata-irc-bot<xwlpt> Is there anyway to check the agent’s log on the host?07:32
kata-irc-bot<xwlpt> @graham.whaley @archana.m.shinde07:38
*** EricRen has quit IRC07:52
*** EricRen has joined #kata-dev07:54
*** sgarzare has joined #kata-dev08:14
*** pcaruana has joined #kata-dev08:29
*** davidgiluk has joined #kata-dev09:04
*** gwhaley has joined #kata-dev09:11
kata-irc-bot<graham.whaley> @xwlpt - I think so - if you enable agent debug (in the config file) and also proxy or shim debug (depending if you are using vsock or not), then I think you should get the agent logs mixed in with the proxy or shim log - I think.....09:19
kata-irc-bot<graham.whaley> so, I will ask you a favour @xwlpt - if you work it out, and it is not in the documentation already, maybe you can make a PR to add it? :slightly_smiling_face:09:20
kata-irc-bot<xwlpt> I am using shimv2,  do I still need to enable  shim debug?09:20
kata-irc-bot<xwlpt> Let me have a try, if it works, I will have a PR for it.09:21
kata-irc-bot<xu> I think, with shim-v2,  the logs could be feed to containerd's log, right?09:21
kata-irc-bot<xwlpt> @xu Not found any agent log from containerd’s log09:22
kata-irc-bot<xwlpt> Maybe I am missing something09:23
kata-irc-bot<graham.whaley> @xu - do you mean they *could* be passed to containerd logs, or they *are* passed to containerd logs? :slightly_smiling_face:09:23
kata-irc-bot<xu> @graham.whaley let me check :,)09:25
*** pcaruana has quit IRC09:30
kata-irc-bot<xwlpt> Not works for me  :crying_cat_face:09:35
kata-irc-bot<fupan> you should enabled it by add   “agent.log=debug ” to  kernel’s boot parameter in kata config09:39
kata-irc-bot<xwlpt> kernel_params = ” agent.log=debug,initcall_debug ”09:39
kata-irc-bot<xwlpt> I add these two09:40
kata-irc-bot<fupan> and then  set enable_debug = true  in  runtime section09:40
kata-irc-bot<fupan> oh,  I remember, the  containerd’s  debug setting will overrides the kata’s config setting, you should make your containerd  enabled debug09:42
kata-irc-bot<xu> @fupan I think we should have a document on this09:47
kata-irc-bot<fupan> yeah, I will send a PR to address this issue09:48
kata-irc-bot<xu> cool, thanks @fupan09:48
kata-irc-bot<graham.whaley> :thumbsup:09:55
kata-irc-bot<xwlpt> Feb 18 03:04:23 tess-node-sbtxw-3867512 kata[10883]: time=“2020-02-18T03:04:23.210290459-07:00” level=error msg=“Failed to read agent logs” ID=41be98283d17320282031ae7aa43c01c4079c36aea99302c3a3c3db2c7f14ec0 console-protocol=unix console-socket=/run/vc/vm/41be98283d17320282031ae7aa43c01c4079c36aea99302c3a3c3db2c7f14ec0/console.sock error=“read unix @->/run/vc/vm/41be98283d17320282031ae7aa43c01c4079c36aea99302c3a3c3db2c7f14ec0/con10:06
kata-irc-botuse of closed network connection” sandbox=41be98283d17320282031ae7aa43c01c4079c36aea99302c3a3c3db2c7f14ec0 source=virtcontainers subsystem=kata_agent10:06
kata-irc-bot<xwlpt> I get this error10:06
kata-irc-bot<xwlpt> >  oh,  I remember, the  containerd’s  debug setting will overrides the kata’s config setting, you should make your containerd  enabled debug10:07
kata-irc-bot<xwlpt> What you mean is: ```[plugins.linux]         shim_debug = true```10:08
kata-irc-bot<xwlpt> @fupan10:08
kata-irc-bot<xwlpt> If I add agent.debug_console to the boot param, there is no such kind of error. But I still can’t found any agent logs.10:09
kata-irc-bot<fupan> what hypervisor did you use? qemu  or firecracker?10:10
kata-irc-bot<xwlpt> qemu10:10
kata-irc-bot<fupan> that’s weird , it seems shimv2 try to fetch the agent log from /run/vc/vm/41be98283d17320282031ae7aa43c01c4079c36aea99302c3a3c3db2c7f14ec0/console.sock, but it closed.10:13
kata-irc-bot<xwlpt> @fupan Can you have a try whether this works in your env? If it works, I will check from my side. Thanks10:14
kata-irc-bot<fupan> yes, it worked from my side10:18
kata-irc-bot<fupan> sandbox=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 source=virtcontainers subsystem=kata_agent vmconsole=“time=\“2020-02-18T10:18:17.663412385Z\” level=debug msg=\“new request\” debug_console=false name=kata-agent pid=41 req= request=/grpc.Health/Check sandbox=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 source=agent” time=“2020-02-18T18:18:17.675113410+08:00” level=debug msg=“read10:18
kata-irc-botID=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 sandbox=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 source=virtcontainers subsystem=kata_agent vmconsole=“time=\“2020-02-18T10:18:17.663486439Z\” level=debug msg=\“request end\” debug_console=false duration=533ns name=kata-agent pid=41 request=/grpc.Health/Check resp=\“status:SERVING \” sandbox=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6c10:18
kata-irc-botsource=agent” time=“2020-02-18T18:18:18.674550051+08:00” level=info msg=“{\“execute\“:\“query-status\“}” ID=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 source=virtcontainers subsystem=qmp time=“2020-02-18T18:18:18.674721155+08:00" level=info msg=“{\“return\“: {\“status\“: \“running\“, \“singlestep\“: false, \“running\“: true}}” ID=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6cc10:18
kata-irc-botsubsystem=qmp time=“2020-02-18T18:18:18.674767336+08:00" level=debug msg=“sending request” ID=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 name=grpc.CheckRequest req= source=virtcontainers subsystem=kata_agent time=“2020-02-18T18:18:18.675051391+08:00" level=debug msg=“reading guest console” ID=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c06910:18
kata-irc-botsandbox=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 source=virtcontainers subsystem=kata_agent vmconsole=“time=\“2020-02-18T10:18:18.66339434Z\” level=debug msg=\“new request\” debug_console=false name=kata-agent pid=41 req= request=/grpc.Health/Check sandbox=b36d2ca71b45de8a493dc44321c3f4bd95463e440e00565d9b6ccb07d9a2c069 source=agent”10:18
kata-irc-bot<fupan> the  source=agent  lines are the logs from the agent10:19
kata-irc-bot<xwlpt> Thanks10:21
kata-irc-bot<fupan> did you do any change to the kernel  boot parameters except adding  agent.log=debug?10:22
kata-irc-bot<xwlpt> Not any other changes.10:23
kata-irc-bot<xwlpt> I found that there is no level=debug info in the logs.10:23
kata-irc-bot<xwlpt> I need to enable this? ```[plugins.linux]         shim_debug = true``` right?10:24
kata-irc-bot<xwlpt> I see that our containerd’s log is info but not debug.10:25
kata-irc-bot<xwlpt> Let me change it.10:25
*** pcaruana has joined #kata-dev10:28
*** pcaruana has quit IRC10:45
kata-irc-bot<fupan> hmm, yes, you should make the three option enabled: containerd debug enabled, kata runtime  debug enabled and passed  agent.log=debug to  guest kernel boot parameters.10:48
kata-irc-bot<fupan> I think you can enable containerd debug by ```[debug]         level = "debug"```10:49
kata-irc-bot<fupan> please see https://github.com/containerd/containerd/blob/master/docs/getting-started.md10:49
*** pcaruana has joined #kata-dev10:55
*** EricRen has quit IRC11:25
*** EricRen has joined #kata-dev11:33
kata-irc-bot<xwlpt> Seems it not works for kata shim v2.11:40
kata-irc-bot<xwlpt> I can see the docker shim has -debug parameter11:40
kata-irc-bot<xwlpt> But kata shim v2 doesnot has it.11:40
kata-irc-bot<xwlpt> root     12453     1  0 03:21 ?        00:00:06 /var/usrlocal/bin/containerd-shim-kata-v2 -namespace k8s.io -address /var/containerd/containerd.sock -publish-binary /var/usrlocal/bin/containerd -id d414cb4b17bb8edf675f3e67b363bf07596bc08cd060ef93d3a0b7bbae191d5c root     13919     1  0 Feb12 ?        00:00:37 containerd-shim -namespace k8s.io -workdir11:41
kata-irc-bot/var/lib/containerd/io.containerd.runtime.v1.linux/k8s.io/10e6b6f25b2e9508ec86ea9ba641107b27278d82db274e6ea8eaa5955dc3c354 -address /var/containerd/containerd.sock -containerd-binary /var/usrlocal/bin/containerd -debug11:41
*** gwhaley has quit IRC12:02
*** EricRen has quit IRC13:01
*** gwhaley has joined #kata-dev13:15
*** fuentess has joined #kata-dev13:21
*** canyounot has joined #kata-dev13:35
*** EricRen has joined #kata-dev13:35
*** sameo has quit IRC13:55
*** igordc has joined #kata-dev14:04
*** EricRen has quit IRC14:06
*** pcaruana has quit IRC14:14
*** devimc has joined #kata-dev14:19
*** sameo has joined #kata-dev14:24
*** igordc has quit IRC15:00
*** pcaruana has joined #kata-dev15:03
*** lpetrut has quit IRC15:11
*** pcaruana has quit IRC15:53
*** pcaruana has joined #kata-dev15:55
*** pcaruana has quit IRC15:58
*** pcaruana has joined #kata-dev16:00
fidenciodavidgiluk: devimc: What would be the best way to approach https://github.com/kata-containers/runtime/issues/2464?16:27
fidenciodavidgiluk: devimc: the options currently passed do not make sense for upstream virtiofs. we could just leave everything empty16:27
fidenciodavidgiluk: devimc: my guess is the way to approach that would be "leave everything empty by default", and provide options or users to just override that from the configuration file16:28
fidenciobut how hard would that break existing deployments?16:28
davidgilukfidencio: or should it be a flag day16:29
fidenciodavidgiluk: flag as in for compiling those options off?16:31
davidgilukfidencio: No, I mean a commit where we flip everything16:32
fidenciodavidgiluk: that would be ideal16:32
fidenciodavidgiluk: I'm just wondering whether we really want to flip everything16:32
fidenciodavidgiluk: let me re-phrase, does make sense to offer the users options to set any of those options?16:33
davidgilukfidencio: It does to me16:34
fidenciodavidgiluk: okay, cool, so I'll (try to) do this in two steps: 1) Add those new options in the config file; 2) Remove the current flags16:35
fidenciodavidgiluk: and we can (try to) have those plus the other virtiofs patches merged at once16:35
fidenciopossibly after the 1.11 release?16:35
devimcfidencio, currently there is an option in the conf file to pass extra option, I think you should deprecated it, and allow users have full control over the virtiofsd option16:36
devimc*options16:36
*** pcaruana has quit IRC16:36
devimcfidencio, but there are some lazy users (like me) that may not want to investigate all virtiofsd flags16:37
devimcfidencio, so, we should at least use a default virtiofsd flags, just in case the user doesn't want to deal with that16:38
fidenciodevimc: davidgiluk can correct if I'm mistaken, but not using any options may be the default one16:38
fidencioI mean, may be good enough for the majority of the cases16:38
devimcfidencio, yes16:39
devimcvirtio_fs_extra_args is just to appends extra options16:39
devimcnot to overwrite default options16:40
devimcmaybe we should deprecate that option and add a new one (virtiofs_args)16:41
fidenciodevimc: let's take it in parts. I totally agree with deprecating that option and adding a new one16:42
devimcif virtiofs_args == "" then use default args (args defined by kata)16:42
fidenciodevimc: what I said that may be good enough for the majority of the cases is not having any of the sharedDirVirtioFS*Options set by default16:42
devimcif virtiofs_args == " " then don't use args16:43
devimcbecause " " overrides default args16:43
fidenciodevimc: aha!16:44
devimcfidencio, why?16:44
fidenciodevimc: I didn't know about the difference of "" and " "16:44
devimc"" is empty (nothing)16:45
* davidgiluk notes he's out next week (check mail occasionally)16:45
devimc" " is a space (something that overwrite default args)16:45
fidenciodevimc: sure, it does make sense16:45
devimcfidencio, IMO, we should at least define a list of default args16:46
fidenciodevimc: okay, I'll work on this in parts then: 1) deprecate virtio_fs_extra_args; 2) add virtio_fs_args (documenting what's already set as default);16:47
devimcfidencio, yes16:47
fidenciodevimc: one thing that bothers me about the current options is that they do not work with upstream stuff16:48
devimcfidencio, but maybe you want to name it virtiofs_args16:48
devimchah16:48
fidenciodevimc: and that's the reason of my bug report in the first place :-)16:48
fidencioor request for enhancement16:48
devimcyes, that make sense, the same thing happen with qemu, we have to update QMP and command line option to support the latest version16:49
*** devimc has quit IRC16:52
*** devimc has joined #kata-dev16:52
kata-irc-bot<xu> @eric.ernst Just discussed with @bergwolf, we could write a series of issues as proposals for 2.0. Then we may discuss them in the following AC meetings.16:54
kata-irc-bot<eric.ernst> +116:55
kata-irc-bot<eric.ernst> Sounds great.16:55
kata-irc-bot<eric.ernst> Looking forward to these -- let me know if you need help on this.16:55
kata-irc-bot<eric.ernst> in particular.16:55
*** eernst has joined #kata-dev17:02
*** ailan has joined #kata-dev17:06
*** eernst has quit IRC17:07
*** igordc has joined #kata-dev17:09
*** sgarzare has quit IRC17:33
*** ailan has quit IRC18:10
*** eernst has joined #kata-dev18:44
*** sameo has quit IRC18:55
*** devimc has quit IRC19:16
*** devimc has joined #kata-dev19:35
*** eernst has quit IRC19:48
*** eernst has joined #kata-dev20:05
*** davidgiluk has quit IRC20:06
*** gwhaley has quit IRC20:08
*** eernst has quit IRC20:09
*** jugs has quit IRC20:11
*** jugs has joined #kata-dev20:13
*** canyounot has quit IRC21:49
*** fuentess has quit IRC22:08
*** devimc has quit IRC23:07

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!