| opendevreview | Bui Doan Dang proposed openstack/heat master: fix wrong attribute in heat senlin client https://review.opendev.org/c/openstack/heat/+/876822 | 01:39 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/heat master: fix wrong attribute in heat senlin client https://review.opendev.org/c/openstack/heat/+/876822 | 03:55 |
| zigo | Hi there! Building Heat Antelope RC1, I have 12 unit tests failure if I use python-novaclient 18.3.0, but no issue with 18.1.0. Is there a patch available for this?!? | 09:05 |
| zigo | Failures: https://paste.opendev.org/show/b7jj8TjpEurg9mFRWMfE/ | 09:08 |
| zigo | tkajinam: ^ | 09:31 |
| tkajinam | https://review.opendev.org/c/openstack/python-novaclient/+/806918 | 09:34 |
| tkajinam | this is killing us | 09:34 |
| tkajinam | https://review.opendev.org/c/openstack/requirements/+/874234 | 09:34 |
| * tkajinam sighs | 09:34 | |
| zigo | tkajinam: Oh, thanks a lot! :) | 09:34 |
| tkajinam | zigo, are you saying you'll fix it ? :-) | 09:34 |
| zigo | tkajinam: Well I thought what you wrote is that https://review.opendev.org/c/openstack/python-novaclient/+/806918 is fixing it, right? | 09:35 |
| zigo | Or what ?!? | 09:35 |
| tkajinam | no that broke heat unit tests | 09:35 |
| tkajinam | and has been blocking requirement bump | 09:35 |
| zigo | Should I just revert that patch in my novaclient package then? | 09:35 |
| tkajinam | or you can skip these broken unit tests for now | 09:36 |
| tkajinam | I'll look into it and will submit a fix. that's annoying... | 09:36 |
| zigo | tkajinam: If you confirm it's only an issue in tests, and not in the actual code, then yeah, I'll skip the unit tests, thanks! | 09:36 |
| zigo | (truth is: it really looked like a testing issue, but I had to make sure of it...) | 09:44 |
| tkajinam | the problem should be test only. but I can't guarantee it 100% because there is not real functional tests ;-) | 09:55 |
| opendevreview | Takashi Kajinami proposed openstack/heat master: Fix unit tests with python-novaclient 18.3.0 https://review.opendev.org/c/openstack/heat/+/876950 | 10:14 |
| opendevreview | Merged openstack/heat master: Fix unit tests with python-novaclient 18.3.0 https://review.opendev.org/c/openstack/heat/+/876950 | 12:54 |
| opendevreview | Takashi Kajinami proposed openstack/heat stable/2023.1: Fix unit tests with python-novaclient 18.3.0 https://review.opendev.org/c/openstack/heat/+/876922 | 13:15 |
| opendevreview | Jeremy Stanley proposed openstack/heat master: DNM: Testing submit requirements https://review.opendev.org/c/openstack/heat/+/876984 | 15:05 |
| -opendevstatus- NOTICE: Yesterday's change to Gerrit configs to use submit-requirements had a boolean logic bug. This has now been corrected and any changes that did not merge as a result can be rechecked. We have reenqueued the changes we identified as being affected. | 17:22 | |
| opendevreview | Merged openstack/heat stable/2023.1: Update .gitreview for stable/2023.1 https://review.opendev.org/c/openstack/heat/+/876726 | 17:25 |
| opendevreview | Merged openstack/heat stable/2023.1: Update TOX_CONSTRAINTS_FILE for stable/2023.1 https://review.opendev.org/c/openstack/heat/+/876727 | 17:43 |
| opendevreview | Merged openstack/heat master: Update master for stable/2023.1 https://review.opendev.org/c/openstack/heat/+/876728 | 17:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!