| opendevreview | Takashi Kajinami proposed openstack/heat master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/heat/+/850132 | 04:46 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/heat master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/heat/+/850133 | 04:46 |
| opendevreview | Takashi Kajinami proposed openstack/heat master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/heat/+/850132 | 04:48 |
| opendevreview | Takashi Kajinami proposed openstack/heat master: Do not merge: Testing new swiftclient in functional tests. https://review.opendev.org/c/openstack/heat/+/850134 | 04:51 |
| opendevreview | Takashi Kajinami proposed openstack/python-heatclient master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/python-heatclient/+/850135 | 04:52 |
| opendevreview | Rabi Mishra proposed openstack/heat master: Fix for swiftclient 4.0.1 https://review.opendev.org/c/openstack/heat/+/850136 | 05:22 |
| ramishra | tkajinam: oops, you're also working on it. Let's change to use the old default till requirements bumped. ^^ | 05:24 |
| ramishra | tkajinam: sorry did not not notice ur patch before proposing mine | 05:24 |
| bshephar | haha yeah, I just stashed my changes when I checked this channel as well. | 05:25 |
| tkajinam | we were all aware of that. that's good thing :-) | 05:25 |
| bshephar | I'm reviewing tkajinams changes atm. | 05:26 |
| bshephar | The tempurl can be sha256 or sha512. So we might need to accept a 3rd value? | 05:27 |
| ramishra | let's use the old default and not fix the tests till req is bumped | 05:27 |
| tkajinam | ramishra, hmm. but we need to bump swiftclient to use even your workaround | 05:28 |
| tkajinam | the digest argument was added in 4.0.1 | 05:29 |
| ramishra | tkajinam: Ah, right.. | 05:31 |
| ramishra | OK, I'll abandon mine then | 05:32 |
| opendevreview | Takashi Kajinami proposed openstack/python-heatclient master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/python-heatclient/+/850135 | 05:32 |
| tkajinam | I think just switching to sha256 is fine. I could not find any logic hardly relying on sha1 | 05:34 |
| tkajinam | or we can revert it back to sha1 once bump is made | 05:35 |
| opendevreview | Takashi Kajinami proposed openstack/heat master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/heat/+/850132 | 05:37 |
| opendevreview | Takashi Kajinami proposed openstack/python-heatclient master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/python-heatclient/+/850135 | 05:38 |
| opendevreview | Takashi Kajinami proposed openstack/heat master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/heat/+/850132 | 05:38 |
| ramishra | All existing deployment temp_urls would be using sha1, I assume swift would recognize that accordingly.. it may not break anything | 05:39 |
| tkajinam | yeah swift still accepts sha1 so the existing tempurl should keep functioning | 05:41 |
| tkajinam | unless FIPS is enabled | 05:41 |
| ramishra | some tempurls are valid for ever;) | 05:41 |
| tkajinam | which is quite rare I'd say | 05:41 |
| ramishra | let's fix the tests and address others when the need arises | 05:42 |
| tkajinam | yeah | 05:42 |
| tkajinam | https://review.opendev.org/c/openstack/heat/+/850134/ | 05:42 |
| tkajinam | this would show us any breackage in functional tests, I hope | 05:42 |
| tkajinam | ramishra, do you mind reviewing this one as well ? fixing the same tempurl problem https://review.opendev.org/c/openstack/python-heatclient/+/850135 | 05:52 |
| tkajinam | just in case you missed that. thx for +2 on the heat patch | 05:52 |
| opendevreview | Merged openstack/python-heatclient master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/python-heatclient/+/850135 | 06:52 |
| opendevreview | Merged openstack/heat master: Accept sha256 hash for swift tempurl https://review.opendev.org/c/openstack/heat/+/850132 | 06:57 |
| *** ysandeep is now known as ysandeep|lunch | 08:38 | |
| *** ysandeep|lunch is now known as ysandeep | 10:23 | |
| opendevreview | Takashi Kajinami proposed openstack/heat master: Do not merge: Testing new swiftclient in functional tests. https://review.opendev.org/c/openstack/heat/+/850134 | 12:24 |
| opendevreview | Merged openstack/heat stable/wallaby: Log parameters merged https://review.opendev.org/c/openstack/heat/+/845667 | 14:07 |
| opendevreview | Merged openstack/heat master: Set cache_ok to avoid SAWarning https://review.opendev.org/c/openstack/heat/+/845866 | 14:11 |
| *** ysandeep is now known as ysandeep|out | 15:17 | |
| *** tosky_ is now known as tosky | 19:45 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!