*** ysandeep|out is now known as ysandeep | 05:35 | |
ysandeep | bshephar, ramishra hello o/ happy monday, I am moving glance to OSC, It have two resources OS::Glance::WebImage and OS::Glance::Image. | 05:41 |
---|---|---|
ysandeep | OS::Glance::Image was deprecated like 4 years ago with https://review.opendev.org/c/openstack/heat/+/419043 , Can I remove this completely? | 05:41 |
ysandeep | https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/glance/image.py#L349 | 05:41 |
bshephar | I would do that as a seperate change rather than along with the OSC migration. But yeah, we can probably remove it by now. | 05:51 |
bshephar | https://docs.openstack.org/heat/latest/developing_guides/supportstatus.html#life-cycle-of-resource-property-attribute | 05:51 |
ramishra | ysandeep: we don't remove resources, map them to OS:Heat:None | 05:52 |
ramishra | ex. https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/designate/record.py#L19 | 05:52 |
ramishra | we can do that | 05:52 |
bshephar | Should we set the support status to hidden for that class as well? Or do we just do that for properties | 05:53 |
bshephar | https://docs.openstack.org/heat/latest/developing_guides/supportstatus.html#removing-process-of-object | 05:53 |
ramishra | yes like in https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/designate/record.py#L28 | 05:54 |
bshephar | Oh yeah, that example sets it to hidden, I see | 05:54 |
ysandeep | ramishra, bshephar thanks! | 05:54 |
ysandeep | okay, So after deprecated we move support status to hidden, I will propose something soon. | 05:56 |
ysandeep | bshephar, yes I plan to do that move OS::Glance::Image first and move to osc in a separate patch. | 05:58 |
bshephar | Sounds good. | 06:00 |
*** ysandeep is now known as ysandeep|afk | 07:05 | |
*** ysandeep|afk is now known as ysandeep | 08:36 | |
*** ysandeep is now known as ysandeep|coffee | 11:08 | |
*** ysandeep|coffee is now known as ysandeep | 11:54 | |
*** ysandeep is now known as ysandeep|out | 16:17 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!