| *** jmlowe has joined #heat | 00:01 | |
| *** jmlowe has quit IRC | 00:06 | |
| *** jmlowe has joined #heat | 00:11 | |
| *** gfidente has quit IRC | 00:14 | |
| *** vishalmanchanda has joined #heat | 00:21 | |
| *** jmlowe has quit IRC | 00:26 | |
| *** jmlowe has joined #heat | 00:29 | |
| *** jmlowe has quit IRC | 00:34 | |
| *** jdandrea has quit IRC | 00:38 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat master: Handle OS::Mistral::Workflow resource replacement properly https://review.opendev.org/709428 | 03:07 |
|---|---|---|
| *** vishalmanchanda has quit IRC | 03:09 | |
| openstackgerrit | Rico Lin proposed openstack/heat stable/stein: Update Fedora image ref and add UPPER_CONSTRAINTS_FILE https://review.opendev.org/709335 | 03:28 |
| ramishra | ricolin: Hey! Is there a patch to change to fedora30 for master? | 03:34 |
| ramishra | oh we use 30 on fedora.. nvm | 03:35 |
| ramishra | * f30 on master | 03:36 |
| openstackgerrit | Rico Lin proposed openstack/heat stable/queens: Use stable constraint and update fedora mirror https://review.opendev.org/707760 | 03:37 |
| ramishra | Ah! https://review.opendev.org/#/c/709321/ merged few hours back.. I saw that error yesterday and was wondering how it magically got fixed;) | 03:39 |
| zaneb | ramishra: yep, also merged the train one | 03:43 |
| zaneb | the really mysterious thing is that there's a patch for rocky but not stein ;) | 03:44 |
| zaneb | maybe we should just change the scripts to always pull from the latest fedora? it's a pain updating all the stable branches once or twice a year | 03:45 |
| zaneb | oh, stein is in https://review.opendev.org/709335 now. ok | 03:46 |
| ricolin | :) | 03:49 |
| *** higgins has quit IRC | 03:50 | |
| ricolin | feel free to update https://review.opendev.org/#/q/topic:fix-stable-gate+(status:open) if it failed still! | 03:51 |
| *** higgins has joined #heat | 03:51 | |
| *** hoonetorg has quit IRC | 03:52 | |
| *** hoonetorg has joined #heat | 03:54 | |
| *** joxyuki has joined #heat | 03:57 | |
| *** jdandrea has joined #heat | 04:01 | |
| *** skramaja has joined #heat | 04:06 | |
| *** udesale has joined #heat | 04:23 | |
| *** vishalmanchanda has joined #heat | 04:31 | |
| *** jdandrea has quit IRC | 04:33 | |
| *** strigazi has quit IRC | 06:16 | |
| *** strigazi has joined #heat | 06:18 | |
| *** sm806 has quit IRC | 07:44 | |
| *** sm806 has joined #heat | 07:45 | |
| *** tkajinam has quit IRC | 08:22 | |
| *** flwang1 has joined #heat | 08:36 | |
| flwang1 | ramishra: can you please help review https://review.opendev.org/#/c/709419/ thanks | 08:37 |
| *** tkajinam has joined #heat | 08:43 | |
| *** shardy has joined #heat | 08:51 | |
| *** gfidente has joined #heat | 08:52 | |
| ramishra | flwang1: looking | 08:53 |
| openstackgerrit | Witold Bedyk proposed openstack/heat-tempest-plugin master: [WIP]Add tests for autoscaling with monasca https://review.opendev.org/700876 | 08:54 |
| flwang1 | ramishra: thank you very much | 08:55 |
| ramishra | flwang1: I don't get it. I think if you don't specify a property for a resource it would be None and not '', why're you getting empty string? | 08:56 |
| ramishra | the story created does not have any details... | 08:57 |
| flwang1 | ramishra: you can try to pass in a null to volume az, it will be return "" at that line | 08:57 |
| ramishra | though the patch looks harmless | 08:57 |
| ramishra | why would you pass null? Is it about the condition thing for propery you discussed earlier? | 08:58 |
| ramishra | *property | 08:58 |
| flwang1 | ramishra: and ec2 volume is doing the same thing https://github.com/openstack/heat/blob/master/heat/engine/resources/aws/ec2/volume.py#L89 | 08:59 |
| flwang1 | ramishra: let me show you more background | 08:59 |
| flwang1 | ramishra: https://github.com/openstack/magnum/blob/master/magnum/drivers/k8s_fedora_atomic_v1/templates/kubemaster.yaml#L787 | 08:59 |
| flwang1 | in magnum, we need to support specify the az for volumes, however, we also need to support the case when the az is not set | 09:00 |
| ramishra | https://github.com/openstack/magnum/blob/master/magnum/drivers/k8s_fedora_atomic_v1/templates/kubemaster.yaml#L354 | 09:00 |
| ramishra | you've a default for the parameter | 09:01 |
| ramishra | so it's going as empty string... | 09:01 |
| flwang1 | the az default value in magnum is "", but even if i set null for the volume az, at line https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/cinder/volume.py#L283 it will return "" | 09:01 |
| flwang1 | that's why we need this change in Heat to gracefully return None instead of "" for this case | 09:02 |
| flwang1 | that's why i asked you how to pass in None in Heat for resource property | 09:03 |
| flwang1 | does that make more sense? | 09:04 |
| ramishra | may be an issue with group nested stacks where you pass a value for one member and not or 'null' for another.. but the commit message is not very clear | 09:05 |
| flwang1 | without this support in Heat, we have to make very very ugly heat template in Magnum | 09:05 |
| ramishra | It's harmless so I'll aprove it | 09:05 |
| flwang1 | ramishra: thank you very much | 09:06 |
| *** udesale has quit IRC | 09:07 | |
| ramishra | Without setting, the property availability_zone of volume always | 09:07 |
| ramishra | ignore... | 09:07 |
| flwang1 | ramishra: how can we do the "without setting"? i think we always have to set a value for the property, no? | 09:13 |
| *** joxyuki has quit IRC | 09:14 | |
| *** k_mouza has joined #heat | 09:20 | |
| ramishra | flwang1: not specifying the property for the resource | 09:21 |
| flwang1 | ramishra: as I mentioned above, we have to specify the property to support the az | 09:21 |
| ramishra | I think your issue is it's a nested stack and that too for a group resource | 09:21 |
| ramishra | flwang1: if you don't specify az in your template and then use the property when making the cinder call from heat, it would be sent as None | 09:24 |
| ramishra | https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/cinder/volume.py#L283 should send it as None | 09:24 |
| ramishra | try with a simple volume resource... | 09:25 |
| flwang1 | ramishra: again, i totally understand that without setting the az for the volume resource, it will pass in None for the AZ | 09:25 |
| flwang1 | but we have to specify the AZ property for volume resource to support the scenario that user can set az for the volume | 09:26 |
| ramishra | flwang1: right. It's one of those cases.. imo, should have been handled by nova/cinder.. but anyway | 09:29 |
| flwang1 | ramishra: yep, i agree, it's the old nova/cinder az issue :( | 09:29 |
| flwang1 | ramishra: thank you again | 09:29 |
| ramishra | np:) | 09:30 |
| *** flwang1 has quit IRC | 09:38 | |
| ricolin | Just send a mail for OpenDev Vancouver survey for heat http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012801.html | 09:46 |
| ricolin | ramishra, zaneb pas-ha ^^^ | 09:46 |
| ricolin | Also the gate fix for stein is ready: https://review.opendev.org/#/c/709335 | 09:47 |
| openstackgerrit | Rico Lin proposed openstack/heat stable/queens: Use stable constraint and update fedora mirror https://review.opendev.org/707760 | 09:52 |
| openstackgerrit | Merged openstack/heat master: Support handling empty string for volume AZ https://review.opendev.org/709419 | 10:59 |
| *** udesale has joined #heat | 11:17 | |
| *** ivve has joined #heat | 11:30 | |
| *** rcernin has quit IRC | 11:37 | |
| brtknr | ricolin: would it be acceptable to backport https://review.opendev.org/709419 to train? | 11:45 |
| brtknr | ramishra: ^ | 11:50 |
| *** jawad_axd has joined #heat | 11:54 | |
| *** tkajinam has quit IRC | 12:30 | |
| *** jdandrea has joined #heat | 13:37 | |
| *** tkajinam has joined #heat | 13:53 | |
| *** jmlowe has joined #heat | 14:10 | |
| *** jawad_axd has quit IRC | 14:42 | |
| *** jawad_axd has joined #heat | 14:43 | |
| *** jawad_axd has quit IRC | 14:43 | |
| *** jawad_axd has joined #heat | 14:45 | |
| zaneb | brtknr: (1) probably yes; (2) did y'all see https://storyboard.openstack.org/#!/story/2007330#comment-152628 ? | 14:47 |
| *** jawad_ax_ has joined #heat | 14:48 | |
| *** jawad_axd has quit IRC | 14:49 | |
| *** jawad_ax_ has quit IRC | 14:52 | |
| *** tkajinam has quit IRC | 15:08 | |
| *** skramaja has quit IRC | 15:21 | |
| brtknr | yes, we tried many things. in the end, this was what the HOT template ended up looking like which seemed a bit ridiculous: https://review.opendev.org/#/c/705592/2/magnum/drivers/k8s_fedora_atomic_v1/templates/kubemaster.yaml | 15:26 |
| *** irclogbot_0 has quit IRC | 15:27 | |
| *** irclogbot_3 has joined #heat | 15:27 | |
| *** jawad_axd has joined #heat | 16:02 | |
| *** jawad_axd has quit IRC | 16:06 | |
| zaneb | brtknr: ah, ok, server depends on volume so there's no way to pass it through from the server to the volume :/ | 16:19 |
| *** mailingsam has joined #heat | 16:28 | |
| mailingsam | Hi All, Heat functional tests are failing due to missing fedora image. Fedora link seems to be updated. | 16:31 |
| mailingsam | https://review.opendev.org/#/c/704630 | 16:32 |
| mailingsam | Is anyone working on fixing the heat function tests? | 16:32 |
| *** k_mouza has quit IRC | 17:01 | |
| *** udesale has quit IRC | 17:04 | |
| *** vishalmanchanda has quit IRC | 17:11 | |
| openstackgerrit | Rico Lin proposed openstack/heat stable/queens: Use stable constraint and update fedora mirror https://review.opendev.org/707760 | 17:11 |
| *** mailingsam has quit IRC | 17:16 | |
| openstackgerrit | Rico Lin proposed openstack/heat master: Use resource_id instead of phy rsrc name in InstanceGroup https://review.opendev.org/700367 | 17:17 |
| openstackgerrit | Rico Lin proposed openstack/heat master: Use resource_id instead of phy rsrc name in InstanceGroup https://review.opendev.org/700367 | 17:17 |
| *** ivve has quit IRC | 17:47 | |
| brtknr | zaneb: nope | 18:02 |
| openstackgerrit | Merged openstack/heat master: Handle OS::Mistral::Workflow resource replacement properly https://review.opendev.org/709428 | 18:07 |
| *** shardy has quit IRC | 19:02 | |
| openstackgerrit | Merged openstack/heat master: Make tags handling more robust https://review.opendev.org/687672 | 21:22 |
| *** gmoro has quit IRC | 22:29 | |
| *** gmoro has joined #heat | 22:30 | |
| *** k_mouza has joined #heat | 22:52 | |
| *** k_mouza has quit IRC | 22:56 | |
| *** tkajinam has joined #heat | 22:58 | |
| *** k_mouza has joined #heat | 23:11 | |
| *** sm806 has quit IRC | 23:23 | |
| *** sm806 has joined #heat | 23:24 | |
| *** k_mouza has quit IRC | 23:27 | |
| *** rcernin has joined #heat | 23:39 | |
| *** sm806 has quit IRC | 23:50 | |
| *** sm806 has joined #heat | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!