Thursday, 2018-02-22

« Wednesday, 2018-02-21 Index Friday, 2018-02-23 »
openstackgerritAkihiro Motoki proposed openstack/heat-dashboard master: Improve doc structure  https://review.openstack.org/54680700:28
openstackgerritAkihiro Motoki proposed openstack/heat-dashboard master: Improve installation guide  https://review.openstack.org/54682000:28
*** dmellado has joined #heat00:33
openstackgerritAkihiro Motoki proposed openstack/heat-dashboard master: DO NOT MERGE: UT check  https://review.openstack.org/54682300:35
*** liusheng has quit IRC00:36
*** liusheng has joined #heat00:37
openstackgerritAkihiro Motoki proposed openstack/heat-dashboard master: Declare heat-dashboard depends on mox  https://review.openstack.org/54682700:42
*** d0ugal has quit IRC00:47
*** d0ugal has joined #heat00:57
*** Dave has quit IRC01:01
*** stevebaker has joined #heat01:03
*** ysandeep has joined #heat01:10
*** pengdake has joined #heat01:12
*** Guest87022 has quit IRC01:14
*** Guest87022 has joined #heat01:17
*** kiennt26 has joined #heat01:31
*** yangyapeng has quit IRC01:33
openstackgerritAkihiro Motoki proposed openstack/heat-dashboard master: Enables warning-is-error in sphinx  https://review.openstack.org/54683601:33
openstackgerritAkihiro Motoki proposed openstack/heat-dashboard master: Improve doc structure  https://review.openstack.org/54680701:33
openstackgerritAkihiro Motoki proposed openstack/heat-dashboard master: Improve installation guide  https://review.openstack.org/54682001:33
*** yangyapeng has joined #heat01:33
*** yangyapeng has quit IRC01:38
*** namnh has joined #heat01:50
*** hongbin has joined #heat02:13
*** zhenguo has joined #heat02:32
*** ricolin has joined #heat02:40
*** sgran has quit IRC03:02
*** sgran has joined #heat03:03
*** ramishra has joined #heat03:19
*** fragatina has quit IRC03:32
*** Cheeky-Celery has quit IRC03:33
*** Dodgy-Debaser has quit IRC03:33
*** Dodgy-Debaser has joined #heat03:36
*** Cheeky-Celery has joined #heat03:37
*** ramishra has quit IRC03:41
*** ramishra has joined #heat03:43
*** d0ugal has quit IRC04:00
*** gkadam has quit IRC04:01
*** gkadam has joined #heat04:02
*** d0ugal has joined #heat04:26
*** links has joined #heat04:30
*** gkadam has quit IRC04:41
*** zhenguo has quit IRC04:42
*** gkadam has joined #heat04:51
*** Guest87022 has quit IRC04:53
*** Guest87022 has joined #heat04:56
*** fragatin_ has joined #heat04:56
*** hongbin has quit IRC05:02
*** skramaja has joined #heat05:06
*** om2 has joined #heat05:10
*** aluria has quit IRC05:16
ramishraricolin: Hi! around?05:36
ricolinramishra, yes05:37
ramishraricolin: grenade job is probably broken for all branches now with tempest switching to stestr https://git.openstack.org/cgit/openstack/tempest/commit/?id=24a753dcfbbda143254c64e58b06d15f40e78f5905:38
ramishraI've commented on https://review.openstack.org/#/c/54665005:39
ramishraI think it's only master and queens. May be we can merge https://review.openstack.org/#/q/status:open+project:openstack/heat+branch:master+topic:rolling-upgrade and backport to queens05:43
ramishraIf we want to land https://review.openstack.org/#/c/546650 before cutting rc205:44
*** om2 has quit IRC05:45
ramishraOh, there are 2 patches in that series and the second one switches to stestr:/05:46
*** om2 has joined #heat05:46
ramishraI'll put a fix then05:47
*** om2 has quit IRC05:51
*** om2 has joined #heat05:55
*** om2 has quit IRC05:55
*** om2 has joined #heat05:59
*** hieulq has joined #heat06:03
openstackgerritRabi Mishra proposed openstack/heat master: Update .stestr.conf with the group_regex  https://review.openstack.org/54687106:07
*** mdnadeem has joined #heat06:08
openstackgerritOpenStack Proposal Bot proposed openstack/heat master: Imported Translations from Zanata  https://review.openstack.org/54565906:21
*** mdnadeem_ has joined #heat06:31
*** dbecker has quit IRC06:31
*** mdnadeem has quit IRC06:33
openstackgerritOpenStack Proposal Bot proposed openstack/heat-dashboard master: Imported Translations from Zanata  https://review.openstack.org/54688306:37
*** dbecker has joined #heat06:44
*** jtomasek has joined #heat06:47
*** jtomasek has quit IRC06:47
*** mdnadeem_ has quit IRC06:52
*** jtomasek has joined #heat06:56
*** om2 has quit IRC06:56
*** mdnadeem has joined #heat07:01
*** SmearedBeard has joined #heat07:06
*** rcernin has quit IRC07:20
*** fragatin_ has quit IRC07:46
*** armaan has quit IRC07:48
*** armaan has joined #heat07:48
*** SmearedBeard has quit IRC07:53
*** aluria has joined #heat08:06
*** AlexeyAbashkin has joined #heat08:07
*** liusheng has quit IRC08:17
*** hoonetorg has quit IRC08:18
*** liusheng has joined #heat08:18
*** hoonetorg has joined #heat08:35
*** gfidente has joined #heat08:36
*** liusheng has quit IRC08:44
*** liusheng has joined #heat08:44
openstackgerritMerged openstack/heat-dashboard master: Imported Translations from Zanata  https://review.openstack.org/54688308:51
therveramishra, We'll need https://review.openstack.org/#/c/546871/ on queens before rc2?08:51
ramishratherve: If we want to merge anything like https://review.openstack.org/#/c/546650/ before rc2 then yes, else no08:54
therveYeah not sure how major this is08:54
ramishrabug https://bugs.launchpad.net/heat/+bug/1739447 does not have a target milestone though;)08:55
openstackLaunchpad bug 1739447 in OpenStack Heat "stack validation fails when "resource with type being template filename" is used in template provided to OS::Heat::Stack resource" [High,Fix released] - Assigned to Zane Bitter (zaneb)08:55
thervericolin, Can we release rc2 then?08:56
ramishraprobably good if we get that in too08:57
ricolintherve, will release later today08:57
therveCool08:57
*** pengdake_ has joined #heat08:59
*** pengdake has quit IRC09:03
openstackgerritMerged openstack/heat-dashboard master: Declare heat-dashboard depends on mox  https://review.openstack.org/54682709:05
openstackgerritMerged openstack/heat-dashboard master: Enables warning-is-error in sphinx  https://review.openstack.org/54683609:05
*** kiennt26 has quit IRC09:36
ramishraricolin: have you seen http://lists.openstack.org/pipermail/openstack-dev/2018-February/127606.html? There is no activity to fix the bug it seems. Probably you should wake up the dashboard guys;)09:41
*** gkadam_ has joined #heat09:43
*** gkadam has quit IRC09:44
*** gkadam_ has quit IRC09:44
*** gkadam_ has joined #heat09:44
ricolinramishra, thx, will do09:45
*** gmoro has quit IRC09:47
*** gmoro has joined #heat09:48
*** SmearedBeard has joined #heat09:52
*** serlex has joined #heat09:57
*** k_mouza has joined #heat10:08
*** links has quit IRC10:09
*** links has joined #heat10:10
*** pengdake_ has quit IRC10:13
*** tiantian has quit IRC10:28
*** tiantian has joined #heat10:29
*** hieulq has quit IRC10:41
*** Guest87022 has quit IRC10:44
*** k_mouza has quit IRC10:44
*** k_mouza has joined #heat10:44
*** yassine has joined #heat10:47
*** yassine is now known as Guest9811610:47
*** ricolin_ has joined #heat10:49
*** ricolin has quit IRC10:52
*** gkadam__ has joined #heat10:54
*** Cheeky-Celery has quit IRC10:56
*** kei-ichi_ has joined #heat10:57
*** gkadam_ has quit IRC10:57
*** kei-ichi has quit IRC10:59
*** EmilienM has quit IRC10:59
*** links has quit IRC10:59
*** nwonknu has quit IRC10:59
*** EmilienM has joined #heat11:00
*** Cheeky-Celery has joined #heat11:00
*** links has joined #heat11:00
*** kei-ichi_ has quit IRC11:01
*** Qiming has quit IRC11:01
*** nwonknu has joined #heat11:03
*** k_mouza has quit IRC11:03
*** namnh has quit IRC11:03
*** k_mouza has joined #heat11:03
*** kei-ichi has joined #heat11:04
*** Qiming has joined #heat11:05
*** k_mouza has quit IRC11:08
*** Qiming_ has joined #heat11:26
*** vegarl has joined #heat11:28
*** Cheeky-Celery_ has joined #heat11:29
openstackgerritAndrea Frittoli proposed openstack/heat-tempest-plugin master: Fix idempotent id for heat scenario tests  https://review.openstack.org/54695311:31
andreaframishra ricolin_ alinanesterova https://review.openstack.org/546953  ^^^11:32
*** Qiming has quit IRC11:34
*** vegarl_ has quit IRC11:34
*** Cheeky-Celery has quit IRC11:34
*** rwsu has quit IRC11:34
*** blues-man has joined #heat11:34
*** rwsu has joined #heat11:35
*** armaan has quit IRC11:39
*** armaan has joined #heat11:40
*** pbourke has quit IRC11:42
*** shardy has quit IRC11:42
*** tiantian has quit IRC11:46
*** tiantian has joined #heat11:46
*** armaan has quit IRC11:46
*** pbourke has joined #heat11:47
*** pbourke_ has joined #heat11:52
*** ysandeep has quit IRC11:52
*** armaan has joined #heat11:57
*** pbourke has quit IRC11:58
*** thorre_se has joined #heat12:03
*** thorre has quit IRC12:06
*** thorre_se is now known as thorre12:06
*** thorre_se has joined #heat12:09
*** thorre has quit IRC12:13
*** thorre_se is now known as thorre12:13
*** skramaja has quit IRC12:28
*** links has quit IRC12:29
*** k_mouza has joined #heat12:34
*** links has joined #heat12:42
*** wolsen has quit IRC12:50
*** wolsen has joined #heat12:51
*** blomquisg_gone is now known as blomquisg12:58
*** mchlumsky has quit IRC12:59
*** k_mouza has quit IRC13:02
*** k_mouza has joined #heat13:03
*** k_mouza has quit IRC13:05
*** mchlumsky has joined #heat13:05
*** jcoufal has joined #heat13:12
*** dprince has joined #heat13:16
*** eqrt has joined #heat13:22
*** yangyapeng has joined #heat13:34
*** sshnaidm|afk is now known as sshnaidm13:37
*** yangyapeng has quit IRC13:39
*** fragatina has joined #heat13:41
*** k_mouza has joined #heat13:45
*** shardy has joined #heat13:48
*** k_mouza has quit IRC13:50
*** k_mouza has joined #heat13:50
*** mwhahaha has quit IRC13:54
*** mwhahaha has joined #heat13:56
shardyHey folks, I wanted to discuss ResourceGroup validation if anyone is around, specifically:14:02
shardyhttps://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/resource_group.py#L30314:02
shardyThat code was added (by me, a really long time ago) to work around the problem that custom constraints can fail for nested stacks if e.g an image doesn't exist in glance, but it's never actually used because we have a zero count14:03
shardyhowever, there is an undesired side-effect when using nested validation to get a parameters schema for all templates14:03
shardythe schema for the nested template is not returned when the size is zero14:04
*** blues-man has quit IRC14:04
shardyI'm trying to decide if it's reasonable to special-case this so that the schema is always returned, but we don't validate the values at runtime when the count is zero14:04
shardyjtomasek, zaneb, therve, ramishra: ^^ comments welcome14:04
shardythis is related to a problem with the tripleo-ui jtomasek is experiencing14:05
therveThat's a tough one14:05
*** jmlowe has quit IRC14:06
therveshardy, Do you have an idea of alternatives?14:07
therveEg set the size to 1 for validation?14:07
jtomasekshardy: the problem we're facing with tripleo-ui right now becuase of this is that we can't get role configuration before setting it's count - we would like to treat the count as just another parameter of role14:07
shardytherve: yeah we did discuss that, it's tricky because atm the UI depends on some data from the nested per-role template (the flavor in particular, to enable selecting the right nodes), before it allows the user to select a non-zero count14:08
shardytherve: it might be possible, and we could also move the flavor parameters into the overcloud template14:08
shardybut I wanted to discuss the more generic problem first14:08
shardyincase there's a common solution in heat we can consider instead of a semi-hacky workaround in tripleo-common14:09
jtomasektherve: setting the size to 1 would return incorrect value for the count parameter default value, which is quite unfortunate, so we would have to run the validation twice. and running the validation is quite costly14:10
thervejtomasek, What about just validating the nested stack maybe?14:10
shardyjtomasek: well the Default is returned in the schema, as well as the Value, would that allow us to pass 1 but still consume the defaults?14:10
therveshardy, So the main objection obviously is that we're returning something that we don't validate14:11
shardytherve: yeah we discussed that yesterday too, it's possible but not idea because code ends up coupled to the t-h-t templates14:11
therveWell14:11
shardytherve: I think we can validate it, but not the value14:11
therveYou could possibly identify the count 0 resource groups, but yeah14:11
shardyI suspect that conditional pre-dates the validate_value boolean14:11
shardywhich IIRC was added later for similar reasons14:12
shardye.g we couldn't validate values during validation, only at runtime when the value is derived from some other resource14:12
therveRight14:12
shardyI wonder if we could use that method instead e.g don't validate values when count=0?14:12
shardyinstead of just not validating anything at all14:13
therveshardy, Is your plan to get rid of the size check ? Does that work now?14:13
shardytherve: that's one idea - yes it does work but it won't catch any broken templates when size=014:14
shardyso that solution was something of a sledgehammer in retrospect ;)14:14
therveshardy, So what about not raising an exception if size is 0?14:14
therveYou somewhat keep compatibility14:14
*** derekh has joined #heat14:15
therveThough, I'm not sure where we actually return stuff14:15
therveRemoving that check is probably not enough, we need to effectively override the size14:17
shardyhttps://github.com/openstack/heat/blob/master/heat/engine/stack.py#L83514:17
shardyI'm wondering if we can remove the size check because we now set strict_validate=False in ResourceGroup14:18
shardyThat should ignore any parameter validate errors I think14:19
therveSo hold on14:19
therveOh ok14:19
therveshardy, So you *do* have parameters error to ignore as well?14:19
*** blues-man has joined #heat14:19
shardytherve: well you can, like if you create a BlockStorage group with zero size, but the image "blockstorage-image" doesn't exist14:20
shardythat shouldn't fail validation because we won't use it on deploy14:20
shardy(I know we use overcloud-full everywhere, just an example)14:20
therveshardy, But... we don't validate right now. I thought you care about returning the schema14:20
therveThat's a different step, right?14:20
therveI mean, after validation14:21
shardytherve: yes, but IIRC (and it was a long time ago!) the reason I added that was we'd never get past validation even though the create would actually work14:21
therveI'd think what you want is to fix ResourceGroup.preview14:21
shardyhmm, maybe, yeah we use that for nested validation14:22
therveshardy, Right, because create with size 0 doesn't do anything14:22
thervevalidation validates a size 1 all the time14:22
therveUnless it's 0 because of that check14:22
therveI believe that part is "fine", because you have errors you want to ignore14:23
therveTo build the schema though, you need to override the size so that the nested template is not empty14:23
therveI think14:23
shardytherve: Ah yeah, we generate an empty nested stack of the type being scaled14:24
shardygah14:24
shardyand we'd want preview to create the correct count, but (possibly) validate to always create 1 to validate the syntax, but return the real count parameter in the validate response14:25
shardythat could make validate faster for huge groups as well I guess14:25
*** k_mouza has quit IRC14:26
therveshardy, https://review.openstack.org/#/c/374226/14:26
*** jmlowe has joined #heat14:28
shardytherve: thanks, I forgot about that one14:33
shardyI wonder can we modify that to only force the size on validate?14:33
therveOn preview you mean?14:34
shardytherve: yeah, that was the basis of my previous concern, I just added some more comments14:34
shardyI wonder, would strict_validate=False ever be set for preview?14:35
shardyI think not?14:35
*** liyi has joined #heat14:35
shardyif so I wonder if we could force to 1 when that is False or find some other way to detect it's validate not preview14:35
therveshardy, You want size to be 1 in preview, not validate14:37
therveIf size is 1 in validate, it could fail as you mentioned14:37
shardyI mean the API calls - template validate only ever returns a parameters schema, so the resource count doesn't matter14:39
*** liyi has quit IRC14:39
shardybut IIRC stack preview does return the actual resources, so this could break that?14:39
* shardy hasn't used stack preview in a while14:39
therveAh ok14:40
therveYeah that's possible. We need to check the path14:41
shardytherve: would you have time to take a look and maybe revive your patch? :)14:41
therveshardy, Will do!14:41
shardytherve: thanks, jtomasek and owe you some beers next week :)14:42
therveshardy, Do you have an example or a bug referencing the issue?14:42
shardyjtomasek: did you raise a bug for this yet?14:42
shardyif not I can create a minimal reproducer to show the problem14:42
*** tiantian has quit IRC14:42
*** tiantian has joined #heat14:43
jtomasekshardy: not yet14:43
shardyjtomasek: Ok sec I'll raise one14:43
jtomasekshardy, therve: thanks!!14:44
shardyhttps://bugs.launchpad.net/heat/+bug/175107414:51
openstackLaunchpad bug 1751074 in OpenStack Heat "template validate doesn't return schema for nested resources when resource group count is zero" [Undecided,Triaged]14:51
shardytherve, jtomasek: ^^14:51
therveThanks14:52
*** gkadam__ has quit IRC14:53
*** fragatina has quit IRC15:00
openstackgerritMerged openstack/heat-tempest-plugin master: Fix idempotent id for heat scenario tests  https://review.openstack.org/54695315:05
*** blues-man has quit IRC15:07
*** mdnadeem has quit IRC15:19
therveshardy, So stack preview doesn't have a nested parameter15:20
thervepreview update does, though...15:20
*** links has quit IRC15:20
*** blues-man has joined #heat15:20
shardytherve: I think preview shows nested resources by default:15:24
*** felipemonteiro has joined #heat15:25
shardyhttp://paste.openstack.org/show/682097/15:26
therveHum...15:29
therveshardy, Did you change the templates?15:29
therveThat's not what I see15:29
shardytherve: yes the nested one, see the bottom of the paste15:29
therveshardy, But you have count 0?15:29
shardytherve: Ah no, that's with count=115:29
therveAh alright15:29
shardytherve: yeah resources is [[]] with count=015:30
therveOK that makes sense15:31
therveSo yeah we can't override preview blindly15:33
*** hongbin has joined #heat15:46
*** liyi has joined #heat15:49
*** liyi has quit IRC15:53
*** om2 has joined #heat15:58
openstackgerritZane Bitter proposed openstack/heat master: Fix grenade test  https://review.openstack.org/54704616:00
*** crose has joined #heat16:04
*** ramishra has quit IRC16:11
*** sshnaidm is now known as sshnaidm|off16:12
*** sshnaidm|off has quit IRC16:17
*** ktibi has joined #heat16:19
ktibiHi heat, I use pike and I have issue with heat and ceilometer. (I use kolla).  I don't know why but heat want to use public endpoint for join ceilometer. If I check my conf I have [clients] endpoint_type = internalURL16:20
ktibiAny idea why heat use ceilometer public API ? because public endpoint have SSL and is in public network.16:21
*** eqrt has quit IRC16:22
openstackgerritThomas Herve proposed openstack/heat master: Return nested parameters for resource group.  https://review.openstack.org/54705516:22
*** armaan has quit IRC16:33
*** serlex has quit IRC16:33
*** armaan has joined #heat16:33
*** d0ugal has quit IRC16:35
*** d0ugal has joined #heat16:40
*** om2 has quit IRC16:47
*** Smeared_Beard has joined #heat16:48
*** SmearedBeard has quit IRC16:50
*** om2 has joined #heat16:51
*** liyi has joined #heat16:58
*** liyi has quit IRC17:02
*** links has joined #heat17:05
*** fragatina has joined #heat17:08
*** AlexeyAbashkin has quit IRC17:09
*** armaan has quit IRC17:12
*** armaan has joined #heat17:13
*** ricolin_ has quit IRC17:17
*** dprince has quit IRC17:28
openstackgerritMerged openstack/heat master: Imported Translations from Zanata  https://review.openstack.org/54565917:29
*** om2 has quit IRC17:33
*** crose has quit IRC17:47
*** armaan has quit IRC17:51
*** armaan has joined #heat17:52
*** om2 has joined #heat17:52
*** dprince has joined #heat17:55
*** liyi has joined #heat17:57
*** derekh has quit IRC18:00
*** liyi has quit IRC18:02
*** blomquisg is now known as blomquisg_gone18:14
*** gfidente has quit IRC18:16
*** blues-man has quit IRC18:26
*** gfidente has joined #heat18:29
*** openstackgerrit has quit IRC18:33
*** AlexeyAbashkin has joined #heat18:36
*** AlexeyAbashkin has quit IRC18:40
*** pbourke_ has quit IRC18:53
*** liyi has joined #heat18:57
*** liyi has quit IRC19:01
*** gfidente has quit IRC19:09
*** links has quit IRC19:11
*** liyi has joined #heat19:47
*** liyi has quit IRC19:51
*** fragatina has quit IRC20:12
*** dprince has quit IRC20:27
prometheanfireare the openstack clients ACTUALLY required or is it more of a soft requirement? (in requirements.txt)20:30
*** ktibi has quit IRC20:37
*** jmlowe has quit IRC20:50
*** liyi has joined #heat21:16
*** dprince has joined #heat21:18
*** liyi has quit IRC21:21
*** jtomasek has quit IRC21:27
zanebprometheanfire: more of a soft requirement, although obviously without any of them there's not much you can do ;)21:44
prometheanfirezaneb: sure, I was hoping we could just have a subset or do a setup.cfg extras thing so the end user can pick21:50
*** jcoufal has quit IRC22:09
*** armaan has quit IRC22:13
*** liyi has joined #heat22:16
*** liyi has quit IRC22:21
*** felipemonteiro has quit IRC22:31
*** dprince has quit IRC22:33
*** rcernin has joined #heat22:38
*** sshnaidm has joined #heat22:40
*** sshnaidm is now known as sshnaidm|off22:40
*** fragatina has joined #heat22:42
*** hoonetorg has quit IRC22:56
*** jmlowe has joined #heat23:08
*** hoonetorg has joined #heat23:11
*** dbecker has quit IRC23:20
*** hongbin has quit IRC23:34
« Wednesday, 2018-02-21 Index Friday, 2018-02-23 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!