Friday, 2018-02-02

*** liyi has joined #heat00:06
*** liyi has quit IRC00:06
*** rcernin has joined #heat00:27
*** yangyapeng has quit IRC00:31
*** yangyapeng has joined #heat00:32
*** yangyapeng has quit IRC00:36
*** pengdake_ has joined #heat01:16
*** clayton has quit IRC01:22
*** clayton has joined #heat01:25
*** yangyapeng has joined #heat01:26
*** Sandy619 has joined #heat01:34
*** ricolin has joined #heat01:43
*** liyi has joined #heat01:56
*** liyi has quit IRC02:31
*** liyi has joined #heat02:35
*** liyi has quit IRC02:35
*** liyi has joined #heat02:35
*** namnh has joined #heat02:46
*** derekjhyang has joined #heat02:50
derekjhyangHey, folks02:50
derekjhyanghttps://www.irccloud.com/pastebin/nwR0owjr/02:51
derekjhyangAny ideas to solve it ?02:51
derekjhyangmy heat version is pike and my python-heatclient version is 1.11.002:52
*** hongbin has joined #heat02:56
*** Sandy619 has quit IRC03:11
*** openstackgerrit has joined #heat03:18
openstackgerritlvxianguo proposed openstack/heat-dashboard master: fix error url  https://review.openstack.org/54022603:18
openstackgerritliyi proposed openstack/heat master: Delete unreachable code in octavia_base  https://review.openstack.org/54023203:27
*** pengdake_ has quit IRC03:33
*** pengdake_ has joined #heat03:35
*** ramishra has joined #heat03:38
*** flwang1 has quit IRC03:49
*** pengdake_ has quit IRC03:59
openstackgerritRabi Mishra proposed openstack/heat master: Fix some docstrings for octavia resources  https://review.openstack.org/54024304:07
*** harlowja_ has quit IRC04:09
*** felipemonteiro has joined #heat04:15
ricolinramishra, I think you happen to encounter  depend on issue when they test on new depends on method04:19
ricolinhttps://www.mail-archive.com/openstack-infra@lists.openstack.org/msg05779.html04:19
ricolinramishra, ^^^04:19
ramishraI tried the new method, but that did not work either https://review.openstack.org/#/c/539088/204:21
ramishraricolin: I don't know, why it did not work then, but yeah, we should use the new syntax04:23
ricolinyeah, the old way will retired any second:)04:23
ricolinramishra, can you review https://review.openstack.org/#/c/539949/ when you got free time04:24
ricolinheat-agents tests is broken without it04:25
ramishraricolin: sure, will have a look, 652 lines of change;)04:29
ramishraricolin: Done04:36
ricolinramishra, thx04:39
*** jmlowe_ has quit IRC04:40
*** jmlowe has joined #heat04:41
*** felipemonteiro has quit IRC04:42
ramishraricolin: opestack-tox-cover post pipeline job is failing http://logs.openstack.org/9e/9e4cda46e636d20a5da70e7112827e4be703526d/post/openstack-tox-cover/c1598ab/job-output.txt.gz#_2018-01-31_11_44_14_76996904:43
ramishrathough not blocking we should land https://review.openstack.org/#/c/539516/ soon:)04:44
ricolinramishra, +2ed04:46
openstackgerritMerged openstack/heat-agents master: Fix heat docker agent tests  https://review.openstack.org/53994904:46
*** jmlowe has quit IRC04:54
*** jmlowe has joined #heat04:55
*** harlowja has joined #heat04:56
*** pengdake_ has joined #heat04:59
*** hongbin has quit IRC05:00
*** links has joined #heat05:15
*** jmlowe has quit IRC05:15
*** jmlowe has joined #heat05:17
derekjhyangI met this errors as follows when I ran a simple heat template, anyone have ideas to solve it ? my heatclient version is 1.11.0 and my heat version is pike05:23
derekjhyang================================05:23
derekjhyangFeb 02 19:06:43 ubuntu devstack@h-api.service[12842]: ERROR heat.common.wsgi Traceback (most recent call last):05:23
derekjhyangFeb 02 19:06:43 ubuntu devstack@h-api.service[12842]: ERROR heat.common.wsgi   File "/opt/stack/heat/heat/common/wsgi.py", line 836, in __call__05:23
derekjhyangFeb 02 19:06:43 ubuntu devstack@h-api.service[12842]: ERROR heat.common.wsgi     request, **action_args)05:23
*** derekjhyang has quit IRC05:23
*** derekjhyang has joined #heat05:23
*** pengdake_ has quit IRC05:24
*** yangyapeng has quit IRC05:25
*** pengdake_ has joined #heat05:28
ramishraderekjhyang: may be you can paste the full traceback at http://paste.openstack.org/ for someone to check. 3 lines of traceback would not help;)05:34
*** mdnadeem has joined #heat05:34
derekjhyangramishra thank you for your hint05:37
derekjhyanghere is my full traceback05:37
derekjhyanghttp://paste.openstack.org/show/658385/05:37
ramishraderekjhyang: Are you using postgresql?05:40
*** jmlowe has quit IRC05:42
*** jmlowe has joined #heat05:43
ramishraIt's a db error, "Remote error: DBError (psycopg2.ProgrammingError) relation "stack" does not exist",  probably your db is not good05:43
*** k_mouza has joined #heat05:47
ramishraderekjhyang: We don't test with postgresql, you're better off using mysql I think05:49
*** k_mouza has quit IRC05:52
openstackgerritMerged openstack/heat-agents master: Add reno for release notes management  https://review.openstack.org/52658505:53
*** jmlowe has quit IRC05:57
*** jmlowe has joined #heat06:00
*** yangyapeng has joined #heat06:00
*** armaan has quit IRC06:00
openstackgerritMerged openstack/heat-tempest-plugin master: Zuul: Remove project name  https://review.openstack.org/53858306:10
*** jmlowe has quit IRC06:10
*** jmlowe has joined #heat06:12
*** rcernin has quit IRC06:20
*** pengdake has joined #heat06:21
*** jmlowe has quit IRC06:22
*** pengdake_ has quit IRC06:23
*** jmlowe has joined #heat06:24
*** dbecker has quit IRC06:32
*** jmlowe has quit IRC06:34
*** dbecker has joined #heat06:45
openstackgerritKazunori Shinohara proposed openstack/heat master: Add Blazar support to Heat  https://review.openstack.org/53457606:47
*** jmlowe has joined #heat06:48
openstackgerritAndreas Jaeger proposed openstack/heat-agents master: Update requirements manually  https://review.openstack.org/53944706:53
*** jmlowe has quit IRC07:00
*** jmlowe has joined #heat07:06
openstackgerritOpenStack Proposal Bot proposed openstack/heat master: Imported Translations from Zanata  https://review.openstack.org/54027907:12
*** jmlowe has quit IRC07:17
*** AlexeyAbashkin has joined #heat07:18
*** jmlowe has joined #heat07:29
*** gfidente has joined #heat07:31
*** jmlowe has quit IRC07:46
*** AlexeyAbashkin has quit IRC07:47
*** jtomasek has joined #heat07:50
*** jmlowe has joined #heat07:52
*** AlexeyAbashkin has joined #heat07:55
*** jmlowe has quit IRC07:59
*** zhenguo has joined #heat07:59
*** gfidente is now known as gfidente|not08:03
*** gfidente has joined #heat08:06
*** gfidente has joined #heat08:06
kazshlooks still senlin/openstack sdk issue is happening...08:14
*** wangshuwei has joined #heat08:16
kazshhttp://logs.openstack.org/76/534576/13/check/openstack-tox-py27/9d7b3fa/job-output.txt.gz08:21
*** jmlowe has joined #heat08:23
ricolinkazsh, yeah, try to fix now:)08:26
kazshricolin: sounds great, thx mate!08:27
*** flwang1 has joined #heat08:27
ricolinkazsh, reviewing patches?:)08:28
kazshricolin: I'm working on path for Blazar support :)08:29
ricolincool, and remember that we will review it first but since it's a feature, we will not land it before we start rocky cycle08:31
*** flwang1 has quit IRC08:31
ricolinnow is feature freeze time:)08:32
kazshricolin: Noted with thanks:) Blazar team is saying ok this patch will be landed in rocky cycle, your review first will be highly appreciated !08:37
*** jmlowe has quit IRC08:39
*** yangyapeng has quit IRC08:55
*** yangyapeng has joined #heat08:55
*** jmlowe has joined #heat08:56
*** ccard_ has joined #heat08:57
ccard_I'm not sure whether this is a question for heat or neutron, but here goes ...08:58
ricolinccard_, try us:)08:59
ccard_I have a heat template which creates a (coreos) instance using OS::Nova::Server which has a fixed ip specified as part of the networks property09:01
openstackgerritRico Lin proposed openstack/heat master: Fix handle HttpException in Senlin Policy resource  https://review.openstack.org/54031509:02
ccard_When I try to do "heat stack-update" I always get UPDATE_FAILED on the first attempt, with the error "The IP address <blah> is in use."09:02
ricolinkazsh, ^^^09:02
ccard_This appears to be because the neutron.ipallocations table is checked for the existence of a row matching network_id, subnet_id and fixed_ip, and that row still exists.09:03
ccard_I am using Mitaka (sorry!). Is this a known issue?09:03
kazshricolin: thx:)09:03
therveccard_, What does your stack update try to do?09:06
ccard_It's a coreos instance, and the user_data is ignition JSON. The stack-update is updating that user_data, so the instance should get rebuilt.09:08
*** k_mouza has joined #heat09:08
therveOK09:08
therveIt's possible the situation has been improved since Mitaka09:09
ccard_That's what I'm interested in finding out - is there a patch I can apply, for example09:10
ccard_There's not much chance of upgrading from Mitaka :(09:10
therveIt's EOL, you should really try to upgrade09:11
*** jmlowe has quit IRC09:12
*** wangshuwei has quit IRC09:13
ccard_therve: not my decision unfortunately.09:15
ccard_therve: is it likely to be an issue fixed in heat itself?09:16
therveLikely, I don't know09:16
therveIf it's fixed, it's in Heat09:16
*** jmlowe has joined #heat09:17
ccard_Does Newton version of Heat require Newton version of everything else?09:17
therveNo09:18
ccard_So it should be possible in principle to upgrade Heat independently of the rest of OpenStack?09:18
therveYes09:19
ricolinccard_,  no, but you have to check your resource use cases. Some resource might change for a bit09:19
*** liyi has quit IRC09:19
ccard_Thanks09:19
ricolinand yes, it's independently09:20
*** flwang1 has joined #heat09:20
ricolinccard_, also in heat, we calulate ports to remove and send request to nova to do the work, so not likely a issue in heat09:21
*** armaan has joined #heat09:23
ccard_ricolin: what nova request is generated by that, so I can track it down in the logs?09:24
*** jmlowe has quit IRC09:26
ricolinccard_, you should be able to trace the request id09:29
ricolinccard_, we use `interface_detach` in novaclient if you're interest to know09:31
ccard_ricolin: thanks09:31
*** huangtianhua_ has quit IRC09:37
*** huangtianhua_ has joined #heat09:38
*** derekh has joined #heat09:44
*** jmlowe has joined #heat09:48
openstackgerritRico Lin proposed openstack/heat master: Fix handle HttpException in Senlin Policy resource  https://review.openstack.org/54031509:48
ccard_ricolin: I can see "Detach interface <blah> successful from server <blah> when prepare for replace." in the heat-engine log, but the port still exists, and can be seen with "neutron port-show", though it is DOWN.09:50
ccard_As far as I can see "nova interface-detach" is not meant to do anything except remove the port from the server.09:53
*** yangyapeng has quit IRC09:55
*** jmlowe has quit IRC10:04
ccard_This old bug https://bugs.launchpad.net/heat/+bug/1301486 mentions my scenario:10:08
openstackLaunchpad bug 1301486 in OpenStack Heat "Stack update on "OS::Nova::Server" resource fails due instance port still in use" [High,Fix released] - Assigned to Steve Baker (steve-stevebaker)10:08
ccard_" If the port specifies a fixed_ips ip_address which doesn't change10:08
ccard_    during stack-update, an error will be raised that 2 ports exist10:08
ccard_    with the same IP address. The only current workaround would be10:08
ccard_    to set update_policy:AUTO and not make any changes to the server10:08
ccard_    which results in server replacement (or do 2 stack updates using10:08
ccard_    a transition ip_address)."10:08
*** hieulq_ has quit IRC10:13
*** AlexeyAbashkin has quit IRC10:14
*** AlexeyAbashkin has joined #heat10:14
*** pengdake has quit IRC10:21
ramishraccard_: create a neutron port and use it in the server resource, rather than specifying fixed_ip directly in network property10:23
ramishrahttps://github.com/openstack/heat-templates/blob/master/hot/servers_in_new_neutron_net.yaml#L7510:23
*** AlexeyAbashkin has quit IRC10:23
*** AlexeyAbashkin has joined #heat10:23
*** jmlowe has joined #heat10:25
ccard_ramishra: I did try that, and I got a similar issue as far as I remember. I'll try it again and report back10:26
ramishraccard_: that should work I think10:26
ccard_The port also has a floating ip, so maybe that caused problems.10:27
*** shardy has joined #heat10:27
*** jmlowe has quit IRC10:38
*** d0ugal has quit IRC10:48
*** pbourke has quit IRC10:49
*** liyi has joined #heat10:51
*** pbourke has joined #heat10:51
*** flwang1 has quit IRC10:51
*** kei-ichi has quit IRC10:54
*** flwang1 has joined #heat10:54
*** kei-ichi has joined #heat10:55
*** liyi has quit IRC10:55
ccard_ramishra: with a separate port resource, I still get UPDATE-FAILED, but this time I get the error: "Update Failed: InterfaceDetachFailed: resources.<blah>: Failed to detach interface (<blah>) from server (<blah>)"10:55
*** d0ugal has joined #heat10:56
ccard_Not every time though. The first update attempt worked, so it may be a timing issue.10:56
pas-hahi all, have the following problem - AFAIU right now both the url for waitconditons and for alarms are forced to use the same heat endpoint. Is it somehow possible to differentiate them? For example, I need my waitconditions to post to the public heat API endpoint (since usually VMs do not have access to the mgmt/internal endpoints) but the Alarms to post to internal endpoint (since that will be done by AODH from some10:56
pas-hacontroller node that usually has such access)10:56
ramishraccard_: yeah, may be increase the number of attempts https://github.com/openstack/heat/blob/mitaka-eol/heat/common/config.py#L13510:58
ccard_ramishra: thanks, I'll take a look at that11:01
*** kei-ichi has quit IRC11:06
*** flwang1 has quit IRC11:07
*** kei-ichi has joined #heat11:07
*** flwang1 has joined #heat11:13
ccard_ramishra: looks like we're using the default of 10 for max_interface_check_attempts, which I think amounts to 5 seconds if I'm reading the code right11:15
*** flwang1 has quit IRC11:22
*** flwang1 has joined #heat11:22
openstackgerritDavid Rabel proposed openstack/heat master: Add missing space in template guide  https://review.openstack.org/54034711:30
ccard_ramishra: I'm going to try increasing max_interface_check_attempts to 100. Which service uses it? heat-api? heat-engine?11:32
*** liyi has joined #heat11:39
ramishraccard_: It waits for half second after every success/failed attempt, if increasing 100 helps your case, I don't know why it should take so much time... don't think it's used by anything else11:40
ccard_yes, so 10 attempts is 5 seconds. I am running a 3-controller HA OpenStack setup controlled by pacemaker, so I just wanted to know which of the heat services needed to be restarted to pick up this config change11:42
*** liyi has quit IRC11:44
ramishraheat-engine11:44
ccard_thanks11:46
*** pengdake has joined #heat11:48
*** ricolin_ has joined #heat11:48
ccard_trying some stack-updates now ...11:49
*** ricolin has quit IRC11:52
*** pengdake has quit IRC11:55
*** namnh has quit IRC11:57
openstackgerritRabi Mishra proposed openstack/heat master: Fix senlin/sdk client plugin unit tests  https://review.openstack.org/54031512:11
ramishraricolin_: I've updated your patch that fixes the tests ^^12:12
*** jmlowe has joined #heat12:16
*** jmlowe has quit IRC12:30
*** k_mouza has quit IRC12:33
*** k_mouza has joined #heat12:35
*** jmlowe has joined #heat12:38
*** yangyapeng has joined #heat12:42
*** jmlowe has quit IRC12:48
*** jmlowe has joined #heat12:50
*** gfidente has quit IRC12:53
*** gfidente|not is now known as gfidene12:54
*** gfidene is now known as gfidenyr12:54
*** gfidenyr is now known as gfidente12:54
*** k_mouza has quit IRC12:58
*** k_mouza has joined #heat12:59
*** ricolin_ has quit IRC12:59
*** jmlowe has quit IRC13:03
*** jmlowe has joined #heat13:04
*** ricolin has joined #heat13:08
ccard_ramishra: I've run a number of stack-updates now with no failures, so increasing the retry limit appears to have done the trick, in combination with having an explicit port resource. Thanks for your help!13:08
*** jmlowe has quit IRC13:14
*** jmlowe has joined #heat13:15
*** d0ugal has quit IRC13:16
*** d0ugal has joined #heat13:16
*** d0ugal has quit IRC13:16
*** d0ugal has joined #heat13:16
ramishraccard_: np:)13:19
*** jmlowe has quit IRC13:27
*** jmlowe has joined #heat13:29
*** liyi has joined #heat13:43
*** liyi has quit IRC13:47
*** k_mouza has quit IRC13:49
*** k_mouza has joined #heat13:52
*** k_mouza has quit IRC14:00
*** ramishra has quit IRC14:05
*** k_mouza has joined #heat14:08
*** jcoufal has joined #heat14:08
*** links has quit IRC14:30
*** k_mouza has quit IRC14:30
*** k_mouza has joined #heat14:31
*** k_mouza has quit IRC14:31
*** k_mouza has joined #heat14:32
*** mdnadeem has quit IRC14:56
*** blomquisg_gone is now known as blomquisg14:56
*** livelace-link has joined #heat15:23
*** armaan has quit IRC15:24
*** livelace-link has quit IRC15:26
*** livelace-link has joined #heat15:28
*** ayoung has joined #heat15:35
zanebgreat, now openstacksdk has broken the gate15:45
*** felipemonteiro has joined #heat15:49
*** mdnadeem has joined #heat15:51
*** felipemonteiro_ has joined #heat15:53
*** felipemonteiro has quit IRC15:56
ricolinzaneb, this should fix it https://review.openstack.org/#/c/540315/15:58
zanebricolin: thanks, approved16:00
*** liyi has joined #heat16:02
*** crose has joined #heat16:04
*** liyi has quit IRC16:06
*** frippe75 has joined #heat16:09
*** dmellado has quit IRC16:11
openstackgerritMerged openstack/heat-agents master: Update requirements manually  https://review.openstack.org/53944716:11
*** stevebaker has quit IRC16:11
*** mdnadeem has quit IRC16:11
*** dmellado has joined #heat16:14
*** AlexeyAbashkin has quit IRC16:14
*** livelace-link has quit IRC16:15
*** liusheng has quit IRC16:15
*** yangyapeng has quit IRC16:15
*** livelace-link has joined #heat16:16
*** yangyapeng has joined #heat16:16
*** liusheng has joined #heat16:16
*** livelace-link has quit IRC16:17
*** links has joined #heat16:19
*** yangyapeng has quit IRC16:20
*** stevebaker has joined #heat16:21
*** yangyapeng has joined #heat16:30
*** crose has quit IRC16:34
*** crose has joined #heat16:46
*** crose has quit IRC16:47
*** liusheng has quit IRC16:52
*** liusheng has joined #heat16:52
*** FL1SK has quit IRC16:55
*** pbourke has quit IRC16:56
*** AlexeyAbashkin has joined #heat16:56
*** pbourke has joined #heat16:57
*** liyi has joined #heat17:21
*** liyi has quit IRC17:25
*** ricolin has quit IRC17:29
*** derekh has quit IRC17:29
*** stevebaker has quit IRC17:33
*** dmellado has quit IRC17:34
*** harlowja has quit IRC17:37
*** AlexeyAbashkin has quit IRC17:39
*** k_mouza has quit IRC17:42
openstackgerritMerged openstack/heat master: Fix senlin/sdk client plugin unit tests  https://review.openstack.org/54031517:54
openstackgerritMonty Taylor proposed openstack/heat master: Update openstacksdk construction for forward compat  https://review.openstack.org/53192318:00
openstackgerritMonty Taylor proposed openstack/heat master: Update use of sdk interface to use 0.11  https://review.openstack.org/54046718:00
*** mordred has joined #heat18:09
*** gfidente has quit IRC18:11
*** liyi has joined #heat18:20
*** harlowja has joined #heat18:21
*** liyi has quit IRC18:25
*** dmellado has joined #heat18:35
*** links has quit IRC18:41
*** yangyape_ has joined #heat18:41
*** yangyapeng has quit IRC18:45
*** AlexeyAbashkin has joined #heat19:11
openstackgerritAndreas Jaeger proposed openstack/heat-agents master: Create doc/requirements.txt  https://review.openstack.org/52898019:17
*** stevebaker has joined #heat19:19
*** felipemonteiro_ has quit IRC19:28
*** felipemonteiro_ has joined #heat19:29
*** liyi has joined #heat19:30
*** liyi has quit IRC19:35
*** AlexeyAbashkin has quit IRC19:58
*** AlexeyAbashkin has joined #heat20:04
*** armaan has joined #heat20:16
*** armaan has quit IRC20:18
*** armaan has joined #heat20:18
*** AlexeyAbashkin has quit IRC20:19
*** liyi has joined #heat20:20
*** liyi has quit IRC20:24
*** Guest99280 has quit IRC20:27
*** felipemonteiro__ has joined #heat20:39
*** hongbin has joined #heat20:41
*** felipemonteiro_ has quit IRC20:42
openstackgerritJames E. Blair proposed openstack/heat master: Zuul: Remove project name  https://review.openstack.org/54052620:52
*** armaan has quit IRC20:58
*** mchlumsky has quit IRC20:58
*** mchlumsky has joined #heat21:03
*** liyi has joined #heat21:19
*** liyi has quit IRC21:24
openstackgerritMonty Taylor proposed openstack/heat master: Update openstacksdk construction for forward compat  https://review.openstack.org/53192321:41
openstackgerritMonty Taylor proposed openstack/heat master: Update use of sdk interface to use 0.11  https://review.openstack.org/54046721:41
openstackgerritMatthew Edmonds proposed openstack/heat master: fix logger names  https://review.openstack.org/49531022:01
mordredzaneb: do you think we should just squash those two patches?22:15
zanebmordred: it seems like we probably could at this point22:16
mordredzaneb: cool - I'll go ahead and do that - only one patch to squeeze through the gate that way :)22:16
zanebwfm :)22:16
mordredzaneb: also - did I see mention somewhere that heat supports talking to multiple/foreign clouds now?22:20
zanebmordred: no, only other regions in the same cloud22:21
zanebmordred: we'd like to do that but we don't know how to get the user's credentials for the foreign cloud in a secure way22:21
*** jcoufal has quit IRC22:21
mordredah, k. I don't know where I saw the thing that made me think of that...22:21
zanebit's a much-requested feature22:21
mordredzaneb: yah - turns out multi-cloud is super important :)22:22
mordredbut also - credentials22:22
zanebI think the answer may be 'get them from Barbican', but we haven't ever tried implementing it22:22
mordredif only the world of the internet had some mostly standard way to, you know, authorize applications to interact with services on behalf of users ...22:22
zanebikr22:23
openstackgerritMonty Taylor proposed openstack/heat master: Update openstacksdk construction  https://review.openstack.org/53192322:24
* zaneb adds an agenda item for the PTG22:25
*** felipemonteiro_ has joined #heat22:26
*** felipemonteiro__ has quit IRC22:26
mordredzaneb: yah - I'd love to chat about that topic - it's a topic we'll need to solve if/when we ever do anything with oaktree too - so I betcha if we can solve it once it'll work for both of us22:32
* zaneb changes session driver to mordred...22:33
mordreduhoh22:33
zanebjk ;)22:33
zanebhttps://etherpad.openstack.org/p/heat-rocky-ptg22:34
mordredzaneb: speaking of ... I *would* love to chat with the heat team about heat/sdk interaction and roadmap ... and would be perfectly happy to drive or co-drive that one22:34
mordredah. etherpad22:34
mordredoh! there's already a session on there22:35
zanebmordred: by happy coincidence I see Rabi added that topic already22:35
mordred\o/22:35
*** felipemonteiro__ has joined #heat22:48
*** felipemonteiro_ has quit IRC22:52
*** mchlumsky has quit IRC23:00
*** felipemonteiro__ has quit IRC23:04
*** shardy has quit IRC23:30
*** shardy has joined #heat23:30
*** pengdake has joined #heat23:52
mordred*HEADDESK*23:53
mordreddon't ya love it when the hard tests all pass but you mess up pep8?23:53

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!