*** EricGonczer_ has quit IRC | 00:48 | |
*** vijendar has joined #heat | 01:02 | |
*** vijendar1 has joined #heat | 01:02 | |
*** zz_dimtruck is now known as dimtruck | 01:08 | |
*** zhurong has joined #heat | 01:14 | |
*** yanyanhu has joined #heat | 01:21 | |
*** elynn has joined #heat | 01:29 | |
*** elynn_ has joined #heat | 01:35 | |
*** elynn has quit IRC | 01:35 | |
*** jcoufal has quit IRC | 01:38 | |
*** dimtruck is now known as zz_dimtruck | 01:52 | |
*** zhihui has joined #heat | 01:58 | |
*** EricGonczer_ has joined #heat | 02:00 | |
*** asalkeld has joined #heat | 02:16 | |
*** sdake_ has quit IRC | 02:18 | |
*** vijendar has quit IRC | 02:18 | |
*** EricGonczer_ has quit IRC | 02:28 | |
*** vijendar has joined #heat | 02:33 | |
*** vishwanathj has joined #heat | 02:53 | |
*** vishwanathj has quit IRC | 02:53 | |
*** code-R has joined #heat | 03:06 | |
*** sdake has joined #heat | 03:12 | |
*** code-R_ has joined #heat | 03:17 | |
*** code-R has quit IRC | 03:18 | |
*** code-R_ has quit IRC | 03:18 | |
*** code-R has joined #heat | 03:18 | |
*** tochi has quit IRC | 03:25 | |
*** chlong has joined #heat | 03:30 | |
*** blomquisg is now known as blomquisg_gone | 03:32 | |
*** KanagarajM has joined #heat | 03:42 | |
*** code-R has quit IRC | 03:44 | |
*** tochi has joined #heat | 03:51 | |
*** code-R has joined #heat | 04:04 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/heat: Squash database patches https://review.openstack.org/386456 | 04:05 |
---|---|---|
openstackgerrit | OpenStack Proposal Bot proposed openstack/heat: Updated from global requirements https://review.openstack.org/386359 | 04:05 |
*** flwang1 has quit IRC | 04:07 | |
openstackgerrit | Kanagaraj Manickam proposed openstack/heat: Adds 5 backport db migration place holder for newton https://review.openstack.org/386342 | 04:10 |
*** vijendar has quit IRC | 04:13 | |
*** KanagarajM has quit IRC | 04:24 | |
*** vijendar has joined #heat | 04:28 | |
*** KanagarajM has joined #heat | 04:33 | |
*** elynn_ has quit IRC | 04:34 | |
*** ctayal has joined #heat | 04:36 | |
*** KanagarajM has quit IRC | 04:38 | |
*** askb has quit IRC | 04:46 | |
*** askb has joined #heat | 04:47 | |
*** ctayal has quit IRC | 05:03 | |
*** yprokule has joined #heat | 05:08 | |
*** elynn_ has joined #heat | 05:11 | |
*** ctayal has joined #heat | 05:16 | |
*** elynn_ has quit IRC | 05:16 | |
*** elynn_ has joined #heat | 05:17 | |
*** KanagarajM has joined #heat | 05:22 | |
*** sdake has quit IRC | 05:23 | |
*** sdake has joined #heat | 05:33 | |
*** askb has quit IRC | 05:33 | |
*** sdake has quit IRC | 05:44 | |
*** jaosorior has joined #heat | 05:48 | |
*** tiantian has quit IRC | 05:53 | |
*** vijendar has quit IRC | 06:05 | |
*** rcernin has joined #heat | 06:06 | |
*** ramishra has joined #heat | 06:09 | |
*** vijendar has joined #heat | 06:21 | |
*** ctayal has quit IRC | 06:23 | |
*** shadower has joined #heat | 06:26 | |
*** jprovazn has joined #heat | 06:29 | |
*** mohankumar has joined #heat | 06:29 | |
*** jtomasek_ has joined #heat | 06:31 | |
*** ctayal has joined #heat | 06:35 | |
*** jtomasek_ has quit IRC | 06:47 | |
*** ccard has quit IRC | 07:21 | |
*** zhurong has quit IRC | 07:26 | |
*** vijendar has quit IRC | 07:29 | |
*** akuznetsov has joined #heat | 07:30 | |
*** openstackgerrit has quit IRC | 07:34 | |
*** bana_k has joined #heat | 07:34 | |
*** openstackgerrit has joined #heat | 07:35 | |
*** jpich has joined #heat | 07:35 | |
*** duvarenkov has quit IRC | 07:46 | |
*** shardy has joined #heat | 07:46 | |
*** vijendar has joined #heat | 07:48 | |
*** ctayal has quit IRC | 07:49 | |
*** flwang has quit IRC | 07:51 | |
*** duvarenkov has joined #heat | 07:51 | |
*** zzzeek has quit IRC | 08:00 | |
*** tochi has quit IRC | 08:01 | |
*** zzzeek has joined #heat | 08:01 | |
*** dbecker has joined #heat | 08:01 | |
*** flwang has joined #heat | 08:03 | |
*** sorantis has joined #heat | 08:12 | |
*** akuznetsov has quit IRC | 08:17 | |
*** tochi has joined #heat | 08:23 | |
*** tochi has quit IRC | 08:33 | |
*** ttx has joined #heat | 08:34 | |
*** ttx has left #heat | 08:35 | |
*** bana_k has quit IRC | 08:37 | |
*** ccamacho has joined #heat | 08:51 | |
*** code-R has quit IRC | 08:52 | |
*** derekh has joined #heat | 08:59 | |
*** flwang1 has joined #heat | 08:59 | |
openstackgerrit | Thomas Herve proposed openstack/heat: Add filter function https://review.openstack.org/387277 | 09:02 |
*** elynn__ has joined #heat | 09:21 | |
*** vijendar has quit IRC | 09:23 | |
*** elynn_ has quit IRC | 09:24 | |
*** chlong has quit IRC | 09:26 | |
*** KanagarajM has quit IRC | 09:27 | |
*** vijendar has joined #heat | 09:39 | |
*** askb has joined #heat | 09:39 | |
*** jaosorior has quit IRC | 09:41 | |
*** jaosorior has joined #heat | 09:42 | |
*** elynn__ has quit IRC | 09:44 | |
*** code-R has joined #heat | 09:45 | |
openstackgerrit | Merged openstack/heat: Don't resolve attribute pre-storage https://review.openstack.org/368833 | 09:45 |
*** code-R_ has joined #heat | 09:46 | |
*** code-R has quit IRC | 09:49 | |
*** eliqiao has quit IRC | 10:02 | |
*** yanyanhu has quit IRC | 10:13 | |
openstackgerrit | Merged openstack/heat: Keystone::Endpoint observe reality implementation https://review.openstack.org/300973 | 10:18 |
openstackgerrit | Merged openstack/heat-specs: Support OS::Aodh::CompositeAlarm resource https://review.openstack.org/352202 | 10:32 |
openstackgerrit | Merged openstack/python-heatclient: Updated from global requirements https://review.openstack.org/385745 | 10:33 |
*** sdake has joined #heat | 10:40 | |
*** sdake has quit IRC | 10:40 | |
openstackgerrit | huangtianhua proposed openstack/heat: Raise TypeError when a bool property has int value https://review.openstack.org/387350 | 10:49 |
openstackgerrit | huangtianhua proposed openstack/heat: Support composite alarm https://review.openstack.org/352354 | 10:51 |
openstackgerrit | huangtianhua proposed openstack/heat: Support composite alarm https://review.openstack.org/352354 | 10:51 |
openstackgerrit | Merged openstack/heat: Add new hot function str_replace_strict https://review.openstack.org/355143 | 10:52 |
openstackgerrit | Merged openstack/python-heatclient: Fix "heat output-show -F json" output format https://review.openstack.org/380379 | 10:53 |
*** derekjhyang has quit IRC | 11:10 | |
*** askb has quit IRC | 11:13 | |
*** vijendar has quit IRC | 11:20 | |
*** EricGonczer_ has joined #heat | 11:26 | |
*** EricGonczer_ has quit IRC | 11:31 | |
*** vijendar has joined #heat | 11:34 | |
*** dprince has joined #heat | 11:43 | |
*** steveg_afk has joined #heat | 11:58 | |
*** steveg_afk has quit IRC | 11:58 | |
*** EricGonczer_ has joined #heat | 12:02 | |
*** jcoufal has joined #heat | 12:08 | |
*** sai has quit IRC | 12:19 | |
*** rook_ has quit IRC | 12:20 | |
*** Guest23990 is now known as zigo | 12:21 | |
*** rook has joined #heat | 12:26 | |
*** rook is now known as Guest40693 | 12:26 | |
*** sai has joined #heat | 12:27 | |
*** zhurong has joined #heat | 12:34 | |
openstackgerrit | Thomas Herve proposed openstack/heat: Add filter function https://review.openstack.org/387277 | 12:39 |
*** sileht has quit IRC | 12:42 | |
*** jprovazn has quit IRC | 12:46 | |
*** zaneb has quit IRC | 12:47 | |
therve | ramishra, Have you seen http://paste.openstack.org/show/585947/ ? | 12:47 |
*** zaneb has joined #heat | 12:48 | |
*** sileht has joined #heat | 12:49 | |
therve | zaneb, http://paste.openstack.org/show/585947/ has been popping out since eager loading has been removed | 12:50 |
zaneb | wth | 12:51 |
therve | zaneb, Maybe just a case of NotFound not handled well | 12:52 |
therve | It seems to be concurrent with purge tests | 12:52 |
zaneb | are we not doing the purge in a single transaction? | 12:54 |
*** zhurong has quit IRC | 12:55 | |
*** zhurong has joined #heat | 12:55 | |
therve | Probably not. I don't think it matters for this anyway, as we're not in purge | 12:55 |
*** strigazi1AFK has joined #heat | 12:55 | |
therve | https://review.openstack.org/361570 changes the way purge works though | 12:56 |
zaneb | ah, so I guess we're not reading the template and the stack in the same transaction, so it's prone to getting deleted from under us | 12:56 |
therve | Right | 12:57 |
zaneb | we're currently doing the DB transactions at too low a level | 12:57 |
zaneb | but the oslo_db decorators push everything to too high a level | 12:58 |
therve | Does it? I thought it made it around basic db functions | 12:58 |
zaneb | we need to find the goldilocks equilibrium | 12:58 |
zaneb | stevebaker: ^ | 12:58 |
*** zhihui has quit IRC | 12:58 | |
*** strigazi_AFK has quit IRC | 12:58 | |
zaneb | therve: the intention AIUI is that you decorate the whole RPC/HTTP request, which doesn't work for us | 13:00 |
therve | zaneb, Ah, yeah. That indeed doesn't work | 13:00 |
therve | But stevebaker worked on something that looked reasonable | 13:00 |
therve | zaneb, https://review.openstack.org/#/c/330800/ | 13:01 |
therve | That doesn't look like what it does last time I looked though | 13:02 |
therve | Maybe because of what you said | 13:02 |
zaneb | yeah IIRC it didn't work for some reason I don't recall | 13:03 |
zaneb | but also it was still equally low-level as what we have now, so it didn't actually help | 13:03 |
therve | It's a little bit more clear IMO | 13:05 |
therve | But yeah | 13:05 |
therve | Also reader/writer distinction | 13:06 |
*** EricGonczer_ has quit IRC | 13:08 | |
*** ramishra has quit IRC | 13:08 | |
*** vijendar has quit IRC | 13:20 | |
*** jprovazn has joined #heat | 13:27 | |
*** vijendar has joined #heat | 13:30 | |
*** sorantis has quit IRC | 13:36 | |
*** cmartin has joined #heat | 13:38 | |
openstackgerrit | Merged openstack/heat: Get rid of cfn-compatibility in ResourceDefinition.Diff https://review.openstack.org/386849 | 13:38 |
*** blomquisg_gone is now known as blomquisg | 13:39 | |
openstackgerrit | Merged openstack/heat: Remove the Resource.parsed_template() method https://review.openstack.org/386850 | 13:40 |
*** wirehead_ has quit IRC | 13:42 | |
*** akuznetsov has joined #heat | 13:46 | |
*** akuznetsov has quit IRC | 13:47 | |
*** wirehead_ has joined #heat | 13:48 | |
*** akuznetsov has joined #heat | 13:50 | |
*** zaneb has quit IRC | 13:54 | |
*** blues-man has joined #heat | 13:55 | |
*** zaneb has joined #heat | 13:56 | |
*** jnettlet has joined #heat | 14:01 | |
*** tanvirt has joined #heat | 14:05 | |
*** ricolin has joined #heat | 14:07 | |
*** jasond has joined #heat | 14:08 | |
*** blues-man has quit IRC | 14:11 | |
*** rajpatel has joined #heat | 14:12 | |
*** KanagarajM has joined #heat | 14:13 | |
*** blues-man has joined #heat | 14:16 | |
*** vijendar has quit IRC | 14:16 | |
openstackgerrit | Rico Lin proposed openstack/heat: Add Placeholder class https://review.openstack.org/387463 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Add InvalidPlaceholder exception https://review.openstack.org/387464 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Add allow_placeholder to seperate validation cases https://review.openstack.org/387465 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Do not allow ignore InvalidTemplateAttribute https://review.openstack.org/387466 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Use InvalidPlaceholder to mark resource fail https://review.openstack.org/387467 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Raise InvalidPlaceholder in non-validation https://review.openstack.org/387468 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Use Placeholder to get defalut property value https://review.openstack.org/387469 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Avoid Process Placeholder in parameter https://review.openstack.org/387470 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Avoid further parsing placeholder in functions https://review.openstack.org/387471 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Allow get_resource return Placeholder https://review.openstack.org/387472 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Check Placeholder for FnGetAtt in get_attribute https://review.openstack.org/387473 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Return Placeholder in get attribute function https://review.openstack.org/387474 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Replace None with Placeholder in is_placeholder https://review.openstack.org/387475 | 14:16 |
openstackgerrit | Rico Lin proposed openstack/heat: Return Placeholder for get_attribute in resources https://review.openstack.org/387476 | 14:16 |
*** chris_hultin|AWA is now known as chris_hultin | 14:19 | |
*** EricGonczer_ has joined #heat | 14:19 | |
*** vijendar1 has quit IRC | 14:19 | |
*** EricGonczer_ has quit IRC | 14:21 | |
*** sorantis has joined #heat | 14:25 | |
*** EricGonczer_ has joined #heat | 14:29 | |
*** mfisch` is now known as mfisch | 14:30 | |
*** mfisch is now known as Guest56218 | 14:30 | |
*** randallburt has joined #heat | 14:33 | |
*** Drago has joined #heat | 14:36 | |
*** Drago has quit IRC | 14:36 | |
*** Drago has joined #heat | 14:36 | |
*** randallburt has quit IRC | 14:37 | |
*** randallburt has joined #heat | 14:41 | |
*** crose has joined #heat | 14:47 | |
*** dprince has quit IRC | 14:49 | |
*** EricGonczer_ has quit IRC | 14:52 | |
*** palexster1 is now known as palexster | 14:53 | |
*** spotz_zzz is now known as spotz | 14:54 | |
*** tanvirt has quit IRC | 14:58 | |
*** vijendar has joined #heat | 14:59 | |
*** vijendar_ has joined #heat | 14:59 | |
*** akuznetsov has quit IRC | 15:09 | |
openstackgerrit | boden proposed openstack/heat: Replace retrying with tenacity https://review.openstack.org/367638 | 15:13 |
*** sdake has joined #heat | 15:15 | |
*** zhurong has quit IRC | 15:22 | |
*** tanvirt has joined #heat | 15:22 | |
*** code-R_ has quit IRC | 15:26 | |
*** rcernin has quit IRC | 15:26 | |
*** rajpatel1 has joined #heat | 15:29 | |
*** rajpatel has quit IRC | 15:31 | |
*** lamt has joined #heat | 15:39 | |
*** KanagarajM has quit IRC | 15:41 | |
*** harlowja_at_home has joined #heat | 15:41 | |
*** crose has quit IRC | 15:42 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/heat: Updated from global requirements https://review.openstack.org/386359 | 15:43 |
*** jistr is now known as jistr|biab | 15:46 | |
*** code-R has joined #heat | 15:46 | |
*** code-R_ has joined #heat | 15:50 | |
*** david-lyle_ has joined #heat | 15:52 | |
*** david-lyle has quit IRC | 15:53 | |
*** ctayal has joined #heat | 15:53 | |
*** code-R has quit IRC | 15:53 | |
*** sdake_ has joined #heat | 15:55 | |
*** sdake has quit IRC | 15:58 | |
*** code-R_ has quit IRC | 16:00 | |
*** code-R has joined #heat | 16:01 | |
*** blues-man has quit IRC | 16:01 | |
*** Guest56218 is now known as mfisch | 16:06 | |
*** mfisch is now known as Guest8770 | 16:06 | |
*** ctayal has quit IRC | 16:06 | |
*** rcernin has joined #heat | 16:10 | |
*** Guest8770 is now known as mfisch | 16:10 | |
*** mfisch has quit IRC | 16:10 | |
*** mfisch has joined #heat | 16:10 | |
*** zaneb has quit IRC | 16:13 | |
*** dprince has joined #heat | 16:14 | |
*** yprokule has quit IRC | 16:18 | |
*** jpich has quit IRC | 16:18 | |
*** Zer0Byte__ has joined #heat | 16:20 | |
*** jistr|biab is now known as jistr | 16:22 | |
*** david-lyle_ is now known as david-lyle | 16:24 | |
*** jtomasek has quit IRC | 16:28 | |
*** dprince has quit IRC | 16:28 | |
*** dprince has joined #heat | 16:29 | |
*** zaneb has joined #heat | 16:29 | |
*** bana_k has joined #heat | 16:33 | |
*** ctayal has joined #heat | 16:34 | |
*** ricolin has quit IRC | 16:40 | |
*** code-R has quit IRC | 16:41 | |
*** derekh has quit IRC | 16:44 | |
*** sorantis has quit IRC | 16:51 | |
*** sorantis has joined #heat | 16:51 | |
*** harlowja_at_home has quit IRC | 16:55 | |
*** Drago has quit IRC | 16:56 | |
*** randallburt has quit IRC | 16:56 | |
*** jaosorior has quit IRC | 16:57 | |
*** Drago has joined #heat | 16:59 | |
*** lamt has quit IRC | 17:00 | |
*** beekneemech has quit IRC | 17:02 | |
*** rajpatel1 has quit IRC | 17:02 | |
*** bana_k has quit IRC | 17:02 | |
*** jtomasek has joined #heat | 17:04 | |
*** jaosorior has joined #heat | 17:06 | |
*** jtomasek has quit IRC | 17:06 | |
*** jtomasek has joined #heat | 17:06 | |
*** bnemec has joined #heat | 17:07 | |
*** Drago has quit IRC | 17:08 | |
*** duvarenkov has quit IRC | 17:10 | |
*** jasond has quit IRC | 17:14 | |
*** jasond` has joined #heat | 17:14 | |
*** sdake has joined #heat | 17:14 | |
*** sdake_ has quit IRC | 17:17 | |
openstackgerrit | Merged openstack/heat: Updated from global requirements https://review.openstack.org/386359 | 17:17 |
*** jaosorior has quit IRC | 17:41 | |
*** jaosorior has joined #heat | 17:42 | |
*** dprince has quit IRC | 17:42 | |
*** dprince has joined #heat | 17:43 | |
*** ayoung has joined #heat | 17:45 | |
*** spzala has joined #heat | 17:46 | |
*** jaosorior has quit IRC | 17:51 | |
*** sdake has quit IRC | 17:52 | |
*** sdake has joined #heat | 17:52 | |
*** tanvirt has quit IRC | 17:54 | |
*** lamt has joined #heat | 18:01 | |
*** lamt has quit IRC | 18:03 | |
*** randallburt has joined #heat | 18:06 | |
*** vijendar_ has quit IRC | 18:08 | |
*** vijendar has quit IRC | 18:09 | |
*** lamt has joined #heat | 18:11 | |
*** ctayal has quit IRC | 18:14 | |
*** code-R has joined #heat | 18:16 | |
*** shardy is now known as shardy_afk | 18:19 | |
*** rajpatel has joined #heat | 18:19 | |
*** ctayal has joined #heat | 18:21 | |
*** jcoufal has quit IRC | 18:23 | |
*** vijendar has joined #heat | 18:23 | |
*** vijendar1 has joined #heat | 18:23 | |
*** code-R_ has joined #heat | 18:23 | |
*** code-R has quit IRC | 18:26 | |
*** Drago has joined #heat | 18:31 | |
*** dprince has quit IRC | 18:32 | |
*** dprince has joined #heat | 18:32 | |
*** annegentle has joined #heat | 18:42 | |
*** mohankumar has quit IRC | 18:44 | |
*** blomquisg is now known as blomquisg_gone | 18:51 | |
*** blomquisg_gone is now known as blomquisg | 18:58 | |
*** Drago has quit IRC | 18:58 | |
*** cwolferh has joined #heat | 18:59 | |
*** rajpatel has quit IRC | 19:03 | |
*** dyasny_ is now known as dyasny | 19:03 | |
*** rajpatel has joined #heat | 19:10 | |
*** annegentle has quit IRC | 19:10 | |
*** EricGonczer_ has joined #heat | 19:11 | |
*** Drago has joined #heat | 19:12 | |
*** Drago has quit IRC | 19:12 | |
*** Drago has joined #heat | 19:13 | |
*** Drago has quit IRC | 19:13 | |
*** Drago has joined #heat | 19:13 | |
*** sorantis has quit IRC | 19:16 | |
*** Drago has quit IRC | 19:18 | |
*** Drago has joined #heat | 19:18 | |
*** vishwanathj has joined #heat | 19:24 | |
*** Guest40693 is now known as rook | 19:25 | |
*** sdake_ has joined #heat | 19:26 | |
*** sdake has quit IRC | 19:27 | |
*** annegentle has joined #heat | 19:29 | |
rook | shardy_afk: heya | 19:30 |
*** spotz is now known as spotz_zzz | 19:32 | |
*** ctayal has quit IRC | 19:33 | |
*** ccamacho has quit IRC | 19:34 | |
*** jcoufal has joined #heat | 19:34 | |
*** bdeschenes has joined #heat | 19:35 | |
*** akuznetsov has joined #heat | 19:38 | |
*** akuznetsov has quit IRC | 19:42 | |
stevebaker | zaneb, therve: https://review.openstack.org/#/c/330800/ is the next step, then we need to figure out how to add transaction decorators, but keep a session open for the whole request so that the identity map can be used | 19:46 |
therve | stevebaker, What happens when you don't have a request? | 19:47 |
zaneb | stevebaker: the immediate problem is actually simpler than that: https://bugs.launchpad.net/heat/+bug/1634127/comments/1 | 19:48 |
openstack | Launchpad bug 1634127 in heat "Failure trying to list stacks" [Medium,Triaged] | 19:48 |
stevebaker | therve: I mean for the duration of the life of the request context, however that is created | 19:48 |
therve | Hum | 19:49 |
therve | stevebaker, What's the identity map? | 19:49 |
stevebaker | therve: the sqlalchemy caching thing where .get calls will return any already loaded db objects instead of hitting the database | 19:49 |
therve | I thought it was bound to transactions | 19:51 |
*** ccamacho has joined #heat | 19:51 | |
therve | Isn't that super dangerous to use that outside transaction boundaries? | 19:51 |
stevebaker | its bound to sessions, I'm still unsure about the extent to which a session can have multiple user-defined transactions | 19:52 |
stevebaker | I think as far as the engine facade pattern is intended to be used session==transaction, but that doesn't really meet our needs | 19:53 |
therve | Well | 19:53 |
therve | It's safe, at least | 19:54 |
therve | Or it behaves as we suppose it does | 19:55 |
*** askb has joined #heat | 19:55 | |
therve | I thought that at least moving to use read-only transactions when applicable would be nice | 19:56 |
stevebaker | therve: right now we have a session which lasts for the whole context, and an implicit transaction *per query* | 19:56 |
therve | Ah yeah. Then clearly we don't use the cache, otherwise things would blow up I suspect | 19:57 |
stevebaker | therve: I don't think that read/write metadata is actually used by anything, it was implemented for a galera architecture which didn't end up being used | 19:57 |
therve | stevebaker, I thought it was at least used internally by sqlalchemy to return lighter objects that don't need tracking | 19:58 |
*** spzala has quit IRC | 19:58 | |
*** spzala has joined #heat | 19:59 | |
stevebaker | therve: thats not the impression I got from zzzeek | 19:59 |
therve | Hum, okay | 19:59 |
*** spzala has quit IRC | 19:59 | |
*** spzala has joined #heat | 19:59 | |
therve | stevebaker, Why do we have implicit transactions? | 19:59 |
*** bana_k has joined #heat | 20:00 | |
*** brad[] has quit IRC | 20:00 | |
*** mfisch has quit IRC | 20:00 | |
*** mfisch has joined #heat | 20:00 | |
*** mfisch has quit IRC | 20:01 | |
*** mfisch has joined #heat | 20:01 | |
stevebaker | therve: thats the autocommit behaviour if you don't define transactions explicitly | 20:01 |
therve | Dang we have autocommit on? That's super sad | 20:02 |
stevebaker | bingo | 20:02 |
*** dsneddon is now known as dsneddon_ | 20:07 | |
*** spotz_zzz is now known as spotz | 20:08 | |
therve | zaneb, I don't really understand your comment on the bug BTW | 20:09 |
zaneb | therve: stack-list doesn't require a template, so loading the versioned object should just load the DB object for the stack and nothing else | 20:11 |
zaneb | therve: but instead it also loads the versioned object for the template, even though we don't need it | 20:11 |
zaneb | and that requires another round-trip to the DB because I made it not eager-load it at the same time as the stack | 20:12 |
therve | zaneb, But it loads it if it's there? There is no additional query | 20:12 |
*** code-R_ has quit IRC | 20:12 | |
zaneb | therve: not following. it won't be there (for values of 'there' == the identity map) because we didn't eager-load it, so new query | 20:14 |
therve | zaneb, You mean accessing the field will trigger the query? | 20:14 |
zaneb | no, I mean calling raw_template.RawTemplate.from_db_object() will trigger a query | 20:15 |
therve | Right, that's what I'm saying, it doesn't do that | 20:16 |
therve | from_db_object takes a result | 20:16 |
zaneb | oh, I see | 20:17 |
therve | But accessing the field probably does trigger the query, as it's declared in the model | 20:17 |
zaneb | so yeah, doing db_stack['raw_template'] does a query | 20:17 |
zaneb | (as opposed to raw_template_id) | 20:17 |
therve | So... yeah we should just not load it if it's not there, I don't know how we can check that | 20:18 |
therve | Removing eager loading is probably a regression otherwise | 20:18 |
zaneb | therve: make it a lazy-loaded @property that uses the raw_template_id to load it if needed | 20:19 |
zaneb | yes, correct, it was | 20:19 |
zaneb | (a regression) | 20:19 |
*** randallburt has quit IRC | 20:19 | |
zaneb | luckily we didn't backport that one to newton | 20:19 |
*** rajpatel has quit IRC | 20:20 | |
*** brad[] has joined #heat | 20:21 | |
therve | I wonder how hard it would be to remove versionedobjects. Probably not very | 20:21 |
*** flwang1 has quit IRC | 20:21 | |
*** vijendar has quit IRC | 20:24 | |
*** vijendar has joined #heat | 20:25 | |
*** vijendar1 has quit IRC | 20:25 | |
*** vijendar1 has joined #heat | 20:26 | |
*** rajpatel has joined #heat | 20:27 | |
*** ctayal has joined #heat | 20:29 | |
*** tanvirt has joined #heat | 20:32 | |
*** rajpatel has quit IRC | 20:33 | |
tanvirt | zaneb: Could you explain what operation exactly you are trying to support in this bug: https://bugs.launchpad.net/heat/+bug/1625759. Heat already has a subnet class in: heat/engine/resources/openstack/neutron/subnet.py | 20:33 |
openstack | Launchpad bug 1625759 in heat "Should be able to select external subnet for FloatingIP" [Medium,Triaged] - Assigned to Tanvir Talukder (tanvirt16) | 20:33 |
stevebaker | not very, I think. | 20:33 |
zaneb | tanvirt: the bug is about http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Neutron::FloatingIP-prop-floating_network | 20:35 |
*** code-R has joined #heat | 20:35 | |
*** jprovazn has quit IRC | 20:47 | |
*** blomquisg is now known as blomquisg_gone | 20:54 | |
openstackgerrit | Merged openstack/python-heatclient: Use region_name and interface with session https://review.openstack.org/385790 | 20:59 |
*** Drago has quit IRC | 21:01 | |
*** Drago has joined #heat | 21:02 | |
*** jcoufal has quit IRC | 21:09 | |
openstackgerrit | Crag Wolfe proposed openstack/heat: Add allow_empty_param_val argument to str_replace_strict function https://review.openstack.org/359605 | 21:10 |
*** cmartin has quit IRC | 21:12 | |
*** vijendar has quit IRC | 21:17 | |
*** vijendar1 has quit IRC | 21:17 | |
*** dprince has quit IRC | 21:17 | |
*** spzala has quit IRC | 21:18 | |
*** chris_hultin is now known as chris_hultin|AWA | 21:19 | |
*** spzala has joined #heat | 21:19 | |
openstackgerrit | Crag Wolfe proposed openstack/heat: Add resource_properties_data data migration https://review.openstack.org/361900 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Add migration function for legacy properties data https://review.openstack.org/364710 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Add the ResourcePropertiesData object https://review.openstack.org/361901 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Refactor purge_deleted, operate on batches of stacks https://review.openstack.org/361570 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: One transaction per encrypt/decrypt batch https://review.openstack.org/362290 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Refactor batch encrypt/decrpyts of params, props https://review.openstack.org/361902 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Add resource_properties_data assoc. to resource, event objs https://review.openstack.org/362661 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: De-duplicate properties_data between events, resources https://review.openstack.org/363415 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Minor encrypt/decrypt unittest refactor https://review.openstack.org/361898 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Refactor, add encrypt/decrypt data dict functions to crypt https://review.openstack.org/361899 | 21:32 |
openstackgerrit | Crag Wolfe proposed openstack/heat: Lazy-load resource_properties_data for events https://review.openstack.org/368188 | 21:32 |
*** vishwanathj has quit IRC | 21:38 | |
*** shardy_afk has quit IRC | 21:44 | |
*** flwang1 has joined #heat | 21:46 | |
*** code-R has quit IRC | 21:54 | |
*** code-R has joined #heat | 21:57 | |
*** jasond` has quit IRC | 21:58 | |
*** bdeschenes has quit IRC | 22:04 | |
*** rcernin has quit IRC | 22:06 | |
*** code-R has quit IRC | 22:07 | |
*** tanvirt has quit IRC | 22:11 | |
*** spzala has quit IRC | 22:17 | |
*** ctayal has quit IRC | 22:17 | |
*** EricGonczer_ has quit IRC | 22:19 | |
*** sdake_ has quit IRC | 22:27 | |
*** sdake has joined #heat | 22:30 | |
*** EricGonczer_ has joined #heat | 22:30 | |
*** rajpatel has joined #heat | 22:36 | |
*** ctayal has joined #heat | 22:37 | |
*** sdake_ has joined #heat | 22:40 | |
*** lamt has quit IRC | 22:41 | |
*** sdake has quit IRC | 22:44 | |
*** bdeschenes has joined #heat | 22:46 | |
*** vijendar has joined #heat | 22:48 | |
*** annegentle has quit IRC | 22:49 | |
*** vijendar1 has joined #heat | 22:53 | |
*** daneyon has joined #heat | 22:56 | |
*** vijendar has quit IRC | 23:01 | |
*** vijendar has joined #heat | 23:01 | |
*** zz_dimtruck is now known as dimtruck | 23:04 | |
*** vijendar1 has quit IRC | 23:13 | |
*** vijendar has quit IRC | 23:13 | |
cwolferh | not sure how scarce the check experimental resources are. i'd be curious if the needle moves for https://review.openstack.org/#/c/385111/ (not super optimistic it will). anyway, wanted to check here before adding the "check experimental" comment | 23:13 |
*** vijendar has joined #heat | 23:13 | |
*** vijendar1 has joined #heat | 23:18 | |
*** vijendar has quit IRC | 23:25 | |
*** ctayal has quit IRC | 23:26 | |
*** vijendar has joined #heat | 23:26 | |
*** vijendar1 has quit IRC | 23:26 | |
*** vijendar has quit IRC | 23:30 | |
*** lamt has joined #heat | 23:31 | |
*** rajpatel has quit IRC | 23:35 | |
*** elynn has joined #heat | 23:35 | |
*** ctayal has joined #heat | 23:36 | |
*** chlong has joined #heat | 23:41 | |
*** sdake has joined #heat | 23:46 | |
*** sdake_ has quit IRC | 23:50 | |
*** Drago has quit IRC | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!