| *** rajpatel1 has quit IRC | 00:02 | |
| *** rajpatel has joined #heat | 00:02 | |
| *** rajpatel has left #heat | 00:04 | |
| *** zhurong has quit IRC | 00:04 | |
| *** bana_k has quit IRC | 00:08 | |
| *** Drago has quit IRC | 00:22 | |
| *** Drago has joined #heat | 00:23 | |
| *** Drago has quit IRC | 00:23 | |
| *** Drago has joined #heat | 00:23 | |
| *** vijendar has quit IRC | 00:27 | |
| *** vijendar has joined #heat | 00:31 | |
| *** annegent_ has quit IRC | 00:32 | |
| *** Drago has quit IRC | 00:33 | |
| *** Drago has joined #heat | 00:35 | |
| *** Drago has quit IRC | 00:41 | |
| *** Drago has joined #heat | 00:42 | |
| *** vijendar has quit IRC | 00:45 | |
| openstackgerrit | Merged openstack/heat: Hidden policies property of OS::Mistral::Workflow https://review.openstack.org/359853 | 00:47 |
|---|---|---|
| *** Drago has quit IRC | 00:56 | |
| *** Drago has joined #heat | 00:56 | |
| *** spotz is now known as spotz_zzz | 01:19 | |
| *** zhurong has joined #heat | 01:20 | |
| *** fultonj has joined #heat | 01:34 | |
| *** yanyanhu_ has joined #heat | 01:36 | |
| *** dfflanders has joined #heat | 01:40 | |
| *** zhihui has joined #heat | 01:40 | |
| *** Drago has quit IRC | 01:42 | |
| *** fultonj has quit IRC | 01:48 | |
| *** Drago has joined #heat | 01:58 | |
| *** Drago has quit IRC | 01:58 | |
| *** Drago has joined #heat | 01:59 | |
| *** vijendar has joined #heat | 02:00 | |
| *** sabeen1 has quit IRC | 02:05 | |
| *** sabeen has joined #heat | 02:09 | |
| *** vijendar has quit IRC | 02:10 | |
| *** caowei has joined #heat | 02:11 | |
| *** tiantian has joined #heat | 02:14 | |
| *** EricGonczer_ has quit IRC | 02:15 | |
| *** om has quit IRC | 02:21 | |
| openstackgerrit | Merged openstack/heat: Use minimal image wherever possible https://review.openstack.org/379109 | 02:24 |
| openstackgerrit | Merged openstack/heat: Using assertIsNone() instead of assertEqual(None, ...) https://review.openstack.org/378147 | 02:24 |
| openstackgerrit | Merged openstack/heat: Speed up environment test https://review.openstack.org/376521 | 02:25 |
| *** om has joined #heat | 02:25 | |
| openstackgerrit | zhufl proposed openstack/heat: Remove unnecessary setUp and tearDown https://review.openstack.org/373586 | 02:45 |
| *** yuanying has quit IRC | 02:47 | |
| *** spotz_zzz is now known as spotz | 02:54 | |
| *** yuanying has joined #heat | 02:55 | |
| *** david-lyle has quit IRC | 03:04 | |
| *** priteau has joined #heat | 03:16 | |
| *** priteau has quit IRC | 03:21 | |
| *** om has joined #heat | 03:23 | |
| *** yuanying has quit IRC | 03:38 | |
| *** yuanying has joined #heat | 03:49 | |
| *** links has joined #heat | 03:59 | |
| *** ramishra has quit IRC | 04:26 | |
| *** ramishra has joined #heat | 04:28 | |
| *** cllewellyn_ has joined #heat | 04:34 | |
| *** Drago has quit IRC | 04:34 | |
| *** Zer0Byte__ has quit IRC | 04:41 | |
| *** sdake_ has joined #heat | 04:42 | |
| *** sdake has quit IRC | 04:46 | |
| *** om has quit IRC | 04:49 | |
| *** sdake_ has quit IRC | 05:19 | |
| *** code-R has joined #heat | 05:22 | |
| *** code-R_ has joined #heat | 05:23 | |
| *** code-R has quit IRC | 05:27 | |
| *** cllewellyn_ has quit IRC | 05:31 | |
| *** jaosorior has joined #heat | 05:40 | |
| *** code-R_ has quit IRC | 05:43 | |
| *** bks has joined #heat | 05:53 | |
| *** sdake has joined #heat | 05:59 | |
| *** spotz is now known as spotz_zzz | 06:04 | |
| *** rcernin has joined #heat | 06:07 | |
| *** yprokule has joined #heat | 06:11 | |
| openstackgerrit | shizhihui proposed openstack/heat: Remove redundant import code https://review.openstack.org/379951 | 06:18 |
| *** jprovazn has joined #heat | 06:27 | |
| *** sdake has quit IRC | 06:35 | |
| *** sdake has joined #heat | 06:35 | |
| *** jaosorior has quit IRC | 06:40 | |
| *** mohankumar has joined #heat | 06:54 | |
| *** yanyanhu_ has quit IRC | 07:22 | |
| *** jamielennox is now known as jamielennox|away | 07:23 | |
| *** rwsu has quit IRC | 07:27 | |
| *** evilt0ne has quit IRC | 07:27 | |
| *** akuznetsov has joined #heat | 07:30 | |
| *** sdake_ has joined #heat | 07:34 | |
| *** mohankumar has quit IRC | 07:35 | |
| *** sdake has quit IRC | 07:37 | |
| *** ayoung has quit IRC | 07:47 | |
| *** jpich has joined #heat | 07:53 | |
| *** ayoung has joined #heat | 07:54 | |
| *** rwsu has joined #heat | 07:54 | |
| *** spotz_zzz is now known as spotz | 07:55 | |
| *** sabeen has quit IRC | 07:56 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #heat | 08:00 | |
| *** ayoung has quit IRC | 08:00 | |
| *** yassine has joined #heat | 08:07 | |
| *** yassine is now known as Guest97631 | 08:07 | |
| *** sorantis has joined #heat | 08:11 | |
| *** shardy has joined #heat | 08:16 | |
| *** priteau has joined #heat | 08:20 | |
| *** derekh has joined #heat | 08:20 | |
| *** sdake_ has quit IRC | 08:23 | |
| *** mohankumar has joined #heat | 08:33 | |
| *** akuznetsov has quit IRC | 08:36 | |
| *** zhurong has quit IRC | 08:39 | |
| *** code-R has joined #heat | 09:20 | |
| *** code-R_ has joined #heat | 09:22 | |
| *** code-R has quit IRC | 09:24 | |
| *** ramishra has quit IRC | 09:38 | |
| *** ramishra has joined #heat | 09:39 | |
| *** zhihui has quit IRC | 09:46 | |
| *** prazumovsky has joined #heat | 10:06 | |
| *** mohankumar has quit IRC | 10:15 | |
| *** jprovazn has quit IRC | 10:19 | |
| prazumovsky | ricolin: there is the question, addressed to you, please pay attention: https://review.openstack.org/#/c/373548/ | 10:20 |
| openstackgerrit | Merged openstack/heat-specs: Changed the homepage of heat-specs https://review.openstack.org/375302 | 10:29 |
| openstackgerrit | Merged openstack/heat: Remove unnecessary setUp and tearDown https://review.openstack.org/373586 | 10:47 |
| *** shardy is now known as shardy_lunch | 10:59 | |
| openstackgerrit | Merged openstack/heat: Break cycle between Resource and Attributes https://review.openstack.org/377061 | 11:00 |
| openstackgerrit | Merged openstack/heat: Fix a typo in engine_wrapper.py https://review.openstack.org/378456 | 11:05 |
| *** spotz is now known as spotz_zzz | 11:09 | |
| *** zaneb has quit IRC | 11:22 | |
| *** tiantian has quit IRC | 11:27 | |
| *** liusheng has quit IRC | 11:27 | |
| *** dprince has joined #heat | 11:40 | |
| *** ccamacho has quit IRC | 11:40 | |
| *** shardy_lunch is now known as shardy | 11:42 | |
| *** ccamacho has joined #heat | 11:51 | |
| *** jprovazn has joined #heat | 11:51 | |
| *** EricGonczer_ has joined #heat | 11:55 | |
| openstackgerrit | Mocan Cosmin proposed openstack/heat-templates: Fixed MSSQL template to support 2008, 2014, 2016 versions. https://review.openstack.org/377658 | 11:57 |
| *** caowei has quit IRC | 11:58 | |
| openstackgerrit | Dmitriy Uvarenkov proposed openstack/heat: Fix cache storing problem https://review.openstack.org/366696 | 11:59 |
| prazumovsky | KanagarajM: hi! I update patch https://review.openstack.org/#/c/365651/ , please, take a look | 12:13 |
| openstackgerrit | shizhihui proposed openstack-dev/heat-cfnclient: Standardize the output format of 'help' in some files https://review.openstack.org/377279 | 12:20 |
| *** dfflanders has quit IRC | 12:23 | |
| *** ccamacho is now known as ccamacho|lunch | 12:25 | |
| *** zhihui has joined #heat | 12:31 | |
| *** zhihui has quit IRC | 12:46 | |
| *** vijendar has joined #heat | 12:54 | |
| *** links has quit IRC | 12:56 | |
| *** david-lyle has joined #heat | 12:57 | |
| therve | shardy, https://review.openstack.org/377061 seems to be improving the memory situation a bit | 13:01 |
| shardy | therve: great, I'll pull it and plot the results for tripleo :) | 13:02 |
| therve | shardy, Don't get too excited :) | 13:02 |
| therve | shardy, BTW, can you explain a little bit how you measure those? | 13:03 |
| shardy | therve: yeah, it's pretty basic, I just use top in a shell script | 13:04 |
| shardy | http://paste.fedoraproject.org/439057/47524062 | 13:04 |
| shardy | then plot the results in an openoffice spreadsheet | 13:04 |
| *** sdake has joined #heat | 13:04 | |
| shardy | pretty sure there are much better ways, but it was quick ;) | 13:04 |
| shardy | I restart heat-engine, then do a two node nonha overcloud deployment | 13:05 |
| shardy | with the output of that script tee'd to a file | 13:05 |
| therve | shardy, So that's the most basic deployment right? | 13:06 |
| therve | Wondering if that's what I was testing | 13:06 |
| shardy | therve: Yup, it's the default/minimal deployment | 13:06 |
| shardy | one controller, one compute | 13:06 |
| shardy | it is actually possible to do all-in-one tripleo deployments now, but for these tests I've been using two since I started measuring things early in Newton | 13:07 |
| therve | Yeah I get a tiny bit better in master, around 10% | 13:08 |
| shardy | well, it's a step in the right direction I guess | 13:08 |
| therve | I made a bunch of tests the last couple of days, and it's unlikely to be a single cause unfortunately | 13:08 |
| shardy | only another 390% to go ;) | 13:08 |
| shardy | thanks for looking into it :) | 13:08 |
| *** caowei has joined #heat | 13:09 | |
| therve | I went back a bit on tht, and around end of august it was about 25% less | 13:09 |
| shardy | Yeah, I was expecting it to be a bit worse because we're using yaql fairly heavily now | 13:09 |
| therve | Trying to change heat code up to around early august didn't matter | 13:09 |
| therve | Well in theory yaql is limited to 10M each | 13:11 |
| therve | But it can add up, especially if it doesn't release well | 13:11 |
| shardy | https://github.com/openstack/heat/blob/master/heat/engine/hot/functions.py#L36 | 13:12 |
| shardy | that says 10000 bytes | 13:12 |
| shardy | we had to increase it to 100,000 in TripleO | 13:12 |
| therve | Oh :) | 13:12 |
| therve | shardy, So you got into the issue I guess | 13:13 |
| shardy | so that may be partially related, but I don't think it accounts for the whole increase, unless as you say there's something circular causing each query to accumulate memory usage | 13:13 |
| therve | But it's only 10k then | 13:13 |
| therve | 100k for tripleo | 13:13 |
| therve | Right, it's possibly it doesn't release well | 13:13 |
| therve | The parser is a global class variable for example | 13:14 |
| shardy | I guess we could try a reproducer with a bunch of yaql expressions? | 13:14 |
| openstackgerrit | Merged openstack/heat-specs: New Resource Type OS::Nova::Quota https://review.openstack.org/373546 | 13:14 |
| shardy | we could probably create a hacked up tripleo-heat-templates which doesn't deploy the servers and passes dummy data back from the nested stacks into the queries | 13:14 |
| shardy | https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/controller.yaml#L147 | 13:15 |
| shardy | just overriding OS::TripleO::Server with a dummy stack might be enough | 13:15 |
| therve | You need something signaling back though? | 13:16 |
| therve | That'd be fantastic if we could have that | 13:16 |
| shardy | Yeah, we'd have to either have a script polling for IN_PROGRESS deployments then signalling via heat resource-signal, or set everything to no signal | 13:16 |
| shardy | I've got to clear some other tripleo release blockers today, but can probably help next week unless anyone gets it done before then | 13:17 |
| openstackgerrit | Dmitriy Uvarenkov proposed openstack/heat-specs: Integrate Glare functionality https://review.openstack.org/315439 | 13:17 |
| shardy | I actually suspect something about the signaling may be related | 13:17 |
| shardy | as that correlates better with the steps in the graph | 13:18 |
| therve | Right, the increase is not immediate | 13:18 |
| therve | It matches the tht step deployment phase roughly, from what I can tell | 13:18 |
| shardy | Yeah, and most of our yaql evaluations happen right after the servers are built | 13:19 |
| shardy | e.g pretty near the start of the graph | 13:19 |
| therve | Interesting | 13:19 |
| shardy | yeah, so we're creating a bunch of SoftwareDeploymentGroup resources with pretty large puppet manifests repeatedly passed | 13:19 |
| shardy | then signal back and repeat | 13:19 |
| openstackgerrit | Dmitriy Uvarenkov proposed openstack/heat-specs: Integrate Glare functionality https://review.openstack.org/315439 | 13:21 |
| *** ccamacho|lunch is now known as ccamacho | 13:21 | |
| *** crose has joined #heat | 13:26 | |
| *** dave-johnston has joined #heat | 13:30 | |
| prazumovsky | therve, zaneb, shardy, stevebaker: can someone explain me, why http://docs.openstack.org/developer/heat/template_guide/openstack.html#OS::Nova::Server-prop-user_data_format uses HEAT_CFNTOOLS format by default? AFAIK, heat tries to be independent from cfn. Why we have still cfntools format, not raw by default? (asked you in case of sahara guy request) | 13:34 |
| therve | prazumovsky, Because that was the default from the beginning | 13:34 |
| therve | So "backward compatibility" is the response | 13:35 |
| prazumovsky | oh, right... it becomes crazy with all these deprecated-translation mechanism... But, if default will change, running stacks stay workable, and this will be just recreate/update user issue, isn't it? | 13:37 |
| therve | Running stacks don't change, but templates are broken | 13:39 |
| therve | We've made default configurable for other properties, maybe we could do that | 13:40 |
| prazumovsky | OK, thanks for response, will think about configurable property. | 13:40 |
| *** bks has quit IRC | 13:41 | |
| *** crose has quit IRC | 13:45 | |
| *** crose has joined #heat | 13:46 | |
| *** adrian_otto has joined #heat | 13:48 | |
| shardy | therve: I can confirm we've shaved a couple of hundred MB off my previous tests with latest master :) | 13:49 |
| shardy | so that's a good start | 13:49 |
| therve | Cool | 13:49 |
| therve | Maybe worth backporting to newton then | 13:49 |
| shardy | yes, definitely | 13:49 |
| *** akshai has joined #heat | 13:51 | |
| openstackgerrit | Peter Razumovsky proposed openstack/heat-specs: Fix milestone and new ideas to properties group https://review.openstack.org/333304 | 13:55 |
| *** K3KH has joined #heat | 13:57 | |
| *** shadower has quit IRC | 13:57 | |
| *** jasond has joined #heat | 13:58 | |
| *** shadower has joined #heat | 14:00 | |
| *** sorantis has quit IRC | 14:02 | |
| *** adrian_otto has quit IRC | 14:04 | |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Make nova server user_data format configurable https://review.openstack.org/380326 | 14:08 |
| *** spotz_zzz is now known as spotz | 14:11 | |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Make nova server user_data format configurable https://review.openstack.org/380326 | 14:12 |
| *** vishwanathj has joined #heat | 14:19 | |
| *** vijendar has quit IRC | 14:20 | |
| *** K3KH has quit IRC | 14:23 | |
| openstackgerrit | Peter Razumovsky proposed openstack/heat: Make nova server user_data format configurable https://review.openstack.org/380326 | 14:23 |
| *** rajpatel has joined #heat | 14:25 | |
| *** jprovazn has quit IRC | 14:28 | |
| *** chris_hultin|AWA is now known as chris_hultin | 14:31 | |
| *** bks has joined #heat | 14:32 | |
| *** david-lyle has quit IRC | 14:37 | |
| *** david-lyle has joined #heat | 14:38 | |
| *** kumarb has joined #heat | 14:38 | |
| *** bks has quit IRC | 14:38 | |
| *** randallburt has joined #heat | 14:40 | |
| *** rafael_ has joined #heat | 14:44 | |
| *** randallburt1 has joined #heat | 14:45 | |
| *** randallburt has quit IRC | 14:45 | |
| *** rafael_ has quit IRC | 14:45 | |
| *** adrian_otto has joined #heat | 14:48 | |
| *** annegentle has joined #heat | 14:50 | |
| *** adrian_otto has quit IRC | 14:50 | |
| *** charlesr has joined #heat | 14:52 | |
| *** rajpatel has quit IRC | 14:56 | |
| *** om has joined #heat | 15:01 | |
| *** zaneb has joined #heat | 15:02 | |
| *** prazumovsky has quit IRC | 15:02 | |
| *** vijendar has joined #heat | 15:06 | |
| *** sabeen has joined #heat | 15:16 | |
| *** akshai has quit IRC | 15:17 | |
| *** bnemec is now known as beekneemech | 15:20 | |
| *** sabeen has quit IRC | 15:21 | |
| *** Drago has joined #heat | 15:22 | |
| *** rajpatel has joined #heat | 15:27 | |
| *** adrian_otto has joined #heat | 15:27 | |
| *** rajpatel has quit IRC | 15:29 | |
| *** ccamacho has quit IRC | 15:29 | |
| *** rajpatel has joined #heat | 15:31 | |
| *** akuznetsov has joined #heat | 15:32 | |
| *** code-R_ has quit IRC | 15:37 | |
| *** yprokule has quit IRC | 15:38 | |
| *** zhenguo has quit IRC | 15:43 | |
| *** rajpatel has quit IRC | 15:43 | |
| *** rajpatel has joined #heat | 15:44 | |
| *** caowei has quit IRC | 15:56 | |
| *** zhenguo has joined #heat | 15:59 | |
| *** rajpatel has quit IRC | 16:00 | |
| *** code-R has joined #heat | 16:00 | |
| *** b00tcat has quit IRC | 16:01 | |
| *** akshai has joined #heat | 16:01 | |
| *** akshai_ has joined #heat | 16:02 | |
| *** ccamacho has joined #heat | 16:03 | |
| *** akshai has quit IRC | 16:06 | |
| *** EricGonczer_ has quit IRC | 16:07 | |
| *** rcernin has quit IRC | 16:08 | |
| *** EricGonczer_ has joined #heat | 16:08 | |
| *** charlesr has quit IRC | 16:10 | |
| therve | shardy, FWIW, I'm already at 3.2G/1.5 before creating any software deploymetn | 16:11 |
| therve | After the big middle spike | 16:11 |
| *** EricGonc_ has joined #heat | 16:11 | |
| *** bana_k has joined #heat | 16:12 | |
| shardy | therve: ack - Ok so it may be related to the yaql use early in the deployment then | 16:12 |
| *** EricGonczer_ has quit IRC | 16:13 | |
| therve | Possibly. It also just does a ton of stuff :) | 16:13 |
| shardy | therve: one think I did think - we're using yaql in outputs from nested stacks, I'm wondering if moving some of that usage to OS::Heat::Value resources might help | 16:13 |
| shardy | e.g I'm not certain if we may be re-resolving the yaql output stuff | 16:14 |
| therve | The top level template is 1M from what I can tell? | 16:14 |
| therve | shardy, Ah, you mean you're repeating the same operation? | 16:14 |
| *** code-R_ has joined #heat | 16:14 | |
| shardy | therve: there's a bit of duplication I can possibly avoid | 16:14 |
| shardy | but I mainly was thinking do we re-run the query if there's multiple get_attr's referencing the output from the parent template | 16:15 |
| shardy | because we do do that | 16:15 |
| *** code-R has quit IRC | 16:16 | |
| shardy | therve: not sure on the 1M number, in my environment the rendered overcloud.yaml is 60K or 1282 lines | 16:16 |
| shardy | and that's deploying an additional role, so the default should be less | 16:17 |
| shardy | the combination of all the data could certainly be 1M or more | 16:17 |
| therve | shardy, Hum you're right, don't know where I saw that | 16:20 |
| therve | It's about 50k | 16:20 |
| shardy | ack, that sounds about right | 16:20 |
| therve | shardy, Totally unrelated, and probably for another time, but I'd be interested to know how you get to use jinja | 16:22 |
| therve | And why we couldn't make it work in hot | 16:22 |
| shardy | therve: we need to repeat blocks of stuff in various templates depending on which roles are enabled | 16:23 |
| shardy | and we've previously rejected looping functionality in hot, and told folks to use jinja2 | 16:23 |
| shardy | so I did that ;) | 16:23 |
| shardy | definitely open to discussion on heat-native ways to do it | 16:23 |
| shardy | j2 was just the only option I could see during the newton timeframe | 16:24 |
| therve | fair | 16:24 |
| shardy | it's actually working pretty nicely tbh | 16:24 |
| shardy | it'd be pretty easy to add client side support for j2 templating e.g inside heatclient, but I recall we rejected a proposal a long time ago to support it server side | 16:25 |
| *** priteau has quit IRC | 16:26 | |
| *** priteau has joined #heat | 16:26 | |
| *** bana_k has quit IRC | 16:27 | |
| *** bana_k has joined #heat | 16:28 | |
| *** shardy has quit IRC | 16:28 | |
| *** kumarb has quit IRC | 16:29 | |
| *** bks has joined #heat | 16:31 | |
| *** KanagarajM_ has joined #heat | 16:31 | |
| zaneb | 2016-08-25 12:47 6106202112.0 | 16:33 |
| zaneb | 2016-08-25 17:01 8089440256.0 | 16:33 |
| Drago | zaneb: ping | 16:33 |
| zaneb | shardy, therve: step change in the memory usage is right there ^ | 16:34 |
| zaneb | Drago: pong | 16:34 |
| Drago | zaneb: Seeing a bug in my devstack. I have an update-only softwaredeployment. When I go to update it with a stack-update, it hits _get_derived_config_id(), which blows up because the SD doesn't have a resource_id | 16:35 |
| zaneb | Drago: ouch, yeah that's a bug :( | 16:38 |
| Drago | zaneb: I was thinking of either setting the resource_id during create no matter what, or checking resource_id in handle update like it's done in handle_delete. What do you think? | 16:38 |
| Drago | I'm not sure what the right fix is since I'm not familiar with what derived configs are | 16:39 |
| zaneb | Drago: I'd say check for it in handle_update | 16:39 |
| zaneb | https://review.openstack.org/#/c/360831/ is the cause btw | 16:40 |
| zaneb | derived config is the config with all the input values substituted in | 16:40 |
| *** rafael_ has joined #heat | 16:40 | |
| *** jpich has quit IRC | 16:40 | |
| zaneb | so it's basically a copy of the sw config, but its specific to a particular deployment | 16:41 |
| zaneb | sorry, https://review.openstack.org/#/c/360122/ is the cause | 16:41 |
| zaneb | same bug, wrong patch | 16:42 |
| Drago | I found that, yeah | 16:42 |
| zaneb | so yeah, if the derived config doesn't exist then we should not check for changed input values and never raise UpdateReplace | 16:43 |
| zaneb | Drago: did you raise a launchpad bug? I think this might be rc3-worthy | 16:45 |
| zaneb | therve: ^ | 16:45 |
| Drago | zaneb: Is it as simple as having at the top of handle_update: if self.resource_id is None: return self._handle_action(self.UPDATE) | 16:46 |
| zaneb | Drago: I believe that would do it, yes | 16:46 |
| Drago | zaneb: Okay, I will try that. | 16:46 |
| Drago | zaneb: No, I just found it and wanted to run it past you first | 16:46 |
| Drago | And you happened to be online :) | 16:46 |
| zaneb | Drago: actually, you probably still need to set self.properties | 16:47 |
| zaneb | otherwise it will use old values | 16:48 |
| Drago | zaneb: So, in a normal SD, handle_create is simply self._handle_action(self.CREATE), and it does the rest. I don't see any self.UPDATE or self.CREATE specific code in _handle_action. It only checks resource_id | 16:48 |
| zaneb | yep | 16:49 |
| zaneb | in both cases it creates a new derived config and then deploys it | 16:49 |
| Drago | zaneb: I don't see where I need to set self.properties | 16:51 |
| zaneb | Drago: http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/openstack/heat/software_deployment.py#n443 | 16:52 |
| Drago | I must be blind | 16:53 |
| Drago | Thanks | 16:53 |
| zaneb | lol | 16:53 |
| Drago | zaneb: Can I put that at the top of handle_update? | 16:54 |
| zaneb | you know, you could just do "if self.resource_id is None: old_inputs = {}; else: ..." | 16:54 |
| zaneb | where else: ... is ll. 438-441 | 16:54 |
| zaneb | and the rest would just work | 16:55 |
| Drago | Seems less clear than skipping 448-454 entirely | 16:56 |
| Drago | But if you think that would be the best way, I'll do it | 16:56 |
| *** derekh has quit IRC | 16:59 | |
| *** spotz is now known as spotz_zzz | 17:01 | |
| *** bana_k has quit IRC | 17:02 | |
| zaneb | Drago: I don't care much either way, I just thought it might be easier than either duplicating the self.properties assignment or having 2 if blocks | 17:02 |
| zaneb | and it is at least logical - there was no previous config so the set of old_inputs is empty | 17:04 |
| *** Zer0Byte__ has joined #heat | 17:05 | |
| *** Drago has quit IRC | 17:06 | |
| *** Drago has joined #heat | 17:06 | |
| *** akuznetsov has quit IRC | 17:07 | |
| *** akuznetsov has joined #heat | 17:07 | |
| *** akuznetsov has quit IRC | 17:12 | |
| Drago | zaneb, therve: https://bugs.launchpad.net/heat/+bug/1629397 | 17:28 |
| openstack | Launchpad bug 1629397 in heat "Update-only SoftwareDeployment fails on update" [Undecided,New] | 17:28 |
| Drago | back in a few | 17:28 |
| *** akshai_ has quit IRC | 17:29 | |
| openstackgerrit | Merged openstack/heat: Fix create/update keystone endpoint with service name https://review.openstack.org/303628 | 17:32 |
| *** Zer0Byte__ has quit IRC | 17:33 | |
| *** KanagarajM_ has quit IRC | 17:34 | |
| *** akshai has joined #heat | 17:43 | |
| *** Zer0Byte__ has joined #heat | 17:46 | |
| openstackgerrit | Yosef Hoffman proposed openstack/heat-specs: New Resource Type OS::Neutron::Quota https://review.openstack.org/380462 | 17:49 |
| *** Zer0Byt__ has joined #heat | 17:49 | |
| *** Zer0Byte__ has quit IRC | 17:51 | |
| *** Zer0Byt__ has quit IRC | 17:52 | |
| *** spotz_zzz is now known as spotz | 17:54 | |
| openstackgerrit | Yosef Hoffman proposed openstack/heat: Add OS::Neutron::Quota resource https://review.openstack.org/380471 | 17:54 |
| *** Zer0Byte__ has joined #heat | 17:55 | |
| openstackgerrit | Yosef Hoffman proposed openstack/heat-specs: New Resource Type OS::Neutron::Quota https://review.openstack.org/380462 | 17:58 |
| *** Guest97631 has quit IRC | 18:06 | |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Add resource_properties_data data migration https://review.openstack.org/361900 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Add migration function for legacy properties data https://review.openstack.org/364710 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Add the ResourcePropertiesData object https://review.openstack.org/361901 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Refactor purge_deleted, operate on batches of stacks https://review.openstack.org/361570 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: One transaction per encrypt/decrypt batch https://review.openstack.org/362290 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Refactor batch encrypt/decrpyts of params, props https://review.openstack.org/361902 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Add resource_properties_data assoc. to resource, event objs https://review.openstack.org/362661 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: De-duplicate properties_data between events, resources https://review.openstack.org/363415 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Minor encrypt/decrypt unittest refactor https://review.openstack.org/361898 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Refactor, add encrypt/decrypt data dict functions to crypt https://review.openstack.org/361899 | 18:08 |
| openstackgerrit | Crag Wolfe proposed openstack/heat: Lazy-load resource_properties_data for events https://review.openstack.org/368188 | 18:08 |
| *** ccamacho has quit IRC | 18:08 | |
| *** Zer0Byte__ has quit IRC | 18:08 | |
| *** adrian_otto has quit IRC | 18:11 | |
| *** vishwanathj has quit IRC | 18:11 | |
| *** adrian_otto has joined #heat | 18:14 | |
| *** vijendar has quit IRC | 18:16 | |
| *** EricGonc_ has quit IRC | 18:17 | |
| *** EricGonczer_ has joined #heat | 18:17 | |
| *** Guest97631 has joined #heat | 18:19 | |
| *** vijendar has joined #heat | 18:22 | |
| *** Zer0Byte__ has joined #heat | 18:22 | |
| openstackgerrit | Drago proposed openstack/heat: [WIP] Don't get derived config if resource ID unset https://review.openstack.org/380479 | 18:22 |
| *** zhenguo has quit IRC | 18:23 | |
| *** EricGonc_ has joined #heat | 18:31 | |
| *** EricGonczer_ has quit IRC | 18:32 | |
| *** Zer0Byte__ has quit IRC | 18:34 | |
| *** bana_k has joined #heat | 18:35 | |
| *** dave-johnston has quit IRC | 18:41 | |
| *** MVenesio has joined #heat | 18:50 | |
| *** Guest97631 has quit IRC | 18:52 | |
| *** bks has quit IRC | 18:54 | |
| *** bks has joined #heat | 18:55 | |
| openstackgerrit | Drago proposed openstack/heat: Don't get derived config if resource ID unset https://review.openstack.org/380479 | 18:56 |
| Drago | zaneb: ^ | 18:56 |
| zaneb | Drago: +2, thank you! | 18:58 |
| Drago | zaneb: Thanks for the guidance :) | 18:58 |
| *** spotz is now known as spotz_zzz | 19:03 | |
| *** spotz_zzz is now known as spotz | 19:04 | |
| *** spotz is now known as spotz_zzz | 19:04 | |
| *** annegentle has quit IRC | 19:10 | |
| *** annegentle has joined #heat | 19:10 | |
| *** openstackgerrit has quit IRC | 19:18 | |
| *** openstackgerrit has joined #heat | 19:19 | |
| *** om has quit IRC | 19:19 | |
| *** dyasny has quit IRC | 19:39 | |
| *** bks has quit IRC | 19:41 | |
| *** akuznetsov has joined #heat | 19:53 | |
| *** dyasny has joined #heat | 19:54 | |
| *** akuznetsov has quit IRC | 19:54 | |
| *** akuznetsov has joined #heat | 19:56 | |
| *** dyasny has quit IRC | 20:00 | |
| *** vijendar has quit IRC | 20:03 | |
| *** dyasny has joined #heat | 20:03 | |
| *** akuznetsov has quit IRC | 20:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-heatclient: Updated from global requirements https://review.openstack.org/378885 | 20:05 |
| *** Zer0Byte__ has joined #heat | 20:06 | |
| *** akuznetsov has joined #heat | 20:07 | |
| *** om has joined #heat | 20:09 | |
| *** dprince has quit IRC | 20:13 | |
| *** annegentle has quit IRC | 20:13 | |
| *** annegentle has joined #heat | 20:14 | |
| *** akuznetsov has quit IRC | 20:22 | |
| *** code-R_ has quit IRC | 20:32 | |
| *** vijendar has joined #heat | 20:39 | |
| *** MVenesio has quit IRC | 20:45 | |
| *** cllewellyn_ has joined #heat | 20:50 | |
| *** EricGonc_ has quit IRC | 20:55 | |
| *** EricGonczer_ has joined #heat | 20:57 | |
| *** spotz_zzz is now known as spotz | 20:57 | |
| *** spotz is now known as spotz_zzz | 20:58 | |
| *** om has quit IRC | 20:58 | |
| *** randallburt1 has quit IRC | 21:03 | |
| *** akshai has quit IRC | 21:07 | |
| *** crose has quit IRC | 21:11 | |
| *** sdake has quit IRC | 21:19 | |
| *** sdake has joined #heat | 21:25 | |
| *** cllewellyn_ has quit IRC | 21:39 | |
| *** sdake has quit IRC | 21:45 | |
| *** sdake has joined #heat | 21:46 | |
| *** jtomasek has quit IRC | 21:50 | |
| *** priteau has quit IRC | 21:51 | |
| *** vijendar has quit IRC | 21:56 | |
| *** jamielennox|away is now known as jamielennox | 21:59 | |
| *** sdake has quit IRC | 21:59 | |
| *** jasond has quit IRC | 22:01 | |
| *** annegentle has quit IRC | 22:05 | |
| *** evilt0ne has joined #heat | 22:18 | |
| *** evilt0ne has joined #heat | 22:18 | |
| openstackgerrit | Merged openstack/heat: Don't get derived config if resource ID unset https://review.openstack.org/380479 | 22:36 |
| *** Drago has quit IRC | 22:39 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/heat: Updated from global requirements https://review.openstack.org/380563 | 23:20 |
| *** rafael_ has quit IRC | 23:22 | |
| *** sdake has joined #heat | 23:29 | |
| *** bana_k has quit IRC | 23:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!