| *** openstack has joined #heat | 06:00 | |
| *** alex_xu has quit IRC | 06:03 | |
| *** alex_xu has joined #heat | 06:06 | |
| *** jprovazn has joined #heat | 06:14 | |
| *** ramishra has quit IRC | 06:21 | |
| *** neatherweb has joined #heat | 06:21 | |
| *** rcernin has joined #heat | 06:24 | |
| *** ramishra has joined #heat | 06:26 | |
| *** jcoufal has quit IRC | 06:36 | |
| *** afazekas is now known as afazekas|dentist | 06:52 | |
| *** ramishra has quit IRC | 07:00 | |
| *** ramishra has joined #heat | 07:05 | |
| *** sorantis has joined #heat | 07:05 | |
| *** bana_k has quit IRC | 07:06 | |
| *** jamielennox is now known as jamielennox|away | 07:12 | |
| *** zeih has joined #heat | 07:16 | |
| *** vincentll has joined #heat | 07:18 | |
| *** permalac has quit IRC | 07:19 | |
| *** ramishra has quit IRC | 07:19 | |
| *** ramishra has joined #heat | 07:19 | |
| *** ramishra has quit IRC | 07:26 | |
| *** ramishra has joined #heat | 07:28 | |
| *** shardy has joined #heat | 07:30 | |
| *** wangbo has quit IRC | 07:31 | |
| *** ramishra has quit IRC | 07:32 | |
| *** eldon_ has quit IRC | 07:32 | |
| *** ccamacho has joined #heat | 07:35 | |
| *** ramishra has joined #heat | 07:37 | |
| openstackgerrit | Steven Hardy proposed openstack/heat: Add test for SoftwareDeploymentGroup resource https://review.openstack.org/329460 | 07:41 |
|---|---|---|
| *** neatherweb has quit IRC | 07:43 | |
| *** ramishra has quit IRC | 07:46 | |
| *** ramishra has joined #heat | 07:46 | |
| *** eldon_ has joined #heat | 07:48 | |
| shardy | ramishra: Hi! Are you around? | 07:51 |
| *** wangbo has joined #heat | 07:53 | |
| *** jaosorior has quit IRC | 08:07 | |
| *** jaosorior has joined #heat | 08:08 | |
| *** permalac has joined #heat | 08:09 | |
| *** zeih has quit IRC | 08:14 | |
| *** zeih has joined #heat | 08:15 | |
| *** wangbo has quit IRC | 08:18 | |
| *** zeih has quit IRC | 08:19 | |
| *** jprovazn has quit IRC | 08:21 | |
| *** wangbo has joined #heat | 08:31 | |
| *** zeih has joined #heat | 08:31 | |
| ramishra | shardy: hi | 08:32 |
| ramishra | shardy: sorry was away for lunch | 08:36 |
| *** jamie_h has joined #heat | 08:43 | |
| *** yassine__ has joined #heat | 08:45 | |
| *** derekh has joined #heat | 08:47 | |
| *** jprovazn has joined #heat | 08:59 | |
| *** dmk0202 has joined #heat | 09:02 | |
| *** nijaba has quit IRC | 09:06 | |
| *** nijaba has joined #heat | 09:13 | |
| *** zeih has quit IRC | 09:22 | |
| *** mkoderer__ has quit IRC | 09:28 | |
| openstackgerrit | huangtianhua proposed openstack/heat: Decouple hot and cfn for outputs https://review.openstack.org/328917 | 09:29 |
| *** zeih has joined #heat | 09:36 | |
| openstackgerrit | Steven Hardy proposed openstack/heat-specs: Add spec for more flexible environment merging https://review.openstack.org/330414 | 09:40 |
| openstackgerrit | huangtianhua proposed openstack/heat: Provides 'if' intrinsic function https://review.openstack.org/283479 | 09:45 |
| openstackgerrit | huangtianhua proposed openstack/heat: Add a Macro class to heat.engine.function https://review.openstack.org/322248 | 09:45 |
| openstackgerrit | huangtianhua proposed openstack/heat: Support resource/output condition https://review.openstack.org/283366 | 09:45 |
| shardy | If anyone is interested in bug #1592374 https://review.openstack.org/#/c/329460/ appears to be reproducing it now | 09:49 |
| openstack | bug 1592374 in heat "deleting in_progress stack with nested stacks fails with convergence enabled" [High,Confirmed] https://launchpad.net/bugs/1592374 | 09:49 |
| shardy | the CI results seem to indicate it is a convergence specific problem | 09:49 |
| shardy | I'm unlikely to have time to pick it up in the next few days, feel free to take it if anyone wants to | 09:49 |
| *** KanagarajM has quit IRC | 09:50 | |
| *** yanyanhu has quit IRC | 10:11 | |
| *** zhurong has quit IRC | 10:14 | |
| *** jamielennox|away is now known as jamielennox | 10:15 | |
| *** sorantis has quit IRC | 10:23 | |
| *** sirushti has quit IRC | 10:26 | |
| *** sorantis has joined #heat | 10:26 | |
| *** jtomasek_ has joined #heat | 10:31 | |
| *** sirushti has joined #heat | 10:33 | |
| *** elynn_ has quit IRC | 10:36 | |
| *** sdake has joined #heat | 10:40 | |
| *** sdake_ has joined #heat | 10:42 | |
| *** sdake has quit IRC | 10:45 | |
| *** Rotwang_ has joined #heat | 10:55 | |
| Rotwang_ | Hi, can I have something like "terraform plan" with heat? | 10:55 |
| *** ccamacho is now known as ccamacho|lunch | 10:56 | |
| *** Rotwang_ is now known as Rotwang | 10:56 | |
| *** Rotwang has quit IRC | 10:56 | |
| *** Rotwang has joined #heat | 10:56 | |
| *** jtomasek_ has quit IRC | 10:59 | |
| *** mohankumar has joined #heat | 11:00 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat: Add test for SoftwareDeploymentGroup resource https://review.openstack.org/329460 | 11:06 |
| openstackgerrit | Rabi Mishra proposed openstack/heat: [WIP]Support rolling_update for SDG https://review.openstack.org/330467 | 11:06 |
| openstackgerrit | Rabi Mishra proposed openstack/heat: [WIP]Add test for rolling_update https://review.openstack.org/330468 | 11:06 |
| *** sdake_ has quit IRC | 11:10 | |
| *** ramishra has quit IRC | 11:10 | |
| *** ramishra has joined #heat | 11:16 | |
| Rotwang | the other question is cloudformation vs hot, is cloudformation not going to be accepted by heat in a later time? | 11:17 |
| Rotwang | I'm just reading a pdf from cisco on heat and this is what I've found: "HOT is not backward compatible with AWS. However, it is OpenStack native and meant to | 11:18 |
| Rotwang | replace CFN over time." | 11:18 |
| *** ananta has quit IRC | 11:25 | |
| therve | Rotwang, No it won't replace it | 11:25 |
| Rotwang | therve: so they are developed in parallel? | 11:39 |
| Rotwang | I have a elasticsearch cluster to deploy to openstack | 11:40 |
| therve | Kinda yeah | 11:40 |
| Rotwang | so I'm trying to figure out what should I use: terraform vs hot vs cloudformation | 11:40 |
| Rotwang | we use aws quite extensively, so my first thought was cloudformation | 11:41 |
| Rotwang | however template for aws and openstack wont be identical I guess (e.g. vpc settings) | 11:42 |
| Rotwang | the other thing is that cloudformation seems to lack features that hot has | 11:42 |
| Rotwang | e.g. admin_user for compute instance | 11:42 |
| Rotwang | yet another problem is that both hot and cloudformation doesn't have "previev" or "plan" that terraform or cloudformation on aws has | 11:44 |
| Rotwang | any hints for someone who wants to be able to switch between aws and openstack? | 11:44 |
| therve | I don't know what's terraform, but I guess you can't use it on Heat | 11:49 |
| therve | Heat has a preview API, not sure what you need | 11:50 |
| *** ramishra has quit IRC | 11:52 | |
| Rotwang | therve: I want see what is hot going to change if I update a stack | 11:52 |
| therve | Yeah we have that | 11:53 |
| *** dprince has joined #heat | 11:54 | |
| therve | http://developer.openstack.org/api-ref-orchestration-v1.html#stack_update_preview | 11:54 |
| Rotwang | so what is the difference between openstack command line utility and heat command line utility | 11:54 |
| Rotwang | I've heard from someone that heat is deprecated | 11:55 |
| Rotwang | but I can't find anywhere that that's true | 11:55 |
| therve | Yeah it ought to be | 11:55 |
| Rotwang | so I should use openstack cli utils then, any announcement I can refer to? | 12:00 |
| therve | "Use openstack CLI" | 12:02 |
| therve | There ^^^ :) | 12:03 |
| *** ramishra has joined #heat | 12:03 | |
| *** shardy has quit IRC | 12:04 | |
| *** sdake has joined #heat | 12:05 | |
| *** wangbo has quit IRC | 12:05 | |
| *** wangbo has joined #heat | 12:06 | |
| *** ramishra has quit IRC | 12:10 | |
| *** ramishra has joined #heat | 12:12 | |
| *** slagle_ is now known as slagle | 12:16 | |
| *** ramishra has quit IRC | 12:16 | |
| *** ramishra has joined #heat | 12:21 | |
| *** rcernin has quit IRC | 12:24 | |
| *** wangbo has quit IRC | 12:25 | |
| *** zhurong has joined #heat | 12:25 | |
| *** ccamacho|lunch is now known as ccamacho | 12:26 | |
| Rotwang | therve: thanks | 12:27 |
| *** pradk has joined #heat | 12:31 | |
| *** jcoufal has joined #heat | 12:34 | |
| *** lrensing has joined #heat | 12:34 | |
| *** tochi has quit IRC | 12:34 | |
| *** rcernin has joined #heat | 12:38 | |
| *** wangbo has joined #heat | 12:39 | |
| *** mwheckmann has joined #heat | 12:40 | |
| *** wangbo has quit IRC | 12:44 | |
| *** zeih has quit IRC | 12:44 | |
| *** wangbo has joined #heat | 12:49 | |
| *** steveg_afk has joined #heat | 12:51 | |
| *** zeih has joined #heat | 12:53 | |
| *** rcernin has quit IRC | 12:54 | |
| *** ramishra has quit IRC | 12:54 | |
| openstackgerrit | garyk proposed openstack/heat: Fix typo in LBaaS support https://review.openstack.org/330525 | 12:56 |
| *** fultonj has joined #heat | 12:57 | |
| *** ramishra has joined #heat | 12:58 | |
| *** rajpatel has joined #heat | 12:59 | |
| *** rajpatel has quit IRC | 13:00 | |
| *** ramishra has quit IRC | 13:05 | |
| *** vgridnev has joined #heat | 13:05 | |
| *** ramishra has joined #heat | 13:05 | |
| *** rcernin has joined #heat | 13:06 | |
| *** cllewellyn_ has joined #heat | 13:11 | |
| *** cllewellyn__ has joined #heat | 13:11 | |
| *** zeih has quit IRC | 13:11 | |
| *** zeih has joined #heat | 13:12 | |
| *** zeih has quit IRC | 13:18 | |
| *** wangbo has quit IRC | 13:19 | |
| *** zeih has joined #heat | 13:19 | |
| *** jcoufal has quit IRC | 13:23 | |
| *** KanagarajM has joined #heat | 13:23 | |
| *** akshai has joined #heat | 13:26 | |
| *** akshai_ has joined #heat | 13:27 | |
| *** vincentll has quit IRC | 13:28 | |
| *** vincentll has joined #heat | 13:28 | |
| *** akshai has quit IRC | 13:31 | |
| *** ramishra has quit IRC | 13:31 | |
| *** wangbo has joined #heat | 13:32 | |
| *** ramishra has joined #heat | 13:37 | |
| *** zeih has quit IRC | 13:39 | |
| *** dyasny has joined #heat | 13:42 | |
| *** randallburt has joined #heat | 13:47 | |
| *** randallburt1 has joined #heat | 13:49 | |
| *** randallburt has quit IRC | 13:52 | |
| *** jcoufal has joined #heat | 13:52 | |
| openstackgerrit | Rabi Mishra proposed openstack/heat: [WIP]Add test for rolling_update https://review.openstack.org/330468 | 14:00 |
| *** crose has joined #heat | 14:07 | |
| *** spotz_zzz is now known as spotz | 14:07 | |
| *** crose has quit IRC | 14:14 | |
| *** zeih has joined #heat | 14:17 | |
| *** zz_dimtruck is now known as dimtruck | 14:18 | |
| *** hemanth has joined #heat | 14:22 | |
| hemanth | Is it possible to update Security group of already created port (using neutron port-create command) using Heat templates? | 14:22 |
| *** vgridnev has quit IRC | 14:23 | |
| *** zeih has quit IRC | 14:27 | |
| *** jistr is now known as jistr|mtg | 14:28 | |
| openstackgerrit | Dmitriy Uvarenkov proposed openstack/heat: Add new resource Security Group Rule https://review.openstack.org/330608 | 14:31 |
| *** EricGonczer_ has joined #heat | 14:34 | |
| *** ramishra has quit IRC | 14:34 | |
| openstackgerrit | Zane Bitter proposed openstack/heat: Unit tests: add a test resource that takes multiple steps https://review.openstack.org/330611 | 14:34 |
| openstackgerrit | Zane Bitter proposed openstack/heat: Always call TaskRunner._sleep() https://review.openstack.org/330612 | 14:34 |
| openstackgerrit | Zane Bitter proposed openstack/heat: Scheduler: Add a progress callback to TaskRunner https://review.openstack.org/330613 | 14:34 |
| *** ramishra has joined #heat | 14:37 | |
| therve | hemanth, I don't think so. What do you use to do that ? (without heat) | 14:41 |
| *** cllewellyn_ has quit IRC | 14:48 | |
| *** cllewellyn__ has quit IRC | 14:48 | |
| *** jaosorior has quit IRC | 14:49 | |
| hemanth | Actually I am trying to launch Loadbalancer setup using heat templates | 14:50 |
| hemanth | Where I need to attach security policies to VIP port | 14:50 |
| *** EricGonczer_ has quit IRC | 14:50 | |
| hemanth | I am not able to do tht using VIP as it doesnt have atttributes of Security group | 14:50 |
| hemanth | So my idea is to attach security group using neutron port (VIP one) in the heat template itself | 14:52 |
| therve | I think you need a floating ip anyway, no? | 14:52 |
| therve | Then you can attach the group to that | 14:52 |
| hemanth | Even with floating IP ... packets reaches VIP it drops based on security group | 14:53 |
| hemanth | I am using OpenStack+Contrail setup ... where COntrail allocates by default 'default' security group to VIP port | 14:53 |
| hemanth | I dont want to update my rules in default security group | 14:53 |
| hemanth | Have created a new security group and want to attach the same | 14:54 |
| *** sdake has quit IRC | 14:54 | |
| therve | OK I don't know | 14:54 |
| *** ramishra has quit IRC | 14:57 | |
| *** vijendar has joined #heat | 14:57 | |
| *** ramishra has joined #heat | 14:59 | |
| *** zhurong has quit IRC | 14:59 | |
| *** sdake has joined #heat | 14:59 | |
| *** david-lyle_ is now known as david-lyle | 15:00 | |
| openstackgerrit | Zane Bitter proposed openstack/heat: Improve unit tests for stack-update-cancel https://review.openstack.org/330059 | 15:13 |
| *** ramishra has quit IRC | 15:14 | |
| *** ramishra has joined #heat | 15:16 | |
| *** jistr|mtg is now known as jistr | 15:19 | |
| *** EricGonczer_ has joined #heat | 15:21 | |
| *** ricolin has joined #heat | 15:25 | |
| openstackgerrit | Jay Dobies proposed openstack/heat-specs: Add spec for more flexible environment merging https://review.openstack.org/330414 | 15:26 |
| *** openstackgerrit has quit IRC | 15:34 | |
| *** openstackgerrit has joined #heat | 15:35 | |
| *** EricGonczer_ has quit IRC | 15:35 | |
| *** vincentll has quit IRC | 15:35 | |
| *** wangbo has quit IRC | 15:35 | |
| *** wangbo has joined #heat | 15:37 | |
| *** wangbo has quit IRC | 15:42 | |
| *** EricGonczer_ has joined #heat | 15:42 | |
| *** sorantis has quit IRC | 15:53 | |
| *** coreyob has quit IRC | 15:54 | |
| *** prazumovsky has joined #heat | 15:57 | |
| *** akshai has joined #heat | 15:58 | |
| *** dprince has quit IRC | 16:01 | |
| *** akshai_ has quit IRC | 16:01 | |
| *** dprince has joined #heat | 16:02 | |
| *** akshai_ has joined #heat | 16:10 | |
| *** sabeen has joined #heat | 16:11 | |
| *** akshai has quit IRC | 16:13 | |
| *** permalac has quit IRC | 16:15 | |
| *** KanagarajM has quit IRC | 16:16 | |
| *** coreyob has joined #heat | 16:17 | |
| *** bana_k has joined #heat | 16:17 | |
| *** dprince has quit IRC | 16:20 | |
| *** sdake has quit IRC | 16:20 | |
| *** dprince has joined #heat | 16:21 | |
| *** ramishra has quit IRC | 16:22 | |
| *** ramishra has joined #heat | 16:26 | |
| *** sdake has joined #heat | 16:28 | |
| *** prazumovsky has quit IRC | 16:31 | |
| *** ramishra has quit IRC | 16:34 | |
| *** david-lyle has quit IRC | 16:35 | |
| *** EricGonc_ has joined #heat | 16:35 | |
| *** EricGonczer_ has quit IRC | 16:37 | |
| openstackgerrit | Merged openstack/heat: Fix typo in LBaaS support https://review.openstack.org/330525 | 16:39 |
| *** ramishra has joined #heat | 16:40 | |
| *** ricolin has quit IRC | 16:42 | |
| *** dmk0202 has quit IRC | 16:42 | |
| *** KanagarajM has joined #heat | 16:43 | |
| *** EricGonc_ has quit IRC | 16:46 | |
| *** EricGonczer_ has joined #heat | 16:50 | |
| *** ramishra has quit IRC | 16:55 | |
| *** derekh has quit IRC | 16:59 | |
| jaimguer | hello everyone | 16:59 |
| *** EricGonczer_ has quit IRC | 17:01 | |
| *** akshai_ has quit IRC | 17:06 | |
| *** sabeen has quit IRC | 17:13 | |
| *** bana_k has quit IRC | 17:16 | |
| *** rcernin has quit IRC | 17:21 | |
| *** boltR_ has quit IRC | 17:27 | |
| *** akshai has joined #heat | 17:28 | |
| *** ccamacho has quit IRC | 17:30 | |
| *** jprovazn has quit IRC | 17:44 | |
| *** bana_k has joined #heat | 17:45 | |
| *** KanagarajM has quit IRC | 17:59 | |
| *** dimtruck is now known as zz_dimtruck | 18:01 | |
| *** spotz is now known as spotz_zzz | 18:01 | |
| *** spotz_zzz is now known as spotz | 18:02 | |
| *** rcernin has joined #heat | 18:07 | |
| *** akshai has quit IRC | 18:08 | |
| *** sabeen has joined #heat | 18:10 | |
| *** akshai has joined #heat | 18:11 | |
| *** yassine__ has quit IRC | 18:13 | |
| *** mkoderer__ has joined #heat | 18:24 | |
| *** zz_dimtruck is now known as dimtruck | 18:41 | |
| *** dmk0202 has joined #heat | 18:44 | |
| *** dmk0202 has quit IRC | 18:45 | |
| *** akshai_ has joined #heat | 18:45 | |
| *** akshai has quit IRC | 18:47 | |
| *** akshai_ has quit IRC | 18:50 | |
| *** EricGonczer_ has joined #heat | 19:08 | |
| *** EricGonczer_ has quit IRC | 19:13 | |
| *** fultonj has quit IRC | 19:23 | |
| *** fultonj has joined #heat | 19:24 | |
| *** dprince has quit IRC | 19:27 | |
| *** vijendar has quit IRC | 19:28 | |
| *** dimtruck is now known as zz_dimtruck | 19:39 | |
| *** vijendar has joined #heat | 19:39 | |
| *** dmk0202 has joined #heat | 19:40 | |
| *** EricGonczer_ has joined #heat | 19:41 | |
| *** dmk0202 has quit IRC | 19:43 | |
| *** EricGonczer_ has quit IRC | 19:45 | |
| *** sabeen has quit IRC | 19:46 | |
| *** fragatin_ has quit IRC | 19:51 | |
| *** sabeen has joined #heat | 19:58 | |
| *** spotz is now known as spotz_zzz | 20:00 | |
| *** zz_dimtruck is now known as dimtruck | 20:07 | |
| *** fragatina has joined #heat | 20:10 | |
| *** fragatina has quit IRC | 20:10 | |
| *** fragatina has joined #heat | 20:11 | |
| *** jcoufal has quit IRC | 20:12 | |
| *** akshai has joined #heat | 20:13 | |
| *** openstackstatus has joined #heat | 20:18 | |
| *** ChanServ sets mode: +v openstackstatus | 20:18 | |
| *** ayoung has quit IRC | 20:18 | |
| *** dmk0202 has joined #heat | 20:23 | |
| *** lrensing has quit IRC | 20:27 | |
| *** mwheckmann has quit IRC | 20:32 | |
| openstackgerrit | Merged openstack/heat: Fix building query key for ceilometer alarm https://review.openstack.org/323256 | 20:35 |
| *** vijendar has quit IRC | 20:41 | |
| *** spotz_zzz is now known as spotz | 20:41 | |
| *** daneyon has quit IRC | 20:42 | |
| *** jamie_h has quit IRC | 20:57 | |
| *** fultonj has quit IRC | 21:06 | |
| *** vijendar has joined #heat | 21:21 | |
| *** vijendar has quit IRC | 21:28 | |
| *** jamespd_ has left #heat | 21:32 | |
| *** rcernin has quit IRC | 21:36 | |
| *** dimtruck is now known as zz_dimtruck | 21:37 | |
| *** zz_dimtruck is now known as dimtruck | 21:37 | |
| *** dimtruck is now known as zz_dimtruck | 21:37 | |
| *** dmk0202 has quit IRC | 21:38 | |
| openstackgerrit | Steve Baker proposed openstack/heat: Be consistent about context first argument in db api https://review.openstack.org/330798 | 21:39 |
| openstackgerrit | Steve Baker proposed openstack/heat: del _session(), use context.session directly https://review.openstack.org/330799 | 21:39 |
| openstackgerrit | Steve Baker proposed openstack/heat: WIP switch to oslo_db enginefacade pattern https://review.openstack.org/330800 | 21:39 |
| *** zzzeek has joined #heat | 21:41 | |
| stevebaker | zzzeek: I've just posted https://review.openstack.org/#/c/330800/ which came from oslo_db docs and neutron's WIP https://review.openstack.org/#/c/300017/13 | 21:42 |
| zzzeek | ok | 21:42 |
| stevebaker | zzzeek: unit tests currently fail because tables are not being created, for example http://paste.openstack.org/show/516732/ | 21:43 |
| zzzeek | stevebaker: well you already have a "context" so that's good! seems like the right idea is here. | 21:43 |
| stevebaker | zzzeek: unit test db is created by this which is run in test setUp http://git.openstack.org/cgit/openstack/heat/tree/heat/tests/utils.py#n52 | 21:44 |
| zzzeek | ok so...everyones test suite has a different hting going on | 21:45 |
| zzzeek | create_all(), that's refreshing (rather than running all the migrations) | 21:45 |
| stevebaker | zzzeek: here is our BASE http://git.openstack.org/cgit/openstack/heat/tree/heat/db/sqlalchemy/models.py#n29 | 21:46 |
| zzzeek | stevebaker: so, when we see "tables aren't created", a good guess is that the engine which is here is not the same one that the tests are using, if this is a sqlite in-memory database | 21:46 |
| zzzeek | unless that "heat.db" is a database file | 21:46 |
| stevebaker | zzzeek: I think we desire an in-memory sqlite for faster test runs, its been years since I had to know that though. My working dir has no heat.db | 21:48 |
| zzzeek | stevebaker: OK, that is fine | 21:48 |
| zzzeek | so where you do this _facade = context_manager._factory.get_legacy_facade() | 21:49 |
| zzzeek | that is likely the line we have to change | 21:49 |
| zzzeek | stevebaker: in fact yes because the decorator you're using is @enginefacade.writer etc., that's the "global" context | 21:50 |
| zzzeek | stevebaker: but then for the get_legacy() you're using a local module-level context | 21:50 |
| stevebaker | zzzeek: I can take out the decorators for now if they're not helping | 21:51 |
| zzzeek | stevebaker: those decorators are the whole thing :) you either need to make those local to that context_manager, or make the get_engine() / get_session() point to the "global" context | 21:51 |
| zzzeek | stevebaker: want me to just update this to make it work ? | 21:52 |
| stevebaker | zzzeek: yes, for now, and just to improve my understanding | 21:52 |
| zzzeek | stevebaker: ok | 21:52 |
| *** zz_dimtruck is now known as dimtruck | 21:53 | |
| stevebaker | zzzeek: also backing up a bit, one reason I'm doing this is that currently every query is preceded by a SELECT 1 - I think this is an indication that we're DoingThingsWrong but I'm not sure why or exactly how enginefacade helps | 21:56 |
| *** dimtruck is now known as zz_dimtruck | 21:57 | |
| zzzeek | stevebaker: the SELECT 1 is per transaction, so if every query has that then yes you are getting a new session / transaction on every query :) | 21:57 |
| zzzeek | stevebaker: which is the problem enginefacade seeks to solve | 21:57 |
| stevebaker | that is what I thought, so good | 21:57 |
| zzzeek | stevebaker: im just looking to see the best way to get osprofiler in here, some other ppl had trouble w/ that | 21:58 |
| zzzeek | and i was hoping osprofiler would add integration but seems like they havent | 21:58 |
| stevebaker | neutron has this proposed https://review.openstack.org/#/c/312393/9/neutron/db/api.py | 21:59 |
| *** dmk0202 has joined #heat | 22:04 | |
| *** akshai has quit IRC | 22:11 | |
| zzzeek | stevebaker: im making some progress here but now im stuck inside of getting a method to use the right session and stuff. haven't worked w/ heat API before | 22:17 |
| *** randallburt1 has quit IRC | 22:21 | |
| stevebaker | zzzeek: you mean the ones that call get_session() or the ones using context.session? I think I'll be aiming to get rid of get_session entirely as part of this series but I'd need to understand why they are not using the context session in each case | 22:21 |
| zzzeek | stevebaker: yes , but im getting a much more specific failure which I believe indicates something along the chain of a certain test is not doing the right thing | 22:22 |
| zzzeek | stevebaker: but im jumping into a totally random test that does lots of things none of which I know anything about :) | 22:22 |
| stevebaker | zzzeek: heat/tests/db/test_sqlalchemy_api.py should be a good self-contained test to start with | 22:23 |
| zzzeek | stevebaker: good idea | 22:23 |
| stevebaker | zzzeek: if you get that going I could do the rest | 22:23 |
| *** dmk0202 has quit IRC | 22:39 | |
| stevebaker | zzzeek: or at least get a proportion of the tests passing | 22:45 |
| zzzeek | stevebaker: ive got a lot passsing | 22:45 |
| stevebaker | cool | 22:45 |
| zzzeek | stevebaker: trying to get a tricky one to pass to set up some more patterns | 22:45 |
| stevebaker | k | 22:45 |
| zzzeek | stevebaker: the hard part is that all ofthis code assumes transaction per method call | 22:46 |
| zzzeek | including the tests | 22:46 |
| stevebaker | zzzeek: yeah, we may need a transition period of adding explicit transactions initially | 22:49 |
| *** sabeen has quit IRC | 22:51 | |
| *** hemanth has quit IRC | 22:52 | |
| *** spotz is now known as spotz_zzz | 23:07 | |
| *** pradk has quit IRC | 23:07 | |
| *** rustyeddy has quit IRC | 23:11 | |
| openstackgerrit | Michael Bayer proposed openstack/heat: del _session(), use context.session directly https://review.openstack.org/330799 | 23:15 |
| openstackgerrit | Michael Bayer proposed openstack/heat: Be consistent about context first argument in db api https://review.openstack.org/330798 | 23:15 |
| openstackgerrit | Michael Bayer proposed openstack/heat: WIP switch to oslo_db enginefacade pattern https://review.openstack.org/330800 | 23:15 |
| zzzeek | stevebaker: these were chained in three commits, i only appended onto the top one | 23:15 |
| stevebaker | zzzeek: sweet, I'll take a look | 23:16 |
| *** daneyon has joined #heat | 23:16 | |
| zzzeek | stevebaker: ok im out, lets talk tomorrow | 23:17 |
| stevebaker | zzzeek: ok, lets do it next week, my tomorrow is saturday | 23:18 |
| zzzeek | stevebaker: congrats, will do | 23:18 |
| stevebaker | zzzeek: thanks again | 23:18 |
| *** daneyon has quit IRC | 23:33 | |
| *** tochi has joined #heat | 23:39 | |
| *** chlong has quit IRC | 23:42 | |
| *** sshen_ has quit IRC | 23:43 | |
| *** sshen has joined #heat | 23:48 | |
| *** sdake has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!