Thursday, 2015-12-17

*** Drago has joined #heat00:03
*** Drago has quit IRC00:03
*** sabeen3 has joined #heat00:03
*** Drago has joined #heat00:03
*** sabeen has quit IRC00:06
*** spzala has joined #heat00:06
*** Qiming has quit IRC00:08
*** harlowja has joined #heat00:09
*** tochi has quit IRC00:09
*** sabeen3 has quit IRC00:12
*** tochi has joined #heat00:16
*** Drago has quit IRC00:16
*** randallburt has quit IRC00:24
*** dims has quit IRC00:29
*** Drago has joined #heat00:33
*** ricolin has joined #heat00:41
*** pratikmallya has joined #heat00:42
*** Qiming has joined #heat00:56
*** chlong has joined #heat01:07
*** DragoRosson has quit IRC01:11
*** _cjones_ has quit IRC01:19
openstackgerrithuangtianhua proposed openstack/heat: Add release note for bp/support-neutron-qos  https://review.openstack.org/25777801:22
*** zhiyan has quit IRC01:25
*** zhiyan has joined #heat01:28
*** zhenguo has joined #heat01:38
*** Yanyanhu has joined #heat01:45
*** hdd has quit IRC01:48
*** signed8bit has quit IRC01:49
*** Drago has quit IRC01:51
*** manishg has joined #heat01:58
*** manishg has joined #heat01:58
*** dixiaoli has joined #heat02:00
*** Yanyanhu has quit IRC02:03
*** dixiaoli has quit IRC02:04
*** elynn_ has joined #heat02:05
*** elynn_ has quit IRC02:10
*** chlong has quit IRC02:10
*** elynn_ has joined #heat02:10
*** daneyon_ has quit IRC02:10
*** daneyon has joined #heat02:11
*** sridhar_ram has quit IRC02:19
*** chlong has joined #heat02:22
*** sthillma has quit IRC02:29
*** manishg has quit IRC02:40
*** manishg has joined #heat02:41
*** DragoRosson has joined #heat02:54
openstackgerrithuangtianhua proposed openstack/heat: Add release note for bp/support-neutron-qos  https://review.openstack.org/25777802:55
*** harlowja has quit IRC02:58
ramishra_morning all02:59
*** bana_k has quit IRC03:00
*** ricolin has quit IRC03:02
openstackgerrithuangtianhua proposed openstack/heat: Add release note for bp/support-neutron-qos  https://review.openstack.org/25777803:03
*** DragoRosson has quit IRC03:04
*** EricGonczer_ has joined #heat03:11
*** hdd has joined #heat03:17
openstackgerritShuquan Huang proposed openstack/heat-cfntools: Replace assertEqual(None, *) with assertIsNone in tests  https://review.openstack.org/25877303:20
*** Yanyanhu has joined #heat03:21
*** jamielennox is now known as jamielennox|away03:26
*** links has joined #heat03:28
*** jamielennox|away is now known as jamielennox03:31
*** Marga__ has quit IRC03:37
*** Marga_ has joined #heat03:37
*** logan- has joined #heat03:47
*** sthillma has joined #heat03:48
*** EricGonczer_ has quit IRC03:49
*** sthillma_ has joined #heat03:50
*** sthillma has quit IRC03:52
*** sthillma_ is now known as sthillma03:52
openstackgerritDi XiaoLi proposed openstack/python-heatclient: OpenstackClient plugin for software deployment output show  https://review.openstack.org/25164103:58
*** hdd has quit IRC04:02
*** dyasny has quit IRC04:03
*** pratikmallya has quit IRC04:16
*** EricGonczer_ has joined #heat04:16
*** EricGonczer_ has quit IRC04:17
*** elynn_ has quit IRC04:29
*** EricGonczer_ has joined #heat04:35
*** spzala has quit IRC04:37
*** KanagarajM has joined #heat04:38
KanagarajMgood morning all !04:40
*** EricGonczer_ has quit IRC04:43
*** manishg has quit IRC04:43
*** manishg has joined #heat04:46
*** ricolin has joined #heat04:49
*** bana_k has joined #heat04:51
*** KanagarajM has quit IRC04:51
*** manishg has quit IRC04:51
*** boris-42_ has quit IRC04:53
*** kirankv has joined #heat04:53
*** bana_k has quit IRC04:56
*** gus has quit IRC05:04
*** mtreinish has quit IRC05:08
*** elynn_ has joined #heat05:13
*** mtreinish has joined #heat05:17
*** hdd has joined #heat05:18
*** signed8bit has joined #heat05:20
*** bana_k has joined #heat05:44
*** gus has joined #heat05:49
*** vijayagurug has joined #heat05:59
*** signed8bit is now known as signed8bit_ZZZzz06:16
*** elynn_ has quit IRC06:17
*** elynn_ has joined #heat06:17
*** signed8bit_ZZZzz has quit IRC06:30
openstackgerritDi XiaoLi proposed openstack/python-heatclient: OpenstackClient plugin for software deployment list  https://review.openstack.org/24912706:30
openstackgerritDi XiaoLi proposed openstack/python-heatclient: OpenstackClient plugin for software deployment metadata show  https://review.openstack.org/25012806:30
openstackgerritAnkit Agrawal proposed openstack/heat: Remove duplicate keys from dictionary  https://review.openstack.org/25882206:30
*** pratikmallya has joined #heat06:32
*** hdd has quit IRC06:38
*** dixiaoli has joined #heat06:42
*** liusheng has quit IRC06:52
*** liusheng has joined #heat06:52
*** gberginc has joined #heat06:55
*** ricolin has quit IRC07:09
openstackgerrithuangtianhua proposed openstack/heat: Add release note for bp/support-neutron-qos  https://review.openstack.org/25777807:21
*** tobe has joined #heat07:27
*** chlong has quit IRC07:36
ramishra_ http://logs.openstack.org/22/258822/1/check/gate-grenade-dsvm-heat/e4db83d/logs/grenade.sh.txt.gz#_2015-12-17_06_49_25_84307:53
ramishra_hehe, 'Failed to update apt repos, we're dead now'07:53
*** jcoufal has joined #heat08:04
*** zeih has joined #heat08:06
*** jtomasek has joined #heat08:07
*** sorantis has joined #heat08:09
*** sthillma has quit IRC08:10
*** zeih has quit IRC08:10
*** jprovazn has joined #heat08:13
*** zeih has joined #heat08:18
*** shardy has joined #heat08:22
*** zeih has quit IRC08:23
*** e0ne has joined #heat08:23
shardytiantian: Hey, thanks for the comment on https://review.openstack.org/#/c/257966/408:29
shardyI just replied - unless you feel strongly re the NETWORK_ID, I'd rather leave it, as it provides an explicit interface which shows that both NETWORK and NETWORK_ID should never be passed to the client despite being update_allowed=True08:30
shardyI can see that it's not really needed, but that's not obvious unless you understand exactly how the translation rules work, so could easily be missed by folks in the future08:30
shardymaybe in the future we can make this more generic, and have something in the properties_schema which encodes that although a property is update_allowed, it is handled inside heat and not passed on to the client08:32
shardyramishra_ made the same comment yesterday, and after thinking about it I decided to leave it08:32
shardyhappy to go with the consensus tho ;)08:32
tiantianshardy, ok, I don't want to be the blocker:)08:34
shardySame comment re https://review.openstack.org/#/c/257904/08:34
shardyalso, we need NETWORK_ID for backport to kilo, because the translation rules stuff doesn't exist there08:35
tiantianshardy, but line453 of port.py, 'if after_props != before_props:' here an ValueError may be raised?08:36
shardytiantian: You mean on kilo?08:37
*** pratikmallya has quit IRC08:38
*** e0ne has quit IRC08:38
*** sthillma has joined #heat08:39
*** LimorStotland has joined #heat08:39
LimorStotlandhi all can i please get another +2 onhttps://review.openstack.org/#/c/243087/ thanks08:39
*** e0ne has joined #heat08:40
*** jprovazn has quit IRC08:43
*** Marga_ has quit IRC08:45
*** zeih has joined #heat08:48
*** sthillma has quit IRC08:48
*** zeih has quit IRC08:52
*** e0ne has quit IRC08:53
*** bana_k has quit IRC08:59
*** pas-ha has joined #heat09:05
*** derekh has joined #heat09:09
*** jistr has joined #heat09:09
pas-hamorning all09:10
*** chestack has joined #heat09:10
*** yassine__ has joined #heat09:13
openstackgerritRico Lin proposed openstack/heat: Add support for a resource level external_id  https://review.openstack.org/13549209:19
openstackgerritRui Chen proposed openstack/python-heatclient: Fix Resource.__eq__ mismatch semantics of object equal  https://review.openstack.org/25183009:20
*** zigo has quit IRC09:25
*** zigo_ has joined #heat09:26
*** zeih has joined #heat09:26
*** sorantis has quit IRC09:29
*** sorantis has joined #heat09:32
*** tobe has quit IRC09:38
*** pratikmallya has joined #heat09:39
*** tobe has joined #heat09:40
*** tobe has quit IRC09:41
*** tobe has joined #heat09:41
*** blues-man has joined #heat09:43
*** pratikmallya has quit IRC09:43
*** tobe has quit IRC09:46
openstackgerritsonu proposed openstack/python-heatclient: Removes MANIFEST.in as it is not needed explicitely by PBR  https://review.openstack.org/25890609:46
*** openstackgerrit has quit IRC09:47
*** openstackgerrit has joined #heat09:48
openstackgerritMerged openstack/heat: Neutron port allow switching between network_id and network  https://review.openstack.org/25796609:53
*** e0ne has joined #heat09:55
*** e0ne has quit IRC10:05
openstackgerritUkesh Kumar proposed openstack/heat: Add support for 'binding:profile' property in heat template  https://review.openstack.org/24452910:08
openstackgerritMerged openstack/heat: Enable simple json format in workflow signal  https://review.openstack.org/24308710:14
*** LimorStotland has quit IRC10:18
openstackgerritMerged openstack/heat: Remove duplicate keys from dictionary  https://review.openstack.org/25882210:19
*** shakamunyi has quit IRC10:20
*** Qiming has quit IRC10:20
*** shakamunyi has joined #heat10:21
*** superflyy has quit IRC10:21
*** barra204 has joined #heat10:21
*** Yanyanhu has quit IRC10:26
openstackgerritPeter Razumovsky proposed openstack/heat: Add basic get_live_state implementation  https://review.openstack.org/24406510:27
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Nova::Server get_live_state implementation  https://review.openstack.org/24406610:27
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::Server get_live_state implementation  https://review.openstack.org/24406610:29
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] EncryptedVolumeType get_live_state implementation  https://review.openstack.org/25066610:29
openstackgerritPeter Razumovsky proposed openstack/heat: EncryptedVolumeType get_live_state implementation  https://review.openstack.org/25066610:30
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Nova::KeyPair get_live_state implementation  https://review.openstack.org/24987110:30
*** elynn_ has quit IRC10:31
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Nova::Flavor get_live_state implementation  https://review.openstack.org/24868210:32
*** sorantis has quit IRC10:32
*** sorantis has joined #heat10:34
openstackgerritSergey Kraynev proposed openstack/heat: Unify workers options for API services  https://review.openstack.org/25472810:34
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::Flavor get_live_state implementation  https://review.openstack.org/24868210:34
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::KeyPair get_live_state implementation  https://review.openstack.org/24987110:35
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Nova::ServerGroup get_live_state implementation  https://review.openstack.org/24984410:36
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::ServerGroup get_live_state implementation  https://review.openstack.org/24984410:37
*** LimorStotland has joined #heat10:43
*** e0ne has joined #heat10:43
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::HostAggregate get_live_state implementation  https://review.openstack.org/25037010:47
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Add basic get_live_state implementation  https://review.openstack.org/24406510:47
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Cinder::VolumeType get_live_state implementation  https://review.openstack.org/25045110:48
*** dixiaoli has quit IRC10:48
openstackgerritPeter Razumovsky proposed openstack/heat: Cinder::VolumeType get_live_state implementation  https://review.openstack.org/25045110:49
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Glance::Image get_live_state implementation  https://review.openstack.org/25070510:49
openstackgerritPeter Razumovsky proposed openstack/heat: Glance::Image get_live_state implementation  https://review.openstack.org/25070510:49
*** dixiaoli has joined #heat10:50
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Barbican::Order get_live_state implementation  https://review.openstack.org/25297610:50
openstackgerritPeter Razumovsky proposed openstack/heat: Barbican::Order get_live_state implementation  https://review.openstack.org/25297611:01
*** liusheng has quit IRC11:06
*** dims has joined #heat11:07
*** liusheng has joined #heat11:08
*** Qiming has joined #heat11:08
dixiaolihi,all. Can you help to review the spec: Support Role-based Access Control for Networks in Heat: https://review.openstack.org/#/c/254037/4  Thx~11:09
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Nova::FloatingIP get_live_state implementation  https://review.openstack.org/25421111:12
*** LimorStotland has quit IRC11:19
openstackgerritPeter Razumovsky proposed openstack/heat: Add basic get_live_state implementation  https://review.openstack.org/24406511:20
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::Server get_live_state implementation  https://review.openstack.org/24406611:21
openstackgerritPeter Razumovsky proposed openstack/heat: EncryptedVolumeType get_live_state implementation  https://review.openstack.org/25066611:21
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::KeyPair get_live_state implementation  https://review.openstack.org/24987111:21
openstackgerritPeter Razumovsky proposed openstack/heat: Barbican::Order get_live_state implementation  https://review.openstack.org/25297611:22
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::Flavor get_live_state implementation  https://review.openstack.org/24868211:22
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::HostAggregate get_live_state implementation  https://review.openstack.org/25037011:22
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::ServerGroup get_live_state implementation  https://review.openstack.org/24984411:23
openstackgerritPeter Razumovsky proposed openstack/heat: Glance::Image get_live_state implementation  https://review.openstack.org/25070511:23
openstackgerritPeter Razumovsky proposed openstack/heat: Cinder::VolumeType get_live_state implementation  https://review.openstack.org/25045111:23
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Nova::FloatingIP get_live_state implementation  https://review.openstack.org/25421111:24
*** pas-ha has quit IRC11:29
*** kse has quit IRC11:32
*** blues-man has quit IRC11:32
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::FloatingIP get_live_state implementation  https://review.openstack.org/25421111:35
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Barbican::Secret get_live_state implementation  https://review.openstack.org/25422611:36
*** zeih has quit IRC11:37
*** LimorStotland has joined #heat11:41
*** blues-man has joined #heat11:44
openstackgerritPeter Razumovsky proposed openstack/heat: Barbican::Secret get_live_state implementation  https://review.openstack.org/25422611:44
*** blomquisg has quit IRC11:46
openstackgerritPeter Razumovsky proposed openstack/heat: Designate::Domain get_live_state implementation  https://review.openstack.org/25426011:54
*** zeih has joined #heat12:03
openstackgerritMerged openstack/python-heatclient: Fix Resource.__eq__ mismatch semantics of object equal  https://review.openstack.org/25183012:05
*** sorantis has quit IRC12:06
openstackgerritjaveme proposed openstack/heat: oslo_middleware.http_proxy_to_wsgi instead of ssl  https://review.openstack.org/25831112:06
*** zeih has quit IRC12:08
*** sorantis has joined #heat12:09
openstackgerritPeter Razumovsky proposed openstack/heat: Designate::Record get_live_state implementation  https://review.openstack.org/25525312:09
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Neutron::Net get_live_state implementation  https://review.openstack.org/25528712:11
openstackgerritDi XiaoLi proposed openstack/heat: Add test_stack_snapshot in heat_integrationtests  https://review.openstack.org/24678512:12
*** dixiaoli has quit IRC12:18
*** dprince has joined #heat12:22
*** LimorStotland has quit IRC12:24
openstackgerritPeter Razumovsky proposed openstack/heat: Batching for tasks in scheduler  https://review.openstack.org/24411712:25
openstackgerritPeter Razumovsky proposed openstack/heat: Neutron::Net get_live_state implementation  https://review.openstack.org/25528712:25
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Neutron::Subnet get_live_state implementation  https://review.openstack.org/25575312:25
*** LimorStotland has joined #heat12:33
openstackgerritPeter Razumovsky proposed openstack/heat: Neutron::Subnet get_live_state implementation  https://review.openstack.org/25575312:35
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Neutron::Router get_live_state implementation  https://review.openstack.org/25577612:35
*** Marga_ has joined #heat12:39
*** pratikmallya has joined #heat12:41
*** tlashchova has joined #heat12:43
openstackgerritPeter Razumovsky proposed openstack/heat: Neutron::Router get_live_state implementation  https://review.openstack.org/25577612:45
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Neutron::ExtraRoute get_live_state implementation  https://review.openstack.org/25579912:45
*** pratikmallya has quit IRC12:46
*** KLuka_ has joined #heat12:53
*** blomquisg has joined #heat12:55
*** Marga_ has quit IRC12:56
*** links has quit IRC12:58
*** tochi has quit IRC13:01
*** ricolin has joined #heat13:06
*** dslevin_ has joined #heat13:09
openstackgerritPeter Razumovsky proposed openstack/heat: Neutron::ExtraRoute get_live_state implementation  https://review.openstack.org/25579913:09
*** zeih has joined #heat13:11
shardytherve: Hi!13:12
therveshardy, Hi13:12
shardytherve: When you get a moment, I wanted to discuss backport of https://review.openstack.org/#/c/248719/13:13
shardytherve: tiantian has backported it to liberty via https://review.openstack.org/#/c/258307/13:13
shardybut I've got some reports that we need it for kilo13:14
*** elynn_ has joined #heat13:14
shardyI tried cherry-picking but there are quite a few conflicts13:14
therveDo we have translation in kilo?13:14
shardytherve: I don't think so, so my question is how we might address the issue on kilo13:15
therveAh yeah we need a brand new patch13:15
shardytherve: context is this downstream bug:13:15
shardyhttps://bugzilla.redhat.com/show_bug.cgi?id=129215213:15
openstackbugzilla.redhat.com bug 1292152 in openstack-heat "HEAT template fails in validation started with OSP7" [High,New] - Assigned to zbitter13:15
shardywhich references your patch and the related upstream LP bugs13:15
therveYeah I believe it's the original issue with validation accross nested stack13:15
shardytherve: ack, if you'd be willing to add some notes to the bug, and/or consider how we might address it on kilo via either a partial backport or kilo-only patch, that would be awesome13:19
therveWill do13:19
*** LimorStotland has quit IRC13:19
shardytherve: thanks!13:19
therveI think ramishra_ may have made a related fix in master13:20
*** gberginc has quit IRC13:22
*** vgridnev has joined #heat13:22
ramishra_therve:  do you mean the one I abandoned? https://review.openstack.org/#/c/248661/13:24
openstackgerritPeter Razumovsky proposed openstack/heat: Nova::Server get_live_state implementation  https://review.openstack.org/24406613:24
therveramishra_, Exactly13:24
therveThis one is easily applicable on kilo, and I think it fixes the issue13:24
openstackgerritPeter Razumovsky proposed openstack/heat: [WIP] Neutron::FloatingIP get_live_state implementation  https://review.openstack.org/25626413:24
*** pradk has joined #heat13:31
openstackgerritPeter Razumovsky proposed openstack/heat: Neutron::FloatingIP get_live_state implementation  https://review.openstack.org/25626413:33
*** links has joined #heat13:34
*** hdd has joined #heat13:44
openstackgerritShuquan Huang proposed openstack/python-heatclient: Replace assertEqual(None, *) with assertIsNone in tests  https://review.openstack.org/25902013:56
*** dslevin_ has quit IRC13:57
therveCome on gerrit13:57
therveshardy, ramishra_ https://review.openstack.org/#/c/259023/13:59
*** dyasny has joined #heat14:03
*** ricolin has quit IRC14:03
*** LimorStotland has joined #heat14:03
*** sorantis_ has joined #heat14:06
*** sorantis has quit IRC14:07
*** sorantis_ is now known as sorantis14:07
*** hdd has quit IRC14:09
*** jonesbr has joined #heat14:10
*** pas-ha has joined #heat14:10
*** jcoufal_ has joined #heat14:13
*** spzala has joined #heat14:16
*** jcoufal has quit IRC14:16
*** vijayagurug has quit IRC14:18
jdobshardy: ping14:19
shardyjdob: Hi!14:19
shardyjdob: in a mtg so may be delayed responses14:20
jdobhey, can you explain what you mean in https://review.openstack.org/#/c/241662/7/heat/tests/engine/service/test_service_engine.py ?14:20
jdobkk, no rush14:20
*** elynn_ has quit IRC14:20
jdobnot sure what you mean by the "deep aspect of this"14:20
jdober, "deep merge aspect"14:20
shardyhttps://review.openstack.org/#/c/241662/7/heat/engine/service.py14:21
shardyjdob: it's the template_utils.deep_update14:22
shardyref:14:22
shardyhttp://docs.openstack.org/developer/heat/template_guide/environment.html#override-a-resource-with-a-custom-resource14:22
jdobright, though presumably that's unit tested on its own and doesn't need this test to go nuts with it, no?14:22
shardyhttp://docs.openstack.org/developer/heat/template_guide/environment.html#pause-stack-creation-or-update-on-a-given-resource14:22
shardyjdob: that's why I suggested a functional test14:23
jdobhrm, ok, I can do that14:23
shardyjdob: not a blocker, I'd just prefer to see a functional test with some more representative usage14:23
shardythat can be added as a followup14:23
jdobya, that's fair14:23
*** kirankv has quit IRC14:23
shardyinvariably relying on unit test coverage in another repo bites you eventually ;)14:24
* shardy had discovered the hard way :D14:24
shardys/had/has14:24
jdobhahaha14:24
shardyjdob: if we can agree a functional test is going to be posted as a followup I'm +214:25
*** neelashah has joined #heat14:25
jdobmakes sense, thanks for the clariication14:25
jdobnah, I'll work on it now14:25
shardyjdob: thanks!14:25
*** dyasny has quit IRC14:28
shardytherve: thanks!  So, to clarify, that's a kilo-only patch, right?14:29
therveshardy, Yes14:30
therveWe didn't need it in liberty because we managed to remove the method due to the translation mechanism14:30
shardytherve: ack, would you be able to add a note about that to the commit message please14:31
*** EricGonczer_ has joined #heat14:31
therveSure14:31
shardyso we can justify why it's not an actual backport14:31
shardythanks :)14:31
*** LimorStotland has quit IRC14:31
shardytherve: also is there a simple test we can add?14:32
therveHum, not sure14:32
therveSimple no, as you need at least nested stacks I believe.14:33
openstackgerritPeter Razumovsky proposed openstack/heat: Neutron::FIPA get_live_state implementation  https://review.openstack.org/25904714:33
*** blomquisg has quit IRC14:33
shardytherve: I was more thinking of a unit test for _validate_depr_property_required14:34
shardyat least then we have some coverage14:34
shardyand perhaps we can add a functional test on master later14:34
*** rpothier has joined #heat14:34
therveI don't think the unit test would have much value considering the change14:35
shardytherve: Ok, fair enough14:40
*** pradk has quit IRC14:41
*** hdd has joined #heat14:44
*** blomquisg has joined #heat14:48
*** jasond` has joined #heat14:57
*** randallburt has joined #heat14:58
*** spotz_zzz is now known as spotz14:58
*** ricolin has joined #heat15:02
*** dyasny has joined #heat15:02
*** palexster has quit IRC15:09
*** vgridnev has quit IRC15:10
*** Drago has joined #heat15:11
*** Drago has quit IRC15:11
*** Drago has joined #heat15:12
*** palexster has joined #heat15:12
*** pratikmallya has joined #heat15:12
Dragoshardy: ping15:12
shardyDrago: Hi!15:12
DragoHello again :)15:12
Dragoshardy: shall we continue our conversation from yesterday?15:13
shardyDrago: hey, sure15:14
shardyso, I was thinking, instead of condidionals, we need a StackUser base-class which understands what the transport is, and overrides self._delete_user appropriately, or has a conditional such as you previously described15:16
shardyDrago: I'm looking at SignalResponder and the related work miguelgrinberg did (some of which hasn't yet landed)15:16
shardye.g the uniform resource signals stuff15:17
Dragoshardy: link?15:17
shardyDrago: if things were refactored so when the tempurl transport is used, _delete_user is never called, will that solve your problem?15:17
Dragoshardy: yes, that would solve the problem as well15:18
shardyhttps://github.com/openstack/heat-specs/blob/master/specs/liberty/uniform-resource-signals.rst15:18
shardyhttps://blueprints.launchpad.net/heat/+spec/uniform-resource-signals15:18
*** palexster1 has joined #heat15:19
shardyDrago: one issue is that the nova/server.py isn't a SignalResponder, but it's a starting point (works for SoftwareDeployment)15:19
shardywe almost need a class between StackUser and SignalResponder which abstracts the transport15:20
shardyOr, rename SignalResponder and use it for server.py15:20
shardyDrago: do you know if miguelgrinberg is still working on that stuff?15:20
*** palexster has quit IRC15:20
openstackgerritPeter Razumovsky proposed openstack/heat: Neutron::Port get_live_state implementation  https://review.openstack.org/25907415:20
shardyif so, it'd be good for you to chat with him about this refactoring15:20
Dragoshardy: this is the first time I'm seeing this15:21
Dragoshardy: I can contact him15:21
jdobshardy: another question when you get a second15:22
shardyDrago: https://review.openstack.org/#/c/222844/ is the only outstanding patch, which stalled on negative feedback from jasond`15:22
shardyDrago: I'm happy to follow up and work out a plan on this, but if miguelgrinberg is willing to help, that would be good, as I think this refactoring required is closely related to the work he's already done15:23
shardyjdob: sure15:23
jdobshardy: is there a way to retrieve the environment for a stack?15:23
jdobi have a test creating a stack but I'm trying to figure out how i'm gonna verify this15:24
shardyjdob: no, adding an API to environment-show and files-show (in addition to the existing template-show) is TODO15:24
DragoI'll do some reading and get back to you, thanks shardy!15:24
jdobhrm15:24
shardyit would be very very useful since we added PATCH updates15:24
openstackgerritOleksii Chuprykov proposed openstack/python-heatclient: Resolve outputs from stack object  https://review.openstack.org/25796315:25
jdobya, i'll take a stab at that after the holiday break15:25
jdobuntil then, this test isn't going to be terribly interesting15:25
shardyjdob: ack - I've discussed it with several folks and I think we really need it15:25
jdobactually, I may be able to work something out15:25
jdobin terms of having the test show it works15:26
shardyjdob: you'd need to do an indirect test, like merge environments in an order that say a template designed to fail either takes priority or is overridden15:26
jdobexactly, I'm just gonna break the shit out of the pre-overridden values15:26
shardyOr override in a sequence where you can compare the expected type, or length of RandomString etc15:26
shardyjdob: lol15:26
*** vijendar has joined #heat15:26
jdobquestion on your last point15:27
shardyjdob: having environment-show would make it much easier, and I think it will be super useful15:27
jdobas for the expected type15:27
jdobeverything i'm seeing it showing the alias15:27
jdobso my resources are of types test::R1 and so on15:27
jdoband i map those to something real15:27
shardyjdob: Yeah, you'd need to override then look inside the nested stack15:27
jdobbut everything shows me test::R1 instead of the "real" thing15:27
jasond`shardy: no it isn't15:27
shardyjasond`: I was under the impression you and miguelgrinberg had an unresolved disagreement, which is why I didn't review the patch15:28
shardyI was expecting you to +2 it when that was resolved15:28
jdobok, thanks shardy, I'll figure something out from here15:29
shardyhttps://github.com/openstack/heat/blob/master/heat_integrationtests/functional/test_create_update.py#L31015:30
shardyjdob: you can do something similar to that, and assert the content of the overridden thing (assuming nested stack) is as expected15:30
jasond`shardy: actually, i never got back to reviewing that patch after he posted the next patchset.  my bad.  i'll look at it now15:30
*** manishg has joined #heat15:31
jdobwasn't going so far to have nested stacks, but I think I can do a combination of broken defaults and checking the value of a resource to ensure it's a randomstring15:31
shardyjasond`: Ok, looks like it needs a rebase, I'll gladly review it when you ack it as ready, thanks!15:31
jasond`shardy: np, thanks for bringing it up15:31
shardyjasond`: kk, whatever works - I used the nested stacks in some of those tests as it's pretty easy to see when a different mapping happens15:33
*** jaosorior has joined #heat15:34
*** sridhar_ram has joined #heat15:37
*** zeih has quit IRC15:39
*** palexster1 is now known as palexster15:39
*** Drago has quit IRC15:41
*** sorantis has quit IRC15:41
*** Drago has joined #heat15:45
*** vijayagurug has joined #heat15:50
*** links has quit IRC15:50
*** pratikmallya has quit IRC15:50
*** manishg has quit IRC15:51
*** zeih has joined #heat15:55
*** david-lyle_ has joined #heat15:55
*** david-lyle_ has quit IRC15:57
*** LimorStotland has joined #heat15:58
*** david-lyle has quit IRC15:59
*** zeih has quit IRC16:00
*** jrist has joined #heat16:04
*** david-lyle has joined #heat16:05
*** jrist has quit IRC16:05
*** jrist has joined #heat16:06
*** yassine__ has quit IRC16:06
*** yassine__ has joined #heat16:07
*** arturdaschevici has joined #heat16:07
*** vishwana_ has joined #heat16:07
*** sridhar_ram has quit IRC16:09
*** vishwanathj has quit IRC16:09
*** vgridnev has joined #heat16:10
*** boris-42_ has joined #heat16:11
*** Qiming has quit IRC16:14
*** LimorStotland has quit IRC16:15
*** vijayagurug has left #heat16:18
*** inc0 has quit IRC16:24
*** inc0 has joined #heat16:24
*** pratikmallya has joined #heat16:26
*** pratikma_ has joined #heat16:27
*** pratikmallya has quit IRC16:30
*** rpothier has quit IRC16:35
*** ricolin has quit IRC16:36
*** ricolin has joined #heat16:38
jdobshardy: how sure are we that resource overriding actually works?16:39
jdobactually, before I go there, can you sanity check a quick example for me: https://github.com/jdob/kukri/tree/master/heat-templates/resource-override16:40
jdobwhen I run that, r1 looks like it's becoming a random string too16:40
-openstackstatus- NOTICE: Zuul is moving in very slow motion since roughly 13:30 UTC; the Infra team is investigating.16:41
*** cwolferh has quit IRC16:43
*** manishg has joined #heat16:43
*** cwolferh has joined #heat16:43
shardyjdob: example lgtm - there are some existing tests for this, and it's a documented interface so it should work otherwise we've got bugs16:47
jdobdo you have a second to give that example a shot?16:47
jdobwhat i'm doing with it is:16:48
jdobheat stack-create o -f resource-override.yaml -e env-1.yaml -e env-2.yaml16:48
jdobthen a resource-show on o r116:48
jdobthat's showing a value in the attributes16:48
jdobwhich shouldn't be there if r1 is still None16:48
jdobbut i'm not sure if it's something about the state of my local devstack16:48
shardyjdob: it works for me, r1 attributes are null, r2 are a random string16:52
jdobwell, shit.16:52
jdobyou don't even see a value in r1?16:52
jdobi see value: null16:52
shardyjdob: Yeah I see value: null16:52
jdobya, you don't normally see that with None16:52
shardythat's expected, OS::Heat::None returns None for all attributes16:52
jdobdo it again without env-216:53
*** yassine__ has quit IRC16:53
jdobr1 will look different, the attributes will be {}16:53
shardyHey yeah that is weird16:54
jdobok, so i'm not totally nuts :)16:55
shardySo we're getting the attributes schema of the RandomString, even though it's been overridden by the None resource16:56
shardyI think that's due to the way facade's work16:56
jdobshould I file a bug or is that intended and/or acceptable?16:57
shardyhttps://github.com/openstack/heat/blob/master/heat_integrationtests/functional/test_template_resource.py#L79516:57
shardyjdob: I think it's expected - when you override a resource with another resource, we enforce a facade validation which ensures the interfaces are compatible16:58
shardySo I think this is a byproduct of that16:58
jdobah, ok16:58
shardyasalkeld would be the person to double check with tho, if you can catch him later16:58
jdobcool, I'll restructure my test around that16:58
jdobthanks!16:58
pratikma_if an image and a bootable volume are both specified, then which will be used by a server for booting? i.e. will it boot from volume or use the image?17:04
pratikma_in the template to create a OS::Nova::Server resource17:04
*** Marga_ has joined #heat17:11
*** ricolin has quit IRC17:13
*** daneyon_ has joined #heat17:14
*** crose has joined #heat17:15
openstackgerritPratik Mallya proposed openstack/heat: Add image/flavor validation to OS::Nova::Server  https://review.openstack.org/25871217:16
*** daneyon has quit IRC17:17
*** Marga_ has quit IRC17:18
*** jistr has quit IRC17:19
*** ricolin has joined #heat17:24
*** jcoufal_ has quit IRC17:28
*** Marga_ has joined #heat17:30
openstackgerritPratik Mallya proposed openstack/heat: Add more image/flavor validation to Server  https://review.openstack.org/25871317:31
openstackgerritJay Dobies proposed openstack/heat: Hook into environment merging on server  https://review.openstack.org/24166217:34
*** crose has quit IRC17:34
*** shardy has quit IRC17:43
*** e0ne has quit IRC17:53
*** derekh has quit IRC18:00
randallburtpratikma_:  that's throws a validation error18:01
pratikma_randallburt: does it now? I don't see that in the validation logic. All that it seems to check is that if neither image nor a valid bootable volume is specified https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/nova/server.py#L123818:03
*** ricolin has quit IRC18:04
*** zeih has joined #heat18:11
randallburtpratikma_:  huh, checking18:12
randallburtpratikma_:  odd. Nova fails though.18:14
randallburtpratikma_:  maybe I have mis-remembered18:15
pratikma_randallburt: mis-remembered? :)18:15
pratikma_randallburt: apparantly it is a word: http://dictionary.reference.com/browse/misremember18:15
randallburtpratikma_:  well I'll be :D18:16
*** zeih has quit IRC18:16
openstackgerritPratik Mallya proposed openstack/heat: Support RackConnect V3 LB in Rackspace AutoScaleGroup Resource  https://review.openstack.org/25673818:18
openstackgerritPratik Mallya proposed openstack/heat: Support RackConnect V3 LB in Rackspace AutoScaleGroup Resource  https://review.openstack.org/25673818:20
*** chestack has quit IRC18:23
*** neelashah has quit IRC18:23
*** bana_k has joined #heat18:23
*** harlowja has joined #heat18:27
*** pas-ha has quit IRC18:31
*** sthillma has joined #heat18:32
*** neelashah has joined #heat18:36
*** Marga_ has quit IRC18:36
*** zeih has joined #heat18:38
*** zeih has quit IRC18:43
*** e0ne has joined #heat18:46
*** blomquisg has quit IRC18:49
*** chestack has joined #heat18:50
*** blues-man has quit IRC18:50
*** Marga_ has joined #heat18:53
*** chestack has quit IRC18:54
*** Marga_ has quit IRC18:57
*** rpothier has joined #heat19:03
*** sabeen1 has joined #heat19:08
*** neelashah has quit IRC19:08
openstackgerritPratik Mallya proposed openstack/heat: Support RackConnect V3 LB in Rackspace AutoScaleGroup Resource  https://review.openstack.org/25673819:16
*** jaosorior has quit IRC19:16
pratikma_jasond`: I used nested if's because Drago suggested that they would make the logic easier to follow, which I kinda agree with19:18
pratikma_jasond`: ref https://review.openstack.org/#/c/258713/2/contrib/rackspace/rackspace/resources/cloud_server.py19:19
jasond`pratikma_: do you have the link to Drago's comment?19:20
pratikma_jasond`: https://review.openstack.org/#/c/254413/10/contrib/rackspace/rackspace/resources/cloud_server.py@28419:20
jasond`pratikma_: for future splits, i'd keep the original review open instead of abandoning it so that history is easily accessible19:20
Dragopratikma_, jasond`: I suggested abstracting the conditionals into their own method and IIRC breaking the conditions into separate ifs, but I don't think I suggested nested ifs19:21
jasond`pratikma_: ie. turn the original review back into a cloud server only change and make the server change a dependency19:22
pratikma_jasond`: ah, I see. I'll keep that in min19:23
pratikma_*mind19:23
pratikma_Drago: you're right. I don't want to put words in your mouth :). You did not suggest nested if's19:23
Dragopratikma_, jasond`: commented on that patch19:24
Dragopratikma_: no big19:24
jasond`pratikma_: yeah, i frequently grab the change-id from a commit message and look it up in gerrit for more context about the change.  the comments can really help19:24
*** sabeen1 has quit IRC19:25
openstackgerritMerged openstack/python-heatclient: Removes MANIFEST.in as it is not needed explicitely by PBR  https://review.openstack.org/25890619:31
*** tlashchova has quit IRC19:33
*** e0ne has quit IRC19:34
*** manishg has quit IRC19:39
*** manishg has joined #heat19:40
*** manishg has quit IRC19:44
*** sridhar_ram has joined #heat19:44
openstackgerritPratik Mallya proposed openstack/heat: Support RackConnect V3 LB in Rackspace AutoScaleGroup Resource  https://review.openstack.org/25673819:54
*** sridhar_ram has quit IRC20:01
*** sridhar_ram has joined #heat20:04
*** randallburt has quit IRC20:12
*** sparr has left #heat20:12
*** randallburt has joined #heat20:15
openstackgerritSteve Baker proposed openstack/heat: Make minimum default num_engine_workers>=4  https://review.openstack.org/25917220:21
*** blomquisg has joined #heat20:22
*** Marga_ has joined #heat20:22
openstackgerritPratik Mallya proposed openstack/heat: Support RackConnect V3 LB in Rackspace AutoScaleGroup Resource  https://review.openstack.org/25673820:24
*** zeih has joined #heat20:26
*** e0ne has joined #heat20:27
*** zeih has quit IRC20:31
pratikma_jasond`: in https://review.openstack.org/#/c/249460/5/heat/tests/test_resource.py, what are the tests testing for?20:34
*** pratikma_ is now known as pratikmallya20:35
jasond`pratikmallya: the new functionality20:37
jasond`pratikmallya: do you see a problem?20:38
pratikmallyajasond`: but I don' get the second test. You're setting the action as UPDATE?20:38
jasond`pratikmallya: hm, yeah, looks incorrect20:39
*** vgridnev has quit IRC20:40
*** sridhar_ram has quit IRC20:43
*** sridhar_ram has joined #heat20:44
openstackgerritJason Dunsmore proposed openstack/heat: Do not allow new creates for HIDDEN resources  https://review.openstack.org/24946020:50
jasond`pratikmallya: ^20:50
pratikmallyajasond`: Im curious how the tests were successful in the previous patch20:53
*** mbeierl has joined #heat20:54
jasond`pratikmallya: wrong assertion20:55
mbeierlPerhaps this is a better place to ask my question: I am trying to follow this example: http://hardysteven.blogspot.ca/2014/09/using-heat-resourcegroup-resources.html, but when I run it, I get Could not fetch remote template "server_with_volume.yaml": Invalid URL scheme20:55
mbeierldid something change with heat?  I am using Kilo20:55
pratikmallyajasond`: ah I see20:56
pratikmallyambeierl: server_with_volume.yaml has to be in the same location from which you run heat stack-create command20:58
mbeierlit is20:58
mbeierlIt says "invalid URL scheme" though.  Not file not found...20:59
mbeierlpratikmallya: If I add "file:" in front, it says "Invalid URL scheme file".20:59
pratikmallyambeierl: try the absolute filepath. Although it should work without that21:00
mbeierlpratikmallya: same error21:02
mbeierlpratikmallya: if I put http://127.0.0.1/server_with_volume.yaml, it returns a 404 not found at least21:02
thervembeierl, What your heat client version?21:03
mbeierltherve: heat --version returns 0.2.821:04
pratikmallyarandallburt: it seems the test for asg resource are mocking out the resource21:04
randallburtpratikmallya:  poop. that's problemmatic.21:05
mbeierlI am on Ubuntu 14.04 and I installed it using apt-get install python-heatclient21:06
thervembeierl, That's a bit old. I'd try something more recent21:06
mbeierltherve: where do I get something more recent for Ubuntu 14.04?21:06
*** dslevin has joined #heat21:07
therveYou can install something in a virtualenv, or maybe use some other repositories21:07
mbeierlpip install?21:07
mbeierlsorry, a little new to virtualenv21:07
*** manishg has joined #heat21:07
openstackgerritPratik Mallya proposed openstack/heat: Support RackConnect V3 LB in Rackspace AutoScaleGroup Resource  https://review.openstack.org/25673821:08
therveYeah pip install inside a virtualenv. I encourage you not to do that in your installed system21:09
therveOr use pip install --user21:09
pratikmallyarandallburt: this patch could use some love https://review.openstack.org/#/c/250951/21:11
randallburtpratikmallya:  looking21:11
randallburtRaj are we still doing SPA today?21:15
randallburtwhoops.21:15
*** Raj1 has joined #heat21:15
mbeierltherve: heat 0.8.0 from pip works, thanks!21:15
mbeierlAnother dumb question: How do I pass a property from the group into the single template?21:17
mbeierlparameter I mean21:18
*** daneyon_ has quit IRC21:18
*** daneyon has joined #heat21:19
mbeierlGot it.  Properties.21:21
mbeierlhow does one get the output parameters from the resource group?  I return the IP addresses assigned21:27
*** Raj2 has joined #heat21:34
*** Raj2 has quit IRC21:34
*** Raj2 has joined #heat21:35
*** Raj2 has quit IRC21:37
*** Raj2 has joined #heat21:37
*** Raj1 has quit IRC21:38
openstackgerritSteve Baker proposed openstack/heat: Push deployments metadata on delete  https://review.openstack.org/25443322:04
*** jonesbr has left #heat22:06
*** spzala has quit IRC22:06
*** Raj2 has quit IRC22:06
*** Raj1 has joined #heat22:10
*** Raj1 has quit IRC22:14
*** zeih has joined #heat22:15
*** zeih has quit IRC22:20
*** spzala has joined #heat22:26
*** manishg has quit IRC22:29
*** spzala has quit IRC22:31
*** manishg has joined #heat22:34
*** dslevin has quit IRC22:35
*** vijendar has quit IRC22:37
*** zeih has joined #heat22:42
*** dslevin has joined #heat22:43
*** e0ne has quit IRC22:47
*** zeih has quit IRC22:47
*** spzala has joined #heat22:54
*** EricGonczer_ has quit IRC23:00
*** rpothier has quit IRC23:03
*** spzala has quit IRC23:08
*** zeih has joined #heat23:09
*** yuanying has joined #heat23:12
*** zeih has quit IRC23:14
*** jasond` has quit IRC23:21
*** manishg has quit IRC23:25
*** manishg has joined #heat23:27
*** kse has joined #heat23:30
*** spotz is now known as spotz_zzz23:33
*** zeih has joined #heat23:37
*** tochi has joined #heat23:37
*** dprince has quit IRC23:39
*** chestack has joined #heat23:40
*** zeih has quit IRC23:41
*** Qiming has joined #heat23:46
*** manishg has quit IRC23:51
*** pratikmallya has quit IRC23:51
*** sdake has joined #heat23:51
*** sdake has quit IRC23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!