Tuesday, 2015-09-08

*** dimsum__ has quit IRC00:03
*** pm90_ has quit IRC00:05
openstackgerritMerged openstack/heat: Refactor ResourceGroup._get_batches() to be much, much simpler  https://review.openstack.org/21845400:05
*** kebray has joined #heat00:17
*** sdake has joined #heat00:18
*** shadower has joined #heat00:23
*** Qiming__ has quit IRC00:24
*** eliqiao has joined #heat00:29
openstackgerritTakashi NATSUME proposed openstack/python-heatclient: Use OS::Heat::RandomString in test templates  https://review.openstack.org/22085300:48
*** dimsum__ has joined #heat00:48
*** zengyingzhe has joined #heat00:52
*** kencjohn_ has quit IRC00:57
*** pm90_ has joined #heat01:06
*** pm90_ has quit IRC01:10
*** ricolin has joined #heat01:12
*** hdd has joined #heat01:14
*** Marga_ has joined #heat01:19
*** Marga_ has quit IRC01:20
*** Marga_ has joined #heat01:21
*** Qiming__ has joined #heat01:25
*** yuanying has quit IRC01:32
*** yuanying has joined #heat01:35
*** zhenguo has joined #heat01:35
*** Marga_ has quit IRC01:35
*** pm90_ has joined #heat01:36
*** eliqiao has quit IRC01:38
*** dimsum__ has quit IRC01:40
*** pm90_ has quit IRC01:42
*** eliqiao has joined #heat01:43
*** david-ly_ has joined #heat01:51
*** yuanying has quit IRC01:52
*** yuanying has joined #heat01:53
*** david-lyle has quit IRC01:54
*** Yanyanhu has joined #heat01:56
*** yuanying has quit IRC02:01
*** yuanying has joined #heat02:01
*** yuanying has quit IRC02:02
*** yuanying has joined #heat02:13
*** yuanying has quit IRC02:15
*** vijayagurug has joined #heat02:18
*** steveg_afk has joined #heat02:30
*** yuanying has joined #heat02:38
*** dimsum__ has joined #heat02:40
*** dimsum__ has quit IRC02:46
*** yuanying has quit IRC02:50
*** steveg_afk has quit IRC02:51
*** yuanying has joined #heat02:54
*** hdd has quit IRC02:56
*** vijayagurug has quit IRC02:57
*** nijaba has joined #heat03:10
*** nijaba has quit IRC03:10
*** nijaba has joined #heat03:10
cmystermorning03:22
ricolinmorning: -)03:24
*** vijayagurug has joined #heat03:28
*** Qiming__ has quit IRC03:29
openstackgerritZhongcheng Lao proposed openstack/python-heatclient: Add HTTP Basic/Digest auth  https://review.openstack.org/20407603:29
*** Qiming__ has joined #heat03:29
cmysterstevebaker: what was causing 1493166 ? same race issues?03:30
*** Yanyan has joined #heat03:30
stevebakercmyster: according to asalkeld's fix its a timestamp rounding issue03:32
*** liusheng has joined #heat03:32
cmysterahhh that issue...03:32
*** Yanyanhu has quit IRC03:32
*** Yanyanhu has joined #heat03:32
cmystershould this be effecting downstream as well ?03:32
*** blomquisg has quit IRC03:33
*** Yanyan has quit IRC03:35
*** ananta_ has joined #heat03:36
*** bleepbloop has joined #heat03:36
ananta_stevebaker: hi, regarding convergence scenario tests03:37
ananta_the tests are not failing, I have fixed them03:39
*** yuanying_ has joined #heat03:42
*** yuanying has quit IRC03:44
openstackgerritAnant Patil proposed openstack/heat: convergence scenario tests  https://review.openstack.org/20366103:49
*** hdd has joined #heat03:50
*** jamielennox is now known as jamielennox|away03:56
asalkeldstevebaker: my fix may not sort everything, though it was definitely happening on my setup04:00
*** vijayagurug has quit IRC04:01
*** bleepbloop has left #heat04:02
openstackgerritAngus Salkeld proposed openstack/heat: Round the elapsed time to the nearest second  https://review.openstack.org/22090304:04
*** sabeen2 has quit IRC04:09
*** kebray has quit IRC04:18
*** kebray has joined #heat04:18
cmysterasalkeld: re the time glitch thing, is it on latest or should I expect it in older version as well ?04:18
asalkeldcmyster: not sure, that particular function is newish04:21
asalkeldbut might have been there a while04:21
asalkeld(that calculation)04:21
cmysterasalkeld: how can I test to see if its there? just diff code or is there a test I can try04:22
asalkeldi had a very quick create and delete04:22
asalkeldand it timed out04:22
asalkeldit thought the delete happened just before the create04:22
cmysterhmmm04:22
asalkeld(as the create time was rounded)04:23
* cmyster sees04:23
cmysterI'll try somethingh on killo, will let you know04:23
asalkeldhave 1 random string04:23
asalkeldand in a script create + delete04:23
cmysterja was thinking something like that04:23
cmystera nice for seq 1..100 ; heat create ; heat delete sort of loop04:24
asalkeldlots of functional tests do something similar04:24
cmysteryup04:24
cmysterits why a timeout is important in those tests04:24
cmysternothing in real life is so fast04:24
*** KanagarajM has joined #heat04:29
KanagarajMgood morning all !04:32
*** pm90_ has joined #heat04:39
*** kebray_ has joined #heat04:41
ananta_can someone please eyeball convergence patch https://review.openstack.org/#/c/218233/04:43
*** kebray has quit IRC04:43
*** pm90_ has quit IRC04:44
asalkeldananta_: just picking kids up, will look in ~30mins04:46
*** KanagarajM has quit IRC05:11
*** vijayagurug has joined #heat05:28
cmysterhow would I add something like sleep in a resource?05:38
cmystersilly, but I need to bypass some bugs that neutron won't fix for now05:38
*** inc0 has joined #heat05:39
asalkeldcmyster: https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/test_resource.py#L81-L10905:39
asalkeld(but only for TestResource)05:39
cmysterI know that one asalkeld but that won't work for a real scenario wouldn't it ?05:40
asalkeldyeah, nothing for it then :-(05:40
cmysterif the root resource element can have such a parameter it would be grand, but just to bypass other's bug?05:42
cmysterasalkeld: I am trying to bypass this one BTW https://bugs.launchpad.net/neutron/+bug/143969605:43
openstackLaunchpad bug 1439696 in neutron "Referencing a lb-healthmonitor ID for the first time from Heat would fail" [High,Confirmed] - Assigned to Doug Wiegley (dougwig)05:43
asalkeldcmyster: not sure it would help as there would be issues with *where* to put the sleep05:43
cmysteryup it introduces too many assumptions05:44
*** vgridnev has joined #heat05:45
*** ananta_ has quit IRC05:46
cmysterasalkeld: I'll try maybe to put a depends on in the resource... I'm out of ideas how to make the system wait till everything is OK before probing the link05:48
asalkeldcmyster: that resource can poll a resource05:48
asalkeldcmyster: set "client_name: neutron", "entity_name: ???", value: <id of the resource>05:50
cmysterasalkeld: are you talking about hooks ?05:50
asalkeldhttps://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/heat/test_resource.py#L19005:50
*** rakesh_hs has joined #heat05:53
* cmyster reads05:55
cmysteroh I see,05:55
cmysterbut I don't think it matters05:55
cmysterthe resource is there and its real and the ID is fine. there is a slowness of service in neutron where the resource is created but the link to it is broken for a few milliseconds05:56
cmysterthats at least what I was told by a neutron guy. the 404 is a neutron error propagating to heat05:57
asalkeldok05:57
*** alexpilotti_ has joined #heat06:01
*** radez has quit IRC06:10
*** radez has joined #heat06:10
openstackgerritMerged openstack/heat: Merge Server os-collect-config metadata on create  https://review.openstack.org/21704006:22
*** hdd has quit IRC06:24
*** randallburt has joined #heat06:25
*** randallburt has quit IRC06:25
*** jprovazn has joined #heat06:25
*** randallburt has joined #heat06:25
*** pas-ha has joined #heat06:29
openstackgerritSreeram Vancheeswaran proposed openstack/heat: Change revision to version in heat-manage db_version command  https://review.openstack.org/22116506:35
pas-hawhere are the controls (like code and bugs) for heat-templates and heatclient gates? to fix some failures it seems we must register at least fake endpoints for all the services06:41
*** ananta_ has joined #heat06:44
*** lsmola has joined #heat06:47
*** KanagarajM has joined #heat06:52
*** tiantian has quit IRC06:52
*** tiantian has joined #heat06:53
*** tiantian has quit IRC06:55
*** tiantian has joined #heat06:55
*** kebray_ has quit IRC06:59
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Barbican)  https://review.openstack.org/22102307:10
openstackgerritPeter Razumovsky proposed openstack/heat: Add tests for parent handle_delete method  https://review.openstack.org/22102207:10
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Glance)  https://review.openstack.org/22103007:10
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Cinder)  https://review.openstack.org/22102907:10
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Ceilometer)  https://review.openstack.org/22102407:10
openstackgerritTakashi NATSUME proposed openstack/python-heatclient: Modify test templates and the path to subunit2html  https://review.openstack.org/22085307:11
*** KanagarajM has quit IRC07:14
*** KanagarajM has joined #heat07:16
*** liusheng has quit IRC07:23
*** jtomasek has joined #heat07:29
*** yassine__ has joined #heat07:30
*** pbrooko has joined #heat07:31
*** Guest32267 is now known as d0ugal07:32
*** d0ugal has joined #heat07:32
*** pbrooko has quit IRC07:33
*** inc0 has quit IRC07:34
*** jtomasek has quit IRC07:37
*** randallburt has quit IRC07:37
*** achanda has joined #heat07:43
*** shardy has joined #heat07:44
*** pbrooko has joined #heat07:44
openstackgerritSteven Hardy proposed openstack/heat: Add server validation check for deployments metadata  https://review.openstack.org/21979907:45
openstackgerritSteven Hardy proposed openstack/heat: Merge Server os-collect-config metadata on update  https://review.openstack.org/21944907:45
*** pbrooko has quit IRC07:46
*** pbrooko has joined #heat07:46
*** jtomasek has joined #heat07:48
*** sgran has quit IRC07:50
*** chlong has quit IRC07:56
*** zeih has joined #heat08:06
*** jcoufal has joined #heat08:09
openstackgerritMerged openstack/heat: Support string format 'tags' for stack preview  https://review.openstack.org/21614208:11
*** vgridnev has quit IRC08:12
openstackgerritTakashi NATSUME proposed openstack/python-heatclient: Modify test templates and the path to subunit2html  https://review.openstack.org/22085308:19
openstackgerritAnant Patil proposed openstack/heat: Convergence: Concurrency subtle issues  https://review.openstack.org/21823308:23
*** achanda has quit IRC08:25
*** achanda has joined #heat08:28
*** pm90_ has joined #heat08:29
*** jistr has joined #heat08:30
*** pbrooko has quit IRC08:33
*** pm90_ has quit IRC08:33
openstackgerritSreeram Vancheeswaran proposed openstack/heat: Change revision to version in heat-manage db_version command  https://review.openstack.org/22119808:37
*** blues-man has joined #heat08:43
*** pas-ha has quit IRC08:45
*** pbrooko has joined #heat08:45
*** derekh has joined #heat08:46
*** pas-ha has joined #heat08:48
*** sgran has joined #heat08:48
*** achanda has quit IRC08:52
*** sorantis has joined #heat08:54
*** vgridnev has joined #heat08:58
*** pbrooko has quit IRC08:59
*** pbrooko has joined #heat08:59
openstackgerritSergey Kraynev proposed openstack/heat: Extra check for stack_update in integration tests  https://review.openstack.org/22042809:05
openstackgerritSergey Kraynev proposed openstack/heat: Correctly handle port resource during Replace  https://review.openstack.org/22050209:05
openstackgerritSergey Kraynev proposed openstack/heat: Handle replace and rollback cases for Server  https://review.openstack.org/22103209:05
openstackgerritMerged openstack/heat: Don't return resource names from ResourceGroup._get_batches()  https://review.openstack.org/21845909:10
openstackgerritMerged openstack/heat: Handle scaling up in scaling library next_batch() function  https://review.openstack.org/21895709:10
openstackgerritMerged openstack/heat: Allow ResourceGroup rolling update to scale up  https://review.openstack.org/21895809:10
openstackgerritMerged openstack/heat: Allow ResourceGroup rolling update to scale down  https://review.openstack.org/21895909:10
openstackgerritMerged openstack/heat: Updated from global requirements  https://review.openstack.org/22111009:10
*** Beetnik has joined #heat09:13
*** e0ne has joined #heat09:16
openstackgerritTakashi NATSUME proposed openstack/python-heatclient: Modify test templates and the path to subunit2html  https://review.openstack.org/22085309:16
*** tlashchova has joined #heat09:17
*** lyanchih has joined #heat09:19
*** blues-man has quit IRC09:32
*** shardy_ has joined #heat09:33
*** shardy has quit IRC09:34
*** shardy_ has quit IRC09:38
*** shardy has joined #heat09:39
*** Marga_ has joined #heat09:41
*** e0ne has quit IRC09:41
*** sdake has quit IRC09:42
*** blues-man has joined #heat09:44
*** dimsum__ has joined #heat09:46
*** sgran has quit IRC09:48
*** steveg_afk has joined #heat09:50
*** dims_ has joined #heat09:50
*** sgran has joined #heat09:54
*** dimsum__ has quit IRC09:55
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Magnum)  https://review.openstack.org/22122309:55
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Manila)  https://review.openstack.org/22122409:55
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Mistral)  https://review.openstack.org/22122509:56
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Nova)  https://review.openstack.org/22122609:56
openstackgerritPeter Razumovsky proposed openstack/heat: Delete children handle_delete testing (Sahara)  https://review.openstack.org/22122709:56
*** e0ne has joined #heat09:57
*** Beetnik has quit IRC10:01
openstackgerritSergey Kraynev proposed openstack/heat: Handle replace and rollback cases for Server  https://review.openstack.org/22103210:03
*** kse has quit IRC10:12
*** steveg_afk has quit IRC10:21
*** Yanyan has joined #heat10:25
*** Yanyanhu has quit IRC10:25
*** ricolin has quit IRC10:27
*** Qiming__ has quit IRC10:28
*** Yanyan has quit IRC10:30
openstackgerritSteven Hardy proposed openstack/heat: PATCH update reuse existing template  https://review.openstack.org/20575410:40
openstackgerritSteven Hardy proposed openstack/heat: Add integration test for UPDATE_FAILED recovery  https://review.openstack.org/22124010:40
openstackgerritSteven Hardy proposed openstack/heat: Save previous template on non-convergence updates  https://review.openstack.org/22124110:40
*** sorantis has quit IRC10:41
*** jtomasek has quit IRC10:45
*** jtomasek has joined #heat10:45
*** Marga_ has quit IRC10:46
openstackgerritOleksii Chuprykov proposed openstack/heat: Check number of deployments after stack creation  https://review.openstack.org/21862710:47
openstackgerritOleksii Chuprykov proposed openstack/heat: Add batching create to ResourceGroup  https://review.openstack.org/18538510:48
*** sorantis has joined #heat10:53
openstackgerrithuangtianhua proposed openstack/heat: Allow attach multiple nics for instance in asg  https://review.openstack.org/20983110:53
*** lyanchih has quit IRC10:58
*** Marga_ has joined #heat10:58
skraynevshardy: looks like we do the same work :) https://review.openstack.org/#/c/220428/  https://review.openstack.org/#/c/22124011:07
*** sorantis_ has joined #heat11:08
openstackgerritMerged openstack/heat: Clarify definition of server network prop in doc  https://review.openstack.org/22097711:10
*** sorantis has quit IRC11:11
*** sorantis_ is now known as sorantis11:11
*** Marga_ has quit IRC11:20
LimorStotlandHi all11:26
LimorStotlandcan i pleas geat +2 on this :https://review.openstack.org/#/c/218633/17?11:27
LimorStotlandThanks11:27
*** Qiming__ has joined #heat11:27
*** higgins has quit IRC11:39
*** tochi has quit IRC11:41
*** pm90_ has joined #heat11:46
*** jdob has joined #heat11:48
*** shardy_ has joined #heat11:49
*** mklyus has joined #heat11:50
*** pm90_ has quit IRC11:50
*** higgins has joined #heat11:50
*** pm90_ has joined #heat11:50
*** shardy has quit IRC11:50
*** shardy_ has quit IRC11:55
*** shardy has joined #heat11:55
*** jecarey has quit IRC11:56
*** KanagarajM has quit IRC12:01
*** e0ne has quit IRC12:01
*** alexpilotti_ has quit IRC12:03
*** e0ne has joined #heat12:04
openstackgerritTetiana Lashchova proposed openstack/heat: Support update for sahara node group template  https://review.openstack.org/22127412:18
*** liusheng has joined #heat12:21
*** Marga_ has joined #heat12:21
*** chlong has joined #heat12:22
*** Marga_ has quit IRC12:26
*** e0ne has quit IRC12:26
*** liusheng has quit IRC12:27
*** hdd has joined #heat12:29
*** vijayagurug has left #heat12:32
*** dyasny has joined #heat12:35
*** zengyingzhe has quit IRC12:46
skraynevrakeh_hs: ping12:47
jgrasslerGood afternoon.12:48
jgrasslerAre there any known issues with the get_attr function on Kilo?12:48
*** crose has joined #heat12:50
jgrasslerI'm currently test-driving some of our global resources (which require the use of get_attr in some places) and the bits and all the broken bits have a common theme of get_attr being used to pass stuff exposed by our provider resources into other resource definitions.12:51
jgrasslers/and the bits//12:51
*** hdd has quit IRC12:52
*** rpothier has joined #heat12:55
*** jdandrea has joined #heat12:58
*** jpeeler has joined #heat12:59
openstackgerritOleksii Chuprykov proposed openstack/heat: Wait for metadata actually set to server  https://review.openstack.org/21862713:00
*** lyanchih has joined #heat13:03
*** slagle_ is now known as slagle13:03
*** jonesbr has joined #heat13:04
*** Piet has quit IRC13:07
*** vgridnev has quit IRC13:07
*** vgridnev has joined #heat13:07
*** e0ne has joined #heat13:08
*** mklyus has quit IRC13:11
*** jecarey has joined #heat13:14
*** vijendar has joined #heat13:16
*** neelashah has joined #heat13:17
*** jprovazn has quit IRC13:18
*** aweiteka has joined #heat13:19
*** Marga_ has joined #heat13:20
*** crose has quit IRC13:20
*** spzala has joined #heat13:21
*** jaime49 has joined #heat13:22
openstackgerritOleksii Chuprykov proposed openstack/heat: Wait for metadata actually set to server  https://review.openstack.org/21862713:22
*** Marga_ has quit IRC13:24
*** blomquisg has joined #heat13:27
jdandreashardy: Thanks for the +2 on <https://review.openstack.org/218992>! Should I change the topic to bug/1476345? (That was already a Liberty branch on my end though.)13:31
shardyjdandrea: np, I wouldn't worry about the topic, the commit Closes-Bug has been picked up in the bug OK13:33
jdandreaOk.13:33
*** vijayagurug has joined #heat13:33
*** jaime49 has left #heat13:34
*** aweiteka_ has joined #heat13:35
*** Marga_ has joined #heat13:37
*** Marga_ has quit IRC13:37
*** Marga_ has joined #heat13:37
openstackgerritOleksii Chuprykov proposed openstack/heat: Add batching create to ResourceGroup  https://review.openstack.org/18538513:46
*** ricolin has joined #heat13:49
*** rakesh_hs has quit IRC13:52
*** jprovazn has joined #heat14:00
*** jcoufal has quit IRC14:00
*** jistr is now known as jistr|call14:01
*** shardy_ has joined #heat14:01
*** Marga_ has quit IRC14:03
*** shardy has quit IRC14:03
*** shardy_ has quit IRC14:07
*** shardy has joined #heat14:07
openstackgerritRabi Mishra proposed openstack/heat: Move new capacity calculation to scaling library  https://review.openstack.org/22131214:09
*** zeih has quit IRC14:10
*** Marga_ has joined #heat14:13
*** jasond has joined #heat14:13
*** zeih has joined #heat14:14
*** pm90_ has quit IRC14:17
*** ananta_ has quit IRC14:17
*** Marga_ has quit IRC14:17
*** jistr|call is now known as jistr14:20
*** dims_ has quit IRC14:26
*** steveg_afk has joined #heat14:27
*** dimsum__ has joined #heat14:27
*** Drago has joined #heat14:27
openstackgerritSergey Kraynev proposed openstack/heat: Copy resource data in _delete_backup_stack  https://review.openstack.org/22098614:30
*** vishwanathj has joined #heat14:32
*** inc0 has joined #heat14:33
*** jcoufal has joined #heat14:37
*** Marga_ has joined #heat14:38
*** Marga_ has quit IRC14:38
*** Marga_ has joined #heat14:38
*** Marga_ has quit IRC14:39
*** Drago has quit IRC14:40
*** Drago has joined #heat14:40
*** Marga_ has joined #heat14:42
*** david-ly_ is now known as david-lyle14:53
*** hdd has joined #heat14:56
*** andrearosa has quit IRC15:10
*** Piet has joined #heat15:10
*** pm90_ has joined #heat15:11
*** sabeen has joined #heat15:13
*** andrearosa has joined #heat15:14
*** sabeen3 has joined #heat15:16
*** kencjohn_ has joined #heat15:16
*** andrearosa has left #heat15:17
*** randallburt has joined #heat15:17
*** sabeen has quit IRC15:18
*** zeih has quit IRC15:22
*** dims_ has joined #heat15:25
*** aweiteka has quit IRC15:27
*** aweiteka_ has quit IRC15:27
openstackgerritTetiana Lashchova proposed openstack/heat: Support update for sahara cluster template  https://review.openstack.org/22136215:27
*** dimsum__ has quit IRC15:29
*** sorantis has quit IRC15:29
*** pm90__ has joined #heat15:31
*** vgridnev has quit IRC15:33
*** pm90___ has joined #heat15:33
*** pm90_ has quit IRC15:35
*** Qiming__ has quit IRC15:35
*** higgins has quit IRC15:36
*** pm90__ has quit IRC15:36
*** aweiteka has joined #heat15:39
*** higgins has joined #heat15:40
*** aweiteka_ has joined #heat15:42
*** devlaps has joined #heat15:43
*** yassine__ has quit IRC15:51
*** sergmelikyan has joined #heat15:59
*** Marga_ has quit IRC16:00
*** jprovazn has quit IRC16:00
*** pm90___ has quit IRC16:03
*** pm90_ has joined #heat16:04
*** sdake_ has joined #heat16:06
*** rwsu has joined #heat16:07
*** zhenguo has quit IRC16:08
*** vahidh has joined #heat16:09
*** jistr has quit IRC16:11
*** aweiteka has quit IRC16:12
*** aweiteka_ has quit IRC16:12
openstackgerritRandall Burt proposed openstack/heat-templates: Handle non-zero success codes from Salt  https://review.openstack.org/21125416:20
*** Marga_ has joined #heat16:23
openstackgerritSteven Hardy proposed openstack/heat: PATCH update reuse existing template  https://review.openstack.org/20575416:23
openstackgerritSteven Hardy proposed openstack/heat: Save previous template on non-convergence updates  https://review.openstack.org/22124116:23
*** aweiteka has joined #heat16:25
*** ricolin has quit IRC16:25
*** aweiteka_ has joined #heat16:26
shardyzaneb: Hey, if you get a moment to check out https://review.openstack.org/#/c/205754/ I'd appreciate it - I'm really struggling to see why I'm getting parameter not found errors, when AFAICT the parameter is defined in the new template.Template before the update starts16:27
*** lyanchih has quit IRC16:29
shardyHrm.  /me looks at _prepare_stack_updates16:30
*** kebray has joined #heat16:31
*** dims_ has quit IRC16:31
*** dimsum__ has joined #heat16:32
*** achanda has joined #heat16:32
*** kebray has quit IRC16:34
*** vijayagurug has quit IRC16:35
*** vgridnev has joined #heat16:37
*** kencjohn_ has quit IRC16:41
*** derekh has quit IRC16:42
*** kebray has joined #heat16:42
zanebshardy: added to my todo list. note that there was a patch that went in recently to merge old and new params at the start of an update, so that we don't get that error if we fail part way through (and some new resources are copied over). no idea if that is related16:43
shardyzaneb: Ok, thanks, could be - it seems that we're failing while deleting backup resources, which somehow end up referencing the parameter schemata for the new non-backup stack, or something16:45
shardyhttp://paste.openstack.org/show/450474/16:45
*** inc0 has quit IRC16:46
zanebsounds hairy16:46
*** kencjohn_ has joined #heat16:48
*** crose has joined #heat16:50
*** pbrooko has quit IRC16:53
*** achanda has quit IRC16:56
*** achanda_ has joined #heat16:56
*** e0ne has quit IRC16:56
*** ananta_ has joined #heat16:58
ananta_zaneb: hi! regarding https://review.openstack.org/#/c/220483/116:59
zanebananta_: coincidentally, I just commented on that about 3s ago16:59
zaneb:)17:00
ananta_zaneb: sure, I will look  into it17:00
zanebananta_: I think we basically agree17:00
zanebananta_: the advantage of the shell param is that it makes people explicitly decide which behaviour they want17:01
ananta_zaneb: I am just worried if shell=True is secure enough...it is vulnerable to shell injection17:01
ananta_I am ok will all other stuff17:01
zanebthe places where we would legitimately use that are places where the user is allowed to run any command17:02
zanebit's their box at the end of the day ;)17:02
ananta_zaneb: true :)17:02
*** harlowja has joined #heat17:03
ananta_zaneb: do we really have to convert all the commands to list?17:03
zanebthe problem is where we're using the same code to do something completely different17:03
zanebananta_: some of them are clearly safe (e.g. the ones that have no parameters), but I still think it would pay to convert all the internal ones to a list17:04
zanebprovides a hard boundary between the two use cases17:04
*** kebray has quit IRC17:04
ananta_zaneb: I am thinking the ones where we do curl and the url passed from init may not need it17:05
ananta_like https://github.com/openstack/heat-cfntools/blob/master/heat_cfntools/cfntools/cfn_helper.py#L79117:06
zanebif we control the url, and we know it's properly escaped then we don't *need* it. but we should still do it imho17:06
ananta_zaneb: actually we are running multiple commands there with pipe and redirect17:06
zanebah, yeah, that will be more work to change17:06
zanebI see the problem there17:07
ananta_the url is read from metadata, not sure if it would be safe17:07
*** Marga_ has quit IRC17:07
ananta_but unlike in cfn-signal, it is not interpreted twice17:07
*** Marga_ has joined #heat17:07
*** achanda_ has quit IRC17:08
zanebananta_: true, but those URLs come from the user, they're not necessarily correctly escaped, and the user isn't expecting them to be passed to a shell (unlike when they're specifying e.g. a shell command)17:08
*** Marga_ has quit IRC17:08
ananta_zaneb: sure, got it...17:09
*** Marga_ has joined #heat17:09
ananta_zaneb: I guess more work then to really fix it :(17:09
zanebyeah :/17:09
ananta_I could have easily fixed the pipe ones, but redirect looks hard17:10
zanebI suspect a lot of that could be written in pure python17:10
ananta_zaneb: yes17:11
ananta_zaneb: I will split the fix into two parts: 1. set only EUID and make the execvp to restore the original EUID, 2. make sure list is passed as command to CommandRunner17:11
*** Marga_ has quit IRC17:11
ananta_(1) comes from your comment on the code...I did some experiment and you are right17:11
zanebon the bright side, if you left those ones as being intrepreted by the shell, it would be no worse than before. it would just mean the original bug wasn't really fixed yet17:11
zanebsounds good17:12
ananta_zaneb: I shall try... worst case we shall have the cfn-signal as fixed17:13
ananta_but not all17:13
zanebyep, that will be good progress17:13
zanebI suspect that is the most used one17:13
*** Marga_ has joined #heat17:15
ananta_zaneb: sure! will upload some patches tomorrow, thanks for your valuable comments17:16
ananta_zaneb: have a good day!17:16
zanebthanks, you too!17:16
*** sdake_ has quit IRC17:19
*** ananta_ has quit IRC17:20
*** achanda has joined #heat17:21
*** vahidh has quit IRC17:23
*** pas-ha has quit IRC17:24
*** pas-ha has joined #heat17:24
*** blues-man has quit IRC17:26
openstackgerritMiguel Grinberg proposed openstack/heat: Add signal_transport property to Heat wait conditions  https://review.openstack.org/21999617:28
*** lsmola has quit IRC17:29
*** Nepoc has joined #heat17:32
*** vahidh has joined #heat17:38
*** crose has quit IRC17:38
*** neelashah has quit IRC17:41
*** aweiteka__ has joined #heat17:42
*** sdake has joined #heat17:44
*** aweiteka_ has quit IRC17:46
*** e0ne has joined #heat17:47
*** markvan has joined #heat17:52
*** vgridnev has quit IRC18:00
*** vgridnev has joined #heat18:06
*** pas-ha has quit IRC18:06
*** vgridnev has quit IRC18:06
*** inc0 has joined #heat18:07
*** inc0 has quit IRC18:12
*** sdake_ has joined #heat18:25
*** e0ne has quit IRC18:29
*** sdake has quit IRC18:29
*** openstackgerrit has quit IRC18:31
*** zeih has joined #heat18:32
*** openstackgerrit has joined #heat18:32
*** zeih has quit IRC18:36
*** sdake_ is now known as sdake18:40
*** achanda has quit IRC18:40
*** achanda has joined #heat18:41
*** vijendar has quit IRC18:45
*** sdake_ has joined #heat18:46
*** vgridnev has joined #heat18:48
*** sdake has quit IRC18:49
*** sergmelikyan has quit IRC18:56
*** achanda has quit IRC18:57
*** sergmelikyan has joined #heat18:57
*** sergmelikyan has quit IRC18:58
*** sergmelikyan has joined #heat18:59
*** derekh has joined #heat19:00
*** neelashah has joined #heat19:02
*** Marga_ has quit IRC19:06
*** neelashah has quit IRC19:06
*** neelashah has joined #heat19:08
*** vgridnev has quit IRC19:09
*** pbrooko has joined #heat19:15
*** vijendar has joined #heat19:16
*** vgridnev has joined #heat19:17
*** pbrooko has quit IRC19:18
*** kebray has joined #heat19:20
*** kebray has quit IRC19:20
*** kebray has joined #heat19:21
*** kebray has quit IRC19:36
*** achanda has joined #heat19:38
*** inc0 has joined #heat19:43
*** achanda has quit IRC19:45
*** sdake_ is now known as sdake19:49
*** neelashah has quit IRC19:55
*** inc0 has quit IRC19:55
*** jecarey has quit IRC19:56
*** derekh is now known as derekh_afk19:58
*** dimsum__ is now known as dims20:03
*** dims is now known as Guest8007120:04
*** Guest80071 is now known as dims__20:08
*** steveg_afk has quit IRC20:13
*** steveg_afk has joined #heat20:14
*** jprovazn has joined #heat20:24
*** kencjohn_ has quit IRC20:34
*** sergmelikyan has quit IRC20:36
*** vgridnev has quit IRC20:40
*** jprovazn has quit IRC20:40
*** shardy_ has joined #heat20:41
*** achanda has joined #heat20:41
*** shardy has quit IRC20:42
*** shardy_ has quit IRC20:46
*** Marga_ has joined #heat20:46
*** shardy has joined #heat20:47
*** derekh_afk has quit IRC20:48
*** randallburt has quit IRC20:48
*** jecarey has joined #heat20:50
*** achanda has quit IRC20:51
*** vgridnev has joined #heat20:53
*** achanda has joined #heat20:54
*** sergmelikyan has joined #heat20:55
*** jonesbr1 has joined #heat20:55
*** Nepoc has quit IRC20:55
*** pm90__ has joined #heat20:55
*** steveg_afk has quit IRC20:55
*** Nepoc has joined #heat20:56
*** jonesbr has quit IRC20:57
*** pm90___ has joined #heat20:57
*** neelashah has joined #heat20:58
*** pm90_ has quit IRC20:58
*** pm90__ has quit IRC21:00
*** sergmelikyan has quit IRC21:01
*** sergmelikyan has joined #heat21:02
*** kencjohn_ has joined #heat21:03
*** sergmelikyan has quit IRC21:06
*** sergmelikyan has joined #heat21:06
*** sergmelikyan has quit IRC21:10
*** pm90___ has quit IRC21:10
openstackgerritMerged openstack/python-heatclient: Modify test templates and the path to subunit2html  https://review.openstack.org/22085321:10
*** vgridnev has quit IRC21:13
*** sergmelikyan has joined #heat21:13
*** sergmelikyan has quit IRC21:14
*** jonesbr1 has left #heat21:14
*** sdake_ has joined #heat21:16
*** sdake has quit IRC21:20
*** steveg_afk has joined #heat21:28
*** vgridnev has joined #heat21:31
*** pm90_ has joined #heat21:34
openstackgerritJason Dunsmore proposed openstack/heat: Retry if Swift objects are not available yet  https://review.openstack.org/22151121:34
*** rpothier has quit IRC21:34
*** achanda has quit IRC21:35
*** achanda has joined #heat21:35
*** pm90__ has joined #heat21:35
*** kencjohn_ has quit IRC21:35
*** devlaps has quit IRC21:38
*** pm90_ has quit IRC21:39
*** vgridnev has quit IRC21:44
*** achanda_ has joined #heat21:44
*** achanda has quit IRC21:44
*** sergmelikyan has joined #heat21:45
*** sergmelikyan has quit IRC21:46
*** randallburt has joined #heat21:47
*** randallburt has quit IRC21:47
*** randallburt has joined #heat21:48
*** jamielennox|away is now known as jamielennox21:51
*** sdake_ is now known as sdake21:55
*** pm90__ has quit IRC21:56
*** achanda_ has quit IRC21:58
*** pm90_ has joined #heat21:58
*** jasond has quit IRC22:01
*** neelashah has quit IRC22:01
*** neelashah has joined #heat22:01
*** achanda has joined #heat22:02
*** sdake_ has joined #heat22:02
*** derekh has joined #heat22:03
*** sdake has quit IRC22:05
*** Marga_ has quit IRC22:07
*** Marga_ has joined #heat22:07
*** achanda has quit IRC22:09
*** achanda has joined #heat22:09
*** Piet has quit IRC22:11
*** achanda_ has joined #heat22:13
*** achanda has quit IRC22:13
*** sergmelikyan has joined #heat22:19
*** neelashah has quit IRC22:20
*** derekh has quit IRC22:24
*** sergmelikyan has quit IRC22:26
*** alex_xu has quit IRC22:28
*** alex_xu has joined #heat22:30
*** jecarey has quit IRC22:31
*** neelashah has joined #heat22:31
*** vijendar has quit IRC22:36
*** sabeen3 has quit IRC22:42
*** randallburt has quit IRC22:43
*** Marga__ has joined #heat22:49
*** Marga_ has quit IRC22:51
*** achanda has joined #heat22:55
*** achanda_ has quit IRC22:55
openstackgerritKanagaraj Manickam proposed openstack/python-heatclient: Enable filters for heat resource-type-list  https://review.openstack.org/21769722:55
*** Piet has joined #heat23:00
*** achanda_ has joined #heat23:01
*** achanda has quit IRC23:01
*** steveg_afk has quit IRC23:01
*** sergmelikyan has joined #heat23:15
*** sergmelikyan has quit IRC23:20
*** achanda has joined #heat23:23
*** achanda_ has quit IRC23:23
*** pm90_ has quit IRC23:25
*** asalkeld has quit IRC23:25
*** chlong has quit IRC23:27
*** chlong has joined #heat23:28
*** asalkeld has joined #heat23:30
*** tochi has joined #heat23:33
*** kse has joined #heat23:34
*** Qiming__ has joined #heat23:36
*** sergmelikyan has joined #heat23:37
*** sergmelikyan has quit IRC23:37
*** steveg_afk has joined #heat23:40
*** Drago has quit IRC23:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!