Wednesday, 2013-12-18

*** arbylee has joined #heat00:02
stevebakerheat delete config100:06
stevebakerERROR: Stack config1 already has an action (CREATE) in progress.00:06
stevebakerthat shouldn't be happening00:06
*** agileclipse has left #heat00:09
*** spzala has joined #heat00:10
stevebakerhttps://bugs.launchpad.net/heat/+bug/126201200:11
uvirtbotLaunchpad bug 1262012 in heat "Cannot delete an IN_PROGRESS stack" [High,Triaged]00:12
*** jcru has quit IRC00:13
*** cody-somerville has joined #heat00:14
*** cody-somerville has quit IRC00:14
*** cody-somerville has joined #heat00:14
*** rongze has joined #heat00:16
*** rongze has quit IRC00:21
*** arbylee has quit IRC00:22
*** andersonvom has quit IRC00:22
*** arbylee has joined #heat00:22
*** andersonvom has joined #heat00:22
*** andersonvom has quit IRC00:27
*** arbylee has quit IRC00:27
*** pvaneck has quit IRC00:32
*** jergerber has quit IRC00:45
*** brint has quit IRC00:50
*** yogesh has joined #heat01:02
*** blamar has quit IRC01:03
*** arbylee has joined #heat01:16
spzalastevebaker: Hi. Thanks for the email on software config progress with awesome detail.  I am testing/reviewing it.01:16
*** andrewmi- has joined #heat01:16
*** gamekiller77 has quit IRC01:18
*** spzala has quit IRC01:20
*** andersonvom has joined #heat01:20
*** urulama has joined #heat01:25
*** blamar has joined #heat01:26
*** nosnos has joined #heat01:26
*** urulama has quit IRC01:30
*** spzala has joined #heat01:38
*** sdake has quit IRC01:42
*** sdake has joined #heat01:42
*** sdake has quit IRC01:43
*** sdake has joined #heat01:43
*** yogesh has quit IRC01:43
*** AndrewMichalik has joined #heat01:45
*** cody-somerville has quit IRC01:48
*** agileclipse has joined #heat01:50
*** jomara has quit IRC02:00
*** jomara has joined #heat02:00
*** guohliu has joined #heat02:03
*** AndrewMichalik has quit IRC02:07
sdake_hardwiring internet is so much fun in a brick house02:08
sdake_thank god for hammer drills02:08
openstackgerritAngus Salkeld proposed a change to openstack/heat: Add migration test framework  https://review.openstack.org/6279602:10
asalkeldlifeless, I can't get this data to fail ^02:10
lifelessasalkeld: word02:11
*** arbylee has quit IRC02:11
asalkeldhttps://review.openstack.org/#/c/62796/1/heat/tests/db/test_migrations.py02:11
asalkeldthis is testing sqlite and mysql02:11
lifelessmysql> CREATE TABLE stack_lock (     stack_id VARCHAR(36) NOT NULL,    created_at DATETIME,   updated_at DATETIME,   engine_id VARCHAR(36),   PRIMARY KEY (stack_id),   FOREIGN KEY(stack_id) REFERENCES stack (id) )ENGINE=InnoDB CHARSET=utf8;02:11
lifelessERROR 1005 (HY000): Can't create table 'heat.stack_lock' (errno: 150)02:11
*** gokrokve has joined #heat02:12
asalkeldcan you have a quick look at my test?02:12
lifelessseems plausible02:13
asalkeldreally irritating that the test doen't fail02:14
lifelesshttp://paste.openstack.org/show/55244/02:14
lifelesscurrent schema02:14
*** rongze has joined #heat02:14
zaneblifeless: errno 150 means a problem with foreign keys...02:17
zaneblifeless: http://stackoverflow.com/a/18180299 <- how to get the real error message02:18
zanebooh02:19
zanebhttp://www.eliacom.com/mysql-gui-wp-errno-150.php02:19
lifelesshttps://bugs.launchpad.net/heat/+bug/1261605 - last comment02:20
uvirtbotLaunchpad bug 1261605 in heat "migration 30 -> 31 (031_stack_lock)  fails" [Critical,In progress]02:20
*** blomquisg has quit IRC02:22
stevebakerspzala: good to hear02:38
spzalastevebaker: :-) sure.02:38
*** erkules_ has joined #heat02:41
*** erkules has quit IRC02:44
*** yogesh has joined #heat02:54
*** vkozhukalov has joined #heat02:54
*** yogesh has quit IRC02:58
*** bobzhang_ has joined #heat03:00
*** rongze has quit IRC03:02
*** nati_uen_ has quit IRC03:04
*** swygue has joined #heat03:07
*** rongze has joined #heat03:10
*** blak111 has quit IRC03:25
*** urulama has joined #heat03:26
*** urulama has quit IRC03:31
*** giulivo has quit IRC03:33
*** slong has joined #heat03:34
asalkeldlifeless, http://paste.openstack.org/show/55253/03:41
asalkeldthat ^ works for me03:41
*** bobzhang_ has quit IRC03:45
*** ccs has joined #heat03:47
*** harlowja is now known as harlowja_away03:51
*** IlyaE has joined #heat03:55
*** IlyaE has quit IRC03:57
*** dguerri has quit IRC03:59
*** rcleere has joined #heat04:00
*** IlyaE has joined #heat04:00
*** IlyaE has quit IRC04:02
*** liang has joined #heat04:03
*** dguerri has joined #heat04:05
*** bobzhang_ has joined #heat04:12
*** chandankumar has joined #heat04:15
*** bobzhang_ has quit IRC04:22
*** slong has quit IRC04:24
spzalastevebaker: need some help. Can you please take a look at the link when you get a chance? - http://fpaste.org/62725/13873406/04:24
*** slong has joined #heat04:24
*** ccs has quit IRC04:24
*** ccs has joined #heat04:29
*** topol has joined #heat04:29
SpamapSstevebaker: BTW in the tripleo CD cloud we've started doing stack-update instead of delete/create .. so now if the stack create or update fails.. no retry == manual intervention == annoyed SpamapS04:29
SpamapSstevebaker: so that should motivate me to solve the retry problem soonish :)04:29
*** ccs has quit IRC04:31
*** ccs has joined #heat04:32
*** radez is now known as radez_g0n304:34
stevebakerspzala: are you running neutron or nova networking?04:36
stevebakerSpamapS: yeah, update would be super useful were it not for that04:36
*** guohliu has quit IRC04:36
spzalastevebaker: it's nova04:37
stevebakerspzala: that template has a neutron security group04:38
SpamapSstevebaker: pretty straight forward.. just have to replace failed resources.04:38
spzalastevebaker: ahh, I see04:39
*** akuznetsov has joined #heat04:40
spzalastevebaker: Thanks!! I will try it with neutron.04:43
stevebakerspzala: or just switch the template to use the ec2 security group04:44
spzalastevebaker: Cool. That's definitely better04:46
*** rongze has quit IRC04:59
openstackgerritStephen Sugden proposed a change to openstack/heat: Add PortCheck resource  https://review.openstack.org/6207805:06
*** rushiagr has joined #heat05:11
*** nkhare has joined #heat05:12
*** yogesh has joined #heat05:16
*** xuan has joined #heat05:21
*** SergeyLukjanov has joined #heat05:24
*** guohliu has joined #heat05:26
*** spzala has quit IRC05:27
*** urulama has joined #heat05:27
*** rongze has joined #heat05:30
*** sdake_ has quit IRC05:31
*** urulama has quit IRC05:32
*** rongze has quit IRC05:35
sergmelikyanDoes someone here used pydev debugger with heat?05:41
*** rcleere has quit IRC05:44
*** slong has quit IRC05:50
*** nati_ueno has joined #heat05:51
*** slong has joined #heat05:54
*** SergeyLukjanov is now known as _SergeyLukjanov05:56
*** _SergeyLukjanov has quit IRC05:56
*** gokrokve has quit IRC05:57
*** gokrokve has joined #heat05:58
*** rushiagr has quit IRC05:58
*** gokrokve_ has joined #heat05:58
stevebakersergmelikyan: only for unit tests06:01
openstackgerritStephen Sugden proposed a change to openstack/heat: Add PortCheck resource  https://review.openstack.org/6207806:01
* sergmelikyan usually using PyCharm IDE for developing on python, that use pydev debugger for debugging06:02
*** gokrokve_ has quit IRC06:02
*** gokrokve has quit IRC06:02
sergmelikyanstevebaker, I have some issues with viewing frames - could not extract current scope variables06:03
*** xuan is now known as xuan-afk06:04
openstackgerritJenkins proposed a change to openstack/heat: Imported Translations from Transifex  https://review.openstack.org/6255106:06
stevebakersergmelikyan: I'm not sure, it just works for me06:06
sergmelikyanI had simple setup with running pycharm on local machine and clean devstack on vm.06:06
sergmelikyanWhen trying to create simple stack, I stack with AuthenticationFailed error06:07
sergmelikyanhttps://github.com/openstack/heat/blob/master/heat/engine/clients.py#L12206:07
sergmelikyanThis line while executed no matter what uses 2.0 client for authentication06:07
*** rongze has joined #heat06:08
sergmelikyanhttp://paste.openstack.org/show/55267/ - traceback06:08
*** nkhare has quit IRC06:11
*** SergeyLukjanov has joined #heat06:12
*** radix_ has quit IRC06:13
*** vkozhukalov has quit IRC06:15
*** vkozhukalov has joined #heat06:15
lifelessasalkeld: by works-for-you do you mean makes-the-test-fail?06:17
asalkeldno, just to clean up you db dump06:17
asalkeldit's wipes the parameters06:17
lifelessoh right06:18
lifelessah we have stuff in event - access keys etc06:19
*** sgordon has quit IRC06:19
asalkeldit's easy to add to that script06:19
asalkeldyou could just drop the event table06:20
lifeless+ secret_access_keys in resources06:20
asalkeldI don't need it06:20
lifelessok, just the stack table?06:20
asalkeldstack and template and creds06:20
asalkeldstack + foriegn keyed tables06:20
lifelessdo you mean raw_template?06:21
*** radix_ has joined #heat06:21
asalkeldyip06:21
asalkeldyou could kill the actual template06:21
asalkeldI just want valid references06:21
openstackgerritAngus Salkeld proposed a change to openstack/heat: Add migration test framework  https://review.openstack.org/6279606:24
asalkeldlifeless, this ^test now takes a sql dump06:24
asalkeldso you can see if it is reproducable by moving your sql dump to: heat/tests/db/pre_031_data.sql06:25
*** topol has quit IRC06:26
*** xuan-afk is now known as xuan06:26
lifelessasalkeld: I think I've sanitised, sec while I pull it down06:28
lifelessasalkeld: what gpg key do you want it crypted to?06:28
asalkeldcan you get at my github public key?06:29
lifelessplease wait while subkeys.pgp.net goes slow06:30
asalkeldlifeless, emailed you my pub key06:32
*** gokrokve has joined #heat06:33
*** nkhare has joined #heat06:33
*** fsargent has left #heat06:33
*** gokrokve_ has joined #heat06:35
lifelessasalkeld: lol, thats ssh06:36
lifelessasalkeld: t06:37
lifeless(1)     Angus Salkeld <asalkeld@redhat.com>06:37
lifeless          2048 bit RSA key CA8CF34A, created: 2010-03-1506:37
lifelessasalkeld: you ?06:37
asalkelddoh06:37
asalkeldyeah, that's me06:37
*** gokrokve has quit IRC06:38
asalkeldyou can see I use gpg all day - not06:38
*** gokrokve_ has quit IRC06:40
*** rwsu_ has quit IRC06:41
*** Seal has joined #heat06:43
*** andersonvom has quit IRC06:46
*** Seal has quit IRC06:47
lifelessasalkeld: well, lets see if you can decrypt it ;>06:48
asalkeldtrying to see if I can even find the private key :(06:48
asalkeldga06:48
SpamapSlifeless: converge is expensive06:49
*** amritanshu_RnD has joined #heat06:49
lifelesswhat makes it expensive?06:49
SpamapSlifeless: big stack.. you're going to bombard all of the resources with status updates from their respective API's.06:49
SpamapSThat's the thinking anyway.06:50
SpamapSUpdate is "I know I want to make this change"06:50
lifelessSpamapS: async examination of reality06:50
lifelessSpamapS: did you see the etherpad about how I'd be inclined to tackle it?06:51
SpamapSYes06:51
lifelesscool06:51
SpamapSAnd I championed that cause last week.06:51
lifeless\o/06:51
SpamapSRejected.. "Background threads are bad"06:51
SpamapS"Users can ask for it if they want it."06:51
*** vkozhukalov has quit IRC06:52
lifelesswtf06:52
lifelessheats entire operation is a background thread06:52
lifelessthat argument makes no sense to me06:52
SpamapSlifeless: AFAICT, what will happen is users will have a cron job which pokes Heat to update its' view of reality because we don't want to have such cron jobs in heat-engine.06:52
lifelessthat seems disasterous06:52
*** IlyaE has joined #heat06:53
asalkeldbbl, picking kids up06:53
lifelessI predict large clouds adding a feature to delay such requests06:53
SpamapSlifeless: I don't think it is disasterous, but I do think we could just let Heat do it without the user having to ask.06:53
lifelesson thebasis that everyone cronning them at 5m intervals leads to thundering herd problems06:54
SpamapSlifeless: You can't ask for two at one time on a single stack..06:54
SpamapSlifeless: anyway, update is not going to turn into converge without a proposal. I think it is fine the way it is. You are more than welcome to present evidence to the contrary.06:54
lifelesswhat evidence would be sufficient?06:55
*** dims has quit IRC06:55
SpamapSDunno. I really think they are two wildly different things with valid use cases.06:55
lifelessok, so we can circle back to it06:57
lifelesswhat i really care about is that we're now going to have to write code06:57
lifelessto query glance06:57
lifelessto figure out the image id for the image we name06:57
lifelesscan we put that in the template at least?06:57
lifelessso that we'll get 'converge' on 'update' ?06:57
SpamapSI totally think that we should have a way for Heat to subscribe to notifications and/or poll at its own pace for status of background resources. But think that resolving reality with the stack is different than resolving the difference between two templates.06:57
lifelessSpamapS: I beg to differ, but now is not the time for that discussion.06:58
*** Tross has quit IRC06:58
lifelessSpamapS: I think you will come around to my opinion when you finish making robust rolling upgrades a reality ;)06:58
lifelessSpamapS: and are tired of writing bash loops that go while failed hit it again; fi06:58
SpamapSlifeless: we should add Glance resources to Heat that allow querying the ID associated with a name. That would work.06:59
*** rushiagr has joined #heat07:00
lifelessis that a heat bug, or a tripleo-heat-template bug?07:00
SpamapSboth07:00
SpamapSHeat should be able to orchestrate the glance API, and t-h-t should take advantage of that.07:00
lifelesshow easy is it?07:01
SpamapSlifeless: quite. I'm already through the boilerplate ;)07:01
lifelesscool, thanks07:01
sergmelikyanDesperately need some help :( Stack: http://paste.openstack.org/show/55269   Traceback: http://paste.openstack.org/show/5526807:02
sergmelikyanDevStack + local Heat07:03
sergmelikyanHeat.conf: http://paste.openstack.org/show/5527007:03
*** akuznetsov has quit IRC07:08
*** rushiagr2 has joined #heat07:11
*** rushiagr3 has joined #heat07:13
*** rushiagr has quit IRC07:13
*** SergeyLukjanov has quit IRC07:14
*** Tross has joined #heat07:16
openstackgerritJun Jie Nan proposed a change to openstack/heat: Avoid using python build-in class property  https://review.openstack.org/6281407:17
*** rushiagr2 has quit IRC07:17
skraynevmorning07:17
openstackgerritA change was merged to openstack/heat: Don't pass swift headers as None  https://review.openstack.org/6219907:19
sergmelikyanMay be something is misconfigured?07:25
*** urulama has joined #heat07:28
*** yogesh has quit IRC07:29
*** yogesh has joined #heat07:30
*** urulama has quit IRC07:32
*** gokrokve has joined #heat07:36
sergmelikyanFound my issue... https://answers.launchpad.net/heat/+question/23887907:37
*** ccs has quit IRC07:37
*** urulama has joined #heat07:37
sergmelikyanAdding auth_uri solved problem07:37
*** aignatov has joined #heat07:38
*** ccs has joined #heat07:38
*** gokrokve has quit IRC07:40
*** erkules_ is now known as erkules07:42
*** dims_ has joined #heat07:43
*** bgorski has joined #heat07:48
*** swygue has quit IRC07:50
openstackgerritA change was merged to openstack/heat: Add support for rebuild --preserve-ephemeral.  https://review.openstack.org/6252007:54
*** erkules has quit IRC07:58
*** yogesh has quit IRC07:59
*** yogesh has joined #heat08:02
asalkeldlifeless, I have totally lost that private key, is there any reason to encrypt it, given that we have removed the passwords?08:03
*** IlyaE has quit IRC08:04
*** rushiagr3 has quit IRC08:13
*** rushiagr3 has joined #heat08:18
*** Seal has joined #heat08:20
*** Seal has quit IRC08:22
*** SushilKM has joined #heat08:22
*** shardy_afk is now known as shardy08:24
shardymorning08:24
*** rushiagr3 has quit IRC08:26
*** rushiagr has joined #heat08:26
*** yogesh has quit IRC08:27
*** yogesh has joined #heat08:27
bgorskimorning08:30
*** vkozhukalov has joined #heat08:31
*** SergeyLukjanov has joined #heat08:32
*** yogesh has quit IRC08:36
*** yogesh has joined #heat08:36
*** gokrokve has joined #heat08:36
*** yogesh has quit IRC08:38
*** yogesh has joined #heat08:38
*** ifarkas has joined #heat08:39
*** gokrokve has quit IRC08:41
openstackgerritBartosz Górski proposed a change to openstack/heat: Add an external gateway property to neutron router  https://review.openstack.org/6011808:43
*** akuznetsov has joined #heat08:44
openstackgerritJun Jie Nan proposed a change to openstack/heat: Remove unused variable td  https://review.openstack.org/6282708:48
*** swygue has joined #heat08:51
openstackgerritJun Jie Nan proposed a change to openstack/heat: Removed unused variables  https://review.openstack.org/6282708:59
*** ccs has quit IRC09:10
*** urulama has quit IRC09:10
*** guohliu has quit IRC09:10
*** asalkeld has quit IRC09:10
*** rpothier_ has quit IRC09:10
*** jomara has quit IRC09:10
*** dmakogon_ has quit IRC09:10
*** stannie has quit IRC09:10
*** Andrzej has quit IRC09:11
*** openstackgerrit has quit IRC09:11
*** radix has quit IRC09:11
*** yogesh has quit IRC09:11
*** vkozhukalov has quit IRC09:11
*** bgorski has quit IRC09:11
*** sdake has quit IRC09:11
*** scollier has quit IRC09:11
*** pscheie__ has quit IRC09:11
*** zigo has quit IRC09:11
*** Adri2000 has quit IRC09:11
*** larsks|phone_ has quit IRC09:11
*** john-n-seattle has quit IRC09:11
*** nati_ueno has quit IRC09:11
*** xuan has quit IRC09:11
*** blamar has quit IRC09:11
*** dims_ has quit IRC09:11
*** Tross has quit IRC09:11
*** jpeeler has quit IRC09:11
*** pleia2 has quit IRC09:11
*** al-maisan has quit IRC09:11
*** SpamapS has quit IRC09:11
*** hub_cap has quit IRC09:11
*** lazzurs has quit IRC09:11
*** metabro_ has quit IRC09:11
*** chmouel has quit IRC09:11
*** Daviey has quit IRC09:11
*** stevebaker has quit IRC09:11
*** nosnos has quit IRC09:11
*** faramir1 has quit IRC09:11
*** scroiset has quit IRC09:11
*** pasquier-s has quit IRC09:11
*** shadower has quit IRC09:11
*** obondarev has quit IRC09:11
*** harlowja_away has quit IRC09:11
*** lifeless has quit IRC09:11
*** rushiagr has quit IRC09:11
*** nkhare has quit IRC09:11
*** shardy has quit IRC09:11
*** sirushti has quit IRC09:11
*** skraynev has quit IRC09:11
*** isviridov has quit IRC09:11
*** gondoi has quit IRC09:11
*** chandankumar has quit IRC09:11
*** dguerri has quit IRC09:11
*** TonyBurn1 has quit IRC09:11
*** jasond` has quit IRC09:11
*** grncdr has quit IRC09:11
*** john-n-s| has quit IRC09:11
*** swygue has quit IRC09:11
*** akuznetsov has quit IRC09:11
*** SergeyLukjanov has quit IRC09:11
*** aignatov has quit IRC09:11
*** amritanshu_RnD has quit IRC09:11
*** rongze has quit IRC09:11
*** liang has quit IRC09:11
*** larsks has quit IRC09:11
*** sgran has quit IRC09:11
*** leseb has quit IRC09:11
*** uvirtbot has quit IRC09:11
*** DandyPandy has quit IRC09:11
*** radez_g0n3 has quit IRC09:11
*** agileclipse has quit IRC09:11
*** mordred has quit IRC09:11
*** lekha has quit IRC09:11
*** PhilK has quit IRC09:11
*** kebray has quit IRC09:11
*** sileht has quit IRC09:11
*** wirehead_ has quit IRC09:11
*** DaveJ_ has quit IRC09:11
*** EmilienM has quit IRC09:11
*** russellb has quit IRC09:11
*** christophk has quit IRC09:11
*** clarkb has quit IRC09:11
*** Ng has quit IRC09:11
*** mikal has quit IRC09:11
*** ogelbukh has quit IRC09:11
*** jhurlbert has quit IRC09:11
*** samkottler has quit IRC09:11
*** nijaba has quit IRC09:11
*** ifarkas has quit IRC09:11
*** SushilKM has quit IRC09:11
*** radix_ has quit IRC09:11
*** slong has quit IRC09:11
*** zaneb has quit IRC09:11
*** bnemec has quit IRC09:11
*** ChanServ has quit IRC09:11
*** sergmelikyan has quit IRC09:11
*** andrewmi- has quit IRC09:11
*** therve has quit IRC09:11
*** erkules has joined #heat09:12
*** swygue has joined #heat09:12
*** akuznetsov has joined #heat09:12
*** ifarkas has joined #heat09:12
*** yogesh has joined #heat09:12
*** SergeyLukjanov has joined #heat09:12
*** vkozhukalov has joined #heat09:12
*** rushiagr has joined #heat09:12
*** SushilKM has joined #heat09:12
*** bgorski has joined #heat09:12
*** dims_ has joined #heat09:12
*** ccs has joined #heat09:12
*** aignatov has joined #heat09:12
*** urulama has joined #heat09:12
*** Tross has joined #heat09:12
*** amritanshu_RnD has joined #heat09:12
*** nkhare has joined #heat09:12
*** radix_ has joined #heat09:12
*** rongze has joined #heat09:12
*** slong has joined #heat09:12
*** nati_ueno has joined #heat09:12
*** guohliu has joined #heat09:12
*** xuan has joined #heat09:12
*** chandankumar has joined #heat09:12
*** dguerri has joined #heat09:12
*** liang has joined #heat09:12
*** jomara has joined #heat09:12
*** agileclipse has joined #heat09:12
*** sdake has joined #heat09:12
*** nosnos has joined #heat09:12
*** blamar has joined #heat09:12
*** andrewmi- has joined #heat09:12
*** faramir1 has joined #heat09:12
*** asalkeld has joined #heat09:12
*** scroiset has joined #heat09:12
*** rpothier_ has joined #heat09:12
*** dmakogon_ has joined #heat09:12
*** Andrzej has joined #heat09:12
*** stannie has joined #heat09:12
*** scollier has joined #heat09:12
*** zaneb has joined #heat09:12
*** sergmelikyan has joined #heat09:12
*** gondoi has joined #heat09:12
*** openstackgerrit has joined #heat09:12
*** bnemec has joined #heat09:12
*** shardy has joined #heat09:12
*** mordred has joined #heat09:12
*** lazzurs has joined #heat09:12
*** radix has joined #heat09:12
*** stevebaker has joined #heat09:12
*** hub_cap has joined #heat09:12
*** SpamapS has joined #heat09:12
*** al-maisan has joined #heat09:12
*** pleia2 has joined #heat09:12
*** jpeeler has joined #heat09:12
*** pscheie__ has joined #heat09:12
*** zigo has joined #heat09:12
*** Adri2000 has joined #heat09:12
*** larsks|phone_ has joined #heat09:12
*** john-n-seattle has joined #heat09:12
*** chmouel has joined #heat09:12
*** metabro_ has joined #heat09:12
*** Daviey has joined #heat09:12
*** pasquier-s has joined #heat09:12
*** TonyBurn1 has joined #heat09:12
*** sirushti has joined #heat09:12
*** skraynev has joined #heat09:12
*** ogelbukh has joined #heat09:12
*** shadower has joined #heat09:12
*** obondarev has joined #heat09:12
*** harlowja_away has joined #heat09:12
*** lifeless has joined #heat09:12
*** jhurlbert has joined #heat09:12
*** jasond` has joined #heat09:12
*** grncdr has joined #heat09:12
*** john-n-s| has joined #heat09:12
*** clarkb has joined #heat09:12
*** lekha has joined #heat09:12
*** PhilK has joined #heat09:12
*** kebray has joined #heat09:12
*** isviridov has joined #heat09:12
*** larsks has joined #heat09:12
*** sileht has joined #heat09:12
*** samkottler has joined #heat09:12
*** wirehead_ has joined #heat09:12
*** therve has joined #heat09:12
*** DaveJ_ has joined #heat09:12
*** sgran has joined #heat09:12
*** Ng has joined #heat09:12
*** leseb has joined #heat09:12
*** uvirtbot has joined #heat09:12
*** EmilienM has joined #heat09:12
*** russellb has joined #heat09:12
*** DandyPandy has joined #heat09:12
*** radez_g0n3 has joined #heat09:12
*** mikal has joined #heat09:12
*** christophk has joined #heat09:12
*** nijaba has joined #heat09:12
*** ChanServ has joined #heat09:12
*** hobana.freenode.net sets mode: +o ChanServ09:12
*** ccs has quit IRC09:16
*** urulama has quit IRC09:16
*** guohliu has quit IRC09:16
*** asalkeld has quit IRC09:16
*** rpothier_ has quit IRC09:16
*** jomara has quit IRC09:16
*** dmakogon_ has quit IRC09:16
*** stannie has quit IRC09:16
*** Andrzej has quit IRC09:16
*** openstackgerrit has quit IRC09:16
*** radix has quit IRC09:16
*** yogesh has quit IRC09:16
*** vkozhukalov has quit IRC09:16
*** bgorski has quit IRC09:16
*** sdake has quit IRC09:16
*** scollier has quit IRC09:16
*** pscheie__ has quit IRC09:16
*** zigo has quit IRC09:16
*** Adri2000 has quit IRC09:16
*** larsks|phone_ has quit IRC09:16
*** john-n-seattle has quit IRC09:16
*** nati_ueno has quit IRC09:16
*** xuan has quit IRC09:16
*** blamar has quit IRC09:16
*** dims_ has quit IRC09:16
*** Tross has quit IRC09:16
*** jpeeler has quit IRC09:16
*** pleia2 has quit IRC09:16
*** al-maisan has quit IRC09:16
*** SpamapS has quit IRC09:16
*** hub_cap has quit IRC09:16
*** lazzurs has quit IRC09:16
*** metabro_ has quit IRC09:16
*** chmouel has quit IRC09:16
*** Daviey has quit IRC09:16
*** stevebaker has quit IRC09:16
*** erkules has quit IRC09:16
*** nosnos has quit IRC09:16
*** faramir1 has quit IRC09:16
*** scroiset has quit IRC09:16
*** pasquier-s has quit IRC09:16
*** shadower has quit IRC09:16
*** obondarev has quit IRC09:16
*** harlowja_away has quit IRC09:16
*** lifeless has quit IRC09:16
*** rushiagr has quit IRC09:16
*** nkhare has quit IRC09:16
*** shardy has quit IRC09:16
*** sirushti has quit IRC09:16
*** skraynev has quit IRC09:16
*** isviridov has quit IRC09:16
*** gondoi has quit IRC09:16
*** chandankumar has quit IRC09:16
*** dguerri has quit IRC09:16
*** TonyBurn1 has quit IRC09:16
*** jasond` has quit IRC09:16
*** grncdr has quit IRC09:16
*** john-n-s| has quit IRC09:16
*** swygue has quit IRC09:16
*** akuznetsov has quit IRC09:16
*** SergeyLukjanov has quit IRC09:16
*** aignatov has quit IRC09:16
*** amritanshu_RnD has quit IRC09:16
*** rongze has quit IRC09:16
*** liang has quit IRC09:16
*** larsks has quit IRC09:16
*** sgran has quit IRC09:16
*** leseb has quit IRC09:16
*** uvirtbot has quit IRC09:16
*** DandyPandy has quit IRC09:16
*** radez_g0n3 has quit IRC09:16
*** agileclipse has quit IRC09:16
*** mordred has quit IRC09:16
*** lekha has quit IRC09:16
*** PhilK has quit IRC09:16
*** kebray has quit IRC09:16
*** sileht has quit IRC09:16
*** wirehead_ has quit IRC09:16
*** DaveJ_ has quit IRC09:16
*** EmilienM has quit IRC09:16
*** russellb has quit IRC09:16
*** christophk has quit IRC09:16
*** clarkb has quit IRC09:16
*** Ng has quit IRC09:16
*** mikal has quit IRC09:16
*** ogelbukh has quit IRC09:16
*** jhurlbert has quit IRC09:16
*** samkottler has quit IRC09:16
*** nijaba has quit IRC09:16
*** ifarkas has quit IRC09:16
*** SushilKM has quit IRC09:16
*** radix_ has quit IRC09:16
*** slong has quit IRC09:16
*** zaneb has quit IRC09:16
*** bnemec has quit IRC09:16
*** ChanServ has quit IRC09:17
*** sergmelikyan has quit IRC09:17
*** andrewmi- has quit IRC09:17
*** therve has quit IRC09:17
*** derekh has joined #heat09:22
*** erkules has joined #heat09:22
*** swygue has joined #heat09:22
*** akuznetsov has joined #heat09:22
*** ifarkas has joined #heat09:22
*** yogesh has joined #heat09:22
*** SergeyLukjanov has joined #heat09:22
*** vkozhukalov has joined #heat09:22
*** rushiagr has joined #heat09:22
*** SushilKM has joined #heat09:22
*** bgorski has joined #heat09:22
*** dims_ has joined #heat09:22
*** ccs has joined #heat09:22
*** aignatov has joined #heat09:22
*** urulama has joined #heat09:22
*** Tross has joined #heat09:22
*** amritanshu_RnD has joined #heat09:22
*** nkhare has joined #heat09:22
*** radix_ has joined #heat09:22
*** rongze has joined #heat09:22
*** slong has joined #heat09:22
*** nati_ueno has joined #heat09:22
*** guohliu has joined #heat09:22
*** xuan has joined #heat09:22
*** chandankumar has joined #heat09:22
*** dguerri has joined #heat09:22
*** liang has joined #heat09:22
*** jomara has joined #heat09:22
*** agileclipse has joined #heat09:22
*** sdake has joined #heat09:22
*** nosnos has joined #heat09:22
*** blamar has joined #heat09:22
*** andrewmi- has joined #heat09:22
*** faramir1 has joined #heat09:22
*** asalkeld has joined #heat09:22
*** scroiset has joined #heat09:22
*** rpothier_ has joined #heat09:22
*** dmakogon_ has joined #heat09:22
*** Andrzej has joined #heat09:22
*** stannie has joined #heat09:22
*** scollier has joined #heat09:22
*** zaneb has joined #heat09:22
*** sergmelikyan has joined #heat09:22
*** gondoi has joined #heat09:22
*** openstackgerrit has joined #heat09:22
*** bnemec has joined #heat09:22
*** shardy has joined #heat09:22
*** mordred has joined #heat09:22
*** lazzurs has joined #heat09:22
*** radix has joined #heat09:22
*** stevebaker has joined #heat09:22
*** hub_cap has joined #heat09:22
*** SpamapS has joined #heat09:22
*** al-maisan has joined #heat09:22
*** pleia2 has joined #heat09:22
*** jpeeler has joined #heat09:22
*** pscheie__ has joined #heat09:22
*** zigo has joined #heat09:22
*** Adri2000 has joined #heat09:22
*** larsks|phone_ has joined #heat09:22
*** john-n-seattle has joined #heat09:22
*** chmouel has joined #heat09:22
*** metabro_ has joined #heat09:22
*** Daviey has joined #heat09:22
*** pasquier-s has joined #heat09:22
*** TonyBurn1 has joined #heat09:22
*** sirushti has joined #heat09:22
*** skraynev has joined #heat09:22
*** ogelbukh has joined #heat09:22
*** shadower has joined #heat09:22
*** obondarev has joined #heat09:22
*** harlowja_away has joined #heat09:22
*** lifeless has joined #heat09:22
*** jhurlbert has joined #heat09:22
*** jasond` has joined #heat09:22
*** grncdr has joined #heat09:22
*** john-n-s| has joined #heat09:22
*** clarkb has joined #heat09:22
*** lekha has joined #heat09:22
*** PhilK has joined #heat09:22
*** kebray has joined #heat09:22
*** isviridov has joined #heat09:22
*** larsks has joined #heat09:22
*** sileht has joined #heat09:22
*** samkottler has joined #heat09:22
*** wirehead_ has joined #heat09:22
*** therve has joined #heat09:22
*** DaveJ_ has joined #heat09:22
*** sgran has joined #heat09:22
*** Ng has joined #heat09:22
*** leseb has joined #heat09:22
*** uvirtbot has joined #heat09:22
*** EmilienM has joined #heat09:22
*** russellb has joined #heat09:22
*** DandyPandy has joined #heat09:22
*** radez_g0n3 has joined #heat09:22
*** mikal has joined #heat09:22
*** christophk has joined #heat09:22
*** nijaba has joined #heat09:22
*** ChanServ has joined #heat09:22
*** hobana.freenode.net sets mode: +o ChanServ09:22
*** Alienyyg has joined #heat09:24
openstackgerritSushil Kumar proposed a change to openstack/python-heatclient: Updates .gitignore  https://review.openstack.org/6217409:31
*** lsmola_ has joined #heat09:32
*** tomek_adamczewsk has joined #heat09:33
*** nanjj has joined #heat09:36
*** akuznetsov has quit IRC09:42
*** nkhare is now known as nkhare_afk09:42
shardytherve: https://wiki.openstack.org/wiki/Heat/Blueprints/InstanceUsers09:43
shardytherve: I thought stevebaker and ayoung were going to add some more ideas, but it doesn't look like they have09:44
shardytherve: comments/feedback etc appreciated :)09:45
*** fandikurnia01 has joined #heat09:45
*** pfreund has joined #heat09:51
openstackgerritSimon Pasquier proposed a change to openstack/heat: Simplify update_with_template() method  https://review.openstack.org/6283209:56
therveshardy, Thanks, will do10:06
*** agileclipse has quit IRC10:12
*** rongze has quit IRC10:14
*** yogesh has quit IRC10:15
*** nanjj has quit IRC10:16
*** akuznetsov has joined #heat10:17
*** akuznetsov has quit IRC10:23
*** liang has quit IRC10:31
*** ccs has quit IRC10:34
*** nati_ueno has quit IRC10:34
sergmelikyanhttps://review.openstack.org/61074 - 5 +1 and 1 +2, can someone look at this one more time?10:34
*** gokrokve has joined #heat10:38
*** dmakogon_ is now known as denis_makogon10:40
*** gokrokve has quit IRC10:43
*** aignatov has quit IRC10:44
openstackgerritPavlo Shchelokovskyy proposed a change to openstack/heat: Fix comparison with singletons  https://review.openstack.org/6144710:44
openstackgerritSwann Croiset proposed a change to openstack/heat: Add autoscaling notifications  https://review.openstack.org/6208710:50
*** aignatov has joined #heat10:59
*** fandikurnia01 has quit IRC11:02
*** nati_ueno has joined #heat11:13
*** SergeyLukjanov is now known as _SergeyLukjanov11:13
*** _SergeyLukjanov has quit IRC11:14
*** swygue has quit IRC11:16
*** SnowDust has joined #heat11:17
SnowDusthello guys .. how to add multiple resources in  DependsOn ?11:18
SnowDustanyone ?11:18
SnowDustno help from heat forum :D all sleeping i guess11:20
*** akuznetsov has joined #heat11:22
shardySnowDust: You can pass a list11:22
shardyhttps://review.openstack.org/#/c/51507/11:22
SnowDustthanks .. shardy !11:22
*** rongze has joined #heat11:24
*** che-arne has joined #heat11:25
*** yogesh has joined #heat11:26
openstackgerritA change was merged to openstack/heat: Fix comparison with singletons  https://review.openstack.org/6144711:26
*** agileclipse has joined #heat11:30
*** yogesh has quit IRC11:30
*** faramir1 has quit IRC11:32
openstackgerritSerg Melikyan proposed a change to openstack/heat: Implements Nova FloatingIP resources  https://review.openstack.org/6283611:32
*** SnowDust has quit IRC11:34
* sergmelikyan accidentally published draft change as "ready for review". Tests are terrible :(11:35
* sergmelikyan will appreciate any help with tests11:36
*** guohliu has quit IRC11:36
shardysergmelikyan: Just mark it work in progress in the gerrit ui11:37
shardythen we can all see it and may have review feedback11:37
sergmelikyanshardy, thx, done11:37
shardydraft reviews you have to explicitly add reviewers for them to see it IIRC11:37
*** gokrokve has joined #heat11:39
openstackgerritPavlo Shchelokovskyy proposed a change to openstack/heat: Fix comparison with singletons  https://review.openstack.org/6285211:39
sergmelikyanI had marked all patchsets as published and changed status to Work in Progress, as you suggested11:40
*** gokrokve has quit IRC11:43
*** zbitter has joined #heat11:46
*** zaneb has quit IRC11:48
*** nkhare_afk is now known as nkhare11:50
*** nosnos has quit IRC11:53
*** plomakin has joined #heat11:53
openstackgerritSteven Hardy proposed a change to openstack/heat: SignalResponder, set resource_id in the correct place  https://review.openstack.org/6286212:16
openstackgerritSteven Hardy proposed a change to openstack/heat: Correct create_trust_context docstring  https://review.openstack.org/6243612:24
openstackgerritSteven Hardy proposed a change to openstack/heat: Add sanity check to ensure user_id can be trusted  https://review.openstack.org/6243712:24
*** pshchelo has joined #heat12:25
openstackgerritSerg Melikyan proposed a change to openstack/heat: Implements Nova FloatingIP resources  https://review.openstack.org/6283612:29
*** gokrokve has joined #heat12:39
*** giulivo has joined #heat12:41
*** gokrokve has quit IRC12:44
*** rushiagr2 has joined #heat12:45
*** rpothier_ has quit IRC12:47
*** rpothier_ has joined #heat12:47
*** scollier has quit IRC12:48
*** scollier has joined #heat12:49
*** rushiagr has quit IRC12:49
*** rushiagr2 has quit IRC12:51
*** rushiagr2 has joined #heat12:52
*** rushiagr2 is now known as rushiagr_away12:55
*** giulivo has quit IRC12:57
*** aignatov has quit IRC12:57
*** rushiagr_away is now known as rushiagr213:00
*** rushiagr2 is now known as rushiagr13:01
*** rushiagr2 has joined #heat13:02
*** tomek_adamczewsk has quit IRC13:02
*** fandikurnia01 has joined #heat13:04
*** rushiagr has quit IRC13:06
*** fandikurnia01 has quit IRC13:07
*** tomek_adamczewsk has joined #heat13:07
*** fandikurnia01 has joined #heat13:08
*** rongze has quit IRC13:19
*** agileclipse has quit IRC13:21
*** rongze has joined #heat13:21
openstackgerritPablo Andres Fuente proposed a change to openstack/heat: Deleting a stack with a deleted nested stack fails  https://review.openstack.org/6275213:25
*** rpothier_ has quit IRC13:26
*** agileclipse has joined #heat13:30
*** pafuent has joined #heat13:32
*** nkhare has quit IRC13:33
*** aweiteka has joined #heat13:34
*** agileclipse has quit IRC13:40
*** gokrokve has joined #heat13:40
*** agileclipse has joined #heat13:42
*** gokrokve has quit IRC13:45
*** rushiagr2 has quit IRC13:45
*** SergeyLukjanov has joined #heat13:51
*** che-arne has quit IRC13:53
*** che-arne has joined #heat13:53
*** AndrewMichalik has joined #heat13:56
*** blomquisg has joined #heat14:04
*** radez_g0n3 is now known as radez14:04
*** giulivo has joined #heat14:05
*** nati_ueno has quit IRC14:10
*** plomakin has quit IRC14:12
*** urulama has quit IRC14:14
*** rpothier_ has joined #heat14:15
sdakemorning14:18
pshchelohi, can someone take a look at heat/engine/resource.py, line 421? what is the purpose of this except branch? it seems to me it is never executed, or I am missing something?14:22
*** andersonvom has joined #heat14:23
thervepshchelo, You're missing BaseException14:24
shardypshchelo: It's related to some older eventlet code which incorrectly in herited GreenletExit from BaseException14:27
shardyAnd also, I think the scheduler code relies on GeneratorExit which is also derived from BaseException14:27
therveSystemExit too14:29
shardyYeah, I guess there are a few corner cases we need to catch there14:29
pshchelotherve: aha, thanks.14:29
pshcheloshardy: no, according to docs starting from py2.6 GeneratorExit is a subclass of BAseException, SystemExit the same from py2.514:30
*** pfreund has quit IRC14:31
shardypshchelo: I thought that was what I just said14:31
pshchelooops, misunderstood you14:31
pshchelothanks for the hint!14:34
*** rushiagr2 has joined #heat14:35
shardypshchelo: I actually had it wrong, Greenlet previously inherited from Exception, but it needed to inherit from BaseException, which is what we catch there14:35
shardybug #1096150 has more details14:36
uvirtbotLaunchpad bug 1096150 in heat "Deleting RDS stack while DBInstance create in progress fails" [High,Fix released] https://launchpad.net/bugs/109615014:36
*** rushiagr2 has quit IRC14:40
*** rushiagr2 has joined #heat14:41
*** gokrokve has joined #heat14:41
*** dims_ has quit IRC14:44
*** pfreund has joined #heat14:45
*** gokrokve has quit IRC14:46
*** dims_ has joined #heat14:48
*** SushilKM has quit IRC14:49
openstackgerritA change was merged to openstack/heat: Convert Instance to new Schema format  https://review.openstack.org/6178014:51
*** akuznetsov has quit IRC14:53
shardyjasond`: Around?14:55
jasond`shardy: hey14:56
shardyjasond`: Hi, I think we're still breaking the gate with bug #1261433, or something similar :(14:57
uvirtbotLaunchpad bug 1261433 in heat "heat-tempest-xx already has an action (DELETE) in progress" [High,Fix committed] https://launchpad.net/bugs/126143314:57
shardySee https://review.openstack.org/#/c/62436/14:57
jasond`ugh, okay14:58
jasond`not sure why it says there were ERRORs in the logs http://logs.openstack.org/36/62436/2/gate/gate-tempest-dsvm-postgres-full/c3efd61/logs/screen-h-eng.txt.gz14:59
*** vijendar has joined #heat15:00
shardyYeah, I only see "WARNING heat.engine.stack_lock [-] Lock was already released on stack None"15:00
*** jcru has joined #heat15:00
jasond`ah http://logs.openstack.org/36/62436/2/gate/gate-tempest-dsvm-postgres-full/c3efd61/logs/screen-h-api.txt.gz15:01
shardyouch15:01
shardySo we're not mapping the new exception correctly in the APIs15:02
*** sabeen has joined #heat15:03
jasond`i guess not.  will do some research and submit another patch15:04
jasond`thanks15:04
jasond`shardy: BTW, regarding your comment on https://review.openstack.org/#/c/62760/115:04
*** giulivo has quit IRC15:05
shardyjasond`: yup15:06
jasond`as i understand it, there's a get() default that's applicable when the key doesn't exist and there's the actual property default that's applicable when the property isn't provided by the user.  that patch just removes the get() default because the key always exists15:06
jasond`if the key doesn't exist, someone made a typo in the resource15:06
*** SergeyLukjanov has quit IRC15:06
shardyjasond`: Hmm, I see, yeah maybe you're right15:09
*** gokrokve has joined #heat15:09
jasond`shardy: yeah, it's confusing.  that's why i thought it was important enough to submit a patch15:10
*** rongze has quit IRC15:10
jasond`there should be no functional difference introduced by it15:10
shardyjasond`: It is confusing, I agree.  Hopefully zbitter can confirm the expected behavior of the new Schema getitem and add some feedback to the review15:11
*** topol has joined #heat15:13
jasond`okay, i will wait for his comments15:13
thervejasond`, Presumably, the code is incorrect then (before and after)15:13
*** IlyaE has joined #heat15:14
jasond`therve: yeah, but this change wasn't to fix those bugs15:14
therveOk, fair enough15:14
*** rcleere has joined #heat15:14
therveI really don't like the fact that Properties is a mapping, because of things like that15:15
*** IlyaE has quit IRC15:15
jasond`shardy: i'll put a better description in the commit message to make it clearer15:15
*** tomek_adamczewsk has quit IRC15:15
shardyjasond`: Odd, we're mapping ActionInProgress in FaultWrapper15:17
shardyjasond`: I guess the issue is tempest is trying to delete the stack twice?15:17
jasond`shardy: correct15:17
jasond`shardy: but it only does that when it feels like it :)15:18
shardyWe should fix the tests, to either not do that, or tolerate in progress as a response15:18
jasond`i agree15:20
*** tomek_adamczewsk has joined #heat15:21
*** giulivo has joined #heat15:21
jasond`shardy: i think it's happening here https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/stacks/test_stacks.py#L69-L7115:23
shardyjasond`: Why are we deleting twice tho?15:25
jasond`not sure15:25
shardyhttps://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L8615:26
shardybut that looks like it should tolerate the client exception15:27
jasond`if it's happening there, it's already trying to tolerate the exception.  it's the ERROR message that's causing it to fail15:27
*** amritanshu_RnD has quit IRC15:27
jasond`i need to try to match up timestamps again to see where exactly it's happening15:28
shardyWith debugging enabled the common/wsgi.py creates that error for known HeatExceptions15:31
shardyWhich is probably wrong, if faultwrap can map them15:31
*** sdake_ has joined #heat15:33
jasond`shardy: are you saying ActionInProgress shouldn't be mapped in FaultWrapper?15:33
shardyjasond`: I'm saying it should, and it looks like it is, but we shouldn't log a stacktrace in the API when it happens15:34
jasond`oh ok15:34
jasond`shardy: it's happening for RequestLimitExceeded too (further up)15:36
shardyThis faultwrap stuff has caused so many problems, I don't understand why it has to be so complex15:37
*** SergeyLukjanov has joined #heat15:37
shardyhttps://review.openstack.org/#/c/49155/15:37
shardyThat's where the logging was added, so maybe zbitter has some ideas on how to handle this15:38
*** brint has joined #heat15:38
zbitteruh oh15:38
*** zbitter is now known as zaneb15:38
shardybasically we want errors which happen in the engine to log the stacktrace there, and errors which happen in the API to log their stacktrace in the API log15:38
shardyand faultwrapper should map the responses without exposing the user to the stacktrace15:38
shardyzaneb: Hey, sorry, the dreaded faultwrapper has bitten us again :(15:39
shardyhttp://logs.openstack.org/36/62436/2/gate/gate-tempest-dsvm-postgres-full/c3efd61/logs/screen-h-api.txt.gz15:39
shardytempest sees the ERROR and fails the test, but we're just logging a known exception which is mapped to an appropriate response AFAICS15:40
*** vkozhukalov has quit IRC15:40
*** rongze has joined #heat15:40
*** sabeen has quit IRC15:42
*** sabeen has joined #heat15:42
*** tims has joined #heat15:42
openstackgerritSteven Hardy proposed a change to openstack/heat: Correct assertEqual rsrc.state argument ordering  https://review.openstack.org/6291815:43
openstackgerritSteven Hardy proposed a change to openstack/heat: autoscaling test correct self.assertEqual ordering  https://review.openstack.org/6291915:43
openstackgerritSteven Hardy proposed a change to openstack/heat: SignalResponder, set resource_id in the correct place  https://review.openstack.org/6286215:43
pafuentjasond`: shardy: Maybe this could help. This review solve some of the errors in h-api https://review.openstack.org/#/c/62080/15:44
*** sabeen1 has joined #heat15:45
*** sabeen has quit IRC15:45
shardypafuent: Interesting, thanks15:48
shardypafuent: tbh, I'm not sure adding a new exception base class is the answer15:48
shardye.g what makes StackNotFound an HeatClientException but not StackExists?15:49
jasond`pafuent: would the user see HTTPExceptionDisguise if debug mode is on?15:50
andersonvomhey folks, quick question regarding instance statuses: is it the case that if an instance is not ACTIVE, nor in one of the _deferred_states, then we should necessarily consider that an "error" state and blow up?15:50
*** arbylee has joined #heat15:51
shardyandersonvom: Yes, that is the way we use server.status in the instance resource15:51
pafuentjasond`: The HTTPExceptionDisguise is needed in order to the exception reach the FaultWrapper15:52
pafuentshardy: I only change the exceptions that were related to bug, because I'm new here and I'm not sure which exceptions are candidates for the class that I added.15:53
shardypafuent: That is exactly the problem IMO, expecting everyone to know which class to inherit from will just get us in even more of a mess IMO15:54
shardypafuent: Thanks for the patch tho, it's a good start to the discussion :)15:54
pafuentshardy: :)15:55
*** arbylee1 has joined #heat15:55
*** rongze has quit IRC15:55
*** arbylee has quit IRC15:56
andersonvomshardy: so, yeah, if you look at Instance#_check_active, that's the current implementation, but I'm wondering if this is the case only because we're trying to attach the volume there as well. Meaning, the exception raising would be a part of volume attaching? Or is it really that any other state is necessarily an error?15:56
zanebpafuent: "I'm not sure which exceptions are candidates for the class that I added" <- all of them, that's why an extra superclass is not the way to go15:56
*** IlyaE has joined #heat15:58
openstackgerritVijendar Komalla proposed a change to openstack/heat: Add _() to rackspace resource strings  https://review.openstack.org/6292215:59
pafuentzaneb: NoServiceEndpoint should not log an error?15:59
*** nkhare has joined #heat15:59
zanebshardy: so the answer is probably that we shouldn't log the stack trace for a HeatException... maybe just an info log or something for those ones?15:59
shardyandersonvom: well if Nova gives us a state we don't understand, how can we parse it and make any decision about it's error-ness?15:59
shardyzaneb: I guess, if any HeatException comes from the engine, we just don't log it, as it should already be logged in the engine?16:00
*** rushiagr2 is now known as rushiagr16:00
shardyOr do we also derive exceptions from there in the API code..16:00
shardyI'm fine with just s/ERROR/WARNING if it's easiest16:01
shardyit's a debug message afterall16:01
*** brint_ has joined #heat16:02
*** john-n-seattle1 has joined #heat16:02
*** tims has quit IRC16:03
*** andrew_plunk has joined #heat16:03
*** brint has quit IRC16:04
*** john-n-seattle1 has quit IRC16:05
pafuentshardy: So is better to log all HeatExceptions as warning instead of classifying them?16:08
jasond`shardy: it seems like test_stack_list_responds and test_stack_crud_no_resources are both trying to delete the same stack at the same time http://paste.openstack.org/show/55328/16:09
zanebso... when I wrote that logging code... I'm pretty sure I tested that it only logged exceptions generated in the API, and not ones from the engine16:09
zanebI remember it vividly, because it's not like me to actually test something ;)16:10
*** blamar has quit IRC16:10
*** SushilKM__ has joined #heat16:10
zanebso it seems like maybe the wrapping that jasond` added on that particular exception is causing it to get logged there, when exceptions from the engine normally wouldn't?16:10
jasond`zaneb: this was from before i added the client_exceptions decorator http://logs.openstack.org/17/61717/4/check/check-tempest-dsvm-postgres-full/3b776c3/logs/screen-h-api.txt.gz16:12
jasond`(the engine exception/traceback still got logged in the api log)16:12
zanebugh, it's actually being logged *twice* as well16:13
shardyjasond`: So the tests should create stacks with unique names then..16:13
jasond`shardy: yes, that would fix it16:14
openstackgerritVijendar Komalla proposed a change to openstack/python-heatclient: python-heatclient stack-abandon support  https://review.openstack.org/6292516:14
shardyjasond`: Are you happy to raise a tempest bug and send them a patch?16:14
zanebshardy, jasond`: surely it goes without saying they should do that anyway???16:14
*** tomek_adamczewsk has quit IRC16:15
shardyzaneb: Absolutely, I'm suprised we don't16:15
shardyheat-tempest-1268516181 already has an action (DELETE) in progress.16:15
shardyThat looks like a unique suffix, so possibly the crud test is trying to delete the stack created in the setUpClass or something?16:16
jasond`shardy: sure16:16
jasond`shardy: i don't understand how test_stack_list_responds is deleting a stack16:18
*** zaneb has quit IRC16:19
jasond`shardy: ah, this is probably run after each test https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L11716:21
*** jasond` is now known as jasond16:21
shardyI thought tearDownClass would only happen once per test-class, not for every test case like tearDown()16:22
*** brint_ has quit IRC16:23
shardyhttps://github.com/openstack/tempest/blob/master/tempest/api/orchestration/base.py#L8216:23
jasondshardy: maybe it's running after test_stack_list_responds and trying to delete the same stack that test_stack_crud_no_resources is deleting explicitly16:24
*** zaneb has joined #heat16:24
shardyI think the issue is there, where test_stack_crud_no_resources uses the create_stack classmethod to create the stack16:24
shardyso it gets appended to the list of stacks to cleanup on test teardown, only it's already been deleted16:25
andersonvomshardy: sorry, network problems here. Thanks!16:25
jasondshardy: yeah, so we could either remove that append or remove the delete https://github.com/openstack/tempest/blob/master/tempest/api/orchestration/stacks/test_stacks.py#L69-L7116:25
*** brint has joined #heat16:26
shardyOr get the crud test to pop the stack off the list when it's deleted it16:26
shardyso then it's still deleted if that test fails before delete happens16:26
zanebshardy: ++16:27
jasondshardy: sounds good.  i'll submit a bugfix for that16:27
* shardy realizes usage of pop, stack, and list are confusing above.. ;)16:27
*** SushilKM__ has quit IRC16:27
shardyjasond: thanks!16:27
openstackgerritRichard Lee proposed a change to openstack/heat: Add way to group exceptions in DependencyTaskGroup  https://review.openstack.org/6247916:30
openstackgerritRichard Lee proposed a change to openstack/heat: Refactor Instance#_check_active  https://review.openstack.org/6247816:30
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Check resources are in expected states  https://review.openstack.org/5864116:31
*** SushilKM__ has joined #heat16:35
openstackgerritSteven Hardy proposed a change to openstack/heat: SignalResponder, set resource_id in the correct place  https://review.openstack.org/6286216:37
*** sdake has quit IRC16:41
*** sdake has joined #heat16:41
openstackgerritClint "SpamapS" Byrum proposed a change to openstack/heat: Retry failed actions on update  https://review.openstack.org/6293616:48
*** AndrewMichalik has quit IRC16:49
openstackgerritAnderson Mesquita proposed a change to openstack/heat: Check resources are in expected states  https://review.openstack.org/5864116:51
*** topol has quit IRC16:51
*** IlyaE has quit IRC16:52
*** rongze has joined #heat16:55
*** brint has quit IRC16:56
*** nkhare has quit IRC16:57
*** brint has joined #heat16:58
*** pfreund has quit IRC16:59
*** ifarkas has quit IRC16:59
*** rushiagr has quit IRC17:02
*** AndrewMichalik has joined #heat17:03
*** Andrzej has quit IRC17:04
*** pshchelo has quit IRC17:06
*** rwsu has joined #heat17:08
*** rushiagr has joined #heat17:16
*** pvaneck has joined #heat17:18
*** blamar has joined #heat17:18
*** SushilKM__ has quit IRC17:20
*** hub_cap has left #heat17:20
*** SushilKM has joined #heat17:20
*** topol has joined #heat17:34
*** vkozhukalov has joined #heat17:34
openstackgerritJason Dunsmore proposed a change to openstack/heat: Don't provide default values to properties.get()  https://review.openstack.org/6276017:37
*** yogesh has joined #heat17:42
*** chandankumar has quit IRC17:45
*** pafuent has quit IRC17:56
*** brint has quit IRC17:56
*** giulivo has quit IRC17:56
*** scollier has quit IRC17:56
*** derekh has quit IRC17:56
*** asalkeld has quit IRC17:56
*** jomara has quit IRC17:56
*** denis_makogon has quit IRC17:56
*** stannie has quit IRC17:56
*** openstackgerrit has quit IRC17:56
*** radix has quit IRC17:56
*** yogesh has quit IRC17:56
*** zaneb has quit IRC17:56
*** sdake_ has quit IRC17:56
*** bgorski has quit IRC17:56
*** pscheie__ has quit IRC17:56
*** zigo has quit IRC17:56
*** Adri2000 has quit IRC17:56
*** larsks|phone_ has quit IRC17:56
*** john-n-seattle has quit IRC17:56
*** vkozhukalov has quit IRC17:56
*** blomquisg has quit IRC17:56
*** lsmola_ has quit IRC17:56
*** xuan has quit IRC17:56
*** Tross has quit IRC17:56
*** jpeeler has quit IRC17:56
*** pleia2 has quit IRC17:56
*** al-maisan has quit IRC17:56
*** SpamapS has quit IRC17:56
*** lazzurs has quit IRC17:56
*** SergeyLukjanov has quit IRC17:56
*** andersonvom has quit IRC17:56
*** metabro_ has quit IRC17:56
*** chmouel has quit IRC17:56
*** Daviey has quit IRC17:56
*** stevebaker has quit IRC17:56
*** Alienyyg has quit IRC17:56
*** erkules has quit IRC17:56
*** scroiset has quit IRC17:57
*** pasquier-s has quit IRC17:57
*** shadower has quit IRC17:57
*** obondarev has quit IRC17:57
*** harlowja_away has quit IRC17:57
*** lifeless has quit IRC17:57
*** gokrokve has quit IRC17:57
*** fandikurnia01 has quit IRC17:57
*** shardy has quit IRC17:57
*** sirushti has quit IRC17:57
*** skraynev has quit IRC17:57
*** isviridov has quit IRC17:57
*** rongze has quit IRC17:57
*** arbylee1 has quit IRC17:57
*** vijendar has quit IRC17:57
*** dims_ has quit IRC17:57
*** rpothier_ has quit IRC17:57
*** che-arne has quit IRC17:57
*** agileclipse has quit IRC17:57
*** gondoi has quit IRC17:57
*** dguerri has quit IRC17:57
*** TonyBurn1 has quit IRC17:57
*** jasond has quit IRC17:57
*** grncdr has quit IRC17:57
*** john-n-s| has quit IRC17:57
*** rwsu has quit IRC17:57
*** sdake has quit IRC17:57
*** rcleere has quit IRC17:57
*** jcru has quit IRC17:57
*** aweiteka has quit IRC17:57
*** larsks has quit IRC17:57
*** sgran has quit IRC17:57
*** leseb has quit IRC17:57
*** uvirtbot has quit IRC17:57
*** DandyPandy has quit IRC17:57
*** radez has quit IRC17:57
*** rushiagr has quit IRC17:57
*** AndrewMichalik has quit IRC17:57
*** sabeen1 has quit IRC17:57
*** mordred has quit IRC17:57
*** lekha has quit IRC17:57
*** PhilK has quit IRC17:57
*** kebray has quit IRC17:57
*** sileht has quit IRC17:57
*** wirehead_ has quit IRC17:57
*** DaveJ_ has quit IRC17:57
*** EmilienM has quit IRC17:57
*** russellb has quit IRC17:57
*** christophk has quit IRC17:57
*** clarkb has quit IRC17:57
*** Ng has quit IRC17:57
*** mikal has quit IRC17:57
*** ogelbukh has quit IRC17:57
*** jhurlbert has quit IRC17:57
*** samkottler has quit IRC17:57
*** nijaba has quit IRC17:57
*** SushilKM has quit IRC17:57
*** andrew_plunk has quit IRC17:57
*** radix_ has quit IRC17:57
*** slong has quit IRC17:57
*** bnemec has quit IRC17:57
*** ChanServ has quit IRC17:57
*** topol has quit IRC17:57
*** blamar has quit IRC17:57
*** pvaneck has quit IRC17:57
*** sergmelikyan has quit IRC17:57
*** andrewmi- has quit IRC17:57
*** therve has quit IRC17:57
*** openstack has joined #heat18:02
*** openstack has joined #heat18:06
zaneband is quite often _never read again_18:06
shardySpamapS: personally I spend way more time grepping code than commit messages18:07
*** swygue has joined #heat18:07
zanebyeah, I would much sooner -1 for user-facing stuff like docs. those should actually be fixed18:08
SpamapSshardy: your implication that one who does carefully check the commit message does not carefully check the code is flippant and a lesser man than I might take that personally.18:08
SpamapSzaneb: when the commit message is read.. it is often in a critical regression-hunting situation. The other time is when new contributors are trying to answer the question of why something is the way it is.18:09
zanebSpamapS: I don't think you were the target of that comment, but I do think you're setting an example for the people who are the target of that comment, and I'm not talking about your thorough code reviews (which would be an excellent example to follow)18:09
*** harlowja_away is now known as harlowja18:09
zaneb(shardy's comment, that is)18:10
shardySpamapS: Well it was not meant to be personal, I was trying to say that we should foster a culture of critcical technical review over cosmetic proof-reading18:10
shardyI've already been shot-down on the ML for suggsting that we have a lot of the latter, so probably I should just shut up and get back to coding18:10
*** mestery has joined #heat18:13
*** funzo has joined #heat18:13
*** sgordon` has joined #heat18:13
zaneblook, nobody here is more pedantic than I am18:13
*** SushilKM has quit IRC18:13
SpamapSshardy: aye, me too. Again, I do value your and Zane's positions very much, even if I do not share the position.18:14
zanebbut having lived in a country where I speak the language like a retarded 3-year-old...18:14
zanebI appreciate not having everybody on my case about it, and I am more than happy to extend the same courtesy to others - especially non-native speakers - when their meaning is clear18:14
SpamapSzaneb: I think we should be extremely sensitive to that definitely. That was discussed on openstack-dev a while back and it was agreed that it is appropriate but do be clear and correct thigns explicitly, don't just say "this is wrong".18:17
openstackgerritLars Kellogg-Stedman proposed a change to openstack/python-heatclient: add output-list and output-show  https://review.openstack.org/6059118:17
openstackgerritA change was merged to openstack/heat: Add an external gateway property to neutron router  https://review.openstack.org/6011818:19
* SpamapS starts testing update/retry18:19
*** nati_ueno has joined #heat18:22
*** arbylee1 has quit IRC18:22
*** rushiagr has quit IRC18:25
*** spzala has joined #heat18:28
*** Tross has left #heat18:36
lifelessAs a retarded three year old in training, I want correction :)18:43
*** blamar has quit IRC18:43
zaneblifeless: right :) I'm not saying don't correct, I'm saying there's a time to stall the work pipeline over it and a time when that's not warranted18:45
*** ccs has joined #heat18:46
lifelessone of the things I think causes this to be a source of agnst is long (day+ review turnarounds)18:46
shardylifeless: In comparison to other projects *cough*keystone*cough* our review turnaround is postively super-sonic ;)18:47
shardywow my typing is really bad today, must be all this talk of trivial typos ;)18:48
zaneblifeless: I think that's true18:49
shardylifeless: I agree we can and should do better tho18:49
*** pafuent has left #heat18:49
*** pafuent has joined #heat18:49
lifelessshardy: I meant no critique :)18:50
sdakeour reviews are the fastest of many openstack projects, however, where we fail is when some reviews take some time, they fall to the end of the gerrit list, and review fatigue sets in - with no clearing of the backlog18:50
sdakeone solution to that is to start at the *last* review once in awhile :)18:50
zanebI have 167 unread emails in my Gerrit mailbox right now18:50
lifelessIhttp://russellbryant.net/openstack-stats/heat-openreviews.html18:50
lifeless3rd quartile wait time: 2 days, 8 hours, 25 minutes18:50
*** SushilKM has joined #heat18:50
zanebevery time someone posts another patchset, that's 3 more18:51
*** Tross has joined #heat18:51
*** Tross has quit IRC18:51
zanebmultiply that by the number of people on the review...18:51
lifeless-> 25% of the current open reviews have been waiting > 2d8h without getting a negative feedback18:51
*** Tross has joined #heat18:51
zanebnew patchsets are expensive; they are a proxy for reviewer attention. that's one reason I try to conserve them18:51
shardylifeless: which is way better than almost any other openstack project, except tripleo18:52
*** bgorski has quit IRC18:52
zaneblifeless: we used to be *much* better but things have just exploded since the last summit18:52
shardyyou guys are reviewing machines!18:52
shardyhttp://russellbryant.net/openstack-stats/tripleo-openreviews.html18:52
zanebin terms of numbers of contributions18:53
lifelesszaneb: a good problem to have18:53
zaneblifeless: indeed :) and I think we are close to having trained up some more core reviewers18:53
lifelessshardy: well, we got together as a team, and I've been thrilled with the results18:53
shardylifeless: Hopefully we will be able to expand -core to cope with the number of patches, but it takes time as you know18:53
lifelessthe latency on increasing -core bandwidth is a necessary evil I think18:54
shardyyeah18:54
jasondshardy: can you look at this? https://review.openstack.org/#/c/62938/18:54
shardyjasond: my preference would be to break out the class create_stack, so it cab be used without updating the stacks list18:57
zanebshardy: https://review.openstack.org/#/c/60607/ <- WTF?18:57
shardythen register additional cleanup for that test to remove it18:57
shardyjasond: it will be a bit more work, but better in the long run, IMO18:57
stevebakermorning18:58
shardyzaneb: lol, that looks really wrong18:58
shardyhey stevebaker18:58
zanebstevebaker: what's the though behind having a tenant_id property for a router?18:59
zanebthought18:59
shardyCan users create routers in tenants other than that they have a token scoped to?19:00
zanebdoubt it19:00
shardyI suspect not, unless neutron is more broken than I thought19:00
stevebakerI think it is an admin-only property19:00
zanebI suspect that what we're looking at here is a whole other use case that we're in the process of implementing in a very ad-hoc way19:00
zanebmaybe we need to step back here19:00
zanebit seems to me that the use case is something other than a cloud, it's basically a Neutron-only deployment and the people managing it are all operator-administrators19:01
zanebstevebaker: how am I doing?19:01
*** pablosan has joined #heat19:03
zaneb(NetDHCPAgent and RouterL3Agent also fall in this category)19:04
jasondshardy: hm, not sure i follow.19:04
jasondstevebaker: FYI https://review.openstack.org/#/c/62938/19:04
shardyjasond: Just about to stop for some food before the meeting, I'll add some comments later19:05
stevebakerzaneb: I'm not sure, they probably need to elaborate on their use cases19:05
jasondshardy: okay, thanks19:05
shardyjasond: If what you have is acceptable to the tempest folks, we can go with it and I'll post a followup with the refactoring19:06
jasondshardy: sounds good19:06
stevebakerzaneb: for example, tripleo could use heat to set up neutron (but currently don't plan to) https://github.com/openstack/tripleo-incubator/blob/master/scripts/setup-neutron19:08
*** jergerber has joined #heat19:08
SpamapSzaneb: TripleO can use this.19:09
zanebok, that makes sense. my question is should we be coming up with a way to expose this only to administrators19:09
SpamapSzaneb: it would replace this https://git.openstack.org/cgit/openstack/tripleo-incubator/tree/scripts/setup-neutron19:09
stevebakerzaneb: I think if we just document admin properties as such. Any attempt to use by non-admin will raise a neutron error19:10
zanebnew rule: no new properties without descriptions19:11
*** swygue has quit IRC19:12
SpamapSzaneb: +119:12
stevebakeror schema conversions19:13
*** swygue has joined #heat19:14
openstackgerritPablo Andres Fuente proposed a change to openstack/heat: wsgi.Resource exception handling to not log errors  https://review.openstack.org/6208019:15
zanebstevebaker: all schema conversions should be in the review queue already19:19
*** arbylee has joined #heat19:20
stevebakerzaneb: maybe we should use judicious use of -2 on some other changes to give the schema changes a chance of landing19:21
zanebstevebaker: it's probably quicker to go review all the ones that already have one +2 ;)19:22
*** pscheie__ has quit IRC19:23
stevebakeryup19:23
*** pscheie has joined #heat19:24
jasondstevebaker: i entered this a couple of days ago https://blueprints.launchpad.net/heat/+spec/stop-delete-stack  should i close it in favor of https://bugs.launchpad.net/heat/+bug/1262012 ?19:27
uvirtbotLaunchpad bug 1262012 in heat "Cannot delete an IN_PROGRESS stack" [High,Triaged]19:27
stevebakerjasond: its a regression, so lets use the bug19:28
jasondok19:28
jasondum, how do I delete the BP?19:30
*** IlyaE has joined #heat19:32
*** gokrokve has quit IRC19:34
*** gokrokve has joined #heat19:35
*** yogesh has quit IRC19:35
*** yogesh has joined #heat19:38
*** gokrokve has quit IRC19:39
stevebakerjasond: mark it as superceded or obsolete, and remove the milestone19:40
jasondstevebaker: done, thanks19:40
*** bgorski has joined #heat19:48
*** pshchelo has joined #heat19:55
stevebakermeeting time all20:00
*** yogesh_ has joined #heat20:01
*** yogesh_ has quit IRC20:03
*** yogesh_ has joined #heat20:03
*** yogesh has quit IRC20:05
openstackgerritChmouel Boudjnah proposed a change to openstack/python-heatclient: Show better error when json fail to parse template  https://review.openstack.org/6231120:07
*** akuznetsov has joined #heat20:08
openstackgerritChmouel Boudjnah proposed a change to openstack/python-heatclient: Show better error when json fail to parse template  https://review.openstack.org/6231120:10
*** AndrewMi_ has quit IRC20:13
*** derekh has joined #heat20:13
*** sgordon has joined #heat20:16
*** sgordon has quit IRC20:16
*** sgordon has joined #heat20:16
*** akuznetsov has quit IRC20:19
openstackgerritClint "SpamapS" Byrum proposed a change to openstack/heat: Retry failed actions on update  https://review.openstack.org/6293620:22
SushilKMwhile writing the heat template, can we accomodate any conditions, that some part of template runs for some condition only like for example volume provisioning20:22
*** vkozhukalov has quit IRC20:28
openstackgerritA change was merged to openstack/heat: Fix misused assertTrue in unit tests  https://review.openstack.org/6181620:30
*** yogesh_ has quit IRC20:34
*** yogesh has joined #heat20:35
*** sdake_ is now known as sdake220:38
*** gokrokve has joined #heat20:38
*** yogesh has quit IRC20:39
*** yogesh has joined #heat20:40
*** arbylee has quit IRC20:43
*** derekh has quit IRC20:45
*** SnowDust has joined #heat20:50
*** pafuent has quit IRC20:52
openstackgerritPablo Andres Fuente proposed a change to openstack/heat: Added tenant_id property to OS::Neutron::Router  https://review.openstack.org/6060720:54
*** pafuent has joined #heat20:55
shardySushilKM: No, you have to conditionally generate the template, e.g in a wrapper script21:01
shardySushilKM: Heat doesn't support conditionals or loops etc in the template DSL21:01
SpamapSSushilKM: what condition do you want exactly?21:04
*** yogesh has quit IRC21:08
openstackgerritSteven Hardy proposed a change to openstack/heat: Fix SignalResponder signature response when deleted  https://review.openstack.org/6298721:09
openstackgerritSteven Hardy proposed a change to openstack/heat: Add test coverage for SignalResponder delete  https://review.openstack.org/6298821:09
openstackgerritSteven Hardy proposed a change to openstack/heat: SignalResponder store access/secret in resource data  https://review.openstack.org/6244021:09
openstackgerritSteven Hardy proposed a change to openstack/heat: heat_keystoneclient revise get_ec2_keypair  https://review.openstack.org/6244121:10
*** yogesh has joined #heat21:10
*** SergeyLukjanov has quit IRC21:12
*** Tross has quit IRC21:19
*** arbylee has joined #heat21:20
grncdrso sorry for the amount of spam I generated with this changeset, I think it's ready for more review now: https://review.openstack.org/#/c/62078/21:29
grncdrthere's a −1 from Liang but I don't know if I agree with it ;)21:29
*** bgorski has quit IRC21:30
*** pshchelo is now known as pshchelo_21:31
*** pshchelo_ is now known as pas-ha21:32
zanebgrncdr: yeah, he's right, we don't want to be creating threads21:33
*** swygue has quit IRC21:33
grncdroh?21:34
grncdrsorry I'm not sure if you mean OS-level threads or eventlet coro's21:34
grncdrif greenpool is creating an OS-level thread that definitely wasn't my intention21:34
*** denis_makogon has quit IRC21:34
grncdrif creating eventlet threads/coro's is undesirable, then I guess I need to find a way to lower timeouts for the serialized connect calls?21:35
*** dmakogon_ has joined #heat21:35
zanebsorry, I tend to use the term thread and greenlet interchangeably21:35
sdakezaneb heresy ;)21:36
zanebgrncdr: so, first thing to note is that we already have a defined workflow for polling a bunch of things: https://github.com/openstack/heat/blob/master/heat/engine/scheduler.py#L33021:36
zanebsdake: eventlet's claims of thread safety are so worthless that they might as well be threads21:37
sdakelol21:37
zanebgrncdr: that doesn't solve the problem of really long timeouts... best fix there is probably to go with a shorter timeout21:38
*** spzala has quit IRC21:39
*** swygue has joined #heat21:41
*** Tross has joined #heat21:42
*** pas-ha has quit IRC21:44
*** pafuent has left #heat21:44
*** pshchelo has joined #heat21:45
SpamapSSo I don't really understand the hesitance to use greenlets for that.21:46
SpamapSheat.engine.scheduler will basically do the same though, right?21:47
asalkeldSpamapS, scheduler uses co-routines not greenlet21:50
*** pshchelo has quit IRC21:52
openstackgerritA change was merged to openstack/heat: rackspace: Convert Scaling resources to new Schema format  https://review.openstack.org/6182721:53
SpamapSasalkeld: right so they would not do parallel I/O even21:53
asalkeldwell making greenlet thread in a resource is a problem as it blocks from the scheduler's point of view21:54
*** pshchelo has joined #heat21:54
asalkeldso no more resouce concurrency21:54
SpamapSahh battling concurrency models21:54
asalkeldyip21:55
zanebSpamapS: this would be the first place where we ever use greenlets in a resource21:55
zanebwe wrote that scheduler crap specifically so we would not ever have to do this21:55
SpamapSzaneb: roger that21:55
openstackgerritA change was merged to openstack/heat: Correct create_trust_context docstring  https://review.openstack.org/6243621:55
SpamapSso then the right thing to do is to setup a non blocking connect and use that instead of eventlet.connect ?21:55
openstackgerritA change was merged to openstack/heat: Add sanity check to ensure user_id can be trusted  https://review.openstack.org/6243721:56
zanebI don't think there is such thing as a non-blocking connect, is there?21:56
zanebwe would have to set a small-ish timeout21:56
zaneband make sure we only do one per yield21:56
SpamapSzaneb: yes all python I/O can be non-blocking21:57
*** radez is now known as radez_g0n321:57
zanebluckily the PollingTaskGroup can handle the latter easily21:57
SpamapSshorter timeout will waste more of the engine's time21:57
SpamapSI'm still in the "I know this is weird and new but I think it makes sense" camp. :-P22:00
*** pshchelo has quit IRC22:00
SpamapSLots of things "block" during their create / check methods.22:01
*** jomara has quit IRC22:02
SpamapSgrncdr: one thing though... is it really all that necessary to optimize this?22:02
SpamapSgrncdr: like can't you just block on any one of them for as long as it takes?22:03
*** jomara has joined #heat22:03
SpamapSif they were a logical OR ... parallel would make more sense.. but they are an AND22:03
openstackgerritChmouel Boudjnah proposed a change to openstack/python-heatclient: Show better error when json fail to parse template  https://review.openstack.org/6231122:04
*** sgordon has quit IRC22:05
zanebSpamapS: yep, and PollingTaskGroup does exactly that22:06
*** topol has quit IRC22:08
SpamapSzaneb: yeah, that seems much more sane. I don't even think the timeout needs lowering.22:10
*** IlyaE has quit IRC22:14
zanebSpamapS, grncdr: I added a comment to that effect22:15
grncdrsorry I had/have some ongoing interrupts at the moment :( will read the comments and fix/reply on gerrit22:17
sdakematahari flashbacks on openstack-dev ml22:17
zaneborly?22:17
sdakesome cat debating c++ vs python22:17
sdakebecause of footprint22:17
sdakeimo should have wrote his agent in c ;-)22:18
*** aweiteka has quit IRC22:18
sdakeif it hurts, dont do it22:18
sdakeso far I've seen 5,  count em 5, unified management agent programs derailed in my career22:19
sdakepretty sure this unified agent in openstack will be #6 ;-)22:19
zanebsdake: which thread are we talking about?22:19
sdakemy thoughts on the unified guest agent22:20
zanebah22:20
sdakethe long and arduous one which you have probably tuned out by now ;)22:20
zanebI never even got started on it22:20
zanebstill have 94 unread emails just in [heat] :(22:20
sdakeprobably bring back some PTSD - recommend avoiding ;)22:20
zaneblol22:21
*** pablosan has quit IRC22:21
zanebI escaped fairly cleanly in the end ;)22:21
sdakeyes, yes you did ;)22:21
zanebI notice the matahariproject.org domain has been taken over by spammers22:22
openstackgerritZane Bitter proposed a change to openstack/heat: Convert Neutron resources to new Schema format  https://review.openstack.org/6182322:23
sdakeheat-api.org up for renewal22:23
sdakeprobably going to let it lapse22:23
sdakebe some good popcorn material see what the domain squatters do with it22:23
*** pablosan has joined #heat22:24
stevebakershardy: https://wiki.openstack.org/wiki/Heat/Blueprints/InstanceUsers#5._Resource-scoped_virtual_keypairs <- you may want to add some Cons ;)22:24
openstackgerritJason Dunsmore proposed a change to openstack/heat: Allow an in-progress stack to be deleted  https://review.openstack.org/6300222:29
zanebsdake: he disagrees with having a single standard for RPC? that's... weird22:33
*** Tross has quit IRC22:34
wirehead_I know what I, were I to be a domain squatter, would do with it.22:36
*** swygue has quit IRC22:37
zanebwirehead_: do tell :)22:38
wirehead_http://xkcd.com/624/22:39
zanebwell played22:40
* wirehead_ bows22:40
stevebakerI think I'll suggest every second heat meeting favours Asia over Europe http://www.timeanddate.com/worldclock/converted.html?iso=20140116T14&p1=2095&p2=0&p3=179&p4=137&p5=47&p6=3322:41
stevebaker0100 UTC22:41
*** sgordon has joined #heat22:43
*** sgordon has quit IRC22:43
*** sgordon has joined #heat22:43
zanebugh 8pm :(22:44
stevebakeryeah, i know22:44
stevebakerzaneb: if you had a choice of slightly earlier or slightly later which would you prefer?22:45
zanebearlier22:45
stevebaker7pm?22:46
zanebwould be better22:46
stevebaker8am might be a bit early for china office commuters22:46
zanebbut probably more important that folks like liang can join22:46
*** vijendar has quit IRC22:47
grncdrok, so I am getting rid of the greenlet pool and just doing the checks one after another, is using eventlet.connect still ok? or should I be using asyncore?22:49
grncdrI was under the impression that using eventlet.connect would make my resource yield control22:49
grncdrwhich I think it does, but maybe not to the right "level"22:49
grncdre.g. do I need to use something different to cooperate with heat.engine.scheduler22:50
SpamapSsdake: the fact that you've seen so many agent unification efforts derailed is a nice piece of data actually.22:50
*** blomquisg has quit IRC22:50
*** rpothier_ has quit IRC22:50
zanebgrncdr: how long is the timeout on connect?22:50
*** SnowDust has quit IRC22:50
grncdrI believe it's OS specific?22:51
grncdrdefault is something like 60 seconds on most systems though22:51
grncdrI could also go with the stdlib socket module22:52
grncdrand set the timeout manually22:52
grncdras far as I can tell that would block the whole process though22:52
*** rongze has joined #heat22:53
grncdreventlet.connect has no way to set timeouts, so I could create my own timeout and catch it, but that adds a lot of complication22:54
grncdrs/complication/complexity/22:55
zanebgrncdr: make_connection() allows you to set the timeout, no?22:55
grncdrI don't know make_connection...22:56
SpamapSgrncdr: eventlet has already monkeypatched the low level socket stuff, so may as well use eventlet.connect().22:56
grncdryou mean socket.socket.create_connection?22:56
*** dims_ has quit IRC22:57
zaneber, yes22:57
grncdrSpamapS: that's what I was thinking, but I wanted to get feedback here before spamming everybody with another review notification ;)22:59
*** rongze has quit IRC22:59
grncdrthat being said, if (stdlib) socket is already monkey-patched22:59
grncdrthen maybe socket.create_connection makes more sense22:59
SpamapSgrncdr: the timeout stuff.. I'm also suspicious that you even need that.23:00
grncdrSpamapS: honestly, *I* don't23:00
grncdrI only need one port per resource23:00
SpamapSthe stack has a timeout.. it will give up eventually... :)23:00
grncdrright, I was worried about causing the stack to give up incorrectly though23:01
grncdrif you have say a 5min timeout on the resource, and 60s timeout on each connect...23:02
grncdrhm, you know what, I think I just rubberducked myself out of the idea23:02
SpamapS:)23:02
*** SnowDust has joined #heat23:03
openstackgerritStephen Sugden proposed a change to openstack/heat: Add PortCheck resource  https://review.openstack.org/6207823:03
*** blomquisg has joined #heat23:04
zanebgrncdr: did you intend to push that? it looks the same23:05
grncdrhuh? it looks different to me...23:05
*** Tross has joined #heat23:05
grncdrhow do I diff against the previous patchset again?23:05
zanebok, technically it's different23:06
zanebbut it's still checking every port on every loop23:06
*** AndrewMichalik has joined #heat23:06
zaneb(go to Patch Sets up the top when you're looking at a diff)23:07
grncdrah there, found it23:07
grncdrzaneb: yes it is? I obviously missed some feedback there23:07
grncdralso it's only checking ports that haven't successfully connected23:07
* grncdr is re-reading previous review comment23:08
zanebgrncdr: the feedback you missed was to use the PollingTaskGroup23:08
zanebwhich implements the same algorithm, except better (yields as soon as one fails)23:09
*** SushilKM has quit IRC23:09
grncdrI see23:10
zanebreuse ftw23:10
*** dims_ has joined #heat23:13
SpamapSembrace the scheduler :)23:14
SpamapSuntil we go to taskflow23:14
SpamapSat which point... eschew the scheduler ;)23:14
zanebwhy can't I buy a Nokia 108 in the US?23:16
zanebit's only available in tinpot countries, like... France23:16
zaneb:(23:16
grncdrgah, I'm getting more confused now… do I run this PollingTaskGroup (using it's __call__) or do I yield it from my handle_create and assume that the engine knows what to do with it?23:19
grncdrs/yield/return/23:19
zanebgrncdr: PollingTaskGroup is a task, so you pass it to TaskRunner the same as you were doing with self._wait23:20
* grncdr slaps forehead23:20
*** andrew_plunk has quit IRC23:23
openstackgerritStephen Sugden proposed a change to openstack/heat: Add PortCheck resource  https://review.openstack.org/6207823:23
grncdrcrap, ignore that23:24
openstackgerritStephen Sugden proposed a change to openstack/heat: Add PortCheck resource  https://review.openstack.org/6207823:25
*** Tross has quit IRC23:39
*** rcleere has quit IRC23:46
*** jergerber has quit IRC23:49
*** gokrokve has quit IRC23:51
*** jcru has quit IRC23:52

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!