| *** wirehead_ has quit IRC | 02:01 | |
| *** wirehead_ has joined #craton | 02:03 | |
| *** VW has quit IRC | 02:16 | |
| *** VW has joined #craton | 02:16 | |
| *** Syed__ has quit IRC | 03:25 | |
| *** VW has quit IRC | 03:32 | |
| *** VW has joined #craton | 03:33 | |
| openstackgerrit | Michael Porras proposed openstack/craton master: Adding wrapper functions to tools https://review.openstack.org/449230 | 04:40 |
|---|---|---|
| anonymike | fsaad: I think I'm gonna take your advice and swap my laptop this week. This is happening every couple of hours http://imgur.com/a/9edEI crazy frustrating | 04:44 |
| *** VW has quit IRC | 05:15 | |
| *** acabot has quit IRC | 07:17 | |
| *** klindgren_ has quit IRC | 07:48 | |
| *** klindgren_ has joined #craton | 07:49 | |
| *** acabot has joined #craton | 07:52 | |
| *** openstackgerrit has quit IRC | 08:33 | |
| *** VW has joined #craton | 11:00 | |
| sulo | oh yikes i didnt realize this was still pending https://review.openstack.org/#/c/447580/ | 11:03 |
| sulo | git-harry: are you clear on what sigmavirus is referring to there ? | 11:05 |
| sulo | would really love to get that patch in if possible | 11:05 |
| sulo | thomasem: jimbaker: do take a look at ^ | 11:05 |
| git-harry | sulo: yes but I was waiting for the opinions of others. I'll add another comment. | 11:12 |
| sulo | ok | 11:15 |
| *** VW has quit IRC | 12:39 | |
| *** VW has joined #craton | 13:09 | |
| *** VW has quit IRC | 13:13 | |
| *** VW has joined #craton | 13:14 | |
| thomasem | sulo: git-harry: done | 13:21 |
| thomasem | :) | 13:21 |
| thomasem | anonymike: that's no fun. I'm sorry you're having to deal with that. :( | 13:22 |
| thomasem | And good morning / afternoon! | 13:22 |
| *** VW has quit IRC | 13:29 | |
| *** openstackgerrit has joined #craton | 13:29 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 13:29 |
| *** VW has joined #craton | 13:32 | |
| fsaad | morning guys | 13:35 |
| fsaad | anonymike: yeah that's pretty bad | 13:36 |
| thomasem | git-harry: https://bugs.launchpad.net/craton/+bug/1676437 | 13:39 |
| openstack | Launchpad bug 1676437 in craton "error responses do not comply with OpenStack API WG guidelines" [Undecided,New] | 13:39 |
| git-harry | thomasem: ta | 13:41 |
| thomasem | da | 13:41 |
| * thomasem waves hands | 13:41 | |
| *** VW has quit IRC | 13:41 | |
| *** VW has joined #craton | 13:43 | |
| anonymike | morning all and yeah, kind of frustrating but it'll be fixed soon | 13:55 |
| *** Syed__ has joined #craton | 14:01 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 14:01 |
| thomasem | Alright, writing up final tests for that patch. Please feel free to review what's done anyway^^ :) | 14:28 |
| *** VW has quit IRC | 14:32 | |
| *** VW has joined #craton | 14:32 | |
| jimbaker | sulo, git-harry - i did take a look and also discussed with sigmavirus re https://review.openstack.org/#/c/447580/ | 14:59 |
| jimbaker | meeting... | 14:59 |
| fsaad | mmm, I'm there by myself | 15:01 |
| fsaad | am I in the wrong channel? :S | 15:02 |
| git-harry | fsaad: #openstack-meeting-4 | 15:02 |
| fsaad | thanks git-harry | 15:02 |
| *** VW has quit IRC | 15:12 | |
| *** VW has joined #craton | 15:12 | |
| *** VW has quit IRC | 15:32 | |
| *** VW has joined #craton | 15:33 | |
| *** klindgren__ has joined #craton | 15:35 | |
| *** klindgren_ has quit IRC | 15:38 | |
| jimbaker | git-harry, so is the plan to fix up your patch such that it complies with https://specs.openstack.org/openstack/api-wg/guidelines/errors.html ? just seems like this could be a second step? | 15:55 |
| thomasem | jimbaker: I am in favor of us making that a second step, myself. | 15:56 |
| thomasem | git-harry: ^^ | 15:56 |
| jimbaker | first step: one exit point; second step: follow guidelines. i think the only tricky part is that iirc the patch currently removes some of the flask error reporting that these guidelines effectively expand upon | 15:57 |
| thomasem | I only intended to point out the thing we probably want to move towards with https://bugs.launchpad.net/craton/+bug/1676437 | 15:57 |
| openstack | Launchpad bug 1676437 in craton "error responses do not comply with OpenStack API WG guidelines" [Undecided,New] | 15:57 |
| jimbaker | thomasem, got it, and i think that's certainly the right place to go | 15:57 |
| thomasem | Which is why I made a separate bug for it. :) | 15:57 |
| thomasem | Cool | 15:58 |
| jimbaker | not certain how it impacts graphql mind you... | 15:58 |
| jimbaker | but separate discussion. long term discussion | 15:58 |
| jimbaker | maybe different endpoint too | 15:58 |
| jimbaker | the other thing that comes to mind is better internal logging of problems. i want my stack trace back... | 15:59 |
| jimbaker | ideally running on 3.6 while we are at it :) (because it does a far better job of logging stack overflows) | 16:00 |
| jimbaker | anyway, not immediate. just putting it out there | 16:00 |
| thomasem | Lol | 16:00 |
| thomasem | Yeah... I have no idea what happened to the tracebacks. | 16:01 |
| thomasem | But it's been really annoying. | 16:01 |
| thomasem | Maybe I'll dig into that a bit and see if it's just something silly (probably is). | 16:01 |
| jimbaker | almost certainly is | 16:01 |
| jimbaker | we did a fair amount of refactoring to be systematic about codes being returned, which this recent patch by git-harry is an extension of | 16:02 |
| thomasem | Right | 16:02 |
| *** klindgren__ is now known as klindgren | 16:04 | |
| jimbaker | btw i highly encourage we use chained exceptions (http://stackoverflow.com/a/16414892/423006) | 16:05 |
| jimbaker | thomasem, this could be a simple bug (i would think) for someone to take care of - most of this needs to be done in craton/db/sqlalchemy/api.py | 16:06 |
| jimbaker | that way we could avoid losing context | 16:06 |
| sulo | sorry folks i missed the meeting today, i had a doctors apt | 16:07 |
| jimbaker | sulo, no worries, we did give you some work :) | 16:08 |
| sulo | jimbaker: nice | 16:09 |
| sulo | although i alrady got some | 16:09 |
| jimbaker | i bet you do | 16:09 |
| sulo | so back to that patch from git-harry | 16:09 |
| sulo | let me see if ya'all got a chance to talk about it or make comments | 16:09 |
| jimbaker | no, it was just the outstanding client stuff for network resources | 16:09 |
| sulo | i need that patch(or revisions of it) for some stuff i am doing | 16:10 |
| sulo | https://review.openstack.org/#/c/447580/ | 16:10 |
| thomasem | jimbaker: good call, re: chained exceptions. I'm fixing that in my patch. | 16:12 |
| jimbaker | so i think the consensus here is that we want to bring back the error array reporting; but do it with respect to wg guidelines | 16:12 |
| jimbaker | so two steps | 16:12 |
| sulo | jimbaker: ok sounds good to me, as long as there is some consensus .. | 16:14 |
| jimbaker | thomasem, yeah, something we can think about in our reviewing. all exceptions should be chained. i cannot think of a reason why not (potentially one could want avoid in certain scenarios where exceptions are being used at a high rate. doesn't apply here) | 16:14 |
| sulo | i just need the output of how the error handled ... etc | 16:14 |
| git-harry | I'm not sure the example in the guidelines applies directly to this situation but some variation on it would probably make sense. | 16:15 |
| jimbaker | yeah, i'm not sure how many projects adhere to these guidelines... | 16:16 |
| jimbaker | still we have enjoyed helping set direction here, as we saw with pagination | 16:17 |
| jimbaker | https://developer.openstack.org/api-guide/compute/paginated_collections.html is merged in... | 16:19 |
| jimbaker | git-harry, also it looks there's a chance to reconcile https://developer.openstack.org/api-guide/compute/faults.html with https://specs.openstack.org/openstack/api-wg/guidelines/errors.html | 16:21 |
| jimbaker | the upshot: definitely more than just one patch required here :) | 16:21 |
| jimbaker | thomasem, i see an opportunity to report back to OSIC on fixing the openstack ecosystem inconsistencies, one small sisyphean boulder at a time | 16:23 |
| jimbaker | :) | 16:23 |
| jimbaker | thomasem, re https://review.openstack.org/#/c/447580/3/craton/tests/functional/test_cell_calls.py, are we good with postponing that in a second phase of work? | 16:32 |
| thomasem | Testing for multiple validation errors? | 16:33 |
| jimbaker | yep | 16:33 |
| thomasem | I don't think so. That's something that's supposed to be supported now. | 16:33 |
| thomasem | Since this code changes that piece, I think it makes sense to assert that it works. | 16:33 |
| jimbaker | ok. i just see it as being superseded by api wg guidelines, that's all | 16:33 |
| thomasem | I see it as making sure the existing implementation meets the expectations we have of it. I don't know how fast a follow the new "standard" may be, and I don't think it's that much more work to add a few tests to assert >1 validation errors. | 16:34 |
| thomasem | If I'm misunderstanding or thinking that's a bunch of extra work to do, please tell me. It seems like the same test as before, just another thing wrong with the request and asserting that the message provides both errors. | 16:35 |
| jimbaker | thomasem, ack | 16:36 |
| thomasem | or we're thinking* | 16:36 |
| thomasem | cool :) | 16:37 |
| thomasem | Also, it lets us add the extra docstring stuff sulo was suggesting, which will help anyone else reading this code. | 16:38 |
| thomasem | So, we had a little bit of reason for a change to it anyway. | 16:38 |
| jimbaker | Syed__, any update on https://review.openstack.org/#/c/425463/ ? | 16:38 |
| thomasem | Syed__: Also, did that fix work that we discussed a couple weeks ago? | 16:39 |
| thomasem | regarding tests for the patch jimbaker mentioned | 16:39 |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 16:39 |
| anonymike | Quick clarification for the fields stuff. Filtering the desired fields from the returned object is all being done through the client, correct? We aren't crafting queries based on requested fields yet | 16:40 |
| sulo | anonymike: querys are filter based | 16:40 |
| sulo | not sure thats what you are saying though .. --fields is different | 16:41 |
| sulo | its just display iirc | 16:41 |
| thomasem | yeah, there's no crafting queries to the API based on --fields, it's simply taking what the API already gives us and modifying how it's displayed | 16:42 |
| thomasem | atm | 16:42 |
| anonymike | perfect | 16:42 |
| anonymike | thomasem | 16:42 |
| anonymike | thanks | 16:42 |
| *** chrisspencer has quit IRC | 16:42 | |
| jimbaker | anonymike, yeah at some point we may want to pushdown this "select" info into craton | 16:43 |
| thomasem | Yep | 16:43 |
| jimbaker | but for now, everything is purely on client side for this work | 16:44 |
| thomasem | Would be nice to have the same capabilities on the API in the future. | 16:44 |
| anonymike | cool, I got a little confused when you brought that up jimbaker, i thought thats what i was doing now | 16:44 |
| thomasem | Especially when it comes to scaling this thing | 16:44 |
| jimbaker | anonymike, nope, that's why we mentioned graphql | 16:44 |
| anonymike | whew okay | 16:44 |
| jimbaker | because we are doing it terribly inefficiently | 16:44 |
| jimbaker | but correctness first | 16:44 |
| jimbaker | then optimize | 16:44 |
| jimbaker | one of many mantras :) | 16:45 |
| jimbaker | my many | 16:45 |
| jimbaker | anonymike, also applies to aliasing. let's do this client side | 16:46 |
| anonymike | i agree, and that was going to be my initial approach. I was just a little confused at the mentions of how it SHOULD be done and started freaking out lol | 16:47 |
| jimbaker | anonymike, as in, what i did just volunteer for? | 16:49 |
| anonymike | exactly | 16:49 |
| anonymike | confident, but gonna take much longer | 16:49 |
| jimbaker | anonymike, yeah, i think we just wanted to impress upon how much this touches. but fortunately all highly useful stuff | 16:49 |
| anonymike | I'm still running into some weird issues with the craton client. I think i really messed up my environment while I was juggling the compose/elastic search stuff and installing the client manually. I'm going to rebuild my instance while I lunch. | 16:53 |
| anonymike | btw jimbaker, I made some good progress last night on the elastic search stuff. I would really like to play around with displaying some data through kibana. It sounds like that should go on the backburner, but Its something I'm still interested in completing in the next few days | 16:54 |
| jimbaker | anonymike, it is a "back burner" project, especially kibana | 16:55 |
| jimbaker | however, i think we can readily do something like tie in to craton as follows | 16:55 |
| jimbaker | v1/resources?q=... proxies the query to ES, getting back a set of json docs. then applies rbac to set and returns | 16:56 |
| jimbaker | anonymike, so this probably can do what we want with search. kibana is trickier, because we need craton to provide rbac as an api it can use. but that's why i suggested sidestepping these integration points for now and just see if the functionality was at all useful | 16:59 |
| jimbaker | before even exploring further | 17:00 |
| anonymike | yeah, i was just wondering how we'd secure those attributes with kibana | 17:00 |
| jimbaker | anonymike, yeah, and do it cheaply as well | 17:01 |
| jimbaker | if if it needs to call craton for every attribute... | 17:01 |
| jimbaker | so best to defer for now | 17:02 |
| anonymike | jimbaker: are there any thoughts or plans around data visualization? Something like the Galaxy UI (observatory) I think that'd go a long way in a demo and help buy in from support. However I completely understand that a lot more has to be completed before we can justify setting up a UI | 17:05 |
| anonymike | just curious... | 17:06 |
| antonym | i'm guessing craton-dashboard plugin for horizon was an attempt at that | 17:07 |
| thomasem | Yeah | 17:08 |
| antonym | but yeah, i'd guess that'd be useful for support | 17:08 |
| jimbaker | right. i think the horizon idea had some merit, but the reality is that we want a better UI | 17:08 |
| jimbaker | anonymike, at one point we were getting into discussion of visualization. mostly with respect to workflows | 17:09 |
| jimbaker | so how we build out a "cloud progress bar" | 17:09 |
| anonymike | gotcha | 17:09 |
| jimbaker | in any case, the key thing here is how to highlight problems | 17:09 |
| jimbaker | note that the vars stuff doesn't directly give us that | 17:10 |
| jimbaker | it doesn't say - what is the expected values, and what if not in compliance | 17:10 |
| anonymike | people like quick tables of inventory as well. drilling down on a webpage is a lot easier than writing a script or entering a long command to see the hosts in a cell | 17:10 |
| jimbaker | it is possible we could say, maybe we could add such things to a namespace | 17:10 |
| anonymike | right | 17:10 |
| jimbaker | anonymike, agreed | 17:10 |
| jimbaker | so i think kibana actually could be a good way for quickly trying out ideas here | 17:11 |
| jimbaker | even if it's not the real dashboard | 17:11 |
| anonymike | Just some stuff I was wondering about :) didn't mean to derail any work. I'm gonna relocate to a coffee shop and continue this work | 17:13 |
| jimbaker | anonymike, no derailing, just great questions! | 17:15 |
| jimbaker | git-harry, sulo , we just need a quick fix on https://review.openstack.org/#/c/447580/3, and we are good | 17:16 |
| sulo | jimbaker: git-harry: yeah, cool. my change is based on that change so i am just waiting for whatever | 17:16 |
| jimbaker | specifically the requested test for https://review.openstack.org/#/c/447580/3/craton/tests/functional/test_cell_calls.py | 17:16 |
| jimbaker | sulo, should be a minor to get in | 17:17 |
| sulo | jimbaker: rgr | 17:17 |
| *** harlowja has quit IRC | 17:18 | |
| *** harlowja has joined #craton | 17:24 | |
| openstackgerrit | Thomas Maddox proposed openstack/craton master: JSON Path-like querying for variables https://review.openstack.org/443941 | 17:42 |
| openstackgerrit | Merged openstack/python-cratonclient master: Remove link to modindex https://review.openstack.org/428580 | 17:48 |
| jimbaker | just cleaned up our review queue with some minor (including taking care of "robot" patches) | 17:49 |
| thomasem | thanks jimbaker | 17:49 |
| jimbaker | we need to get some progress on jovon's doc patches | 17:50 |
| jimbaker | everything else looks like we are moving forward on at this time | 17:50 |
| jimbaker | or at least pings made | 17:51 |
| thomasem | yeah | 17:51 |
| openstackgerrit | Merged openstack/python-cratonclient master: Update link to documentation and bug tracker https://review.openstack.org/449725 | 17:51 |
| openstackgerrit | Merged openstack/craton master: Remove link to modindex https://review.openstack.org/428579 | 17:52 |
| jimbaker | i'm sure we will want to re-add modindex but no need to have a broken link | 17:52 |
| thomasem | Alright, going to write some docs up on how to use this JSON Path thing and submit those next. | 17:53 |
| jimbaker | thomasem, so i take it that the json path func testing is done, and we just need to wrap up reviews on it | 17:59 |
| jimbaker | (which i assume will be quick, given how much time we have collectively looked at it) | 17:59 |
| thomasem | jimbaker: yep | 17:59 |
| thomasem | reviews + any changes that come out of reviews. I, too, hope it's fairly quick. | 17:59 |
| jimbaker | cool. brb, need to walk dog, but will do that next | 17:59 |
| thomasem | Great, thanks! | 17:59 |
| thomasem | I need to head to an appointment over a late lunch. bbiab | 18:00 |
| openstackgerrit | Merged openstack/python-cratonclient master: Drop py34 target in tox.ini https://review.openstack.org/449894 | 18:02 |
| openstackgerrit | Michael Porras proposed openstack/craton master: Adding wrapper functions to tools https://review.openstack.org/449230 | 18:36 |
| thomasem | How was everyones' weekend? | 20:52 |
| antonym | could have been longer :) good outside weather though | 20:56 |
| thomasem | Haha, that's fair. | 20:56 |
| thomasem | Yeah, it was pretty nice out. | 20:56 |
| anonymike | Seriously. I played kickball for a friends birthday party at a local park. It was beautiful outside | 20:59 |
| *** VW_ has joined #craton | 21:00 | |
| thomasem | Nice | 21:00 |
| *** VW_ has quit IRC | 21:02 | |
| *** VW_ has joined #craton | 21:02 | |
| *** VW has quit IRC | 21:04 | |
| openstackgerrit | git-harry proposed openstack/craton master: Ensure JSON responses result from failure https://review.openstack.org/447580 | 21:19 |
| antonym | so with the rbac stuff, we should be able to have read only users right? | 21:22 |
| thomasem | I think that's the idea, but I'd ping jimbaker, as he's been ideating on it much longer and has more context. | 21:56 |
| thomasem | Alright, I'm outta here. Have a lovely evening/day! | 22:06 |
| anonymike | later thomasem! | 22:19 |
| anonymike | I'm gonna go for a run but I'll be on later | 22:19 |
| *** VW has joined #craton | 22:22 | |
| *** VW_ has quit IRC | 22:22 | |
| *** Syed__ has quit IRC | 22:25 | |
| *** VW has quit IRC | 22:54 | |
| *** VW has joined #craton | 22:55 | |
| *** VW has quit IRC | 22:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!