| *** valw has joined #craton | 00:09 | |
| *** valw_ has joined #craton | 00:13 | |
| *** valw has quit IRC | 00:14 | |
| *** Syed__ has quit IRC | 01:15 | |
| *** valw_ has quit IRC | 01:55 | |
| *** valw has joined #craton | 02:14 | |
| *** lcastell has quit IRC | 02:26 | |
| *** VW has joined #craton | 02:41 | |
| *** harlowja has quit IRC | 02:44 | |
| *** VW has quit IRC | 02:46 | |
| *** lcastell has joined #craton | 02:57 | |
| *** VW has joined #craton | 03:17 | |
| *** lcastell has quit IRC | 03:26 | |
| *** lcastell has joined #craton | 04:25 | |
| *** VW has quit IRC | 04:40 | |
| *** VW has joined #craton | 04:41 | |
| *** VW has quit IRC | 04:51 | |
| *** valw has quit IRC | 05:01 | |
| *** VW has joined #craton | 05:11 | |
| *** VW has quit IRC | 05:16 | |
| *** harlowja has joined #craton | 06:34 | |
| *** harlowja has quit IRC | 07:26 | |
| git-harry | sulo: would it be accurate to say that every (endpoint, method) combination should be in scopes in schemas.py? | 12:18 |
|---|---|---|
| sulo | technically yes it should be | 12:25 |
| sulo | but i dont think we are using it to check security scoping | 12:26 |
| sulo | it was something from swagger that we moved away from | 12:26 |
| git-harry | sulo: yeah, the code doesn't look complete | 12:26 |
| git-harry | That's why I was checking | 12:26 |
| sulo | yeah, lets remove that to make it less confusing | 12:27 |
| git-harry | okay, that simplifies things. I'll do that instead. | 12:28 |
| git-harry | Ta | 12:28 |
| sulo | thanks | 12:28 |
| sigmavirus | sulo: uhm that bug description is wrong | 13:15 |
| sulo | which? | 13:15 |
| sigmavirus | global-requirements does care about python3 support | 13:15 |
| sigmavirus | it uses markers for deps that are py3 only or py2 only | 13:15 |
| sigmavirus | And there was a lot of work with sqlalchemy to find a mysql driver that worked well on py3 | 13:15 |
| sigmavirus | If you search openstack-dev archives they found one that worked well | 13:16 |
| sigmavirus | I suspect we should use whichever one they found | 13:16 |
| sigmavirus | ANd I suspect the one they found works for py2 or py3 | 13:16 |
| sulo | cool | 13:17 |
| sulo | will check | 13:17 |
| *** valw has joined #craton | 13:26 | |
| *** lcastell has quit IRC | 13:27 | |
| *** acabot has joined #craton | 13:41 | |
| *** valw_ has joined #craton | 13:44 | |
| *** valw has quit IRC | 13:46 | |
| *** valw_ is now known as valw | 13:59 | |
| *** acabot has quit IRC | 14:08 | |
| *** VW has joined #craton | 14:16 | |
| *** VW has quit IRC | 14:21 | |
| *** acabot has joined #craton | 14:27 | |
| *** VW has joined #craton | 14:46 | |
| *** VW has quit IRC | 14:46 | |
| *** VW has joined #craton | 14:46 | |
| *** jovon has joined #craton | 15:30 | |
| *** Syed__ has joined #craton | 15:33 | |
| *** lcastell has joined #craton | 15:41 | |
| *** VW_ has joined #craton | 15:56 | |
| *** VW__ has joined #craton | 15:59 | |
| *** VW has quit IRC | 16:00 | |
| *** VW__ has quit IRC | 16:01 | |
| *** VW has joined #craton | 16:01 | |
| *** VW_ has quit IRC | 16:01 | |
| *** VW has quit IRC | 16:03 | |
| *** VW has joined #craton | 16:03 | |
| sigmavirus | jimbaker: we're overlappipng with what sounds like a very interesting tech talk | 16:45 |
| jimbaker | sigmavirus, sorry about that | 16:45 |
| sigmavirus | jimbaker: not your fault | 16:46 |
| sigmavirus | I blame Syed__ ;) | 16:46 |
| Syed__ | Haha | 16:46 |
| jimbaker | sigmavirus, i'm happy to include 5 min on me talking on this very subject in today's meeting. but on second thought, no ;) | 16:47 |
| Syed__ | is the tech meeting osic tech talk ? | 16:47 |
| * jimbaker worked extensively with nosql before going back to sql | 16:47 | |
| sigmavirus | Syed__: no, Rackspace | 16:47 |
| sigmavirus | jimbaker: I'm sorry? | 16:47 |
| jimbaker | nosql is awesome for certain workloads of course. i am interested in the newsql space, such as cockroachdb and tidb (the latter of which aims to be in a nearly drop-in replacement for mysql, similar to google spanner has done internally at google) | 16:49 |
| jimbaker | i suspect there are various footnotes and other qualifications for the statement of being a "drop-in replacement" | 16:50 |
| sigmavirus | I bet Oracle would disagree =p | 16:51 |
| jimbaker | yeah, i haven't looked at the breadth of offerings that oracle is putting around mysql. certainly some interesting work there as well | 16:51 |
| jimbaker | need to review the latest in mysql 8 | 16:53 |
| jimbaker | https://etherpad.openstack.org/p/craton-meetings for today's meeting | 17:00 |
| jimbaker | sulo, git-harry, jovon - meeting | 17:00 |
| *** VW has quit IRC | 17:04 | |
| *** VW has joined #craton | 17:07 | |
| *** valw has quit IRC | 17:30 | |
| *** d34dh0r53 is now known as ID-Ten-T | 17:45 | |
| *** ID-Ten-T is now known as blarnath | 17:48 | |
| *** blarnath is now known as d34dh0r53 | 17:48 | |
| *** chrisspe- has joined #craton | 18:34 | |
| *** VW has quit IRC | 18:53 | |
| *** VW has joined #craton | 19:05 | |
| sulo | jimbaker: can you give your views on https://review.openstack.org/#/c/423855/ | 19:10 |
| *** VW has quit IRC | 19:10 | |
| jimbaker | sulo, will do | 19:10 |
| jimbaker | also i figured out the foreign key constraint issue with respect to host deletes | 19:11 |
| sulo | cool | 19:11 |
| jimbaker | probably need to do this work more comprehensively | 19:11 |
| sulo | what was the issue ? | 19:11 |
| jimbaker | just not setting this up in the alembic migration; the underlying issue for that it seems like sqlalchemy needs some help in setup; or possibly the alembic discovery did not reproduce | 19:12 |
| jimbaker | regardless, we need it in our alembic setup | 19:13 |
| jimbaker | i guess we already knew alembic autodiscovery was weak | 19:13 |
| jimbaker | and that's fine | 19:13 |
| jimbaker | just one more issue to fix | 19:14 |
| jimbaker | i am not going to explore the possibility that it cannot be generated by sqlalchemy ddl w/o alembic, since clearly that's not pertinent to us | 19:15 |
| jimbaker | sulo, did that clarify? ;) | 19:15 |
| sulo | yeah | 19:15 |
| jimbaker | could be two problems, masking each other. but it's certainly easy to fix | 19:15 |
| jimbaker | oh, and the fk constraint is just to ensure we do on delete cascade | 19:16 |
| jimbaker | because otherwise we are violating the terms of the fk | 19:16 |
| jimbaker | the other option would have been to do soft deletes, but we early on decided not to do that approach | 19:17 |
| jimbaker | since we have lots of fk constraints, and they are centered on host, we see it show up | 19:17 |
| jimbaker | sulo, re your comment on https://review.openstack.org/#/c/423855/2, yes it makes sense to me. so the ip address of the device is the management ip | 19:20 |
| jimbaker | it may have additional interfaces of course | 19:20 |
| sulo | cool ... thats what i was going with. thx. | 19:21 |
| jimbaker | will note on the review | 19:21 |
| jimbaker | thanks for asking me | 19:21 |
| jimbaker | sulo, i have convinced myself that probably this is the only case we have for now | 19:30 |
| jimbaker | with respect to fk constraint issues | 19:30 |
| sulo | jimbaker: it is from what i know | 19:30 |
| jimbaker | we will get more once we add rbac; and workflow/workflow def | 19:30 |
| jimbaker | but hopefully we will get it right for that modeling | 19:30 |
| jimbaker | easy enough to test | 19:31 |
| sulo | yeah i have functional tests thats failing on that .. everything else is passing | 19:31 |
| jimbaker | sulo, please add your +2 to https://review.openstack.org/#/c/423855 | 19:31 |
| jimbaker | i will add my comment and +2 | 19:31 |
| jimbaker | might as well do the two reviews in this case | 19:31 |
| jimbaker | and hopefully we will soon have more core reviewers so this becomes more routine practice :) | 19:32 |
| jimbaker | you can wait for my comment first i guess... | 19:32 |
| *** VW has joined #craton | 19:32 | |
| sulo | i already did | 19:32 |
| jimbaker | yep, it's fine :) | 19:32 |
| sulo | jimbaker: sigmavirus: so a quick question here https://gist.github.com/sulochan/2a82357f9311b4a964e412cb88de7157 | 19:34 |
| sulo | do we want to show created_at and updated_at ? | 19:34 |
| jimbaker | sulo, yes | 19:35 |
| sulo | we probably do ... which means | 19:35 |
| sulo | jimbaker: +1 | 19:35 |
| *** VW has quit IRC | 19:36 | |
| *** VW has joined #craton | 19:36 | |
| jimbaker | sulo, i just hope the convention is to do such reporting from the CLI with respect to UTC. hopefully! from what i can tell, such times are not consistently reported on in openstack CLIs. but it is very useful info | 19:39 |
| sulo | i think so .. i cant imagine it not being UTC | 19:40 |
| *** harlowja has joined #craton | 19:41 | |
| *** valw has joined #craton | 19:46 | |
| jimbaker | sulo, right, we will do it the sane way :) | 19:51 |
| *** VW has quit IRC | 19:57 | |
| jimbaker | sulo, which functional test change that you wrote is failing on host deletion? | 20:06 |
| sulo | i havent uploaded it yet .. once you fix that, ill upload the test | 20:07 |
| *** VW has joined #craton | 20:08 | |
| jimbaker | sulo, i just wanted to use this as a parent, or otherwise reuse your test | 20:09 |
| jimbaker | because laziness ;) | 20:09 |
| Syed__ | jimbaker: whats the best time to discuss somethings about brace ? | 20:10 |
| Syed__ | rbac | 20:10 |
| Syed__ | autocorrect* | 20:10 |
| jimbaker | Syed__, and here i was thinking you were suggesting we use 'import braces' | 20:10 |
| jimbaker | let me get that right. try this: from __future__ import braces | 20:11 |
| Syed__ | cool stuff, didn't knew about that. just found this article http://stackoverflow.com/questions/101268/hidden-features-of-python | 20:13 |
| *** VW has quit IRC | 20:13 | |
| jimbaker | Syed__, re rbac, we can discuss now. last time we discussed, we were looking at the mechanics of registering policy rules in oslo.policy | 20:30 |
| jimbaker | so we can use authorize, not just enforce | 20:30 |
| Syed__ | yes so i have been looking to get enforcer authorize working but running into some issues | 20:31 |
| jimbaker | and iirc this is basically on the kinds of the rule, eg, rules like fleet:audit | 20:31 |
| jimbaker | where the kind is fleet | 20:31 |
| Syed__ | http://docs.openstack.org/developer/oslo.policy/usage.html#how-to-register | 20:31 |
| sulo | so, how do we want to display variables though cli ... ? | 20:31 |
| sulo | as a json blog ... or list out k:v | 20:32 |
| jimbaker | Syed__, looks straightforward | 20:32 |
| sulo | in table | 20:32 |
| jimbaker | sulo, well not json by default | 20:32 |
| jimbaker | i wonder if there's some value doing k=v, if this could be consumed as env vars | 20:33 |
| jimbaker | also k=v is more what i expect from options | 20:34 |
| jimbaker | hold on, worker at my house | 20:34 |
| sulo | the problem with displaying in table with rows of k/v is .. it gets too big | 20:34 |
| Syed__ | jimbaker: https://gist.github.com/ahsan518/3d843212c4a596f4a26a1d5c21898d08 | 20:34 |
| sigmavirus | Syed__: I'l just say that "pth" files are the devil | 20:35 |
| sulo | sigmavirus: you got any thoughts on displaying variables ^ | 20:35 |
| * sigmavirus scrolls up | 20:36 | |
| *** VW has joined #craton | 20:36 | |
| jimbaker | sulo, so let's assume we are displaying a table like so https://gist.github.com/sulochan/2a82357f9311b4a964e412cb88de7157 | 20:36 |
| sigmavirus | I think I'd prefer it if we could display a table inside the column | 20:37 |
| jimbaker | i would assume that k, v would just follow that model; except that the value could potentially be arbitrarily long/problematic | 20:37 |
| sigmavirus | e.g. variables | <print new table here> | 20:37 |
| sigmavirus | jimbaker: right | 20:37 |
| sigmavirus | I would almost say we should have a separate call to get variables | 20:38 |
| sigmavirus | or a flag to control their retrieval/printing | 20:38 |
| sulo | yeah, but that doesnt help too much i think ...since variable: {very long var chain} | 20:38 |
| *** VW has quit IRC | 20:38 | |
| *** VW has joined #craton | 20:38 | |
| sigmavirus | sulo: I mean a table similar to what's there | 20:38 |
| sigmavirus | just gives you a two column table inside the second column with that info | 20:39 |
| sigmavirus | because I'm an awful person and like to make people's lives harder when they try to sed/awk output | 20:39 |
| jimbaker | sigmavirus, but why nest? effectively we are just adding properties here | 20:39 |
| sulo | sigmavirus: ah ok .. so not worry about displaying indiviual vars right | 20:39 |
| jimbaker | i agree that sigmavirus is suggesting that he's evil, or something like that ;) | 20:39 |
| sigmavirus | so if those vars are displayed as if they're *real* attributes, you are going to confuse the life out of someone | 20:40 |
| sulo | yeah agree | 20:40 |
| jimbaker | sigmavirus, there's that | 20:40 |
| sigmavirus | we could do a ruby-ish thing of that second column printing "var => value" | 20:41 |
| sigmavirus | But I really think it should be something else | 20:41 |
| sigmavirus | craton region-get --id 1 --variables | 20:41 |
| sigmavirus | craton variables-for-region 1 | 20:41 |
| sigmavirus | craton variables-for-user 20 | 20:41 |
| sulo | sigmavirus: +1 | 20:42 |
| sigmavirus | craton variables-for-host 1246643 | 20:42 |
| sigmavirus | reads like a thing too | 20:42 |
| jimbaker | which can just use a standard table output | 20:42 |
| jimbaker | no ambiguity | 20:42 |
| sigmavirus | Idk what kind of thing, but a thing! | 20:42 |
| sigmavirus | jimbaker: right | 20:42 |
| sigmavirus | our formats should allow for JSON outputting too though | 20:42 |
| jimbaker | yes there's an extra strep | 20:42 |
| jimbaker | step | 20:42 |
| sigmavirus | so people can use the stdout values and parse them | 20:42 |
| jimbaker | but they can avoid with the python client | 20:42 |
| sigmavirus | jimbaker: not everyone writes things in python =P | 20:43 |
| jimbaker | sigmavirus, hence the CLI | 20:43 |
| sigmavirus | there are people who would pipe that to jq and do stuff | 20:43 |
| sigmavirus | craton variables-for-host 1235 | bash_script_using_jq.sh | 20:43 |
| jimbaker | anyway the important thing is to make the cli reasonable, as opposed to maximum efficiency (which reqs the python client and presumed caching support, etc) | 20:44 |
| sulo | craton host-variables 1234 --json | bash_script.sh | 20:44 |
| sulo | and craton host-variables 123 = tabled format | 20:44 |
| jimbaker | jq is new to me, but looks reasonable (any idea on how widely used jq is?) | 20:45 |
| jimbaker | https://stedolan.github.io/jq/ | 20:45 |
| jimbaker | sulo, maybe --json is a synonym for --format=json | 20:46 |
| sulo | jimbaker: sure that works too | 20:47 |
| jimbaker | i can also see --format=env to output in env var form | 20:47 |
| jimbaker | presumably with some sort of prefix. maybe selectable. ahh, the endless bikeshedding possibilities of defining a CLI :) | 20:48 |
| jimbaker | (btw, having used a bikeshed in sweden, i can see why they are amenable to such improvements. because they seem to end up being so terrible in practice) | 20:49 |
| sigmavirus | sulo: --format json | 20:49 |
| sigmavirus | not --json | 20:49 |
| sigmavirus | never --json | 20:49 |
| sulo | sigmavirus: 10-4 | 20:49 |
| jimbaker | works for me | 20:50 |
| sigmavirus | and having a hackable/plugin-able --format flag has been wonderful for Flake8 | 20:51 |
| sigmavirus | So I was going to steal my own code for cratonclient | 20:51 |
| jimbaker | +1 | 20:51 |
| *** valw has quit IRC | 20:57 | |
| *** VW has quit IRC | 21:40 | |
| *** VW has joined #craton | 21:47 | |
| *** valw has joined #craton | 21:53 | |
| *** VW has quit IRC | 22:12 | |
| *** VW has joined #craton | 22:13 | |
| *** valw has quit IRC | 22:14 | |
| *** valw has joined #craton | 22:30 | |
| *** jovon has quit IRC | 22:40 | |
| *** david-lyle has quit IRC | 22:50 | |
| *** valw has quit IRC | 22:51 | |
| *** david-lyle has joined #craton | 22:53 | |
| *** VW_ has joined #craton | 23:04 | |
| *** VW has quit IRC | 23:08 | |
| *** harlowja has quit IRC | 23:08 | |
| *** VW_ has quit IRC | 23:08 | |
| *** VW has joined #craton | 23:33 | |
| *** VW has quit IRC | 23:38 | |
| *** harlowja has joined #craton | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!