Tuesday, 2016-10-18

« Monday, 2016-10-17 Index Wednesday, 2016-10-19 »
*** david-lyle has quit IRC00:09
*** david-lyle has joined #craton00:22
*** david-lyle has quit IRC00:29
*** david-lyle has joined #craton00:31
*** david-lyle has quit IRC00:34
*** david-lyle has joined #craton00:36
*** david-lyle has quit IRC00:47
*** david-lyle has joined #craton00:48
*** david-lyle has quit IRC00:51
*** david-lyle has joined #craton00:52
*** david-lyle has quit IRC00:59
*** david-lyle has joined #craton01:01
*** david-lyle has quit IRC01:05
*** david-lyle has joined #craton01:06
*** david-lyle has quit IRC01:07
*** david-lyle has joined #craton01:13
*** david-lyle has quit IRC01:14
*** david-lyle has joined #craton01:15
*** david-lyle has quit IRC01:19
*** david-lyle has joined #craton01:20
*** david-lyle has quit IRC01:21
*** david-lyle has joined #craton01:23
*** david-lyle has quit IRC01:24
*** david-lyle has joined #craton01:26
*** VW has joined #craton01:32
*** david-lyle has quit IRC01:32
*** david-lyle has joined #craton01:34
*** VW has quit IRC01:36
*** david-lyle has quit IRC01:37
*** david-lyle has joined #craton01:38
*** david-lyle has quit IRC01:38
*** david-lyle has joined #craton01:44
*** david-lyle has quit IRC01:44
*** david-lyle has joined #craton01:45
*** david-lyle has quit IRC01:46
*** david-lyle has joined #craton01:57
*** david-lyle has quit IRC01:57
*** david-lyle has joined #craton01:59
*** david-lyle has quit IRC02:00
*** david-lyle has joined #craton02:01
*** david-lyle has quit IRC02:02
*** david-lyle has joined #craton02:03
*** david-lyle has quit IRC02:03
*** david-lyle has joined #craton02:07
*** david-lyle has quit IRC02:08
*** david-lyle has joined #craton02:10
*** david-lyle has quit IRC02:11
*** david-lyle has joined #craton02:12
*** david-lyle has quit IRC02:14
*** david-lyle has joined #craton02:17
*** david-lyle has quit IRC02:18
*** david-lyle has joined #craton02:19
*** david-lyle has quit IRC02:19
*** david-lyle has joined #craton02:21
*** david-lyle has quit IRC02:21
*** david-lyle has joined #craton02:26
*** ahsa518 has quit IRC02:29
*** syed_ has quit IRC02:34
*** david-lyle has quit IRC03:23
*** david-lyle has joined #craton03:24
*** david-lyle has quit IRC03:25
*** david-lyle has joined #craton03:26
*** david-lyle has quit IRC03:27
*** david-lyle has joined #craton03:28
*** david-lyle has quit IRC03:29
*** david-lyle has joined #craton03:30
*** david-lyle has quit IRC03:33
*** david-lyle has joined #craton03:34
*** david-lyle has quit IRC03:36
*** valw_ has quit IRC03:40
*** david-lyle has joined #craton03:50
*** david-lyle has quit IRC03:51
*** david-lyle has joined #craton03:53
*** david-lyle has quit IRC03:54
*** david-lyle has joined #craton03:57
*** david-lyle has quit IRC03:57
*** david-lyle has joined #craton04:00
*** david-lyle has quit IRC04:01
*** david-lyle has joined #craton04:02
*** david-lyle has quit IRC04:04
*** david-lyle has joined #craton04:05
*** david-lyle has quit IRC04:05
*** david-lyle has joined #craton04:06
*** david-lyle has quit IRC04:08
*** david-lyle has joined #craton04:10
*** david-lyle has quit IRC04:11
*** david-lyle has joined #craton04:12
*** david-lyle has quit IRC04:13
*** david-lyle has joined #craton04:14
*** david-lyle has quit IRC04:15
*** david-lyle has joined #craton04:17
*** david-lyle has quit IRC04:18
*** david-lyle has joined #craton04:19
*** david-lyle has quit IRC04:20
*** david-lyle has joined #craton04:21
*** VW has joined #craton07:47
*** VW has quit IRC07:52
sigmavirussulo: jimbaker  https://review.openstack.org/386646 needs reviewing in addition to its dependent change https://review.openstack.org/38674211:54
sulosigmavirus: yeah i already +2'd it yesterday12:31
sigmavirussulo: woops, missed that. Thanks!12:31
sulonp, ill merge it if jimbaker does not get to it today, thanks12:32
sigmaviruswait, did you happen to look at the client change though?12:32
sigmavirusthat still doesn't have a +212:32
sigmavirushttps://review.openstack.org/#/c/386742/12:32
suloahh no .. but i am testing the client now .. so ill use that too12:33
sulothanks12:33
sulodoes cratonclient work from command line ?13:13
sigmavirussulo: yes it should, although I haven't tested it recently13:17
sigmavirusso, I'm working on the project_id change, and I'm getting "DBNonExistentTable" errors when trying to do queries13:18
sigmavirusbut it's clear that the tables exist if you look at hte craton database in mysql13:18
sigmavirus(and I'm using our dockerfile)13:18
sigmavirusah, someone's at the door, brb13:18
sigmavirusso yeah, I can't figure out why switching to sqlalchemy_utils' UUIDType would cause a table not found error13:34
suloyeah thats werird13:34
sulo*weird13:34
sulosigmavirus: the migration went though fine ?13:36
sigmavirussulo: well I changed the only migration we have (because that's been our convention) and yes13:36
sigmavirusit seems to go through fine13:36
*** VW has joined #craton13:39
suloah13:48
*** valw has joined #craton13:55
*** valw_ has joined #craton13:58
*** valw has quit IRC13:58
*** valw_ has quit IRC14:00
-openstackstatus- NOTICE: We are away of pycparser failures in the gate and working to address the issue.14:03
*** valw has joined #craton14:16
sigmavirusah, figured out what's going on14:22
sigmavirusthe DBNonExistentTable was coming from me using the cratondb api from the python interpreter but it was trying to talk to sqlite14:22
sigmavirusso it's not showing me the actual problem with why it can't find the right user for authentication in craton14:23
suloah nice14:25
sigmavirusfigured it out14:34
sigmavirusnow just to fix up some tests14:34
*** jovon has joined #craton14:34
*** valw has quit IRC14:36
*** valw has joined #craton14:36
*** Mudpuppy has joined #craton14:41
*** valw has quit IRC14:45
*** jovon has quit IRC14:54
*** jovon has joined #craton14:58
*** jovon has quit IRC15:04
suloneed a quick client help15:06
sulowhy is this a map here: https://github.com/openstack/python-cratonclient/blob/master/cratonclient/shell/main.py#L13915:06
*** jovon has joined #craton15:12
*** valw has joined #craton15:23
*** syed_ has joined #craton15:29
jimbakersigmavirus, sounds good about https://review.openstack.org/#/c/386742/15:30
*** VW has quit IRC15:30
jimbakersulo, worked fairly late on workflow cleanup, but wasn't able to finalize refactoring into pieces using sqlalchemy, and not using SA15:31
jimbakeri will work on that more today. sorry about it running so late15:31
*** VW has joined #craton15:44
*** VW has quit IRC15:46
*** valw has quit IRC15:46
*** VW has joined #craton15:46
*** valw has joined #craton15:49
jimbakerjovon, sigmavirus, sulo, syed_, and others interested - vidyo meeting in 2 min15:58
syed_jimbaker: thanks. Will be there15:58
sulosigmavirus: https://review.openstack.org/#/c/388091/16:05
-openstackstatus- NOTICE: pycparser 2.16 released to fix assertion error from today.16:09
jimbakersulo, sigmavirus - meeting?16:11
*** valw has quit IRC16:23
*** valw has joined #craton16:25
sigmavirusjimbaker: sorry, was at Dr.'s meeting16:34
jimbakersigmavirus, np16:34
*** Tamayo has joined #craton16:37
*** ahsa518 has joined #craton17:05
*** VW has quit IRC17:07
*** Tamayo has quit IRC17:09
*** VW has joined #craton17:20
*** sballe_ has quit IRC17:33
*** izaakk has quit IRC17:33
*** kencjohnston has quit IRC17:33
*** sulo has quit IRC17:33
*** mhayden has quit IRC17:33
*** sigmavirus has quit IRC17:33
*** johnthetubaguy has quit IRC17:33
*** kencjohnston has joined #craton17:33
*** johnthetubaguy_ has joined #craton17:33
*** sulo has joined #craton17:34
*** johnthetubaguy_ is now known as johnthetubaguy17:34
*** mhayden has joined #craton17:34
*** ChanServ sets mode: +o sulo17:34
*** _sigmavirus24 has joined #craton17:35
*** _sigmavirus24 is now known as sigmavirus17:36
*** sigmavirus has quit IRC17:37
*** sigmavirus has joined #craton17:37
*** ChanServ sets mode: +o sigmavirus17:37
*** sballe_ has joined #craton17:43
*** izaakk has joined #craton17:44
*** valw has quit IRC17:55
*** valw has joined #craton18:00
sigmavirusI'm tempted to rebase https://review.openstack.org/386646 on top of https://review.openstack.org/388139 because the former has some assumptions about project_ids that I think should be resolved. Thoughts?18:11
jimbakersigmavirus, +118:23
sigmavirusjimbaker: +1 rebasing?18:23
jimbakersigmavirus, if there's a dependency here, yes do the rebase18:24
jimbakerbut we can make explicit the process. let me review https://review.openstack.org/38813918:25
jimbakersigmavirus, i think the only thing is whether we should have project_id be (opaque) strings, or further restricted to uuids18:26
sigmavirusjimbaker: so project_id is actually enforced as a UUID18:27
sigmavirussqlalchemy_utils has a UUID Type18:27
jimbakerright, as i see in that review18:27
sigmavirusthere's no real dependency between the two reviews, just a merge conflict18:29
sigmavirusI'll rebase 386646 on top of the new one though for simplicity18:29
syed_sulo: https://review.openstack.org/#/c/384817/18:31
*** VW_ has joined #craton18:33
*** VW_ has quit IRC18:34
*** VW_ has joined #craton18:34
*** VW has quit IRC18:36
*** VW_ has quit IRC18:39
jimbakersigmavirus, so the Dockerfile needs to be updated; see https://github.com/openstack/craton/blob/master/Dockerfile#L17 for what hasn't been changed18:43
jimbakernote that if we try to use an uuid there, generate_fake_data.py fails18:43
jimbakerwith respect to https://review.openstack.org/38813918:43
jimbaker(i always run the Dockerfile as a baseline functional test; syed_ is working on automating this process, eventually to be driven by tox once we make it lightweight)18:43
sigmavirusjimbaker: aha, I use the dockerfile and then run something like my bashs cript18:44
sigmavirusI never noticed the generate-fake-data script before :D18:44
jimbakersigmavirus, no worries. i'm sure we can consolidate testing approaches18:48
jimbakerand must18:48
*** VW has joined #craton18:50
*** valw has quit IRC18:55
*** valw has joined #craton19:02
*** valw_ has joined #craton19:05
*** valw has quit IRC19:06
*** jovon has quit IRC19:07
sigmavirusjimbaker: the revised series should work for you :D19:23
suloi had such a bad headache i could not look at my screen, but nothing 2 neurofen and chinese dinner couldnt fix19:36
sulosyed_: looking19:37
syed_sulo: Glad you are feeling better19:37
sulosyed_: so whats the change in your new patch19:37
suloi see its the same19:37
sulowhat you need to do is restrict what you can update19:38
syed_sulo: i am using   self.assertEqual(resp.json['region_id'], payload['region_id'])19:38
syed_        self.assertEqual(resp.json['project_id'], payload['project_id'])19:38
syed_to assure it stays the same as the one i passed19:38
suloright19:38
syed_isn't this what you meant ?19:38
sulono19:38
syed_So what should i be doing in the case with mocking :/19:39
sulowhat i mean is .. we need to restrict users from updating some of the vlues such has region_id or project_id etc19:39
syed_bit confused on how to restrict19:39
sulonothing to do with testing19:39
syed_oh so in the case of inventory/cells.py19:40
suloso if you create a cell for region 1 then create host for that cell then update region then its going tobe bad19:40
sulothere might be other such cases19:40
suloi havent looked at each and every case19:40
suloproject_id dont need to worry about now after sigmavirus patch, but need to  make sure that there is no ^ type of other cases19:41
sulosyed_: does that make sense ?19:41
syed_so i might need to make changes inventory/cells.py and inventory/hosts.py19:41
suloyeah19:41
syed_i see19:41
suloactually no19:41
syed_ohh19:41
suloits should be as simple as changing schema.py for put19:42
suloand make sure the properties to change are the right ones19:42
sulosee https://github.com/openstack/craton/blob/master/craton/api/v1/schemas.py#L30219:43
sulois using DefinitionsHost .. which allows for certain properteis to be updated19:44
suloif that looks good then just use that .. otherwise create someothing similar but with ony the values we should allow to update19:44
syed_cool19:44
syed_will do that19:44
sulomakes sense ?19:44
syed_yes19:44
syed_perfect sense19:45
sulocool19:45
syed_thank you19:45
sulonp19:45
*** sballe_ has quit IRC19:46
*** sballe_ has joined #craton19:46
*** valw_ has quit IRC19:59
*** VW has quit IRC20:01
*** valw has joined #craton20:02
*** VW has joined #craton20:05
*** ahsa518 has quit IRC20:19
*** valw has quit IRC20:23
*** valw has joined #craton20:39
jimbakersigmavirus, thanks, that patch looks good for project_id's type switch to uuid20:41
*** VW has quit IRC20:44
*** VW has joined #craton20:44
jimbakersigmavirus, just waiting on the update to https://review.openstack.org/#/c/386646/20:50
*** valw has quit IRC20:54
*** Mudpuppy has quit IRC20:58
*** VW has quit IRC21:03
*** syed_ has quit IRC21:15
*** syed_ has joined #craton21:16
*** wirehead_ has quit IRC21:16
*** kencjohnston has quit IRC21:17
*** kencjohnston has joined #craton21:19
*** wirehead_ has joined #craton21:20
syed_sulo: https://review.openstack.org/#/c/384817/21:31
syed_ready for some reviews. Have updated the code for regions, cells and hosts21:31
*** VW has joined #craton21:33
sulosyed_: hosts should have device_type too21:35
syed_sulo: ok will update21:36
jimbakersyed_, were you able to figure out the mock testing for updates?21:36
syed_sulo: kindly see21:50
sulosyed_: think you missed my last comment, check for network_devices and networks21:51
syed_oops just saw21:51
syed_yeah for network21:51
syed_i didn't uploaded tests and this for network21:51
syed_\should i be updating schema for network ?21:52
suloyou need to do the same for networks update21:52
suloand netdevices update21:52
sulosame as region / cell21:52
syed_i see21:53
syed_okay will upload that in a se21:53
syed_sec21:53
syed_should i be uploading tests for network as well ? Or should i be doing that separately ?21:53
syed_since networks tests are missing is already a bug out there ?21:53
*** VW has quit IRC22:12
*** Mudpuppy has joined #craton22:30
*** Mudpuppy has quit IRC22:37
*** Mudpuppy has joined #craton22:38
*** Mudpuppy has quit IRC22:42
« Monday, 2016-10-17 Index Wednesday, 2016-10-19 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!