| openstackgerrit | Eric Kao proposed openstack/congress master: Fix test mocking and disable ceilometer tempest test https://review.openstack.org/515212 | 00:10 |
|---|---|---|
| *** AlexeyAbashkin has joined #congress | 00:29 | |
| *** AlexeyAbashkin has quit IRC | 00:33 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-congressclient master: Updated from global requirements https://review.openstack.org/509451 | 00:51 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-congressclient master: Updated from global requirements https://review.openstack.org/509451 | 00:58 |
| *** AlexeyAbashkin has joined #congress | 01:29 | |
| *** AlexeyAbashkin has quit IRC | 01:33 | |
| *** ekcs has quit IRC | 02:03 | |
| *** catintheroof has joined #congress | 02:24 | |
| openstackgerrit | Merged openstack/congress master: Fix test mocking and disable ceilometer tempest test https://review.openstack.org/515212 | 02:31 |
| *** catintheroof has quit IRC | 02:43 | |
| openstackgerrit | Merged openstack/python-congressclient master: Updated from global requirements https://review.openstack.org/509451 | 03:30 |
| *** ramineni_ has joined #congress | 03:34 | |
| *** ekcs has joined #congress | 04:07 | |
| openstackgerrit | Eric Kao proposed openstack/congress master: Add default configuration files to data_files https://review.openstack.org/509056 | 04:08 |
| openstackgerrit | Eric Kao proposed openstack/congress master: Fix rule in permitted image library policy https://review.openstack.org/514857 | 04:09 |
| openstackgerrit | Eric Kao proposed openstack/congress master: Add tags table to nova driver https://review.openstack.org/509018 | 04:09 |
| *** ekcs has quit IRC | 04:22 | |
| openstackgerrit | Anusha Ramineni proposed openstack/congress-dashboard master: dashboard: View library policies https://review.openstack.org/512486 | 04:22 |
| *** ramineni_1 has joined #congress | 04:25 | |
| *** ramineni_ has quit IRC | 04:28 | |
| *** ramineni_ has joined #congress | 04:55 | |
| *** ramineni_1 has quit IRC | 04:56 | |
| openstackgerrit | Merged openstack/congress master: Call base from_dict in RequestContext https://review.openstack.org/510981 | 05:16 |
| openstackgerrit | Merged openstack/congress master: Replace the usage of some aliases in tempest https://review.openstack.org/509331 | 05:20 |
| openstackgerrit | Merged openstack/congress master: omit openstackdocstheme for READTHEDOCS https://review.openstack.org/511621 | 05:20 |
| *** ekcs has joined #congress | 05:22 | |
| *** ramineni_1 has joined #congress | 05:40 | |
| *** ramineni_ has quit IRC | 05:40 | |
| ramineni_1 | ekcs: hi | 05:42 |
| *** masahito has joined #congress | 05:52 | |
| *** ramineni_1 has quit IRC | 05:59 | |
| *** ramineni_ has joined #congress | 06:05 | |
| ekcs | hi ramineni ramineni_1 | 06:07 |
| ramineni_ | ekcs: have one question | 06:10 |
| ekcs | yup whats up? | 06:10 |
| ramineni_ | https://github.com/openstack/congress/blob/master/congress/api/library_policy_model.py#L68 | 06:10 |
| ramineni_ | get_item should ideally retrieve by both id and name | 06:10 |
| ramineni_ | is name unique in case of library policies | 06:11 |
| ramineni_ | ? | 06:11 |
| ramineni_ | ekcs: ? | 06:13 |
| ramineni_ | its needed from horizon actually , i want to update that function to retrieve from both id and name .. but would like to confirm with u first | 06:13 |
| ramineni_ | is it ok if u update the same | 06:14 |
| ramineni_ | if I update the same ** | 06:16 |
| ekcs | got it. can we use this method instead? the design was to use that one to retrieve by name. https://github.com/openstack/congress/blob/master/congress/api/library_policy_model.py#L34 | 06:18 |
| ramineni_ | ekcs: yes, but to make it consistent with policy /get_item it should be retrievable by name also if its unique? | 06:19 |
| *** ramineni_1 has joined #congress | 06:23 | |
| *** ramineni_ has quit IRC | 06:25 | |
| ekcs | when we discussed it before I took the positon that we don’t want to necessarily commit ourselves to unique names. and then need to break API if we see a reason to change that. but we can certainly revisit that if needed. | 06:25 |
| ramineni_1 | if its not unique , how get_policy_by_name works | 06:27 |
| ramineni_1 | ekcs: ^^ | 06:27 |
| ramineni_1 | it will retrieve all policies with same name? | 06:28 |
| ekcs | get_policy_by_name would stop working, but get_policy_by_name is not public API so we can change that. | 06:28 |
| ramineni_1 | it is publick through get_items | 06:28 |
| ramineni_1 | and horizon uses it .. so it breaks dashboard | 06:28 |
| ramineni_1 | if I use the same, it breaks | 06:29 |
| ramineni_1 | ? | 06:29 |
| ekcs | clarification, what get_policy_by_name are you talking about? | 06:30 |
| ekcs | congress/library_service/library_service.py ? | 06:30 |
| ramineni_1 | yes | 06:30 |
| ramineni_1 | so its not recommended to use https://github.com/openstack/congress/blob/master/congress/api/library_policy_model.py#L34 , as it might break functionality in dashboard right | 06:32 |
| ramineni_1 | as u suggested | 06:32 |
| ekcs | it’s not a public API, so we can change it. along with congress components that use it. | 06:33 |
| ramineni_1 | ekcs: i dont understand , what do you mean by its not puclic API | 06:34 |
| ekcs | so if we make names non-unique, then we’d change get_policy_by_name, change the implementation of get_items, but keep the interface of get_items. | 06:34 |
| ramineni_1 | if users use non-unique names , now it breaks right | 06:35 |
| ramineni_1 | we are restrciting in any way? | 06:35 |
| ramineni_1 | ok, got it , ill update accoridngly | 06:37 |
| ekcs | haha you do? i’m trying to think how to explain it. but tired haha | 06:37 |
| ramineni_1 | ill change the horizon , so that it requires minimal changes when change happens | 06:37 |
| ramineni_1 | ekcs: https://github.com/openstack/congress/blob/master/congress/db/db_library_policies.py#L32 | 06:37 |
| ramineni_1 | just saw this | 06:37 |
| ekcs | i’m actually surprised that horizon needs to retrieve by name. | 06:38 |
| ramineni_1 | ekcs: u told to remove id | 06:38 |
| ramineni_1 | so, thought ill retrieve by name , as thought it is unique as like policies | 06:38 |
| ramineni_1 | but i think i better keep id | 06:39 |
| ramineni_1 | but make it hidden, will be better idea | 06:39 |
| ekcs | i see what you mean. ideally we display name only but horizon remembers ID and retrieve by ID. | 06:39 |
| ramineni_1 | so no issues, non-unique/uniue :) | 06:39 |
| ekcs | ah right that’s what you just said. | 06:39 |
| ekcs | as long as it’s not too hard. if it’s too hard then we find different way. | 06:40 |
| ramineni_1 | ekcs: great, thanks, it shouldnt be :) | 06:40 |
| ekcs | ramineni_1: awesomeness. | 06:41 |
| ekcs | ramineni_1: do you want me to explain more about “what i meant by public API” and how that is different from congress/library_service/library_service.py: get_policy_by_name ? | 06:41 |
| ekcs | I’m going to sleep soon but I can follow up in email. i want to be clear what i mean then you can understand and tell me where you agree and disagree. | 06:43 |
| ramineni_1 | ekcs: no, i think should be fine , thanks .. i remeber lot of discussion happened on this before .. but dont remeber .. so pinged u . i think ill check back those if required | 06:44 |
| ekcs | because your opinion is important =) | 06:44 |
| ramineni_1 | ekcs: will get back u .. if have any doubt | 06:44 |
| ramineni_1 | :) | 06:44 |
| ekcs | ok then =) | 06:44 |
| ekcs | have a good day! i’m going to sleep | 06:44 |
| *** ekcs has quit IRC | 06:46 | |
| *** ramineni_1 has quit IRC | 06:52 | |
| *** ramineni_ has joined #congress | 07:12 | |
| openstackgerrit | Merged openstack/congress master: Add tags table to nova driver https://review.openstack.org/509018 | 07:25 |
| openstackgerrit | Merged openstack/congress master: Add default configuration files to data_files https://review.openstack.org/509056 | 07:26 |
| *** AlexeyAbashkin has joined #congress | 07:58 | |
| *** AlexeyAbashkin has quit IRC | 08:01 | |
| *** AlexeyAbashkin has joined #congress | 08:01 | |
| *** AlexeyAbashkin has quit IRC | 08:21 | |
| *** AlexeyAbashkin has joined #congress | 08:23 | |
| *** ramineni_ has quit IRC | 08:29 | |
| *** ramineni_ has joined #congress | 08:57 | |
| *** ramineni_1 has joined #congress | 09:01 | |
| *** ramineni_ has quit IRC | 09:03 | |
| openstackgerrit | Anusha Ramineni proposed openstack/congress-dashboard master: dashboard: View library policies https://review.openstack.org/512486 | 09:10 |
| *** ramineni_1 has quit IRC | 10:01 | |
| *** ramineni_ has joined #congress | 10:03 | |
| *** masahito has quit IRC | 10:12 | |
| openstackgerrit | Anusha Ramineni proposed openstack/congress-dashboard master: WIP: List rules for library policies https://review.openstack.org/516631 | 11:50 |
| *** ramineni_1 has joined #congress | 12:03 | |
| *** ramineni_ has quit IRC | 12:06 | |
| *** catintheroof has joined #congress | 12:31 | |
| *** catintheroof has quit IRC | 12:32 | |
| *** catintheroof has joined #congress | 12:32 | |
| *** Dinesh_Bhor has quit IRC | 12:47 | |
| *** zhurong has joined #congress | 12:50 | |
| *** AlexeyAbashkin has quit IRC | 13:10 | |
| *** AlexeyAbashkin has joined #congress | 13:11 | |
| *** zhurong has quit IRC | 13:42 | |
| *** ramineni_1 has quit IRC | 13:53 | |
| *** catintheroof has quit IRC | 14:12 | |
| *** catintheroof has joined #congress | 14:14 | |
| *** catintheroof has quit IRC | 14:30 | |
| *** catintheroof has joined #congress | 14:35 | |
| *** AlexeyAbashkin has quit IRC | 15:23 | |
| *** AlexeyAbashkin has joined #congress | 15:23 | |
| *** catintheroof has quit IRC | 15:34 | |
| *** catintheroof has joined #congress | 15:40 | |
| *** catintheroof has quit IRC | 15:42 | |
| *** AlexeyAbashkin has quit IRC | 15:48 | |
| *** catintheroof has joined #congress | 16:40 | |
| *** catintheroof has quit IRC | 16:45 | |
| *** ekcs has joined #congress | 16:52 | |
| *** ramineni has quit IRC | 17:03 | |
| *** ramineni has joined #congress | 17:04 | |
| *** catintheroof has joined #congress | 17:12 | |
| *** ekcs has quit IRC | 17:19 | |
| *** AlexeyAbashkin has joined #congress | 17:20 | |
| *** AlexeyAbashkin has quit IRC | 17:24 | |
| *** AlexeyAbashkin has joined #congress | 18:29 | |
| *** AlexeyAbashkin has quit IRC | 18:33 | |
| *** ekcs has joined #congress | 18:38 | |
| openstackgerrit | Eric Kao proposed openstack/congress master: Use oslo.context from_dict unmodified https://review.openstack.org/513521 | 18:50 |
| openstackgerrit | Eric Kao proposed openstack/congress master: Fix rule in permitted image library policy https://review.openstack.org/514857 | 19:00 |
| *** catintheroof has quit IRC | 19:14 | |
| *** ekcs has quit IRC | 19:17 | |
| *** ekcs has joined #congress | 19:41 | |
| *** catintheroof has joined #congress | 19:55 | |
| *** AlexeyAbashkin has joined #congress | 20:27 | |
| *** AlexeyAbashkin has quit IRC | 20:31 | |
| *** catintheroof has quit IRC | 21:09 | |
| *** AlexeyAbashkin has joined #congress | 21:27 | |
| *** AlexeyAbashkin has quit IRC | 21:31 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!