rafaelweingartner | #startmeeting cloudkitty | 14:00 |
---|---|---|
opendevmeet | Meeting started Mon Aug 5 14:00:40 2024 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
rafaelweingartner | Hello guys! | 14:00 |
rafaelweingartner | Roll count | 14:00 |
rafaelweingartner | \O | 14:00 |
priteau | o/ | 14:00 |
rafaelweingartner | #topic Target reviews | 14:03 |
rafaelweingartner | We merged #link https://review.opendev.org/c/openstack/cloudkitty/+/876643, and now, I guess we should merge #link https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382. | 14:03 |
rafaelweingartner | can we proceed? | 14:03 |
priteau | If it passes tests now. | 14:04 |
rafaelweingartner | the other code was not merged | 14:05 |
rafaelweingartner | how does it work? | 14:05 |
opendevreview | Pierre Riteau proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 14:05 |
priteau | I've rebased it | 14:05 |
mkarpiarz | OK | 14:05 |
rafaelweingartner | ok, thanks | 14:06 |
rafaelweingartner | because the other patch was not merged, as it depends on this one | 14:06 |
rafaelweingartner | I do not know how it works in Zuul | 14:06 |
priteau | We had these issues with another patch set before | 14:07 |
priteau | I am not sure we are doing it correctly | 14:07 |
rafaelweingartner | me neither | 14:08 |
rafaelweingartner | I have never worked with a circular patch as this one | 14:08 |
rafaelweingartner | anyways, moving on while that one is executing | 14:10 |
rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/915992, is waiting for the author response now | 14:10 |
priteau | But remember that the tempest repo is branchless | 14:10 |
rafaelweingartner | also waiting the author response #link https://review.opendev.org/c/openstack/cloudkitty/+/915479 | 14:11 |
priteau | So the master branch of cloudkitty-tempest-plugin is being used to test stable branches of cloudkitty | 14:11 |
priteau | You can't just start depending on a new behaviour in master | 14:11 |
rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/921339 is waiting for the author fixes/amends | 14:11 |
rafaelweingartner | priteau: I think that I did not get it | 14:14 |
rafaelweingartner | so, what would be the process to merge a feature/process such as this one that we have | 14:14 |
priteau | Probably with some configuration variable that tells tempest which behaviour to use | 14:15 |
rafaelweingartner | besides those patches I listed, and this one that we are discussing that is all from my side | 14:20 |
rafaelweingartner | let's see if we can merge this one | 14:20 |
mattcrees | o/ | 14:21 |
priteau | rafaelweingartner: Do you think Pedro or yourself can look at updating the tempest patch to support multiple branches? | 14:26 |
rafaelweingartner | do we need it? | 14:27 |
priteau | Did you see my messages just above? | 14:28 |
priteau | The master branch of cloudkitty-tempest-plugin is being used to test stable branches of cloudkitty | 14:28 |
priteau | So we need test code that supports all maintained versions | 14:28 |
rafaelweingartner | yes, I did | 14:36 |
rafaelweingartner | but that is what i do not understand | 14:36 |
priteau | I am not sure how to explain it in other terms. Which part is unclera? | 14:38 |
priteau | unclear | 14:38 |
rafaelweingartner | =) openstack design sometimes make me very confusing | 14:38 |
rafaelweingartner | I see, the guys are reusing the same set of tests, and applying it to all code branches | 14:38 |
rafaelweingartner | therefore, the functional tests are appart, and when we merge something in upstream, and not in the other branches (code branches), then the functional tests do not pass | 14:39 |
rafaelweingartner | therefore, then one needs to maitain more functional tests | 14:39 |
rafaelweingartner | then, this also needs to be propagate to other configurations I guess | 14:39 |
rafaelweingartner | so much effort to so little gain | 14:39 |
rafaelweingartner | I will discuss with Pedro, and see what we can do | 14:41 |
rafaelweingartner | have no idea where to change things, and what to do, but we will see what needs to be done | 14:41 |
rafaelweingartner | it would be easier to version all of them together, if they depend on each other =), but go figure right... there is always a good reason to make things more complicated | 14:44 |
rafaelweingartner | I already added this here as well to us | 14:45 |
rafaelweingartner | besides these, and the others thare are kind of stuck, I do not have anything else for today's meeting | 14:45 |
mkarpiarz | I have an annoucement to make. | 14:45 |
mkarpiarz | I can no longer devote time to the project on a regular basis and so I've decided I'll be stepping down as a core reviewer by the end of this month. | 14:46 |
mkarpiarz | I'll still be keeping an eye on changes from time to time but won't be joining IRC meetings nor PTGs. | 14:46 |
rafaelweingartner | It is said to see you go mkarpiarz | 14:46 |
rafaelweingartner | but it has been a pleasure to work with you so far | 14:46 |
mkarpiarz | Thanks! I'm really glad to hear this and hopefully, we can find someone who will take my place. | 14:47 |
priteau | Sorry to have to say good bye Mariusz | 14:47 |
mkarpiarz | It's been a pleaure to work with you guys. :) | 14:48 |
mkarpiarz | Please let me know what you want to do when it comes to announcing these changes on the mailing list. Should I send a message there? | 14:48 |
mkarpiarz | Or wait until we find someone who can step in? | 14:48 |
priteau | Some people announce it on the list, some just go away quietly | 14:48 |
priteau | To be honest CloudKitty is a small project within OpenStack, I am not sure there is a need to send email to everyone | 14:49 |
priteau | In terms of replacement, my colleague mattcrees has been working with CloudKitty for a while. He doesn't have many reviews on this project specifically but he has good experience from other projects | 14:50 |
priteau | I would be happy to nominate him as a core reviewer | 14:50 |
rafaelweingartner | I think that he would be a great fit | 14:50 |
mattcrees | Thanks, I would be happy to step up | 14:51 |
mkarpiarz | Thanks, Matt! | 14:51 |
mkarpiarz | In this case maybe we can send one message nominating Matt to a core reviewer and in it we mention I'll be removed from the core team. | 14:52 |
mkarpiarz | Anyway, that's all from my side. | 14:54 |
rafaelweingartner | ok, that might works | 14:55 |
rafaelweingartner | thanks Mariusz | 14:55 |
mkarpiarz | No, thank you all! :) | 14:57 |
rafaelweingartner | if we do not have anything else, we can close for today | 14:58 |
rafaelweingartner | I will take a look into that merge, and send/talk to you guys via e-mail then | 14:58 |
mkarpiarz | OK | 14:59 |
rafaelweingartner | Thank you guys for participating. Have a nice week. | 15:04 |
rafaelweingartner | #endmeeting | 15:04 |
opendevmeet | Meeting ended Mon Aug 5 15:04:59 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:04 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-08-05-14.00.html | 15:04 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-08-05-14.00.txt | 15:04 |
opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2024/cloudkitty.2024-08-05-14.00.log.html | 15:04 |
mattcrees | Cheers | 15:05 |
opendevreview | Rafael Weingartner proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 15:06 |
opendevreview | Rafael Weingartner proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 15:07 |
opendevreview | Pedro Henrique Pereira Martins proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 19:11 |
opendevreview | Pedro Henrique Pereira Martins proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 19:24 |
opendevreview | Pedro Henrique Pereira Martins proposed openstack/cloudkitty-tempest-plugin master: Adapt tests to new rating API https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/892382 | 20:25 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!