| opendevreview | Merged openstack/cloudkitty master: Add rating modules GET endpoints to v2 API https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 13:39 |
|---|---|---|
| rafaelweingartner | Hello guys! | 14:00 |
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon Jun 13 14:00:10 2022 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| rafaelweingartner | \o | 14:00 |
| mkarpiarz | Hi! | 14:00 |
| rafaelweingartner | #topic OpenInfra Summit Berlin 2022 | 14:03 |
| rafaelweingartner | We had two forum panels and one full presentation during the conference | 14:03 |
| priteau | Hello | 14:04 |
| rafaelweingartner | The forum panels responses can be found at https://etherpad.opendev.org/p/cloudkitty-berlin-users-feedback and https://etherpad.opendev.org/p/cloudkitty-berlin-ops-feedback | 14:04 |
| rafaelweingartner | It was a great pleasure to see so many different people using or tying to use CloudKitty | 14:04 |
| rafaelweingartner | I hope that we can get more people collaborating in the future. Also, I really enjoyed meeting you all guys | 14:04 |
| priteau | Likewise! | 14:05 |
| priteau | It was good to meet you both after a long time working together | 14:05 |
| mkarpiarz | Agreed. Meeting you both was definitely a highlight of that day. :) | 14:06 |
| mkarpiarz | And it was nice to see all the people interested in the project. | 14:08 |
| rafaelweingartner | Exactly, I am very happy with that. It was a nice surprise | 14:08 |
| rafaelweingartner | moving on to the reviews | 14:11 |
| rafaelweingartner | #topic Target reviews | 14:11 |
| rafaelweingartner | The patch https://review.opendev.org/c/openstack/cloudkitty/+/684734 has just been merged | 14:11 |
| rafaelweingartner | after we fixed in the last meeting the pipeline, I was able to merge it today | 14:11 |
| mkarpiarz | Awesome! | 14:12 |
| rafaelweingartner | Then, we have the following patch: https://review.opendev.org/c/openstack/cloudkitty/+/837442 | 14:12 |
| rafaelweingartner | you guys already did a review, and I amended the code as requested. | 14:12 |
| rafaelweingartner | I also removed that fix for the broken voluptions from it | 14:13 |
| rafaelweingartner | if you guys have some time to review it, it would be awesome to get this one moving | 14:14 |
| mkarpiarz | I'm currently trying to restore access to my test environment or to create a new one, whichever comes first. | 14:15 |
| mkarpiarz | Then I'll be testing 837442. | 14:15 |
| rafaelweingartner | Then, moving on to the next patch. We have the patch https://review.opendev.org/c/openstack/cloudkitty/+/837200, which has already been approved by Sam and Mariusz | 14:16 |
| rafaelweingartner | that one seems to be ready for merging | 14:16 |
| mkarpiarz | Yes, this one's got a +1 Sam and +2 from me. Should we merge or do you want to give Pierre a chance to review? :) | 14:18 |
| rafaelweingartner | I guess we should wait for Pierre as well | 14:19 |
| rafaelweingartner | since, that is the protocol that we have in place | 14:19 |
| mkarpiarz | Yes, that's fine. | 14:19 |
| priteau | I am looking at it now | 14:20 |
| rafaelweingartner | awesome, thanks! | 14:20 |
| mkarpiarz | So as part of the protocol do we want at least +4 before any change is merged? | 14:22 |
| mkarpiarz | So either two core reviewers or one core and two +1s? | 14:22 |
| mkarpiarz | Or four +1s? :) | 14:22 |
| rafaelweingartner | hmm | 14:23 |
| rafaelweingartner | I thought that it has to be two core reviews | 14:23 |
| rafaelweingartner | but now, if the core reviews give a +1 | 14:23 |
| rafaelweingartner | then, well, I am not sure what we would do | 14:23 |
| priteau | +1 don't count | 14:23 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Allow rating rules that have 12 digits in the integer part of the number https://review.opendev.org/c/openstack/cloudkitty/+/837200 | 14:25 |
| priteau | I just made a slight formatting change | 14:25 |
| mkarpiarz | Sure thing. | 14:26 |
| rafaelweingartner | thanks! | 14:27 |
| priteau | I'll give my +2 once the release note build is complete | 14:28 |
| mkarpiarz | OK | 14:28 |
| rafaelweingartner | ok, thanks! | 14:29 |
| rafaelweingartner | so, moving on | 14:29 |
| rafaelweingartner | I also opened two python client patches | 14:29 |
| rafaelweingartner | https://review.opendev.org/c/openstack/python-cloudkittyclient/+/839052 and https://review.opendev.org/c/openstack/python-cloudkittyclient/+/838724 | 14:29 |
| rafaelweingartner | it would be nice to get them reviewed | 14:30 |
| rafaelweingartner | it will make available the new apis creates in the CLI | 14:30 |
| mkarpiarz | Thanks! These should be handy to have. :) | 14:31 |
| mkarpiarz | Yes, I'll be testing them soon as well. | 14:31 |
| rafaelweingartner | awesome, thanks! | 14:31 |
| rafaelweingartner | and, after those, we have the following patches: https://review.opendev.org/c/openstack/cloudkitty/+/710500 and https://review.opendev.org/c/openstack/cloudkitty/+/824745, which I reviewed | 14:32 |
| rafaelweingartner | but I did not get feedback from the authors | 14:32 |
| rafaelweingartner | I am not sure how to move on there | 14:33 |
| priteau | I will need to pick up the Elasticsearch one, but no time at the moment | 14:34 |
| priteau | The original author has left our company | 14:34 |
| mkarpiarz | 710500 also appears to be related to Elasticsearch... | 14:36 |
| priteau | That's the one I am talking about | 14:37 |
| rafaelweingartner | ok | 14:38 |
| rafaelweingartner | thanks | 14:38 |
| mkarpiarz | I'm not sure what to do with 824745 then. I can at least try to enable Elasticsearch in my test environment. | 14:40 |
| rafaelweingartner | from my side, that was all about the reviews | 14:42 |
| rafaelweingartner | do you guys have something to add? | 14:42 |
| mkarpiarz | Nothing from my side. | 14:43 |
| priteau | Nothing else from me | 14:44 |
| rafaelweingartner | ok, cool | 14:44 |
| rafaelweingartner | and besides the reviews | 14:44 |
| rafaelweingartner | do you guys have something else? | 14:44 |
| mkarpiarz | Nope. | 14:45 |
| rafaelweingartner | Thank you guys for participating. I enjoyed it a lot meeting you guys, and I hope we can meet again in the next conferences. Have a nice week. | 14:46 |
| mkarpiarz | Thanks, Rafael! | 14:48 |
| rafaelweingartner | #endmeeting | 14:49 |
| opendevmeet | Meeting ended Mon Jun 13 14:49:42 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:49 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-06-13-14.00.html | 14:49 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-06-13-14.00.txt | 14:49 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-06-13-14.00.log.html | 14:49 |
| priteau | mkarpiarz: if you are still happy with https://review.opendev.org/c/openstack/cloudkitty/+/837200, let's merge | 15:08 |
| opendevreview | Rafael Weingartner proposed openstack/python-cloudkittyclient master: Introduce the patch scope API in the CLI https://review.opendev.org/c/openstack/python-cloudkittyclient/+/838724 | 16:11 |
| opendevreview | Rafael Weingartner proposed openstack/python-cloudkittyclient master: Introduce reprocessing task API in the CLI https://review.opendev.org/c/openstack/python-cloudkittyclient/+/839052 | 16:12 |
| opendevreview | Merged openstack/cloudkitty master: Allow rating rules that have 12 digits in the integer part of the number https://review.opendev.org/c/openstack/cloudkitty/+/837200 | 17:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!