| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Introduce reprocessing API https://review.opendev.org/c/openstack/cloudkitty/+/799207 | 11:33 |
|---|---|---|
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Introduce reprocessing API https://review.opendev.org/c/openstack/cloudkitty/+/799207 | 12:42 |
| rafaelweingartner | Hello guys! | 13:58 |
| mkarpiarz | Hi! | 13:59 |
| rafaelweingartner | #startmeeting cloudkitty | 14:00 |
| opendevmeet | Meeting started Mon Feb 7 14:00:18 2022 UTC and is due to finish in 60 minutes. The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cloudkitty' | 14:00 |
| rafaelweingartner | Roll count | 14:00 |
| priteau | o/ | 14:00 |
| mkarpiarz | Hi! | 14:01 |
| rafaelweingartner | #topic Target review of meeting | 14:04 |
| rafaelweingartner | We have the following patches as target for this meeting. | 14:04 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/799207 | 14:04 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/684734 | 14:04 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/775359 | 14:04 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/685344 | 14:04 |
| rafaelweingartner | #link https://review.opendev.org/c/openstack/cloudkitty/+/824745 | 14:04 |
| rafaelweingartner | starting with: #link https://review.opendev.org/c/openstack/cloudkitty/+/824745 | 14:05 |
| rafaelweingartner | have you guys been able to review it? | 14:05 |
| priteau | Not yet | 14:06 |
| rafaelweingartner | my biggest question there is that, "is it backward compatible" | 14:07 |
| rafaelweingartner | looking at the code, it feels like it is not going to work with previous versions of ES | 14:07 |
| rafaelweingartner | but, of course, I am not that familiar with ES API | 14:08 |
| rafaelweingartner | so, I might be mistaken | 14:08 |
| mkarpiarz | No, my test environment is set up for 799207. I will be looking at picking up another change for review. | 14:08 |
| mkarpiarz | Should I take 824745 next then or is there something more urgent? | 14:08 |
| priteau | That's a good question. I'll check with Isaac (he's my colleague). It says that it needs ES 7, do we have requirements for keeping compatibility with earlier versions? | 14:09 |
| rafaelweingartner | no, we do not need | 14:10 |
| rafaelweingartner | specially, EOL versions | 14:10 |
| rafaelweingartner | but, we need to warn users that we only support, let's say ES 7+ | 14:11 |
| priteau | Kolla Ansible has been providing Elasticsearch 7 since Wallaby. | 14:11 |
| priteau | I don't know about other deployment tools | 14:11 |
| priteau | A related question is what would be the migration path from existing index layout? | 14:12 |
| mkarpiarz | I agree, if ES 6 is EOL, we should not worry about backward compatibility. | 14:12 |
| rafaelweingartner | exactly | 14:12 |
| rafaelweingartner | but we need to warn users of the drop support for ES 6 | 14:12 |
| mkarpiarz | For sure. | 14:13 |
| rafaelweingartner | I dropped a message there, asking for more information | 14:13 |
| mkarpiarz | I'm not sure we have the manpower to come up with a index migration script/path but it would be nice. | 14:13 |
| rafaelweingartner | exactly, but I guess that is more responsability for the operation of upgrade between ES 6 and 7, then for CloudKitty | 14:15 |
| priteau | Well, upgrade from ES 6 to 7 is not a problem, that's handled by Elasticsearch itself | 14:16 |
| rafaelweingartner | Do we need to worry about the index layout? Anybody coming from ES 6 would not be using it | 14:17 |
| rafaelweingartner | therefore, as long as they do not change the configs, it should work, right? | 14:18 |
| priteau | I need to review the patch in more detail :) | 14:19 |
| rafaelweingartner | Ok | 14:20 |
| rafaelweingartner | we can review it until next meeting, and then we discuss again | 14:20 |
| rafaelweingartner | hopefully, with some feedback from the author | 14:20 |
| mkarpiarz | I agree. | 14:23 |
| rafaelweingartner | Moving on to: https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/685344 | 14:23 |
| rafaelweingartner | I would like to dedicate some time for the tempest tests for V2 API | 14:23 |
| rafaelweingartner | have you guys worked with it? | 14:23 |
| mkarpiarz | I've only worked with Tempest through Rally and only with predefined test scenarios. | 14:25 |
| rafaelweingartner | I see | 14:25 |
| priteau | I've contributed some scenarios for another project, but it was a long time ago | 14:25 |
| rafaelweingartner | Well, I will try to put some energy there, but if you guys have some hints, I would appreciate | 14:26 |
| rafaelweingartner | I think that we need tempest tests for cloudkitty for the V2 aPI | 14:26 |
| rafaelweingartner | to make the system more solid during releases | 14:26 |
| mkarpiarz | OK | 14:28 |
| priteau | Agreed | 14:30 |
| rafaelweingartner | moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/775359, I need to amend the patch. Therefore, at least from my side, I do not have anything to add about it. Do you guys have anything? | 14:31 |
| mkarpiarz | Nothing yet. | 14:34 |
| priteau | I am confused by the config sample update | 14:35 |
| rafaelweingartner | I thought that it was auto generated by tox | 14:35 |
| rafaelweingartner | but that is a point to raise there as well | 14:35 |
| priteau | It would be generated by tox -e genconfig | 14:36 |
| priteau | But you don't have to commit it | 14:36 |
| priteau | It should be a separate commit | 14:36 |
| rafaelweingartner | I see | 14:36 |
| rafaelweingartner | so I can remove it then | 14:36 |
| rafaelweingartner | when I amend the patch | 14:36 |
| priteau | Do you run tox without args? | 14:36 |
| rafaelweingartner | yes | 14:36 |
| rafaelweingartner | I means, which args? | 14:37 |
| rafaelweingartner | I run tox -e <tox_operations_I want,... ex. pep8, py37, and so on> | 14:37 |
| priteau | For example you can run `tox -e pep8` or `tox -e py3`, depending on what you want to run | 14:37 |
| priteau | OK | 14:37 |
| priteau | And this generated the updated config? | 14:37 |
| rafaelweingartner | normally, no | 14:38 |
| priteau | Just an accident then | 14:41 |
| rafaelweingartner | Moving on to: https://review.opendev.org/c/openstack/cloudkitty/+/684734. I approved the patch. I think that it is ready to go. What about you guys? | 14:42 |
| priteau | From a quick look it seems ok. There is also a config update though. | 14:44 |
| priteau | Also should the commit message say /v2? | 14:45 |
| rafaelweingartner | yes | 14:45 |
| priteau | Nevermind, I misunderstood | 14:45 |
| rafaelweingartner | that is what it is doing, right? | 14:45 |
| priteau | They meant implement the endpoints that already exist at /v1 into the v2 api | 14:45 |
| rafaelweingartner | should we create a ptch to update the config sampel file? Then, the diffs in all other patches would dissappear | 14:45 |
| priteau | Sounds good | 14:46 |
| priteau | I left a couple of comments | 14:46 |
| rafaelweingartner | great, thanks | 14:46 |
| rafaelweingartner | I will put on my list this patch then | 14:47 |
| rafaelweingartner | to update the config samples | 14:47 |
| rafaelweingartner | and, finally, the last one, my patch: https://review.opendev.org/c/openstack/cloudkitty/+/799207. I amenede the code with Mariusz suggestions, and I would appriaciate your feedback guys. | 14:51 |
| rafaelweingartner | amended* | 14:54 |
| mkarpiarz | I'm waiting for results from reprocessing but with the latest patch this change seems to be working. | 14:55 |
| rafaelweingartner | awesome! | 14:55 |
| rafaelweingartner | thanks for helping me on this one | 14:55 |
| mkarpiarz | Sure thing! | 14:55 |
| rafaelweingartner | We are almost running out of time, do you guys have anything else to add? | 14:55 |
| opendevreview | Pierre Riteau proposed openstack/cloudkitty master: Update sample configuration file https://review.opendev.org/c/openstack/cloudkitty/+/828163 | 14:55 |
| priteau | rafaelweingartner: I did the config file update ^ | 14:55 |
| rafaelweingartner | ah | 14:56 |
| rafaelweingartner | thanks | 14:56 |
| mkarpiarz | Nothing from my side. | 14:57 |
| rafaelweingartner | Thank you guys for participating. Have a nice week. | 14:58 |
| rafaelweingartner | #endmeeting | 14:58 |
| opendevmeet | Meeting ended Mon Feb 7 14:58:22 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:58 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-02-07-14.00.html | 14:58 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-02-07-14.00.txt | 14:58 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cloudkitty/2022/cloudkitty.2022-02-07-14.00.log.html | 14:58 |
| mkarpiarz | Thanks, guys! | 14:58 |
| priteau | Thanks, good bye | 14:59 |
| opendevreview | Merged openstack/cloudkitty-tempest-plugin master: Add stable/xena jobs on master gate https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/825194 | 15:57 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Avoid DivByZero if there is no metrics to collect https://review.opendev.org/c/openstack/cloudkitty/+/775359 | 16:06 |
| opendevreview | Rafael Weingartner proposed openstack/cloudkitty master: Avoid DivByZero if there is no metrics to collect https://review.opendev.org/c/openstack/cloudkitty/+/775359 | 16:07 |
| opendevreview | Merged openstack/cloudkitty-tempest-plugin master: Update python testing classifier https://review.opendev.org/c/openstack/cloudkitty-tempest-plugin/+/822475 | 17:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!