| *** zhurong has quit IRC | 00:05 | |
| *** zhurong has joined #cloudkitty | 01:13 | |
| *** zhangguoqing has joined #cloudkitty | 01:31 | |
| *** zhangguoqing has quit IRC | 01:44 | |
| *** zhangguoqing has joined #cloudkitty | 01:44 | |
| openstackgerrit | zhangguoqing proposed openstack/cloudkitty-dashboard: Adjust the reporting page https://review.openstack.org/359546 | 02:14 |
|---|---|---|
| openstackgerrit | zhangguoqing proposed openstack/cloudkitty-dashboard: Adjust the reporting page https://review.openstack.org/359546 | 02:40 |
| *** gongysh has joined #cloudkitty | 03:03 | |
| zhangguoqing | I have propesed several path with cloudkitty-dashboard, please reviem them, thank you. | 03:03 |
| zhangguoqing | https://review.openstack.org/#/q/project:openstack/cloudkitty-dashboard | 03:04 |
| *** gongysh has quit IRC | 03:59 | |
| *** peschk_l has joined #cloudkitty | 07:05 | |
| *** zhangguoqing has quit IRC | 09:20 | |
| *** zhangguoqing has joined #cloudkitty | 09:21 | |
| *** zhurong has quit IRC | 09:59 | |
| openstackgerrit | Guillaume Espanel proposed openstack/cloudkitty: Use local.conf instead of localrc in devstack doc https://review.openstack.org/359769 | 11:01 |
| *** zhangguoqing has quit IRC | 13:25 | |
| *** zhangguoqing has joined #cloudkitty | 13:26 | |
| *** openstackgerrit has quit IRC | 13:26 | |
| *** openstackgerrit has joined #cloudkitty | 13:26 | |
| *** zhurong has joined #cloudkitty | 13:37 | |
| *** zhurong has quit IRC | 13:41 | |
| *** zhurong has joined #cloudkitty | 13:42 | |
| zhangguoqing | @Guillaume Espanel, please review https://review.openstack.org/#/c/357680/ again. | 14:15 |
| zhangguoqing | I hope that we can speed up the process, if cloudkitty will be used widely. | 14:16 |
| zhangguoqing | The rating is key of cloud, more and more cloud environments desired it. | 14:18 |
| zhangguoqing | I have worked on telemetry(ceilometer,gnocchi) last year, which is advantage and I'm interesting on cloudkitty. | 14:23 |
| zhangguoqing | let's come on. thanks :) | 14:23 |
| Qu4tre | Hi zhangguoqing we are trying to be more reactive with the reviews | 14:33 |
| Qu4tre | as for 357680, we really need to understand what the review is doing | 14:34 |
| Qu4tre | maybe we can talk about it on IRC and come up with a better commit message | 14:35 |
| *** zhangguoqing has quit IRC | 14:52 | |
| *** zhangguoqing has joined #cloudkitty | 14:52 | |
| zhangguoqing | Qu4tre: what commit message is appropriate? i really don't know how to write. | 14:57 |
| *** zhangguoqing has quit IRC | 14:59 | |
| *** zhangguoqing has joined #cloudkitty | 15:00 | |
| zhangguoqing | I think the original rpc module make the thing a little complex, especially on api RPCHook and service. | 15:02 |
| Qu4tre | So thats a good start | 15:03 |
| zhangguoqing | yeah, we need more discuss and communication. :) | 15:05 |
| Qu4tre | You can say you simp[lified the service part | 15:05 |
| Qu4tre | I see you removed the rpc module and replaced it with messaging, this is worth writing in the commit message I think | 15:06 |
| zhangguoqing | yes, good point. | 15:06 |
| *** zhurong has quit IRC | 15:08 | |
| zhangguoqing | Improve the rpc module | 15:10 |
| zhangguoqing | 1. Removed the rpc module and replaced it with messaging. | 15:10 |
| zhangguoqing | 2. Simplified the service part and RPCHook for api. | 15:10 |
| zhangguoqing | how about? | 15:10 |
| Qu4tre | I think it's better | 15:20 |
| zhangguoqing | OK, I will repush right now. | 15:21 |
| openstackgerrit | zhangguoqing proposed openstack/cloudkitty: Improve the rpc module https://review.openstack.org/357680 | 15:22 |
| zhangguoqing | And can we discuss a bug now? | 15:24 |
| zhangguoqing | https://bugs.launchpad.net/cloudkitty/+bug/1615941 | 15:24 |
| openstack | Launchpad bug 1615941 in cloudkitty "ClientHashMapError: You must specify either service_uuid, field_uuid or group_uuid." [Undecided,New] - Assigned to zhangguoqing (474751729-o) | 15:24 |
| *** sergio_nubeliu has quit IRC | 15:31 | |
| Qu4tre | yes? | 15:48 |
| zhangguoqing | I have get the reason, and I have two ways to fix it, but I'm not sure which is better. | 15:48 |
| Qu4tre | ah yes either in the dashboard or in the API? | 15:49 |
| zhangguoqing | cloudkitty-api | 15:49 |
| zhangguoqing | can not obtain the whole of group information on dashboard | 15:49 |
| zhangguoqing | the first way: fix the cloudkitty source codes cloudkitty/rating/hash/db/sqlalchemy/api.py, remove the elif clause in list_mappings and list_thresholds. Then it may influence the python-cloudkitty. | 15:52 |
| zhangguoqing | the second way: fix the cloudkitty-dashboard directy cloudkittydashboard/dashboards/admin/hashmap/views.py what give completely parameters when mappings.findall and thresholds.findall. | 15:53 |
| zhangguoqing | I think the second way is too clumsy, because it should obtain all services to give completely parameters and not easy to get all. so I can't decide which way is better, could you help me? | 15:56 |
| Qu4tre | I think a mapping is either linked to a service or a field | 15:56 |
| Qu4tre | but you are trying to get all the mappings that belong to a group? | 15:57 |
| *** peschk_l has quit IRC | 15:57 | |
| zhangguoqing | yes, the cloudkitty-dashboard do that. | 15:57 |
| zhangguoqing | https://github.com/openstack/cloudkitty-dashboard/blob/master/cloudkittydashboard/dashboards/admin/hashmap/views.py#L414 | 15:59 |
| zhangguoqing | and #L419 | 15:59 |
| Qu4tre | indeed that looks like a mistake in the db api.py | 16:00 |
| Qu4tre | But i'm not sure it would work without the joins on either service of field | 16:02 |
| Qu4tre | you can try by changing elif not service_uuid and not field_uuid: to elif not service_uuid and not field_uuid and not group_uuid: ? | 16:02 |
| zhangguoqing | mappings = ck_client.hashmap.mappings.findall(group_id=group_id) | 16:05 |
| zhangguoqing | thresholds = ck_client.hashmap.thresholds.findall(group_id=group_id) | 16:05 |
| zhangguoqing | In dashboard only give the one parameter group_id, which case this error. | 16:06 |
| Qu4tre | yes | 16:07 |
| Qu4tre | bu there's no field_uuid or a service_uuid in the dashboard | 16:07 |
| zhangguoqing | your means, I fix the cloudkitty-api is a better way? | 16:07 |
| Qu4tre | I think yes, if it works | 16:08 |
| zhangguoqing | ok, I will try, and it's my inclined way. | 16:10 |
| zhangguoqing | take a minute, other problem: https://review.openstack.org/#/c/355869/ | 16:11 |
| zhangguoqing | https://review.openstack.org/#/c/359179/ the same wrong with image. | 16:11 |
| Qu4tre | So Itake it this is a bug | 16:13 |
| zhangguoqing | yeah, review 355869 again please. | 16:14 |
| zhangguoqing | maybe, i should update the commit message? | 16:14 |
| Qu4tre | The commit message needs some updating yes | 16:15 |
| Qu4tre | But if it's a bug, can you create one in the launchpad and link it to the change? | 16:15 |
| Qu4tre | It will make it easyer for the other devs to know why you are making this change | 16:15 |
| zhangguoqing | ok! | 16:15 |
| Qu4tre | Maybe ceilometer has changed somethings in the frame format | 16:16 |
| zhangguoqing | yes, I will ensure it and describe it on new bug. | 16:18 |
| Qu4tre | Ok, once this is done we will as Gauvain to review it again | 16:20 |
| zhangguoqing | Good, a happy day with you, and indeed we need more more discuss and communication in the future. thank you again. I will fix them tomorrow. good night :) | 16:21 |
| Qu4tre | it's the end of hollidays here, so we have other things to work on but I agree | 16:23 |
| Qu4tre | We are trying to improve the review process but it tqkes time | 16:24 |
| zhangguoqing | yes, let's come on. Bye | 16:25 |
| *** zhangguoqing has quit IRC | 16:29 | |
| *** sergio_nubeliu has joined #cloudkitty | 17:25 | |
| *** huats has quit IRC | 21:03 | |
| *** cgayan has quit IRC | 21:04 | |
| *** sergio_nubeliu has quit IRC | 21:15 | |
| *** sheeprine has quit IRC | 22:55 | |
| *** sheeprine has joined #cloudkitty | 22:58 | |
| *** jd__ has quit IRC | 23:37 | |
| *** jd__ has joined #cloudkitty | 23:38 | |
| *** zhurong has joined #cloudkitty | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!