Tuesday, 2019-06-25

*** jparrill has quit IRC01:35
*** sshnaidm has quit IRC02:05
*** mnaser has quit IRC03:19
*** mnaser has joined #ara03:20
*** altlogbot_2 has quit IRC06:46
*** altlogbot_2 has joined #ara06:48
*** altlogbot_2 has quit IRC06:50
*** altlogbot_2 has joined #ara06:54
*** sshnaidm has joined #ara07:42
*** vincent- has quit IRC10:26
*** vincent- has joined #ara10:28
*** vincent-- has joined #ara10:32
*** vincent- has quit IRC10:34
*** openstackgerrit has quit IRC13:48
*** med_ has joined #ara13:51
*** spiette has quit IRC14:05
*** spiette has joined #ara14:08
dmsimardapollo13: just a question on https://review.opendev.org/#/c/666962/, rest lgtm14:48
apollo13dmsimard: jupp could be14:49
apollo13I am so used to relative imports, let me fix that14:49
*** openstackgerrit has joined #ara14:50
openstackgerritFlorian Apolloner proposed recordsansible/ara master: Added utility method to get the current active client.  https://review.opendev.org/66696214:50
dmsimardnahun: the larger fields are typically only available in detailed view to keep the list responses size in check14:54
dmsimardsome examples: host facts (/api/v1/hosts/<id>), result output (/api/v1/results/<id>), file contents (/api/v1/files/<id>)14:54
nahunthanks, took me longer than I'd like to admit to figure that out15:19
dmsimardnahun: it's documented briefly here: https://ara.readthedocs.io/en/latest/api-documentation.html#relationship-between-objects15:19
dmsimardbut it's not obvious :(15:20
dmsimardah actually that needs to be updated, playbook arguments are in the list view now15:31
nahunIf I was going to mess around and add task detail to the web UI, would you have the user click on the task result for the host and a popup show with the detailed results? So the web UI wouldn't make an API query for the detailed results until the user clicks on the task result for the specific host.16:39
dmsimardnahun: yeah, the web app should ideally not query for something until it needs it16:43
dmsimardotherwise it could end up querying for thousands of detailed results16:43
dmsimardso the list view is "optimized" to provide as much contextual data as possible without the heavy stuff16:43
dmsimardand then if you want to drill down, it would be an additional query16:43
dmsimardin the ara 0.x webapp, the result details is displayed in a modal/popup -- you can see an example here: http://logs.openstack.org/62/666962/3/check/ansible-role-ara-api-ubuntu-postgresql/6550cb8/ara-report/ (expand "tasks" for a playbook and click on CHANGED, OK, etc. on the right hand side)16:44
nahunwould you do a popup like the old web UI for detailed results or another "dropdown" that expands like most of the other stuff in the new web UI?16:45
dmsimardnahun: it's a good question :)16:45
dmsimardthe modal from 0.x was more or less of a hack due to the lack of API16:46
nahunbootstrap has modal, but I don't know patternfly at all. I don't know react at all either... heh16:47
dmsimardhttps://patternfly-react.surge.sh/patternfly-4/ has good docs16:48
dmsimardbut, honestly, getting the data in the UI in some shape or form would be useful16:48
dmsimardwe can iterate to make it prettier16:49
nahunI like the idea of being able to show multiple task results at time, but popups look nice and clean16:49
dmsimardgvincent isn't around right now but he's done most of the work in ara-web, I'll ping him via https://github.com/ansible-community/ara-web/issues/2 to see what he thinks16:50
nahunah nice, already an issue created16:50
dmsimardthere is a few in ara-web16:51
nahunI may try to add it in myself, but the likelihood of it being something that can be merged is low. My code quality with JS usually isn't great. But if I'm not ashamed of it I may let you know.16:52
dmsimardnahun: sure, feel free to take a stab at whatever approach feels easiest to you at first -- we have live previews provided by the CI i.e, http://logs.openstack.org/44/663344/1/check/ara-web-build-dashboard/eed4e31/npm/html/16:54
dmsimardso we can see what it looks like before landing anything16:54
dmsimardI can definitely help push things along, ara-web is where we need the most work done :D16:55
dmsimardadded a comment in the issue16:59
*** dbpiv has joined #ara17:08
*** dbpiv has quit IRC18:08
*** vincent-- has quit IRC18:41
openstackgerritDavid Moreau Simard proposed recordsansible/ara master: Added utility method to get the current active client.  https://review.opendev.org/66696219:43
openstackgerritDavid Moreau Simard proposed recordsansible/ara master: Run actual integration tests for the ara-api role jobs  https://review.opendev.org/66689419:44
openstackgerritDavid Moreau Simard proposed recordsansible/ara master: Add distributed_sqlite db backend and WSGI app  https://review.opendev.org/66532319:44
openstackgerritDavid Moreau Simard proposed recordsansible/ara master: Run actual integration tests for the ara-api role jobs  https://review.opendev.org/66689420:28
openstackgerritMerged recordsansible/ara master: Added utility method to get the current active client.  https://review.opendev.org/66696220:42
*** openstackgerrit has quit IRC21:18

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!