*** zbr_ has joined #ara | 00:12 | |
*** zbr has quit IRC | 00:14 | |
*** _KaszpiR_ has quit IRC | 00:17 | |
*** _KaszpiR_ has joined #ara | 00:19 | |
*** _KaszpiR_ has quit IRC | 00:45 | |
*** _KaszpiR_ has joined #ara | 00:47 | |
*** krion_ has joined #ara | 09:22 | |
*** krion_ has quit IRC | 09:23 | |
*** gvincent has joined #ara | 12:36 | |
*** dbpiv has joined #ara | 12:55 | |
*** openstackgerrit has joined #ara | 13:43 | |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: WIP: Add tests for postgresql https://review.opendev.org/657023 | 13:43 |
---|---|---|
*** zul has joined #ara | 13:56 | |
openstackgerrit | Merged recordsansible/ara feature/1.0: Updated black dependency. https://review.opendev.org/658900 | 13:59 |
openstackgerrit | Merged recordsansible/ara feature/1.0: Also ignore .venv directories. https://review.opendev.org/658902 | 14:00 |
*** sshnaidm has joined #ara | 14:07 | |
*** sshnaidm is now known as sshnaidm|afk | 14:08 | |
dmsimard | apollo13: I don't think I'm able to get postgre to work with your version of the patch :/ | 14:23 |
apollo13 | dmsimard: what problems do you have? | 14:24 |
dmsimard | it uses sqlite despite settings.yaml being set to postgre | 14:24 |
dmsimard | I'll make a reproducer | 14:24 |
apollo13 | show me your settings.yaml | 14:24 |
dmsimard | apollo13: nothing special http://paste.openstack.org/show/751348/ | 14:25 |
apollo13 | yes it is | 14:25 |
apollo13 | get rid of DATABASES | 14:25 |
apollo13 | it is now just DATABASE_NAME DATABASE_USER etc | 14:25 |
dmsimard | apollo13: well that's with my version of the patch :p | 14:25 |
apollo13 | forget your version :þ | 14:26 |
dmsimard | ok hang on T_T | 14:26 |
apollo13 | there should be one way and only one way to do it | 14:26 |
apollo13 | and you wanted to have DATABASE_NAME etc because it is simpler | 14:26 |
apollo13 | so I dropped DATABASES completly since ara will always just have one | 14:26 |
apollo13 | and if not we will think of a migration strategy | 14:26 |
dmsimard | oh | 14:26 |
dmsimard | that made me find the issue | 14:27 |
apollo13 | we made a mistake in the past, we read DATABASE_NAME but wrote the whole DATABASES into the yaml settings file | 14:27 |
apollo13 | hence they never match… | 14:27 |
dmsimard | yeah, I get that | 14:27 |
dmsimard | missed something in your patch, one sec | 14:27 |
dmsimard | we'll need to revisit the logging config at some point, should be configurable imo | 14:32 |
apollo13 | yes, but really want to dump the whole python logging onto endusers? | 14:33 |
dmsimard | maybe a log level and a log file setting should be sufficient | 14:34 |
dmsimard | agreed that logger config is not simple :) | 14:36 |
dmsimard | apollo13: I'll split the LOGGING change out to a different commit if you don't mind -- needs some other changes (docs, ansible role, etc.) | 14:36 |
apollo13 | yes please | 14:37 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: Write only supported configuration params to the settings file. https://review.opendev.org/658184 | 14:42 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: WIP: Add tests for postgresql https://review.opendev.org/657023 | 14:42 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: Write only supported configuration params to the settings file. https://review.opendev.org/658184 | 14:42 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: WIP: Add tests for postgresql https://review.opendev.org/657023 | 14:42 |
dmsimard | apollo13: it works once the role templates out the updated DATABASES config :p | 14:46 |
dmsimard | <3 | 14:46 |
apollo13 | oh | 14:47 |
apollo13 | yeah didn't think of ansible | 14:47 |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: WIP: Add tests for postgresql https://review.opendev.org/657023 | 15:11 |
*** sshnaidm|afk has quit IRC | 15:25 | |
*** dbpiv has quit IRC | 15:25 | |
*** sshnaidm has joined #ara | 15:27 | |
*** sshnaidm is now known as sshnaidm|afk | 15:29 | |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: WIP: Add tests for postgresql https://review.opendev.org/657023 | 15:45 |
*** openstackgerrit has quit IRC | 15:54 | |
*** Tahvok has quit IRC | 16:44 | |
*** openstackgerrit has joined #ara | 17:10 | |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: WIP: Add tests for postgresql https://review.opendev.org/657023 | 17:10 |
*** krion is now known as nsfw | 18:58 | |
*** nsfw is now known as krion | 18:58 | |
*** Tahvok has joined #ara | 19:01 | |
openstackgerrit | David Moreau Simard proposed recordsansible/ara feature/1.0: WIP: Add tests for postgresql https://review.opendev.org/657023 | 19:58 |
*** e-tienne has quit IRC | 21:28 | |
krion | https://robertdebock.nl/ < using ara for integration tests ^^ | 21:43 |
*** harlowja has quit IRC | 22:59 | |
*** irclogbot_1 has quit IRC | 23:45 | |
*** irclogbot_1 has joined #ara | 23:47 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!