| *** resmo has quit IRC | 01:18 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: Instanciate the application inside the callback https://review.openstack.org/580465 | 03:33 |
|---|---|---|
| *** bcoca has quit IRC | 04:58 | |
| *** quiquell|off is now known as quiquell | 05:35 | |
| quiquell | dmsimard: FIx the issue at our code, let's see now | 05:35 |
| quiquell | dmsimard: thanks | 05:35 |
| *** quiquell is now known as quiquell|bbl | 06:58 | |
| *** quiquell|bbl is now known as quiquell | 07:39 | |
| *** resmo has joined #ara | 08:47 | |
| *** quiquell is now known as quiquell|lunch | 11:43 | |
| *** quiquell|lunch is now known as quiquell | 12:08 | |
| *** tbielawa has joined #ara | 12:50 | |
| dmsimard | quiquell: you found an issue on your end ? | 13:30 |
| quiquell | dmsimard: Yep totally, ARA is working like a clock | 13:55 |
| dmsimard | quiquell: I'm curious how you ran into the issue in the first place, did you identify what exactly was wrong ? | 13:55 |
| quiquell | dmsimard: Our collect logs playbook was stuck | 13:56 |
| *** Bakey has joined #ara | 13:56 | |
| quiquell | dmsimard: Tried to reproduce that, but it was working fine | 13:56 |
| quiquell | dmsimard: Was not able to reproduce | 13:57 |
| dmsimard | quiquell: hm, if everything works I won't complain but I had a patch for you to try and see if it got rid of the cache error | 13:57 |
| quiquell | dmsimard: Humm... wait found an issue | 13:58 |
| dmsimard | hopping into a couple back to back meetings now | 13:58 |
| quiquell | dmsimard: setting ARA_DATABASE was failing | 13:58 |
| quiquell | dmsimard: worked with just setting ARA_DIR | 13:58 |
| dmsimard | quiquell: perhaps wrong path ? I know it's weird but there's four front slashes | 13:58 |
| quiquell | so doing for example ARA_DATABASE=sqlite://home/zuul/.ara/ansible.sqlite was failing | 13:59 |
| dmsimard | so like sqlite:////tmp/ansible.sqlite = /tmp/ansible.sqlite | 13:59 |
| dmsimard | yeah sqlite:// is not good enough | 13:59 |
| quiquell | bug doiwn ARA_DIR=/home/zuul/.ara/ was working | 13:59 |
| dmsimard | you need sqlite:////home/zuul/.ara/ansible.sqlite | 13:59 |
| quiquell | 4 bars there ? | 13:59 |
| quiquell | Holy sh... | 14:00 |
| quiquell | I have go with defaults no ARA_DATA_ABSE or ARA_DIR is set now | 14:00 |
| quiquell | just move the .ara dir to ara-report so log.o.o do the work | 14:00 |
| dmsimard | quiquell: sure, that works too | 14:02 |
| quiquell | dmsimard: So we need four bars ? sqlite:////foo/bar ? | 14:03 |
| dmsimard | yes | 14:03 |
| dmsimard | sqlite:// is the protocol | 14:04 |
| dmsimard | and then /foo/bar is the path | 14:04 |
| dmsimard | and there's an extra third slash, basically | 14:04 |
| dmsimard | sqlite:// / /foo/bar | 14:04 |
| quiquell | dmsimard: I see? | 14:04 |
| dmsimard | quiquell: this is a sqlalchemy thing, it's not ara specific | 14:05 |
| quiquell | Ok, now we are good using defaults so we reduce the ara stuff we have to specify | 14:05 |
| *** themurph has joined #ara | 14:21 | |
| *** bcoca has joined #ara | 14:25 | |
| *** bcoca has joined #ara | 14:25 | |
| *** quiquell is now known as quiquell|off | 14:47 | |
| *** openstackgerrit has quit IRC | 15:19 | |
| *** tbielawa is now known as tbielawa|brb | 15:32 | |
| *** tbielawa|brb is now known as tbielawa | 16:05 | |
| *** paulfantom has quit IRC | 16:11 | |
| *** paulfantom has joined #ara | 16:11 | |
| ara-slack | <dmsimard> @harlowja you were having wsgi-related issues with 0.15.0 right ? I just want to make sure they're addressed before I ship a 0.16 | 16:17 |
| ara-slack | <harlowja> hmmm | 16:17 |
| ara-slack | <harlowja> ya, the app context stuff i think fixed it | 16:18 |
| ara-slack | <harlowja> but there was something off at some point | 16:18 |
| ara-slack | <dmsimard> do you have an opportunity to try the current master ? your yield_per stuff landed | 16:18 |
| ara-slack | <harlowja> i can i think | 16:19 |
| ara-slack | <harlowja> i have not yet | 16:19 |
| ara-slack | <dmsimard> that would be super helpful | 16:19 |
| ara-slack | <dmsimard> like I'd mail you stickers helpful | 16:20 |
| ara-slack | <harlowja> lol | 16:20 |
| ara-slack | <harlowja> kk | 16:20 |
| dmsimard | I kind of screwed up 0.15 tbh and I'd like to get 0.16 right. I've been working on improving the integration tests coverage (wsgi was a definite gap) but it's not perfect | 16:21 |
| dmsimard | quite a bit of fixes for 0.16 already https://github.com/openstack/ara/compare/0.15.0...master | 16:22 |
| *** openstackgerrit has joined #ara | 16:22 | |
| openstackgerrit | Joshua Harlow proposed openstack/ara master: Create the app once (and ensure safely done) https://review.openstack.org/580712 | 16:22 |
| ara-slack | <harlowja> ^ might be useful also | 16:22 |
| ara-slack | <dmsimard> @harlowja oh yeah it was https://github.com/openstack/ara/commit/c6b2984141f4957c8bb58c6d0e609b71a34c3b27 I think ? | 16:22 |
| ara-slack | <harlowja> ya | 16:22 |
| ara-slack | <harlowja> https://review.openstack.org/580712 should avoid making the app over and over again i think | 16:23 |
| ara-slack | <harlowja> and uses a context manager for the app context ^ | 16:23 |
| ara-slack | <dmsimard> hmm, tbh the flask context thing confuses me sometimes | 16:24 |
| ara-slack | <dmsimard> whether current_app is available or not, when to create the app, etc | 16:24 |
| ara-slack | <harlowja> ya, same here, lol | 16:24 |
| ara-slack | <dmsimard> so the current approach that your patch proposes, there's a couple places where this is used | 16:24 |
| ara-slack | <harlowja> ya, in webapp.py i think | 16:25 |
| ara-slack | <dmsimard> I'll be happy to move on to the 1.0 backend, everything will be much more straightforward | 16:25 |
| ara-slack | <dmsimard> and no need to keep carrying this odd app context thing | 16:25 |
| ara-slack | <harlowja> lol | 16:26 |
| ara-slack | <harlowja> def | 16:26 |
| ara-slack | <harlowja> we've been using https://review.openstack.org/#/c/580712/ for a few days now if that helps | 16:26 |
| ara-slack | <harlowja> and it seems to be ok :P | 16:26 |
| ara-slack | <harlowja> though i also confused by when to use current_app, or app, or app.context | 16:27 |
| ara-slack | <harlowja> lol | 16:27 |
| dmsimard | eh it's the kind of thing that I'll test but placing a lot of trust in you :p | 16:27 |
| ara-slack | <harlowja> lol | 16:27 |
| dmsimard | basically | 16:27 |
| dmsimard | spinning up the application has a cost | 16:27 |
| dmsimard | so you ideally only ever want to do it once but keep the app context in memory and use that if it's already spun up | 16:28 |
| dmsimard | flask provides this through "current_app" but it's not obvious to me how it /actually/ works | 16:28 |
| dmsimard | it's like.. for the callback, you don't want to bootstrap the entire app every time ansible sends a hook to the callback | 16:29 |
| dmsimard | I guess for your wsgi patch it's the same general concept, you wound up spinning up N apps instead of a single one | 16:29 |
| ara-slack | <harlowja> ya | 16:30 |
| openstackgerrit | Merged openstack/ansible-role-ara master: Listen on 127.0.0.1 by default https://review.openstack.org/576532 | 16:33 |
| openstackgerrit | Merged openstack/ansible-role-ara master: Only generate a versioned package string if we have a version https://review.openstack.org/576533 | 16:33 |
| openstackgerrit | Merged openstack/ansible-role-ara master: Move systemd service setup to the embedded webserver installation https://review.openstack.org/576541 | 16:33 |
| openstackgerrit | Merged openstack/ansible-role-ara master: Don't nest installation variables under a params key https://review.openstack.org/576550 | 16:33 |
| *** Bakey has quit IRC | 16:35 | |
| *** Bakey has joined #ara | 16:36 | |
| openstackgerrit | David Moreau Simard proposed openstack/ansible-role-ara master: use become: true when reloading systemctl daemon https://review.openstack.org/580715 | 16:37 |
| openstackgerrit | David Moreau Simard proposed openstack/ansible-role-ara master: Dump the role configuration to /etc/ara https://review.openstack.org/580716 | 16:37 |
| openstackgerrit | David Moreau Simard proposed openstack/ansible-role-ara master: WIP: Zuul jobs experiments https://review.openstack.org/557933 | 16:43 |
| *** resmo has quit IRC | 16:52 | |
| *** tbielawa is now known as tbielawa|lunch | 17:35 | |
| *** tbielawa|lunch is now known as tbielawa | 18:37 | |
| *** Bakey has quit IRC | 18:45 | |
| *** tbielawa is now known as tbielawa|around | 20:18 | |
| *** tbielawa|around is now known as tbielawa|g0n3 | 21:27 | |
| *** themurph has quit IRC | 21:27 | |
| *** tbielawa|g0n3 has quit IRC | 21:27 | |
| openstackgerrit | David Moreau Simard proposed openstack/ansible-role-ara master: Always set up the ARA systemd unit file https://review.openstack.org/580772 | 21:29 |
| openstackgerrit | David Moreau Simard proposed openstack/ansible-role-ara master: Always set up the ARA systemd unit file https://review.openstack.org/580772 | 21:30 |
| openstackgerrit | David Moreau Simard proposed openstack/ansible-role-ara master: WIP: Zuul jobs experiments https://review.openstack.org/557933 | 21:32 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!