openstackgerrit | David Moreau Simard proposed openstack/ara master: Make arguments for serve_static_packaged standard https://review.openstack.org/461526 | 00:04 |
---|---|---|
openstackgerrit | David Moreau Simard proposed openstack/ara master: Tidy up HTML and get rid of needless whitespace https://review.openstack.org/461551 | 00:23 |
openstackgerrit | Merged openstack/ara master: Make arguments for serve_static_packaged standard https://review.openstack.org/461526 | 00:28 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Add unit tests for CLI: playbook delete https://review.openstack.org/461575 | 00:46 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Remove dead functions/code https://review.openstack.org/461576 | 00:57 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Tidy up HTML and get rid of needless whitespace https://review.openstack.org/461551 | 00:58 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Add unit tests for CLI: playbook delete https://review.openstack.org/461575 | 00:58 |
dmsimard | jrist: still interested in a funny angry and sad versions of the ara logo for 404's and 500's btw :p | 00:59 |
*** iceyao has joined #ara | 01:08 | |
iceyao | morning all | 01:20 |
dmsimard | iceyao: I'm on the other end of the world I guess, good evening :p | 01:29 |
iceyao | hi, I'm from china. | 01:31 |
dmsimard | hey there | 01:34 |
jrist | dmsimard: haha like a frowny face? | 02:16 |
dmsimard | jrist: you have creative freedom sir | 02:17 |
dmsimard | jrist: something on the funny side of things that a bird could look like when it's angry or sad | 02:17 |
dmsimard | angry could have red eyes with plucked feathers floating around or something | 02:17 |
jrist | what about a bunch of ara birds carrying a whale | 02:17 |
jrist | :) | 02:17 |
dmsimard | sad could just have T_T eyes with a tear | 02:17 |
dmsimard | hum, that sounds a lot like the twitter fail whale :P | 02:18 |
dmsimard | http://www.yiyinglu.com/wp-content/uploads/2013/11/lifting-a-dreamer-2009.jpg | 02:18 |
dmsimard | jrist: I'm down for anything you come up with, just want to make custom 404/500 pages | 02:19 |
dmsimard | jrist: the openstack.org is fun https://www.openstack.org/404 | 02:21 |
iceyao | oh, It's funny | 02:24 |
*** iceyao has quit IRC | 02:28 | |
*** iceyao has joined #ara | 02:38 | |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Fix logic inside the treeview unit test https://review.openstack.org/461597 | 02:48 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Remove dead functions/code https://review.openstack.org/461576 | 02:49 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Tidy up HTML and get rid of needless whitespace https://review.openstack.org/461551 | 02:49 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Add unit tests for CLI: playbook delete https://review.openstack.org/461575 | 02:49 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Add unit tests for CLI: playbook delete https://review.openstack.org/461575 | 02:57 |
*** iceyao has quit IRC | 03:03 | |
*** iceyao has joined #ara | 03:22 | |
dmsimard | I don't know who I was discussing this with | 03:25 |
dmsimard | but ARA has this problem where it didn't really save much for tasks with loops involved, it'd write "all items succeeded" and that was it | 03:25 |
*** iceyao has quit IRC | 03:26 | |
openstackgerrit | Merged openstack/ara master: Fix logic inside the treeview unit test https://review.openstack.org/461597 | 03:28 |
openstackgerrit | Merged openstack/ara master: Remove dead functions/code https://review.openstack.org/461576 | 03:28 |
openstackgerrit | Merged openstack/ara master: Add unit tests for CLI: playbook delete https://review.openstack.org/461575 | 03:28 |
openstackgerrit | Merged openstack/ara master: Tidy up HTML and get rid of needless whitespace https://review.openstack.org/461551 | 03:29 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: WIP: Properly store task results provided from loops https://review.openstack.org/461612 | 04:02 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: WIP: Properly store task results provided from loops https://review.openstack.org/461612 | 04:03 |
*** iceyao has joined #ara | 05:06 | |
*** iceyao has quit IRC | 05:17 | |
*** iceyao has joined #ara | 05:33 | |
*** iceyao has quit IRC | 05:37 | |
*** iceyao has joined #ara | 06:13 | |
*** iceyao_ has joined #ara | 06:22 | |
*** iceyao has quit IRC | 06:23 | |
*** iceyao_ has quit IRC | 08:09 | |
*** iceyao has joined #ara | 08:17 | |
*** iceyao has quit IRC | 09:57 | |
*** iceyao has joined #ara | 10:20 | |
*** iceyao has quit IRC | 10:24 | |
*** iceyao has joined #ara | 11:21 | |
dmsimard | larsks: found another obscure ansible bug with ara :( | 13:36 |
larsks | dmsimard: awesome! | 13:36 |
larsks | Is it my fault? :) | 13:36 |
larsks | Oh wait, you said in ansible. | 13:36 |
dmsimard | larsks: no, look at this and tell me what's the problem https://gist.github.com/dmsimard/cc39f4f5283ae31ce9e2ab0cb0b73fc0 | 13:36 |
larsks | What exactly is the problem there? | 13:38 |
dmsimard | larsks: sometimes the task closes before the last item closes | 13:38 |
dmsimard | in that gist, you see one output with two registered items, the other with three | 13:38 |
larsks | Right. I saw that, but wanted to be sure I was looking at the right thing. | 13:39 |
larsks | Is this with 2.3.0? | 13:39 |
dmsimard | yeah | 13:39 |
dmsimard | I got the expected "it's not a bug it's a feature" from upstream :) | 13:39 |
larsks | Did they have any more details? I mean, it looks like some sort of asynchronous execution happening, but you would think that the runner_on_ok method would only be called when the task had completed execution. | 13:41 |
dmsimard | yeah, it's an async tradeoff | 13:41 |
larsks | But...I am confused as to how ansible can determine if the task was successful or not without waiting for all hosts to complete. | 13:42 |
*** iceyao has quit IRC | 13:44 | |
dmsimard | larsks: the task status is determined upstream in the task engine, not from the callback | 13:46 |
dmsimard | but.. I don't know | 13:47 |
larsks | Right, but it's calling the runner_on_ok method...which means it has already determined the task result. | 13:47 |
*** openstackgerrit has quit IRC | 13:48 | |
dmsimard | larsks: shrug, I'll file a formal issue and see how we can work around it in ara -- https://review.openstack.org/#/c/461612/ simply won't work out of the box | 13:58 |
dmsimard | http://logs.openstack.org/12/461612/2/check/gate-ara-integration-latest-centos-7/1d4a204/logs/build/result/ad6ef9ef-8d27-4386-9e31-006ef47ec8a1/ there should be 3 items here | 13:58 |
dmsimard | for callbacks that just print stuff, it's not so much an issue .. you just get lines that get printed a bit out of order | 13:58 |
dmsimard | larsks: created https://github.com/ansible/ansible/issues/24207 | 14:08 |
*** iceyao has joined #ara | 14:11 | |
*** iceyao has quit IRC | 14:16 | |
*** openstackgerrit has joined #ara | 14:25 | |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Properly store task results provided from loops https://review.openstack.org/461612 | 14:25 |
*** iceyao has joined #ara | 14:30 | |
*** iceyao has quit IRC | 14:41 | |
*** hughsaunders has quit IRC | 14:43 | |
*** dmsimard has quit IRC | 14:44 | |
*** jmccrory has quit IRC | 14:45 | |
*** dmsimard has joined #ara | 14:46 | |
*** ChanServ sets mode: +o dmsimard | 14:48 | |
*** hughsaunders has joined #ara | 14:50 | |
*** jmccrory has joined #ara | 14:51 | |
openstackgerrit | Merged openstack/ara master: Properly store task results provided from loops https://review.openstack.org/461612 | 15:00 |
*** iceyao has joined #ara | 16:40 | |
*** los has joined #ara | 16:41 | |
*** iceyao has quit IRC | 16:47 | |
los | HI @dmsimard, first of all, thanks for creating this project, it's been quite helpful for us. As a side note, have you considered the ability to filter results based on tags and have the tasks stats change based on the filter? | 16:47 |
los | I am thinking of the use case where I have a playbook that have tons of tasks, but there are a few critical ones. I could tag the tasks in a way to label them critical and being able to narrow down the ARA report to only those | 16:49 |
dmsimard | los: hi o/ | 16:51 |
dmsimard | los: so ARA does not (yet) do anything with tags in general right now -- there is https://storyboard.openstack.org/#!/story/2000747 that mentions ARA should at least save and display what tags were used for a playbook run | 16:52 |
dmsimard | los: you have a really good idea on the task tagging, though, I'll have to write it down | 16:53 |
*** femto_ has quit IRC | 16:53 | |
dmsimard | I'm not sure if the task's tags are made available in the context where ara is running, I'll need to check | 16:55 |
dmsimard | task tags are totally available inside the task metadata | 16:57 |
los | I'm sure you have a tons of enhancements on the pipeline, this would be a pretty cool one from our point of view :) | 16:59 |
dmsimard | I kind of want to do it now | 16:59 |
dmsimard | cause it's an easy addition | 16:59 |
los | oh man, I thought posing this enhancement was going to be somewhat of a long shot, thanks! | 17:01 |
*** harlowja has quit IRC | 17:04 | |
dmsimard | los: ARA is mostly developed out of user feedback | 17:19 |
dmsimard | whether that my own feedback or others :p | 17:19 |
*** iceyao has joined #ara | 17:27 | |
*** iceyao has quit IRC | 17:32 | |
dmsimard | los: so it's a package deal, you'll get a bit more than what you asked for, apologies | 17:38 |
los | @dmsimard: even better! what do you have in mind? | 17:46 |
dmsimard | screenshot soon | 17:47 |
dmsimard | los: just a poc implementation http://i.imgur.com/HCz8bT9.png | 17:52 |
dmsimard | and task tags will be available and searchable | 17:53 |
dmsimard | Probably going to give the playbook metadata it's own panel | 17:53 |
los | sweet! that was fast, just made my day | 17:55 |
dmsimard | It will land in 0.13 (hopefully this week) | 17:56 |
dmsimard | 0.13 was supposed to be a small release but there's actually a bunch of stuff now | 17:57 |
los | I'll keep an eye on it, thanks again! | 17:58 |
*** harlowja has joined #ara | 18:00 | |
*** iceyao has joined #ara | 21:18 | |
*** iceyao has quit IRC | 21:23 | |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Add playbook parameters and metadata, handle task tags https://review.openstack.org/461907 | 21:27 |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Add playbook parameters and metadata, handle task tags https://review.openstack.org/461907 | 21:27 |
dmsimard | los: ^ I'll send you a link when there's a report generated in-gate | 21:28 |
dmsimard | los: http://logs.openstack.org/07/461907/2/check/gate-ara-integration-latest-centos-7/672e715/logs/build/reports/index.html | 21:32 |
dmsimard | See the parameter tab | 21:32 |
dmsimard | and here: http://logs.openstack.org/07/461907/2/check/gate-ara-integration-latest-centos-7/672e715/logs/build/reports/9c23eba4-e5de-4543-822d-e43ab13f5b4a.html | 21:32 |
dmsimard | If you search for "tag" (or "untag" or "verytag") in the task search box you'll get the appropriate tasks -- tags can be seen in a tooltip if you hover the task name and inside the task result popup too. | 21:33 |
*** iceyao has joined #ara | 21:42 | |
*** iceyao has quit IRC | 21:47 | |
*** iceyao has joined #ara | 22:02 | |
rattboi | oh dmsimard! Is that a permalink to a playbook now? | 22:04 |
rattboi | I must have missed that | 22:04 |
*** iceyao has quit IRC | 22:06 | |
dmsimard | rattboi: yeah, permalinks are coming back in the next version | 22:17 |
rattboi | awesome :) | 22:17 |
dmsimard | Playbooks have their permalink and anything in a popup too (file, task result, hosts, etc) | 22:17 |
rattboi | is there a tl;dr version of what the solution was that didn't kill static compiling time? | 22:18 |
dmsimard | tl;dr it's not bad at the scale at which the static generation is aimed at | 22:18 |
dmsimard | If you're conplaining that static generation takes too long and is too heavy and you're generating data for 20 000 playbooks I'll tell you to use the dynamic version | 22:19 |
rattboi | makes sense to me | 22:20 |
dmsimard | There's data in the commit message here: https://github.com/openstack/ara/commit/8c5f84827541851c07f0e05ee3edd3216a61a574 | 22:20 |
dmsimard | I didn't include generation time because it was essentially the same, for that particular dataset it's around 45 seconds on my laptop | 22:21 |
dmsimard | The amount of permalinks in the previous version of the UI was just too much. The new UI works around that in different clever ways (popups, ajax, etc) | 22:22 |
*** iceyao has joined #ara | 23:07 | |
*** iceyao has quit IRC | 23:12 | |
*** myoung has joined #ara | 23:28 | |
openstackgerrit | David Moreau Simard proposed openstack/ara master: Add playbook parameters and metadata, handle task tags https://review.openstack.org/461907 | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!