| *** cuongnv has joined #ara | 01:48 | |
| *** karimb has joined #ara | 07:16 | |
| *** karimb has quit IRC | 08:31 | |
| *** karimb has joined #ara | 08:35 | |
| *** karimb has quit IRC | 08:39 | |
| *** karimb has joined #ara | 09:02 | |
| *** cuongnv has quit IRC | 10:25 | |
| *** karimb has quit IRC | 11:43 | |
| *** karimb has joined #ara | 12:36 | |
| -openstackstatus- NOTICE: The Gerrit service on http://review.openstack.org is being restarted to address hung remote replication tasks, and should return to an operable state momentarily | 12:50 | |
| logan- | dmsimard: 12.4rc1 seems to work for me :) | 13:14 |
|---|---|---|
| dmsimard | logan-: \o/ | 13:15 |
| logan- | have you ever considered on the playbook reports page to only show the basename of the playbook and save the full path for the tooltag? for most of the ara reports I look at, the playbook full path is pretty long so it is impossible to tell which playbook it is without viewing the tooltip. example of what I'm saying: http://i.imgur.com/1cqnVBg.jpg ..what if the page shows only "rabbitmq-install.yml" and the tooltip still shows the full path? | 13:18 |
| dmsimard | logan-: yeah. | 13:18 |
| dmsimard | logan-: another user mentioned something similar in https://storyboard.openstack.org/#!/story/2000952 (#2) | 13:19 |
| logan- | ah ok cool. thanks | 13:21 |
| dmsimard | logan-: it's not hard to do, just haven't got around to it yet | 13:29 |
| dmsimard | have had some fires in my real full time job :P | 13:29 |
| dmsimard | I can point you at where to do it if you'd like to contribute it ! | 13:29 |
| logan- | sure, I might take a stab at it sometime if you don't beat me to it :P | 13:31 |
| dmsimard | logan-: so this is where it's shown: https://github.com/openstack/ara/blob/master/ara/templates/report_list.html#L27 | 13:31 |
| dmsimard | logan-: er, https://github.com/openstack/ara/blob/master/ara/templates/report_list.html#L28 | 13:32 |
| dmsimard | Just need to pass {{ playbook.path }} to a filter, probably as simple as split on '/' and keep the last item | 13:33 |
| *** karimb has quit IRC | 13:36 | |
| logan- | gotcha | 13:37 |
| logan- | thanks | 13:37 |
| *** tbielawa has joined #ara | 14:22 | |
| *** tbielawa is now known as tbielawa|mtg | 14:47 | |
| *** tbielawa|mtg is now known as tbielawa | 14:53 | |
| *** karimb has joined #ara | 14:56 | |
| *** rustlebee is now known as russellb | 15:29 | |
| *** russellb has quit IRC | 15:29 | |
| *** russellb has joined #ara | 15:29 | |
| *** openstackgerrit has joined #ara | 15:43 | |
| openstackgerrit | Logan V proposed openstack/ara master: Use playbook basename for report list https://review.openstack.org/453718 | 15:43 |
| openstackgerrit | Logan V proposed openstack/ara master: Use playbook basename for report list https://review.openstack.org/453718 | 15:48 |
| dmsimard | logan-: so I think it looks kind of clunky now: http://logs.openstack.org/18/453718/2/check/gate-ara-integration-latest-centos-7/a5ac3ef/logs/build/reports/index.html | 16:36 |
| dmsimard | logan-: probably need to resize some divs around and stuff | 16:37 |
| dmsimard | maybe add a "Duration" next to the duration since we now have plenty of width | 16:37 |
| boxrick1 | Oh its funny since I made more or less the same hack on my own instance | 16:38 |
| dmsimard | logan-: this is probably what we need to tweak: https://github.com/openstack/ara/blob/master/ara/static/css/ara.css#L113-L116 | 16:38 |
| boxrick1 | Just added a couple of comments to the commit | 16:38 |
| -dmsimard- 0.12.4 was just tagged and is coming to a pypi near you | 16:54 | |
| dmsimard | harlowja: fyi ^ fixes your thing | 16:55 |
| * dmsimard actually not sure if the channel-wide notice worked | 16:55 | |
| logan- | it worked | 17:15 |
| logan- | will work on the css | 17:15 |
| logan- | boxrick1: is the path actually ever useful to display in that table? i have never seen it not be truncated, and I can't imagine how a truncated path is a useful thing to display | 17:16 |
| logan- | i'm not in favor of keeping it displayed in that table, especially if we're adding another column which will result in the path being truncated even more aggressively | 17:17 |
| dmsimard | Being pragmatic here, different people will have different opinion or tastes around what the UI should look like. I guess so far this hasn't been much of a problem as I've mostly been the one developing the thing and incorporating user feedback as best as I can. We won't be able to please everyone and that's a hard truth we have to compromise on. | 17:27 |
| dmsimard | The paths can indeed be too damn long (most filesystems cap at 255 characters, however, I checked), with that in mind, it indeed does not make much sense to display the whole thing when most of the time it'll end up being truncated due to lack of width. | 17:28 |
| dmsimard | My vote goes to use the basename of the playbook and then provide the full path in the tooltip as the patch intends to do, except we have to adjust the UI in consequence (adjust width, add "Duration" next to the clock icon thing) so that it makes sense | 17:30 |
| dmsimard | My personal width perception is mostly skewed because I don't work in a 800x600 resolution but I tried to make it so it made sense until ~1300px in width because screw conventions at max 600px of body | 17:32 |
| * dmsimard gets some food | 17:32 | |
| harlowja | dmsimard cools | 18:04 |
| harlowja | thx :) | 18:04 |
| *** harlowja has quit IRC | 18:33 | |
| *** tbielawa is now known as tbielawa|lunch | 18:35 | |
| openstackgerrit | Logan V proposed openstack/ara master: Use playbook basename for report list https://review.openstack.org/453718 | 19:37 |
| openstackgerrit | Logan V proposed openstack/ara master: Use playbook basename for report list https://review.openstack.org/453718 | 19:43 |
| *** karimb has quit IRC | 19:47 | |
| *** karimb has joined #ara | 19:48 | |
| *** tbielawa|lunch is now known as tbielawa | 19:51 | |
| *** karimb has quit IRC | 19:56 | |
| *** harlowja has joined #ara | 19:58 | |
| *** tbielawa has quit IRC | 21:00 | |
| *** karimb has joined #ara | 21:08 | |
| *** harlowja has quit IRC | 22:05 | |
| *** harlowja has joined #ara | 23:25 | |
| harlowja | dmsimard does ara have like a release notes btw | 23:25 |
| harlowja | maybe to premature for that (but am curios if it did) | 23:26 |
| dmsimard | harlowja: it does, they're embedded in the tags | 23:40 |
| dmsimard | https://github.com/openstack/ara/releases/tag/0.12.4 | 23:41 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
