| *** karimb has joined #ara | 09:27 | |
| *** jrosser has joined #ara | 14:35 | |
| *** Ravi has joined #ara | 17:26 | |
| dmsimard | Ravi: hey o/ | 17:26 |
|---|---|---|
| dmsimard | Ravi: I made you core on ansible-role-ara, can you see if you are able to +2 this review ? https://review.openstack.org/#/c/428275/ | 17:27 |
| Ravi | dmsimard: sure | 17:27 |
| dmsimard | So you might want to subscribe to the project so you are notified about new reviews automatically, this is done in the gerrit settings at https://review.openstack.org/#/settings/projects once you're logged in | 17:28 |
| dmsimard | boxrick1: by the way, we created https://github.com/openstack/ansible-role-ara from the existing role that was already done, would love to implement your stuff in there | 17:29 |
| boxrick1 | Ahh ok | 17:30 |
| dmsimard | right now the role has a different implementation (systemd unit that runs the dev server) but I'm sure we can have a toggle or setting that provides httpd/wsgi instead | 17:30 |
| boxrick1 | Let me update my playbook so you can see the new stuff I did | 17:30 |
| Ravi | dmsimard: I am not able to find the review option | 17:40 |
| dmsimard | Ravi: need to click on "reply" | 17:43 |
| dmsimard | and you'll have radio buttons | 17:43 |
| Ravi | dmsimard: Thanks, done | 17:44 |
| boxrick1 | dmsimard: Updated https://github.com/boxrick/ara_install a little bit with some more changes I had unpushed to github. | 17:44 |
| dmsimard | boxrick1: cool thanks | 17:44 |
| boxrick1 | Nothing massive, but at least its my latest working version | 17:45 |
| boxrick1 | Does ARA only show the level of output currently set within Ansible | 17:45 |
| boxrick1 | IE debug etc ? | 17:45 |
| dmsimard | Ravi: cool. So, in typical openstack projects, we usually need two core reviewers to +2 a review and then the second core reviewer does a Workflow+1 | 17:45 |
| dmsimard | Ravi: doing Workflow+1 is what sends the patch for a final batch of tests and then it's merged by gerrit | 17:46 |
| dmsimard | Ravi: since we don't have that many core reviewers in ARA, it's okay to relax that unwritten rule -- if there's at least two responsive core reviewers, we should at least not self-merge our things | 17:46 |
| dmsimard | boxrick1: as far as I'm aware, ARA picks up everything (from the tasks) as if debug had been run, except it doesn't really pick up the ssh-related stuff | 17:47 |
| Ravi | dmsimard: ravi nods | 17:48 |
| dmsimard | boxrick1: hm, maybe not in all cases | 17:48 |
| dmsimard | boxrick1: for example: http://logs.openstack.org/32/425932/4/check/gate-ara-integration-latest-centos-7/b23e578/logs/build/result/a71f9bd2-4df5-44ae-8a1c-5736f9ccc0b5/index.html is fairly verbose | 17:48 |
| boxrick1 | I just seem to see reduced output when debug is off | 17:48 |
| dmsimard | boxrick1: but http://logs.openstack.org/32/425932/4/check/gate-ara-integration-latest-centos-7/b23e578/logs/build/result/82dfb00e-8dc2-41ef-ad39-9f12b6819a4d/index.html is not very helpful | 17:49 |
| dmsimard | boxrick1: so ARA is a callback, it records whatever Ansible throws at it. It's possible that the debug/verbosity level of ansible-playbook has an impact on what the different actions/modules send back as information | 17:50 |
| dmsimard | ex, a module could have like "if debug: send a bunch of debug" | 17:51 |
| dmsimard | so if debug isn't enabled, ARA wouldn,t see that | 17:51 |
| boxrick1 | Ok that makes sense | 17:51 |
| dmsimard | Ravi: so you can go ahead and +Workflow that review | 17:51 |
| dmsimard | Ravi: right now there are no integration jobs but I'll add some soon | 17:52 |
| openstackgerrit | Merged openstack/ansible-role-ara master: Add .gitreview file https://review.openstack.org/428275 | 17:52 |
| dmsimard | well there you go | 17:53 |
| *** gundalow has quit IRC | 17:56 | |
| *** hiroki has quit IRC | 17:56 | |
| *** gundalow has joined #ara | 17:56 | |
| *** hiroki has joined #ara | 17:56 | |
| *** hiroki has quit IRC | 17:56 | |
| *** hiroki has joined #ara | 17:56 | |
| *** dmsimard has quit IRC | 17:56 | |
| *** dmsimard has joined #ara | 17:57 | |
| *** ChanServ sets mode: +o dmsimard | 17:57 | |
| Ravi | dmsimard: let me know if I can help you with integration jobs. Also we need to update role in ansible galaxy to use openstack/ansible-role-ara | 17:57 |
| dmsimard | Ravi: I'll have you review the patches I put up for the tests :) | 17:58 |
| dmsimard | and yes, galaxy ought to be updated | 17:58 |
| dmsimard | that'd be in openstack namespace though, right ? | 17:58 |
| dmsimard | I guess we don't have access to that. | 17:58 |
| dmsimard | What I do for roles that aren't in galaxy is that I use an ansible-role-requirements.yml file with a git src, like so: https://github.com/rdo-infra/weirdo/blob/master/ansible-role-requirements.yml#L9-L12 | 17:59 |
| Ravi | oh.. okay | 18:01 |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: Add new ara_record types: list and dict https://review.openstack.org/429011 | 19:49 |
| dmsimard | larsks: in your quick opinion, what are the odds of https://review.openstack.org/#/c/429011/1/ara/models.py biting me in the rear ? | 19:49 |
| dmsimard | At first glance it looks to work okay, there's no encoding/decoding issues, even with non-ascii characters | 19:49 |
| * larsks looks... | 19:49 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: Add new ara_record types: list and dict https://review.openstack.org/429011 | 19:50 |
| dmsimard | larsks: the problem was when trying to compress non-string types | 19:51 |
| larsks | dmsimard: right, I got that. I mean, Pickle has obvious security issues...if someone were able to modify the database, they could get you to run code when unpickling. | 19:51 |
| larsks | What sort of non-string types are you saving? | 19:52 |
| dmsimard | list/dict | 19:52 |
| larsks | So...just use JSON for serializing? And compress that? | 19:52 |
| dmsimard | hm, json for lists? | 19:53 |
| dmsimard | gotta look. | 19:53 |
| larsks | Sure...JSON does lists. ["this", "is", "a", "list"] | 19:53 |
| dmsimard | interesting, I work too much with dicts | 19:53 |
| larsks | Although... | 19:53 |
| larsks | Your data type is CompressedText. | 19:53 |
| larsks | If you want to handle structured data,rename the data type. | 19:54 |
| larsks | Or make a new one that does the serialize/deserialize dance. | 19:54 |
| larsks | And leave CompressedText just for text. | 19:54 |
| dmsimard | good point | 19:54 |
| larsks | CompressedArbitraryPythonValue | 19:54 |
| dmsimard | :P | 19:55 |
| dmsimard | happy to have asked you a quick review as always | 19:55 |
| dmsimard | <£ | 19:55 |
| dmsimard | er, <3 | 19:56 |
| dmsimard | larsks: hah, nice.. we run bandit in the integration tests | 20:03 |
| dmsimard | and it picked up pickle as a security issue :) | 20:03 |
| larsks | \o/ | 20:03 |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: Add new ara_record types: list and dict https://review.openstack.org/429011 | 20:12 |
| larsks | dmsimard: left you a comment on that patch. | 20:21 |
| dmsimard | ah I tried some variations in interpreter but didn't check that particular one, good catch. | 20:24 |
| larsks | dmsimard: add tests! :) | 20:24 |
| dmsimard | also FWIW, I thought this'd require a migration but turns out it ends up being created as a blob regardless | 20:24 |
| openstackgerrit | David Moreau Simard proposed openstack/ara master: Add new ara_record types: list and dict https://review.openstack.org/429011 | 20:26 |
| *** karimb has quit IRC | 20:42 | |
| *** karimb has joined #ara | 20:43 | |
| *** karimb has quit IRC | 20:48 | |
| *** Ravi has quit IRC | 21:38 | |
| *** themurph has quit IRC | 21:46 | |
| *** themurph_ has joined #ara | 21:58 | |
| *** themurph_ has quit IRC | 21:58 | |
| *** karimb has joined #ara | 22:14 | |
| *** karimb has quit IRC | 22:17 | |
| *** karimb has joined #ara | 22:52 | |
| *** karimb has quit IRC | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!