| -openstackstatus- NOTICE: static.openstack.org (which hosts logs.openstack.org) is currently migrating due to a hardware failure. It should be back up shortly. | 03:09 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Make line numbers highlightable and linkable https://review.openstack.org/331509 | 03:32 |
|---|---|---|
| dmsimard | larsks: I spent way too much time on that ^ | 03:33 |
| dmsimard | but your wish is granted, sir. | 03:33 |
| -openstackstatus- NOTICE: static.openstack.org (which hosts logs.openstack.org and tarballs.openstack.org among others) is currently being rebuilt. As jobs can not upload logs they are failing with POST_FAILURE. This should be resolved soon. Please do not recheck until then. | 05:18 | |
| *** ChanServ changes topic to "static.openstack.org (which hosts logs.openstack.org and tarballs.openstack.org among others) is currently being rebuilt. As jobs can not upload logs they are failing with POST_FAILURE. This should be resolved soon. Please do not recheck until then." | 05:18 | |
| *** ChanServ changes topic to "ARA - Ansible Run Analysis: Recording Ansible Playbook runs to make them easier to visualize, understand and troubleshoot | Git: https://github.com/dmsimard/ara - Docs: https://ara.readthedocs.io/en/latest/ - One month and 200 commits later: https://dmsimard.com/2016/06/07/ara-one-month-and-200-commits-later/" | 10:35 | |
| -openstackstatus- NOTICE: static.openstack.org is back up. If you have POST_FAILURE and are missing logs from your CI jobs, please leave a 'recheck'. | 10:35 | |
| *** myoung|afk has quit IRC | 12:29 | |
| *** myoung|afk has joined #ara | 12:29 | |
| -openstackstatus- NOTICE: OpenID login from review.o.o is experiencing difficulties, possibly due to transatlantic network performance issues. Things are being investigated | 12:55 | |
| *** ChanServ changes topic to "OpenID login from review.o.o is experiencing difficulties, possibly due to transatlantic network performance issues. Things are being investigated" | 12:55 | |
| larsks | dmsimard: going to take a look! | 12:56 |
| *** ChanServ changes topic to "ARA - Ansible Run Analysis: Recording Ansible Playbook runs to make them easier to visualize, understand and troubleshoot | Git: https://github.com/dmsimard/ara - Docs: https://ara.readthedocs.io/en/latest/ - One month and 200 commits later: https://dmsimard.com/2016/06/07/ara-one-month-and-200-commits-later/" | 13:09 | |
| -openstackstatus- NOTICE: OpenID logins are back to normal | 13:09 | |
| dmsimard | larsks: I'll submit a follow up review with links from dashboard cards today | 13:57 |
| * dmsimard really wants to tag a release before going in vacation | 13:57 | |
| *** myoung|afk is now known as myoung | 14:07 | |
| dmsimard | larsks: god damnit it doesn't work | 14:11 |
| dmsimard | the line number link works "in page" but not when linked from outside the page | 14:11 |
| *** jrist has joined #ara | 14:20 | |
| larsks | That's weird. | 14:21 |
| dmsimard | yeah, screw trying to do it in javascript, I'll just try to do something using pygments | 14:22 |
| *** jrist has quit IRC | 14:22 | |
| larsks | Huh, I see what you mean. I wonder what is up with that... | 14:22 |
| *** jrist has joined #ara | 14:22 | |
| dmsimard | larsks: not something I want to do for *this* release but I want to split the web/cli portions from the callback | 14:26 |
| larsks | Oh, you mean, like have two different projects? | 14:26 |
| dmsimard | to try and not install requirements that aren't needed if just using the callback | 14:26 |
| larsks | Ah, okay. | 14:27 |
| dmsimard | dear lord | 14:49 |
| dmsimard | pygments is so easy, why didn't I go that route first | 14:49 |
| *** myoung is now known as myoung|mtg | 15:06 | |
| *** myoung|mtg is now known as myoung | 17:04 | |
| *** myoung is now known as myoung|lunch | 18:06 | |
| dmsimard | larsks: I got it :D | 18:57 |
| dmsimard | cleaning up and submitting new patchset. | 18:57 |
| larsks | Woo! | 18:57 |
| *** myoung|lunch is now known as myoung | 19:07 | |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Make line numbers highlightable, clickable and linkable https://review.openstack.org/331509 | 19:13 |
| dmsimard | oh, some improvements to do. | 19:19 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Make line numbers highlightable, clickable and linkable https://review.openstack.org/331509 | 19:21 |
| dmsimard | larsks: should be good ^ | 19:23 |
| larsks | yup, just looking at it now! :) | 19:23 |
| dmsimard | there's links in there too so easier to test and it makes sense to put them in the same commit | 19:23 |
| larsks | Houston, we have a problem. Let me post a screenshot... | 19:25 |
| dmsimard | oh noes | 19:25 |
| larsks | When I initially followed a link to a file, I got this: | 19:27 |
| larsks | http://chunk.io/f/27d738cf8a694082be5eae0bc33d62bb | 19:27 |
| larsks | and scrolling down a bit, I finally found the top of the file... | 19:27 |
| larsks | http://chunk.io/f/12328c38c0f441999bb53c7fdc579467 | 19:27 |
| larsks | This appears to be related to font size/wrapping somehow. | 19:27 |
| dmsimard | wow weird | 19:28 |
| larsks | If I reduce the font size a couple points, it all works out. I notice that we seem to be artificially restricting the width of the file content (e.g., look at tall the whitespace to the right) | 19:28 |
| dmsimard | don't see this here | 19:28 |
| dmsimard | are you zoomed or something ? | 19:28 |
| dmsimard | ctrl+0 doesn't do anything ? | 19:28 |
| larsks | In that second image, you can see where a stray "s" got wrapped onto the next line, even though there was a lot of free space on the right of the page. | 19:28 |
| larsks | It may have been zoomed (firefox remembers zoom levels for a given page), but given all that whitespace available on the right it shouldn't be wrapping at all. | 19:29 |
| larsks | I'm trying to figure out if there's a max-width set or something. | 19:29 |
| dmsimard | k I'll wait until the static version is generated in the review, don't have that problem locally | 19:30 |
| larsks | Found the culprit: The .col-md-6 class has a "width: 50%" | 19:32 |
| larsks | I don't think there should be any width restriction on this content (I mean, other than the current size of the window). | 19:32 |
| dmsimard | ok the max size is col-md-11 | 19:32 |
| dmsimard | it's really col-md-12 but we offset by 1 so it doesn't bump into the left navbar | 19:33 |
| dmsimard | I'll set it to md-11 | 19:33 |
| larsks | Where is this stuff documented? I'm looking through the patternfly docs... | 19:33 |
| dmsimard | https://getbootstrap.com/examples/grid/ | 19:34 |
| dmsimard | patternfly is based off of bootstrap | 19:34 |
| dmsimard | there's a nowrap attribute we can pass to pygments | 19:35 |
| larsks | I don't think we want nowrap, necessarily (that is, we probably want to wrap on the window width, maybe?) | 19:35 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Make line numbers highlightable, clickable and linkable https://review.openstack.org/331509 | 19:37 |
| dmsimard | larsks: with page size fix ^ | 19:37 |
| dmsimard | div* | 19:37 |
| dmsimard | fwiw I can't reproduce on my end, neither in chrome or in firefox | 19:37 |
| dmsimard | but it should be full width anyway | 19:37 |
| dmsimard | so fixed that | 19:37 |
| larsks | Much better! | 19:40 |
| dmsimard | cool | 19:41 |
| dmsimard | and doh, pep8 | 19:41 |
| dmsimard | reinstalled laptop during the weekend and lost column width setting in my editor | 19:41 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Make line numbers highlightable, clickable and linkable https://review.openstack.org/331509 | 20:05 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Make line numbers highlightable, clickable and linkable https://review.openstack.org/331509 | 20:12 |
| openstackgerrit | David Moreau Simard proposed openstack/ara: Make line numbers highlightable, clickable and linkable https://review.openstack.org/331509 | 20:13 |
| dmsimard | larsks: ^ lgtm | 20:44 |
| dmsimard | larsks: minor change, what do you say to changing the "statistics" header to "Hosts" ? So the cards at the top fit the headers | 21:20 |
| dmsimard | and we could make the cards link to the headers when nothing else is relevant | 21:20 |
| dmsimard | ohhhhhhhhhhhhh | 21:21 |
| dmsimard | I have an idea | 21:21 |
| openstackgerrit | Merged openstack/ara: Make line numbers highlightable, clickable and linkable https://review.openstack.org/331509 | 21:22 |
| larsks | I will await your idea. I am going to go start makin' dinner. :) | 21:27 |
| dmsimard | eh nevermind | 22:03 |
| dmsimard | I'm kinda burned out on frontend | 22:03 |
| *** myoung|remote has joined #ara | 23:07 | |
| *** myoung has quit IRC | 23:11 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!