| airship-irc-bot | <sb048x> can we have reviews please on https://review.opendev.org/c/airship/treasuremap/+/793592/ https://review.opendev.org/c/airship/treasuremap/+/795527/ https://review.opendev.org/c/airship/treasuremap/+/797340/ Changes in Dex for sub-clusters | 13:30 |
|---|---|---|
| airship-irc-bot | <ma257n> Hello All, | 13:35 |
| airship-irc-bot | <vetbijaya> Hi team, can I get some review comments on this PS related to fix error message and typos: https://review.opendev.org/c/airship/airshipctl/+/795872 Also, can I get some reviews on this PS related to Proxy Var Replacement on Flux source-controller: https://review.opendev.org/c/airship/airshipctl/+/795253 Thank you in advance! | 14:13 |
| airship-irc-bot | <mattmceuen> I'd appreciate one more review on this small airshipctl change that allows generated BMH resources to be labelled: https://review.opendev.org/c/airship/airshipctl/+/797130 | 14:28 |
| airship-irc-bot | <sidney.shiba> Is there a way to render `treasuremap/manifests/site/reference-multi-tenant/target/workload` using `kustomize build` or the only option is to use `airshipctl phase render workload-target`? | 17:13 |
| airship-irc-bot | <raliev> you should be able to render it with `--enable_alpha_plugins` flag. do you experience some particular error from `kustomize build` ? | 17:38 |
| airship-irc-bot | <sidney.shiba> The issue was that `airshipctl ansible-playbook` installs an older version (`3.8.5`) and it does not work with it. Konstiantyn recommended to install the V4+ (i.e., `v4.1.3`) and it worked with this version. Note that syntax for enabling plugins changed to `--enable-alpha-plugins` instead of `--enable_alpha_plugins`. | 18:41 |
| airship-irc-bot | <kk6740> nice to know, thats @sidney.shiba | 18:49 |
| airship-irc-bot | <raliev> @sidney.shiba yeah, I know that kustomize syntax has been changed starting from 4.x version. However, please note that airshipctl (while using render command in particular) *does not* use kustomize 4.x.x in its api (and still able to render the phase you mentioned). if you want to be sure that you have same output from kustomize build and airshipctl render commands, it's better to use closer version to airshipctl's one - which is | 19:00 |
| airship-irc-bot | nearly 3.9.4, and it does work just fine with the phase you mentioned | 19:00 |
| airship-irc-bot | <rishabh.k.jain> Hi Team, I need some reviews here . These are required for conformance to pass on k8s version v1.20. Thank you :slightly_smiling_face: ```* Update docker provider k8s version to v1.20.7 https://review.opendev.org/c/airship/airshipctl/+/795582 * Update sonobuoy version to 0.51 https://review.opendev.org/c/airship/airshipctl/+/782614 (has one +2)``` | 19:07 |
| airship-irc-bot | <mf4192> Hi team, this change is ready for review. It fixes the errors when running `make manifests` and checks in generated copies of CRDs of all of our API types so they can be used in CR validation: https://review.opendev.org/c/airship/airshipctl/+/797358 | 20:01 |
| airship-irc-bot | <mf4192> It looks huge because of all the generated CRDs getting checked in, but the actual changes are pretty small :slightly_smiling_face: | 20:02 |
| airship-irc-bot | <mf4716> URGENT: 2.1/sub-cluster core reviews needed for Ian's PS: https://review.opendev.org/c/airship/treasuremap/+/798352 | 21:40 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!