Thursday, 2021-06-10

airship-irc-bot<sidney.shiba> I passed the iso image and `airshipctl phase run initinfra-ephemeral` timed out. Ironic pod took 72 min to get to `PodInitializing`. Everything is very slow and wondering if I need to instantiate a completely new VM for the test.01:52
airship-irc-bot<ao129q> Folks, why don't we pin kubectl version https://opendev.org/airship/airshipctl/src/branch/master/krm-functions/toolbox/Dockerfile#L14 stable is on 1.21.1 now and we're pretty far from that. according to https://github.com/kubernetes/community/blob/master/contributors/design-proposals/release/versioning.md#supported-releases-and-component-skew we should not keep it too far03:53
airship-irc-bot<ao129q> https://review.opendev.org/c/airship/airshipctl/+/79572603:59
airship-irc-bot<ao129q> though it's in design proposals04:01
airship-irc-bot<ao129q> but i guess it makes sense anyway04:01
airship-irc-bot<ao129q> here we go https://kubernetes.io/releases/version-skew-policy/#kubectl04:01
airship-irc-bot<sirishagopigiri> Hi Team, Requesting some reviews on the below PSs related to #280 https://review.opendev.org/c/airship/airshipctl/+/789250 Thank you in advance!13:26
airship-irc-bot<james.gu> Hello Team, can I please have some reviews on a two liner change: https://review.opendev.org/c/airship/airshipctl/+/79516914:33
airship-irc-bot<james.gu> Could I please have some reviews another validate doc script enhancement (in treasuremap this time): https://review.opendev.org/c/airship/treasuremap/+/795172. TIA!15:53
airship-irc-bot<mattmceuen> +1 Andrii -- we should match kubectl to our current kubernetes version (within the skew guidelines) or else we're playing it risky17:17
airship-irc-bot<mattmceuen> All, Andrii also discovered a document validation issue last night: 1. When we switched to gating with a phase plan in change 791715, we accidentally disabled (skipping over) document validation 2. Drew put in a fix here to re-enable it: https://review.opendev.org/c/airship/airshipctl/+/795844 3. From the validation job on Drew's change, like validation failure may have crept in in the meantime?17:21
airship-irc-bothttps://zuul.opendev.org/t/openstack/build/b98d5f8c7125482cbd4fe5764e6ab2f217:21
airship-irc-bot<mattmceuen> ```stdin: Failed initalizing schema https://kubernetesjsonschema.dev/v1.16.0-standalone-strict/networkcatalogue-airshipit-v1alpha1.json: Could not read schema from HTTP, response status is 404 Not Found Failed initalizing schema file:///workdir/schemas-cache/v1.16.0-standalone-strict/networkcatalogue-airshipit-v1alpha1.json: open /workdir/schemas-cache/v1.16.0-standalone-strict/networkcatalogue-airshipit-v1alpha1.json: no such17:21
airship-irc-botfile or directory exit status 1```17:21
airship-irc-bot<mattmceuen> Looks to have more to do with schema-juggling as opposed to our manifests per-se17:21
airship-irc-bot<mattmceuen> Does anyone recognize that error?17:22
airship-irc-bot<mattmceuen> In the meantime - be very careful merging patches till Drew's change merges; schema validation won't be in effect till then.  Non-critical airshipctl changes should probably rebase on top of Drew's change.17:23
airship-irc-bot<mattmceuen> The validation is failing on the `initinfra-networking-ephemeral` phase, which does not have an entry defined in this file -- I feel like the solution will be around that, but I'm not sure whether e.g. simply copying the `initinfra-ephemeral`  configuration (which references the schema in question) is sufficient?17:38
airship-irc-bot<mattmceuen> https://github.com/airshipit/treasuremap/blob/master/manifests/type/multi-tenant/phases/validation-config.yaml#L23-L3317:38
airship-irc-bot<ao129q> hmm. it never had it i guess. do you think it's a root cause?17:48
airship-irc-bot<raliev> @mattmceuen did you include airshipctl schemas to crdList of validation cfg?17:51
airship-irc-bot<raliev> ```When we switched to gating with a phase plan in change 791715, we accidentally disabled (skipping over) document validation Drew put in a fix here to re-enable it: https://review.opendev.org/c/airship/airshipctl/+/795844``` regarding this part, I already filled a github issue and a PS which solves it several days ago: https://review.opendev.org/c/airship/airshipctl/+/79470117:53
airship-irc-bot<ao129q> @sirajudeen.yasin hey, could you please review my comments here https://review.opendev.org/c/airship/treasuremap/+/79467817:56
airship-irc-bot<sirajudeen.yasin> sure.. i will take a look18:21
airship-irc-bot<mattmceuen> @raliev I'd missed your change, that's great -- I didn't spot the `phasePlan` name in the `KubevalOptions`, that would do it.18:22
*** yoctozepto has joined #airshipit18:49
*** yoctozepto[m] has joined #airshipit18:52
airship-irc-bot<pg588x> pls review https://review.opendev.org/c/airship/images/+/795848  https://review.opendev.org/c/airship/airshipctl/+/79571321:09

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!