*** ChanServ has quit IRC | 07:58 | |
*** portdirect has quit IRC | 07:59 | |
*** mugsie has quit IRC | 07:59 | |
*** dasp has quit IRC | 07:59 | |
*** jbryce has quit IRC | 07:59 | |
*** parallax has quit IRC | 07:59 | |
*** donnyd has quit IRC | 07:59 | |
*** vdrok has quit IRC | 07:59 | |
*** iamweswilson has quit IRC | 07:59 | |
*** megheisler has quit IRC | 07:59 | |
*** jayahn has quit IRC | 07:59 | |
*** kukacz has quit IRC | 07:59 | |
*** gagehugo has quit IRC | 07:59 | |
*** mattmceuen has quit IRC | 07:59 | |
*** srwilkers has quit IRC | 07:59 | |
*** rpioso has quit IRC | 07:59 | |
*** mnaser has quit IRC | 07:59 | |
*** anticw has quit IRC | 07:59 | |
*** lemko has quit IRC | 07:59 | |
*** airship-irc-bot has quit IRC | 07:59 | |
*** ianychoi has quit IRC | 07:59 | |
*** antonym has quit IRC | 07:59 | |
*** jhesketh has quit IRC | 07:59 | |
*** Anticimex has quit IRC | 07:59 | |
*** ildikov has quit IRC | 07:59 | |
*** thansen has quit IRC | 07:59 | |
*** jbryce has joined #airshipit | 08:04 | |
*** ChanServ has joined #airshipit | 08:04 | |
*** verne.freenode.net sets mode: +o ChanServ | 08:04 | |
*** portdirect has joined #airshipit | 08:04 | |
*** mugsie has joined #airshipit | 08:04 | |
*** dasp has joined #airshipit | 08:04 | |
*** thansen has joined #airshipit | 08:05 | |
*** parallax has joined #airshipit | 08:05 | |
*** jhesketh has joined #airshipit | 08:05 | |
*** Anticimex has joined #airshipit | 08:05 | |
*** ildikov has joined #airshipit | 08:05 | |
*** megheisler has joined #airshipit | 08:06 | |
*** iamweswilson has joined #airshipit | 08:06 | |
*** vdrok has joined #airshipit | 08:06 | |
*** donnyd has joined #airshipit | 08:06 | |
*** jayahn has joined #airshipit | 08:06 | |
*** antonym has joined #airshipit | 08:06 | |
*** lemko has joined #airshipit | 08:06 | |
*** airship-irc-bot has joined #airshipit | 08:06 | |
*** ianychoi has joined #airshipit | 08:06 | |
*** kukacz has joined #airshipit | 08:06 | |
*** gagehugo has joined #airshipit | 08:06 | |
*** mattmceuen has joined #airshipit | 08:06 | |
*** srwilkers has joined #airshipit | 08:06 | |
*** rpioso has joined #airshipit | 08:06 | |
*** mnaser has joined #airshipit | 08:06 | |
*** anticw has joined #airshipit | 08:06 | |
*** parallax has quit IRC | 08:08 | |
*** parallax has joined #airshipit | 08:13 | |
*** parallax has quit IRC | 08:20 | |
*** parallax has joined #airshipit | 08:20 | |
*** roman_g has joined #airshipit | 13:32 | |
roman_g | Hello team. Please, review https://review.opendev.org/c/airship/airshipctl/+/785522 - Set correct airshipctl/templater stable version :v2 in bootstrap manifests function. | 14:11 |
---|---|---|
airship-irc-bot | <kk6740> hey roman. I have doubts if we should actually change everything to v2.0 in master | 14:12 |
airship-irc-bot | <kk6740> rather than changing everything to latest in master | 14:13 |
airship-irc-bot | <kk6740> i beleive master should be tested against latest | 14:13 |
roman_g | Kostia, we have everything pinned to :v2, except this only one place. | 14:13 |
airship-irc-bot | <kk6740> but i much rather @sean.eagan address this, as he spend most of the time working on releases and versioning | 14:13 |
airship-irc-bot | <kk6740> I know, that is what i am trying to understand, what is correct | 14:14 |
roman_g | Should I create an issue for discussion then? | 14:14 |
airship-irc-bot | <kk6740> switch everything to v2, or switch everything to latest | 14:14 |
airship-irc-bot | <kk6740> maybe Sean can add his comments, and i’ll just follow. because i am sure we had some plan for this | 14:15 |
roman_g | All right. Thanks. | 14:15 |
roman_g | Let me create issue, add Sean and a few more interested parties, and we can discuss. | 14:16 |
airship-irc-bot | <kk6740> sure! | 14:16 |
roman_g | Or I would better reopen https://github.com/airshipit/airshipctl/issues/419 | 14:21 |
roman_g | https://github.com/airshipit/airshipctl/issues/419#issuecomment-816726446 | 14:34 |
airship-irc-bot | <sean.eagan> just to understand the current situation, was there a breaking change made to the templater function which we are hitting when using the `latest` tag? | 14:42 |
roman_g | There are 15 changes, looking trough them now. | 14:46 |
airship-irc-bot | <sean.eagan> that would be one advantage of moving the krm functions to their own git repo, or at least better separating the airshipctl cli code from the krm function code within the repo | 14:52 |
airship-irc-bot | <kk6740> @sean.eagan i sure like that | 14:54 |
airship-irc-bot | <kk6740> but i think that is probably for 2.2 or further | 14:56 |
roman_g | I wasn't able to identify which of the changes has changed behavior of templater | 14:56 |
*** high-rez has joined #airshipit | 14:58 | |
roman_g | Tend to lean to that we weren't testing some parts which are triggering failure of my https://review.opendev.org/c/airship/airshipctl/+/785396 | 14:58 |
roman_g | Would anyone have time and want to jump on a call with me for a review? | 15:03 |
roman_g | I fail to pass check gates, and don't yet understand what changes behavior in a way it drops an error. | 15:05 |
airship-irc-bot | <kk6740> roman, sorry I can’t today :( | 16:29 |
airship-irc-bot | <alexander.hughes> hey team - can I get a review on https://review.opendev.org/c/airship/airshipctl/+/785451/ please? attempts to resolve errors setting up airshipctl dev env behind corporate proxy if using root certs | 16:56 |
roman_g | +@ | 16:57 |
roman_g | +2 | 16:57 |
airship-irc-bot | <alexander.hughes> ty Roman! I left one of your questions on that patch unanswered - I think it's worth discussing here: the images that use a go builder are on 1.15 now but the repository is out of date. how does the team feel about exploring an alternative go builder image so we can bump to 1.16 tag? go1-builder latest is only 1.15 | 16:58 |
*** uzumaki has joined #airshipit | 17:29 | |
roman_g | @Alexander.Hughes, I've sent https://github.com/GoogleCloudPlatform/golang-docker/pull/194 to them. | 17:48 |
roman_g | With update to Go 1.16. | 17:48 |
airship-irc-bot | <kk6740> @alexander.hughes i just need a bit more time to review it | 17:54 |
airship-irc-bot | <kk6740> @alexander.hughes i’ve left a small comment there | 18:05 |
airship-irc-bot | <alexander.hughes> Thanks! I’ll check in a few | 18:08 |
*** roman_g has quit IRC | 18:17 | |
*** roman_g has joined #airshipit | 18:17 | |
*** roman_g has quit IRC | 18:18 | |
airship-irc-bot | <kk6740> @alexander.hughes i changed my comment, as it doesn’t work anyway from the dockerfile in that directory | 18:19 |
airship-irc-bot | <alexander.hughes> gotcha | 18:19 |
airship-irc-bot | <alexander.hughes> can you add WF? Larry said a similar change is needed in one of the CaaS projects so I'll get that up in a few | 18:19 |
airship-irc-bot | <kk6740> sure | 18:20 |
airship-irc-bot | <alexander.hughes> ty! | 18:20 |
airship-irc-bot | <alexander.hughes> https://review.opendev.org/c/airship/vino/+/785691 - same change, but in vino | 18:24 |
airship-irc-bot | <alexander.hughes> Roman - the CaaS projects look like they're using go1-builder:1.13 if you want to replicate your 1.15 change to them, or maybe wait for the bump to 1.16 ? | 18:26 |
airship-irc-bot | <mf4716> URGENT V2.0 GA Airshiptctl core reviews and WF needed for @mattmceuen PS please - https://review.opendev.org/c/airship/airshipctl/+/785256 | 19:06 |
airship-irc-bot | <mf4192> Hi team, schema changes for the VersionsCatalogue ready for review https://review.opendev.org/c/airship/airshipctl/+/784620 | 19:14 |
airship-irc-bot | <mf4192> ^ this is necessary to bring treasuremap’s `versions-treasuremap.yaml` into alignment with the VersionsCatalogue CRD | 19:15 |
airship-irc-bot | <niha.twinkle> Hi Team, Could you please review this PS related to plan list -o yaml command https://review.opendev.org/c/airship/airshipctl/+/771286 Could you please review this PS related to plan status command: https://review.opendev.org/c/airship/airshipctl/+/772890 https://review.opendev.org/c/airship/airshipctl/+/784936 Thanks in advance. | 19:26 |
*** roman_g has joined #airshipit | 19:56 | |
airship-irc-bot | <scnp89> Hello Team, I am having this issue after running this script "./tools/gate/20_run_gate_runner.sh" . Any idea? | 20:04 |
airship-irc-bot | <mf4716> *URGENT V2.0 GA* Airshiptctl core reviews and WF needed for PSs: https://review.opendev.org/c/airship/airshipctl/+/785256 and https://review.opendev.org/c/airship/treasuremap/+/785554 | 22:07 |
*** roman_g has quit IRC | 22:22 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!