Tuesday, 2021-01-26

*** sreejithp has quit IRC01:37
*** uzumaki has quit IRC05:52
*** uzumaki has joined #airshipit06:14
*** antonym has quit IRC06:56
*** antonym has joined #airshipit06:57
*** uzumaki has quit IRC10:48
*** StaceyF has joined #airshipit14:10
*** StaceyF has quit IRC14:22
airship-irc-bot<alexander.hughes> https://review.opendev.org/c/airship/vino/+/772430  small addition to ViNO dev env setup, only 19 lines of markdown14:39
airship-irc-bot<ratnopam.chakrabarti> https://review.opendev.org/c/airship/airshipctl/+/770483 ...needs another +2....this is to close issue 446....please review14:55
airship-irc-bot<sb464f> Good morning team, Looking for one more review here -> https://review.opendev.org/c/airship/airshipctl/+/768249 and treasuremap review -> https://review.opendev.org/c/airship/treasuremap/+/76825017:03
airship-irc-bot<tr.airship.slack> Hello, I tried to run "developper guide" and had the issue:  "open /tmp/secring.gpg: no such file or directory; GPG binary", while launching "sudo ./tools/deployment/24_build_images.sh" It seems that secring.gpg is not used any more by gpg. Did I miss/forget something? Thanks for your help17:04
airship-irc-bot<kk6740> @tr.airship.slack are u running from master?17:05
airship-irc-bot<tr.airship.slack> Yes Kostiantyn17:08
airship-irc-bot<kk6740> that is strange, i dont think we use gpg17:10
airship-irc-bot<kk6740> in airshipctl, can u post entire output?17:10
airship-irc-bot<kk6740> or that is all you have?17:10
airship-irc-bot<tr.airship.slack> Here it is.17:16
airship-irc-bot<sirajudeen.yasin> This might be due to missing SOPs envirnonment variables17:17
airship-irc-bot<sirajudeen.yasin> env | grep -i SOP17:18
airship-irc-bot<sirajudeen.yasin> also sudo -E to run scripts.. to pass env to scripts17:18
airship-irc-bot<steven.fitzpatrick> I'm trying the same script, getting the same error, and I've set up the key as described in step 4. "Download test security key and add it to environment variable."17:21
airship-irc-bot<steven.fitzpatrick> Just tried sudo -E too, but got the same result17:21
airship-irc-bot<kk6740> @sirishagopigiri @aodinokov maybe u have more insight on this ?17:25
airship-irc-bot<msrinivasareddy> hi all, here are my patchsets for #330 that appreciate some attention: https://review.opendev.org/c/airship/airshipctl/+/763265 - clusterctl client changes https://review.opendev.org/c/airship/airshipctl/+/763300 - k8s applier changes https://review.opendev.org/c/airship/airshipctl/+/763304 - pkg phase: cmd, client changes https://review.opendev.org/c/airship/airshipctl/+/763260 - cmd changes18:06
airship-irc-bot<aodinokov> >  sudo ./tools/deployment/24_build_images.sh > maybe u have more insight on this ? @tr.airship.slack if you run scripts from tools/deployment - you need to provide ENV variable SOPS_IMPORT_PGP with the key. more info can be found here. https://github.com/GoogleContainerTools/kpt-functions-catalog/tree/master/examples/sops  if you run scripts from ./tools/gate you don't need to provide ENV, because they're already included in the21:02
airship-irc-botplaybook here https://github.com/airshipit/airshipctl/blob/master/playbooks/airshipctl-gate-runner.yaml#L1721:02
airship-irc-bot<kk6740> @msrinivasareddy could you please remove references to other patchsets in commit message21:09
airship-irc-bot<kk6740> ```Below is the complete flow of PS for #330: https://review.opendev.org/c/airship/airshipctl/+/763265 - clusterctl client changes https://review.opendev.org/c/airship/airshipctl/+/763300 - k8s applier changes https://review.opendev.org/c/airship/airshipctl/+/763304 - pkg phase: cmd, client changes https://review.opendev.org/c/airship/airshipctl/+/763260 - cmd changes```21:09
airship-irc-bot<msrinivasareddy> @kk6740, okay can do that. I added them so that it will be easy for others to link the patchsets to get the complete picture :slightly_smiling_face:21:10
airship-irc-bot<kk6740> yes, i understand, but in terms of git history they dont bring value, on top of that, patchsets maybe removed from gerrit and before merging bases may change, and they will be irrelevant21:12
airship-irc-bot<msrinivasareddy> makes sense, I'll remove them. thank you21:14
airship-irc-bot<sb464f> can i get some reviews here please -> https://review.opendev.org/c/airship/treasuremap/+/76825022:21

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!