Monday, 2020-05-04

*** evrardjp has quit IRC04:35
*** evrardjp has joined #airshipit04:36
*** dpawlik has joined #airshipit06:04
*** dpawlik has quit IRC06:04
*** dpawlik has joined #airshipit06:07
*** dpawlik has quit IRC06:07
*** dpawlik has joined #airshipit06:08
*** rezroo has joined #airshipit06:31
*** roman_g has joined #airshipit08:10
*** roman_g has quit IRC08:50
*** roman_g has joined #airshipit09:03
*** rezroo has quit IRC09:04
*** roman_g has quit IRC09:38
openstackgerritRuslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment  https://review.opendev.org/72262109:39
*** roman_g has joined #airshipit09:55
*** zogger has quit IRC10:51
*** avolkov has joined #airshipit10:52
openstackgerritRuslan Aliev proposed airship/airshipctl master: [WIP] Remove "cluster initinfra" command  https://review.opendev.org/72427612:08
openstackgerritRuslan Aliev proposed airship/airshipctl master: Remove "cluster initinfra" command  https://review.opendev.org/72427612:10
*** SRao has joined #airshipit13:04
*** muhaha has joined #airshipit13:07
*** rezroo has joined #airshipit13:11
*** mikefix has joined #airshipit13:20
*** KeithMnemonic has joined #airshipit13:31
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: Adding in an octant plugin with example  https://review.opendev.org/72493813:40
*** muhaha84 has joined #airshipit13:41
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: Adding in an octant plugin with example  https://review.opendev.org/72493813:55
*** nishantkr has joined #airshipit14:06
openstackgerritSreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest  https://review.opendev.org/71711914:17
openstackgerritSreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest  https://review.opendev.org/71711914:21
openstackgerritArvinderpal Wander proposed airship/airshipctl master: WIP: Adds support for `clusterctl move` of capi and bmo resources from ephermeral to workload cluster.  https://review.opendev.org/72494014:29
airship-irc-bot1<alexander.hughes> code review please https://review.opendev.org/#/c/724828/14:43
openstackgerritDrew Walters proposed airship/airshipctl master: Add state validation to Redfish shutdown/startup  https://review.opendev.org/72492814:52
openstackgerritMatt McEuen proposed airship/airshipctl master: [WIP] Stub out replacement structure  https://review.opendev.org/72486914:53
openstackgerritSophie Huang proposed airship/porthole master: Add openstack and swift clients to mysql utility  https://review.opendev.org/72530015:13
airship-irc-bot1<se6518> Please review fix for the airshipctl config bug: https://review.opendev.org/72440515:16
airship-irc-bot1<se6518> and new CLI: https://review.opendev.org/72057615:16
*** jamesgu has joined #airshipit15:22
openstackgerritSreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest  https://review.opendev.org/71711915:24
openstackgerritSreejith Punnapuzha proposed airship/airshipctl master: New CLI option to get manifest  https://review.opendev.org/71711915:36
*** dpawlik has quit IRC15:59
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: Adding in an octant plugin with example  https://review.opendev.org/72493816:01
openstackgerritPrateek Dodda proposed airship/drydock master: Enabling Apparmor for drydock init containers  https://review.opendev.org/72476816:06
openstackgerritPrateek Dodda proposed airship/deckhand master: Enabling Apparmor profile to deckhand init containers  https://review.opendev.org/72490216:31
openstackgerritPrateek Dodda proposed airship/shipyard master: Enabling Apparmor profile to shipyard init containers  https://review.opendev.org/72470216:33
*** SRao has quit IRC16:35
*** evrardjp has quit IRC16:35
openstackgerritAlexander Hughes proposed airship/pegleg master: Fail early on invalid save locations  https://review.opendev.org/72482816:35
*** evrardjp has joined #airshipit16:36
openstackgerritdiwakar thyagaraj proposed airship/porthole master: [WIP] Enable Deployment consistency across all UC  https://review.opendev.org/72511716:45
*** bornie2bake has joined #airshipit16:51
*** bornie2bake has quit IRC16:54
*** bornie2bake has joined #airshipit16:55
airship-irc-bot1<alexander.hughes> Why do we have nested commands in pkg directory?  It wasn't introduced in this patchset, just first time I've noticed it https://review.opendev.org/#/c/724506/7/pkg/clusterctl/cmd/command.go17:07
*** bornie2bake has quit IRC17:08
airship-irc-bot1<kk6740> @alexander.hughes, sorry didn’t understood that question fully. is that about make of the package ?17:09
airship-irc-bot1<alexander.hughes> so normal structure is ./airshipctl/pkg/<package> or ./airshipctl/cmd/<command>  but in the case of clusterctl, we have ./airshipctl/pkg/clusterctl/cmd/command.go -- why isn't command.go instead located at ./airshipctl/cmd/clusterctl/command.go ?17:10
*** bornie2bake has joined #airshipit17:11
airship-irc-bot1<kk6740> when did that, i expected that there are more commands from clusterctl, not only init, as well move, upgrade and possible more. So I thought since we may have many of these commands, it is logical to put it into pkg/clusterctl/cmd/, rather than into pkg/clusterctl/command.go17:14
airship-irc-bot1<kk6740> as an example i took this from kubectl, where they have pkg/cmd.17:16
airship-irc-bot1<kk6740> https://github.com/kubernetes/kubectl/tree/master/pkg/cmd17:16
*** bornie2bake has quit IRC17:20
airship-irc-bot1<sb464f> Hi Team can I get some reviews here please -> https://review.opendev.org/#/c/725035/17:30
airship-irc-bot1<pb269f> lgtm sai17:31
airship-irc-bot1<pb269f> the pods not being present immediately is a kicker, i like your approach better than what we did in the osh gates17:31
airship-irc-bot1<pb269f> https://github.com/openstack/openstack-helm-infra/blob/master/tools/deployment/common/005-deploy-k8s.sh#L151-L15817:32
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add reader interface  https://review.opendev.org/72514017:42
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add reader interface  https://review.opendev.org/72514017:44
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration  https://review.opendev.org/72450617:48
openstackgerritMerged airship/airshipctl master: Wait for control pods to be ready before moving to initinfra  https://review.opendev.org/72503518:04
openstackgerritMerged airship/pegleg master: Fail early on invalid save locations  https://review.opendev.org/72482818:13
openstackgerritDrew Walters proposed airship/airshipctl master: Add mutual exclusivity to manager host selectors  https://review.opendev.org/72490518:25
openstackgerritDrew Walters proposed airship/airshipctl master: Add SystemPowerStatus tests  https://review.opendev.org/72536618:30
openstackgerritDrew Walters proposed airship/airshipctl master: Add SystemPowerStatus tests  https://review.opendev.org/72536618:31
airship-irc-bot1<sb464f> thanks for the reviews : )18:32
*** mikefix has quit IRC18:41
airship-irc-bot1<ih616h> Could I get some reviews on this:18:47
airship-irc-bot1<ih616h> https://review.opendev.org/#/c/724937/18:47
airship-irc-bot1<ih616h> it deadens a `time.Sleep` when unit testing18:47
openstackgerritIan Pittwood proposed airship/docs master: [WIP] Add issue tracking conventions  https://review.opendev.org/72136119:07
openstackgerritIan Pittwood proposed airship/docs master: Add issue tracking conventions  https://review.opendev.org/72136119:11
openstackgerritMerged airship/airshipctl master: Add a mockable Sleep method to redfish client  https://review.opendev.org/72493719:22
openstackgerritSirajudeen proposed airship/airshipctl master: Copyright Added/Updated with latest format  https://review.opendev.org/72537819:29
*** roman_g has quit IRC19:29
*** roman_g has joined #airshipit19:54
openstackgerritDrew Walters proposed airship/airshipctl master: Add Redfish SystemPowerOn/Off tests  https://review.opendev.org/72538820:45
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] An attempt at moving plugin dropdown popluation to go  https://review.opendev.org/72539020:54
openstackgerritDrew Walters proposed airship/airshipctl master: Add SystemPowerStatus tests  https://review.opendev.org/72536620:55
openstackgerritDrew Walters proposed airship/airshipctl master: Add state validation to Redfish shutdown/startup  https://review.opendev.org/72492820:55
openstackgerritDrew Walters proposed airship/airshipctl master: Add Redfish SystemPowerOn/Off tests  https://review.opendev.org/72538820:55
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] An attempt at moving plugin dropdown popluation to go  https://review.opendev.org/72539020:56
openstackgerritIan Howell proposed airship/airshipctl master: Implement airshipctl config import  https://review.opendev.org/71763021:03
*** muhaha84 has quit IRC21:12
*** muhaha has quit IRC21:12
openstackgerritSophie Huang proposed airship/porthole master: Add openstack and swift clients to mysql utility  https://review.opendev.org/72530021:36
*** avolkov has quit IRC21:42
openstackgerritIan Howell proposed airship/airshipctl master: Implement airshipctl config import  https://review.opendev.org/71763021:42
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration  https://review.opendev.org/72450621:55
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] An attempt at moving plugin dropdown popluation to go  https://review.opendev.org/72539022:10
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add reader interface  https://review.opendev.org/72514022:14
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration  https://review.opendev.org/72450622:15
openstackgerritRuslan Aliev proposed airship/airshipctl master: Ensure map is initialized before assignment  https://review.opendev.org/72262122:38
openstackgerritArvinderpal Wander proposed airship/airshipctl master: WIP: Adds support for `clusterctl move` of capi and bmo resources from ephermeral to workload cluster.  https://review.opendev.org/72494022:47
openstackgerritSophie Huang proposed airship/porthole master: Add openstack and swift clients to mysql utility  https://review.opendev.org/72530022:51
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Skip variables substitution in clusterctl integration  https://review.opendev.org/72450623:00

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!