openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 00:03 |
---|---|---|
*** avolkov has quit IRC | 00:06 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [DNM] Cllusterctl integration https://review.opendev.org/722185 | 02:26 |
openstackgerrit | Rahul Khiyani proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Scheduler https://review.opendev.org/719519 | 02:34 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6 https://review.opendev.org/722188 | 02:39 |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: Refactored airshipctl config https://review.opendev.org/718567 | 02:56 |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: [#116]: added sub-commands to set/get bootstrap info https://review.opendev.org/720576 | 02:56 |
*** SRao__ has joined #airshipit | 03:27 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6 https://review.opendev.org/722188 | 03:48 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 03:51 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 04:16 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 04:33 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 04:33 |
*** evrardjp has quit IRC | 04:35 | |
*** evrardjp has joined #airshipit | 04:35 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 04:48 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: Encoding secret data in airshipctl config files https://review.opendev.org/720289 | 05:11 |
*** roman_g has quit IRC | 05:30 | |
openstackgerrit | Vamsi Savaram proposed airship/airshipctl master: Add initinfra gating tests https://review.opendev.org/721105 | 05:48 |
*** dpawlik has joined #airshipit | 06:01 | |
*** KeithMnemonic has quit IRC | 07:12 | |
*** avolkov has joined #airshipit | 08:30 | |
*** happyhemant has joined #airshipit | 08:46 | |
openstackgerrit | Merged airship/airshipctl master: Extend delays in subsequent Redfish calls https://review.opendev.org/722122 | 08:56 |
*** born2bake has joined #airshipit | 09:47 | |
*** roman_g has joined #airshipit | 10:37 | |
openstackgerrit | Roman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate https://review.opendev.org/722026 | 10:43 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring https://review.opendev.org/721995 | 11:22 |
openstackgerrit | Roman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate https://review.opendev.org/722026 | 13:03 |
openstackgerrit | Roman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate https://review.opendev.org/722026 | 13:15 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: Encoding secret data in airshipctl config files https://review.opendev.org/720289 | 13:47 |
*** uzumaki has joined #airshipit | 13:49 | |
*** mikeifx has joined #airshipit | 13:56 | |
openstackgerrit | Rahul Khiyani proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Scheduler https://review.opendev.org/719519 | 14:00 |
openstackgerrit | Roman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate https://review.opendev.org/722026 | 14:08 |
openstackgerrit | Alexey Odinokov proposed airship/airshipctl master: Reusing apache-server instead of httpd https://review.opendev.org/720643 | 14:18 |
openstackgerrit | sai battina proposed airship/images master: Add readme for ipa-downloader-image https://review.opendev.org/722123 | 14:22 |
*** rezroo has joined #airshipit | 14:34 | |
openstackgerrit | Roman Gorshunov proposed airship/docs master: Add Ansible code formatting documentation https://review.opendev.org/685049 | 14:52 |
openstackgerrit | Roman Gorshunov proposed airship/docs master: Add Ansible code formatting documentation https://review.opendev.org/685049 | 14:53 |
openstackgerrit | Roman Gorshunov proposed airship/docs master: Add Bash shell scripts formatting documentation https://review.opendev.org/685047 | 14:57 |
openstackgerrit | Roman Gorshunov proposed airship/docs master: Add container image and Dockerfile conventions https://review.opendev.org/685038 | 15:05 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6 https://review.opendev.org/722188 | 15:08 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 15:11 |
openstackgerrit | Vamsi Savaram proposed airship/airshipctl master: Add initinfra gating tests https://review.opendev.org/721105 | 15:23 |
openstackgerrit | Smruti Soumitra Khuntia proposed airship/promenade master: Upgrade Hyperkube version from 1.16.2 to 1.17.3 https://review.opendev.org/720134 | 15:27 |
openstackgerrit | Smruti Soumitra Khuntia proposed airship/promenade master: Upgrade Hyperkube version from 1.16.2 to 1.17.3 https://review.opendev.org/720134 | 15:27 |
*** born2bake has quit IRC | 15:28 | |
openstackgerrit | Smruti Soumitra Khuntia proposed airship/promenade master: Upgrade Hyperkube version from 1.16.2 to 1.17.3 https://review.opendev.org/720134 | 15:30 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6 https://review.opendev.org/722188 | 15:47 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6 https://review.opendev.org/722188 | 15:48 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 15:48 |
openstackgerrit | Merged airship/airshipctl master: Use HTTPS to deploy ephemeral node https://review.opendev.org/717377 | 16:01 |
openstackgerrit | Merged airship/airshipctl master: Refactored airshipctl config https://review.opendev.org/718567 | 16:13 |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: [#116]: added sub-commands to set/get bootstrap info https://review.opendev.org/720576 | 16:18 |
openstackgerrit | Sreejith Punnapuzha proposed airship/airshipctl master: Add proxy support for pip3 package installation https://review.opendev.org/722400 | 16:33 |
*** SRao has joined #airshipit | 16:35 | |
*** evrardjp has quit IRC | 16:35 | |
*** evrardjp has joined #airshipit | 16:35 | |
*** SRao__ has quit IRC | 16:38 | |
*** uzumaki has quit IRC | 16:38 | |
airship-irc-bot1 | <se6518> PLease review new CLI commands: https://review.opendev.org/720576 | 17:03 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: Encoding secret data in airshipctl config files https://review.opendev.org/720289 | 17:11 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: Fix for Lint warnings https://review.opendev.org/718289 | 17:16 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable CI for Maas https://review.opendev.org/709763 | 17:17 |
*** SRao has quit IRC | 17:17 | |
openstackgerrit | Rahul Khiyani proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler https://review.opendev.org/719519 | 17:26 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 17:26 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: WIP: Add stricter Redfish error inspection https://review.opendev.org/722156 | 17:37 |
openstackgerrit | Merged airship/airshipctl master: Add proxy support for pip3 package installation https://review.opendev.org/722400 | 18:07 |
openstackgerrit | Merged airship/airshipctl master: Add initinfra gating tests https://review.opendev.org/721105 | 18:28 |
*** KeithMnemonic has joined #airshipit | 18:46 | |
openstackgerrit | Merged airship/treasuremap master: Update default shipyard password in config.sh https://review.opendev.org/717345 | 18:55 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable CI for Maas https://review.opendev.org/709763 | 19:14 |
airship-irc-bot1 | <kk6740> @ih616h when running coverage tests, i’ve noticed that most of `Error() string` functions show 0% coverage, should we cover them only to increase coverage? | 19:18 |
airship-irc-bot1 | <ih616h> hmm, those don't sound like they'd be meaningful tests.. I'm not opposed to it, but I wouldn't go out of your way either | 19:19 |
airship-irc-bot1 | <dwalt> is it ethical to exclude those from a test coverage report? | 19:19 |
airship-irc-bot1 | <ih616h> I'm not certain we _can_ exclude them without moving them into their own packages | 19:21 |
airship-irc-bot1 | <ih616h> so I don't think that's an issue | 19:21 |
airship-irc-bot1 | <ih616h> I think there's a solid argument for simply lowering the coverage threshold if it comes to that. Go has a lot of `if err != nil { return err }` where it's unreasonable to test those cases | 19:23 |
airship-irc-bot1 | <ih616h> 80 was an arbitrary number to begin with anyway :man-shrugging: | 19:23 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 19:24 |
airship-irc-bot1 | <dwalt> That's a good point. Probably makes more sense to just lower it | 19:26 |
airship-irc-bot1 | <kk6740> @ih616h just to make sure, i am talking about these: ```opendev.org/airship/airshipctl/pkg/config/errors.go:41: Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:49: Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:57: | 19:30 |
airship-irc-bot1 | Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:66: Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:76: Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:85: | 19:30 |
airship-irc-bot1 | Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:94: Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:102: Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:110: | 19:30 |
airship-irc-bot1 | Error 0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:118: Error 0.0%``` | 19:30 |
airship-irc-bot1 | <kk6740> not `if err != nil{return err} | 19:31 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 19:35 |
airship-irc-bot1 | <ih616h> right, the `if err != nil{return err}` was just an example | 19:37 |
airship-irc-bot1 | <ih616h> it's a bit strange that those are all at 0% though... | 19:37 |
openstackgerrit | Merged airship/shipyard master: (fix) Updated WTForms and cleaned psycopg2 https://review.opendev.org/722079 | 19:43 |
airship-irc-bot1 | <kk6740> yes, that is strange to me as well, i’ve added a patchset that should increase coverage, but instead it lowers it from 80.8 to 80.4 because of errors: https://review.opendev.org/#/c/722165/9/pkg/clusterctl/implementations/errors.go | 19:43 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add stricter Redfish error inspection https://review.opendev.org/722156 | 19:44 |
*** mikeifx has quit IRC | 19:45 | |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add stricter Redfish error inspection https://review.opendev.org/722156 | 19:46 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add stricter Redfish error inspection https://review.opendev.org/722156 | 19:46 |
openstackgerrit | Prateek Dodda proposed airship/treasuremap master: Uplift porthole chart with the lastest reference https://review.opendev.org/721777 | 19:47 |
openstackgerrit | Prateek Dodda proposed airship/treasuremap master: Uplift porthole chart with the lastest reference https://review.opendev.org/721777 | 19:48 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 20:10 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add management configuration module https://review.opendev.org/720843 | 20:33 |
openstackgerrit | Drew Walters proposed airship/airshipctl master: Add management support to non-ephemeral hosts https://review.opendev.org/720304 | 20:33 |
openstackgerrit | Phil Sphicas proposed airship/shipyard master: Armada DAG: increase retries from 3 to 5 https://review.opendev.org/716791 | 20:33 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] transform airship ui into a standalone electron app https://review.opendev.org/717848 | 21:02 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] transform airship ui into a standalone electron app https://review.opendev.org/717848 | 21:05 |
*** dpawlik has quit IRC | 21:09 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api https://review.opendev.org/722165 | 21:20 |
*** born2bake has joined #airshipit | 21:27 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project https://review.opendev.org/722185 | 21:30 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: [WIP] adding injection certificate authorities into docker image https://review.opendev.org/722522 | 21:37 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipctl master: [WIP] adding injection certificate authorities into docker image https://review.opendev.org/722522 | 21:38 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable CI for Maas https://review.opendev.org/709763 | 22:21 |
openstackgerrit | Chris Wedgwood proposed airship/promenade master: [uwsgi] remove extraneous argument https://review.opendev.org/713306 | 22:28 |
airship-irc-bot1 | <james.gu> Does the bootstrap isogen command work behind proxy for anyone? It failed at "Failed getting release file http://ftp.debian.org/debian/dists/buster/Release" in the debootstrap for me when my system is behind a proxy. I verified that the proxy values were set and passed to the go docker client correctly during the execution. But I think the debootstrap doesn't look at the env values. I had to add --net host option to make it work. | 22:33 |
airship-irc-bot1 | I'm curious if this is expected and if --net host is an acceptable resolution for the isogen step? | 22:33 |
*** born2bake has quit IRC | 22:55 | |
*** avolkov has quit IRC | 23:00 | |
openstackgerrit | Merged airship/shipyard master: Armada DAG: increase retries from 3 to 5 https://review.opendev.org/716791 | 23:33 |
*** uzumaki has joined #airshipit | 23:36 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!