Thursday, 2020-04-23

openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216500:03
*** avolkov has quit IRC00:06
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [DNM] Cllusterctl integration  https://review.opendev.org/72218502:26
openstackgerritRahul Khiyani proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Scheduler  https://review.opendev.org/71951902:34
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6  https://review.opendev.org/72218802:39
openstackgerritStas Egorov proposed airship/airshipctl master: Refactored airshipctl config  https://review.opendev.org/71856702:56
openstackgerritStas Egorov proposed airship/airshipctl master: [#116]: added sub-commands to set/get bootstrap info  https://review.opendev.org/72057602:56
*** SRao__ has joined #airshipit03:27
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6  https://review.opendev.org/72218803:48
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216503:51
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218504:16
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216504:33
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218504:33
*** evrardjp has quit IRC04:35
*** evrardjp has joined #airshipit04:35
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218504:48
openstackgerritSirajudeen proposed airship/airshipctl master: Encoding secret data in airshipctl config files  https://review.opendev.org/72028905:11
*** roman_g has quit IRC05:30
openstackgerritVamsi Savaram proposed airship/airshipctl master: Add initinfra gating tests  https://review.opendev.org/72110505:48
*** dpawlik has joined #airshipit06:01
*** KeithMnemonic has quit IRC07:12
*** avolkov has joined #airshipit08:30
*** happyhemant has joined #airshipit08:46
openstackgerritMerged airship/airshipctl master: Extend delays in subsequent Redfish calls  https://review.opendev.org/72212208:56
*** born2bake has joined #airshipit09:47
*** roman_g has joined #airshipit10:37
openstackgerritRoman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate  https://review.opendev.org/72202610:43
openstackgerritDmitry Ukov proposed airship/airshipctl master: Replacement transformer refactoring  https://review.opendev.org/72199511:22
openstackgerritRoman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate  https://review.opendev.org/72202613:03
openstackgerritRoman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate  https://review.opendev.org/72202613:15
openstackgerritSirajudeen proposed airship/airshipctl master: Encoding secret data in airshipctl config files  https://review.opendev.org/72028913:47
*** uzumaki has joined #airshipit13:49
*** mikeifx has joined #airshipit13:56
openstackgerritRahul Khiyani proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Scheduler  https://review.opendev.org/71951914:00
openstackgerritRoman Gorshunov proposed airship/images master: Fix docker-credential-helpers error in gate  https://review.opendev.org/72202614:08
openstackgerritAlexey Odinokov proposed airship/airshipctl master: Reusing apache-server instead of httpd  https://review.opendev.org/72064314:18
openstackgerritsai battina proposed airship/images master: Add readme for ipa-downloader-image  https://review.opendev.org/72212314:22
*** rezroo has joined #airshipit14:34
openstackgerritRoman Gorshunov proposed airship/docs master: Add Ansible code formatting documentation  https://review.opendev.org/68504914:52
openstackgerritRoman Gorshunov proposed airship/docs master: Add Ansible code formatting documentation  https://review.opendev.org/68504914:53
openstackgerritRoman Gorshunov proposed airship/docs master: Add Bash shell scripts formatting documentation  https://review.opendev.org/68504714:57
openstackgerritRoman Gorshunov proposed airship/docs master: Add container image and Dockerfile conventions  https://review.opendev.org/68503815:05
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6  https://review.opendev.org/72218815:08
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216515:11
openstackgerritVamsi Savaram proposed airship/airshipctl master: Add initinfra gating tests  https://review.opendev.org/72110515:23
openstackgerritSmruti Soumitra Khuntia proposed airship/promenade master: Upgrade Hyperkube version from 1.16.2 to 1.17.3  https://review.opendev.org/72013415:27
openstackgerritSmruti Soumitra Khuntia proposed airship/promenade master: Upgrade Hyperkube version from 1.16.2 to 1.17.3  https://review.opendev.org/72013415:27
*** born2bake has quit IRC15:28
openstackgerritSmruti Soumitra Khuntia proposed airship/promenade master: Upgrade Hyperkube version from 1.16.2 to 1.17.3  https://review.opendev.org/72013415:30
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6  https://review.opendev.org/72218815:47
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Uplift cobra dependency to v0.0.6  https://review.opendev.org/72218815:48
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216515:48
openstackgerritMerged airship/airshipctl master: Use HTTPS to deploy ephemeral node  https://review.opendev.org/71737716:01
openstackgerritMerged airship/airshipctl master: Refactored airshipctl config  https://review.opendev.org/71856716:13
openstackgerritStas Egorov proposed airship/airshipctl master: [#116]: added sub-commands to set/get bootstrap info  https://review.opendev.org/72057616:18
openstackgerritSreejith Punnapuzha proposed airship/airshipctl master: Add proxy support for pip3 package installation  https://review.opendev.org/72240016:33
*** SRao has joined #airshipit16:35
*** evrardjp has quit IRC16:35
*** evrardjp has joined #airshipit16:35
*** SRao__ has quit IRC16:38
*** uzumaki has quit IRC16:38
airship-irc-bot1<se6518> PLease review new CLI commands: https://review.opendev.org/72057617:03
openstackgerritSirajudeen proposed airship/airshipctl master: Encoding secret data in airshipctl config files  https://review.opendev.org/72028917:11
openstackgerritSirajudeen proposed airship/airshipctl master: Fix for Lint warnings  https://review.opendev.org/71828917:16
openstackgerritdiwakar thyagaraj proposed airship/maas master: Enable CI for Maas  https://review.opendev.org/70976317:17
*** SRao has quit IRC17:17
openstackgerritRahul Khiyani proposed airship/shipyard master: Implement Security Context for Airflow_Scheduler  https://review.opendev.org/71951917:26
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216517:26
openstackgerritDrew Walters proposed airship/airshipctl master: WIP: Add stricter Redfish error inspection  https://review.opendev.org/72215617:37
openstackgerritMerged airship/airshipctl master: Add proxy support for pip3 package installation  https://review.opendev.org/72240018:07
openstackgerritMerged airship/airshipctl master: Add initinfra gating tests  https://review.opendev.org/72110518:28
*** KeithMnemonic has joined #airshipit18:46
openstackgerritMerged airship/treasuremap master: Update default shipyard password in config.sh  https://review.opendev.org/71734518:55
openstackgerritdiwakar thyagaraj proposed airship/maas master: Enable CI for Maas  https://review.opendev.org/70976319:14
airship-irc-bot1<kk6740> @ih616h when running coverage tests, i’ve noticed that most of `Error() string`  functions show 0% coverage, should we cover them only to increase coverage?19:18
airship-irc-bot1<ih616h> hmm, those don't sound like they'd be meaningful tests.. I'm not opposed to it, but I wouldn't go out of your way either19:19
airship-irc-bot1<dwalt> is it ethical to exclude those from a test coverage report?19:19
airship-irc-bot1<ih616h> I'm not certain we _can_ exclude them without moving them into their own packages19:21
airship-irc-bot1<ih616h> so I don't think that's an issue19:21
airship-irc-bot1<ih616h> I think there's a solid argument for simply lowering the coverage threshold if it comes to that. Go has a lot of `if err != nil { return err }` where it's unreasonable to test those cases19:23
airship-irc-bot1<ih616h> 80 was an arbitrary number to begin with anyway :man-shrugging:19:23
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216519:24
airship-irc-bot1<dwalt> That's a good point. Probably makes more sense to just lower it19:26
airship-irc-bot1<kk6740> @ih616h just to make sure, i am talking about these: ```opendev.org/airship/airshipctl/pkg/config/errors.go:41:                                         Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:49:                                         Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:57:19:30
airship-irc-bot1            Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:66:                                         Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:76:                                         Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:85:19:30
airship-irc-bot1            Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:94:                                         Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:102:                                        Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:110:19:30
airship-irc-bot1            Error                                           0.0% opendev.org/airship/airshipctl/pkg/config/errors.go:118:                                        Error                                           0.0%```19:30
airship-irc-bot1<kk6740> not `if err != nil{return err}19:31
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218519:35
airship-irc-bot1<ih616h> right, the `if err != nil{return err}` was just an example19:37
airship-irc-bot1<ih616h> it's a bit strange that those are all at 0% though...19:37
openstackgerritMerged airship/shipyard master: (fix) Updated WTForms and cleaned psycopg2  https://review.opendev.org/72207919:43
airship-irc-bot1<kk6740> yes, that is strange to me as well, i’ve added a patchset that should increase coverage, but instead it lowers it from 80.8 to 80.4 because of errors: https://review.opendev.org/#/c/722165/9/pkg/clusterctl/implementations/errors.go19:43
openstackgerritDrew Walters proposed airship/airshipctl master: Add stricter Redfish error inspection  https://review.opendev.org/72215619:44
*** mikeifx has quit IRC19:45
openstackgerritDrew Walters proposed airship/airshipctl master: Add stricter Redfish error inspection  https://review.opendev.org/72215619:46
openstackgerritDrew Walters proposed airship/airshipctl master: Add stricter Redfish error inspection  https://review.opendev.org/72215619:46
openstackgerritPrateek Dodda proposed airship/treasuremap master: Uplift porthole chart with the lastest reference  https://review.opendev.org/72177719:47
openstackgerritPrateek Dodda proposed airship/treasuremap master: Uplift porthole chart with the lastest reference  https://review.opendev.org/72177719:48
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216520:10
openstackgerritDrew Walters proposed airship/airshipctl master: Add management configuration module  https://review.opendev.org/72084320:33
openstackgerritDrew Walters proposed airship/airshipctl master: Add management support to non-ephemeral hosts  https://review.opendev.org/72030420:33
openstackgerritPhil Sphicas proposed airship/shipyard master: Armada DAG: increase retries from 3 to 5  https://review.opendev.org/71679120:33
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] transform airship ui into a standalone electron app  https://review.opendev.org/71784821:02
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] transform airship ui into a standalone electron app  https://review.opendev.org/71784821:05
*** dpawlik has quit IRC21:09
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: Add impl of Repository interface from cluster-api  https://review.opendev.org/72216521:20
*** born2bake has joined #airshipit21:27
openstackgerritKostyantyn Kalynovskyi proposed airship/airshipctl master: [WIP] Add clusterctl client to project  https://review.opendev.org/72218521:30
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: [WIP] adding injection certificate authorities into docker image  https://review.opendev.org/72252221:37
openstackgerritAndrew Schiefelbein proposed airship/airshipctl master: [WIP] adding injection certificate authorities into docker image  https://review.opendev.org/72252221:38
openstackgerritdiwakar thyagaraj proposed airship/maas master: Enable CI for Maas  https://review.opendev.org/70976322:21
openstackgerritChris Wedgwood proposed airship/promenade master: [uwsgi] remove extraneous argument  https://review.opendev.org/71330622:28
airship-irc-bot1<james.gu> Does the bootstrap isogen command work behind proxy for anyone? It failed at "Failed getting release file http://ftp.debian.org/debian/dists/buster/Release" in the debootstrap for me when my system is behind a proxy. I verified that the proxy values were set and passed to the go docker client correctly during the execution. But I think the debootstrap doesn't look at the env values. I had to add --net host option to make it work.22:33
airship-irc-bot1I'm curious if this is expected and if --net host is an acceptable resolution for the isogen step?22:33
*** born2bake has quit IRC22:55
*** avolkov has quit IRC23:00
openstackgerritMerged airship/shipyard master: Armada DAG: increase retries from 3 to 5  https://review.opendev.org/71679123:33
*** uzumaki has joined #airshipit23:36

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!