*** rezroo has quit IRC | 03:39 | |
openstackgerrit | Merged airship/airshipctl master: Refactor Redfish ClientError https://review.opendev.org/713473 | 05:32 |
---|---|---|
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #airshipit | 05:36 | |
openstackgerrit | Merged airship/airshipctl master: [#52] Provide Redfish feedback in RemoteDirect https://review.opendev.org/711992 | 05:46 |
*** mfuller has quit IRC | 06:02 | |
*** mfuller_ has quit IRC | 06:39 | |
*** dpawlik has joined #airshipit | 07:10 | |
*** dpawlik has quit IRC | 07:26 | |
*** rezroo has joined #airshipit | 07:36 | |
*** rezroo has quit IRC | 07:47 | |
*** dpawlik has joined #airshipit | 07:58 | |
openstackgerrit | Vladimir Maliaev proposed airship/promenade master: Updated resiliency gate https://review.opendev.org/708545 | 08:20 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Ensure node power state ON/OFF for Reset command https://review.opendev.org/713201 | 09:00 |
*** dpawlik has quit IRC | 09:03 | |
*** dpawlik has joined #airshipit | 09:03 | |
*** dpawlik has quit IRC | 09:08 | |
*** zogger has quit IRC | 09:57 | |
openstackgerrit | Dmitry Ukov proposed airship/go-redfish master: Wrap On/Off values with quotes https://review.opendev.org/713622 | 10:39 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Ensure node power state ON/OFF for Reset command https://review.opendev.org/713201 | 10:47 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Ensure node power state ON/OFF for Reset command https://review.opendev.org/713201 | 10:49 |
*** zogger has joined #airshipit | 11:06 | |
*** nishantkr has quit IRC | 11:13 | |
*** roman_g has joined #airshipit | 12:01 | |
openstackgerrit | Roman Gorshunov proposed airship/governance master: Add missing contribution guidelines document https://review.opendev.org/712499 | 12:43 |
*** roman_g has quit IRC | 13:06 | |
*** roman_g has joined #airshipit | 13:07 | |
*** rezroo has joined #airshipit | 13:10 | |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Implement Ephemeral cluster readiness probe https://review.opendev.org/713657 | 13:56 |
*** ak3216 is now known as AndrewK | 14:14 | |
*** dwalt has joined #airshipit | 14:23 | |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI https://review.opendev.org/712788 | 14:55 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI https://review.opendev.org/712788 | 15:02 |
airship-irc-bot | <sreejith.punnapuzha> Can i get some reviews on this ps? https://review.opendev.org/#/c/711540/ | 15:35 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Implement Ephemeral cluster readiness probe https://review.opendev.org/713657 | 15:41 |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: [WIP] Implement Ephemeral cluster readiness probe https://review.opendev.org/713657 | 15:55 |
*** mfuller has joined #airshipit | 16:23 | |
airship-irc-bot | <dwalt> Hey @dukov. I'm trying to understand this PR you submitted to the Open API generator to make a follow-up issue to my change that merged yesterday https://github.com/OpenAPITools/openapi-generator/pull/4546/commits/246b8f9799288a230bbd602f26104511ca5e87d6 | 16:28 |
airship-irc-bot | <dwalt> Does this mean that there we will not receive an `http.Response` object when there is no body? | 16:29 |
airship-irc-bot | <dwalt> "we" as in `airshipctl` using the `go-redfish` client | 16:29 |
airship-irc-bot | <dukov> pr adjusts template used for golang code generation | 16:31 |
airship-irc-bot | <dukov> Response object still be create with all appropriate fields (status code in particular) | 16:32 |
airship-irc-bot | <dukov> de-serialised body will be nil in this case | 16:33 |
airship-irc-bot | <dukov> this fix was to template embedded into openapi-generator binary | 16:34 |
airship-irc-bot | <dukov> so we need to regenerate redfish lib using new version of binary | 16:35 |
airship-irc-bot | <dukov> see https://opendev.org/airship/go-redfish/src/branch/master/client/api_default.go#L944 | 16:40 |
airship-irc-bot | <dwalt> I see that the fix made it's way here: https://review.opendev.org/#/c/701811/6/client/client.go | 16:40 |
airship-irc-bot | <dukov> yes | 16:41 |
airship-irc-bot | <dwalt> I just remember a discussion about the HTTP error code being in the range of [300, 200] | 16:41 |
airship-irc-bot | <dwalt> But for instance, I still see that the `http.Response` object gets returned, even if the status code is out of that range https://review.opendev.org/#/c/701811/6/client/api_default.go | 16:43 |
airship-irc-bot | <dwalt> That's where I am struggling to make the connection of why we don't have to check if the status code is in the success range with this change | 16:43 |
airship-irc-bot | <dukov> hm... | 16:46 |
airship-irc-bot | <dukov> looks like you're right | 16:46 |
airship-irc-bot | <dukov> i had strong impression that error returned along with http err | 16:47 |
airship-irc-bot | <dukov> disregard my comment then... sorry for confusion :( | 16:49 |
airship-irc-bot | <dwalt> No worries! Thanks for the explanation | 16:52 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: [#21] - prompt for config init options https://review.opendev.org/710180 | 17:06 |
*** evrardjp has quit IRC | 17:36 | |
*** evrardjp has joined #airshipit | 17:36 | |
openstackgerrit | diwakar thyagaraj proposed airship/promenade master: [WIP] Fix apparmor for Promenade Containers https://review.opendev.org/710132 | 18:06 |
*** dwalt has quit IRC | 18:12 | |
openstackgerrit | Alan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth https://review.opendev.org/713711 | 18:15 |
openstackgerrit | Alan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth https://review.opendev.org/713711 | 18:15 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI https://review.opendev.org/712788 | 18:40 |
*** thansen has quit IRC | 18:58 | |
*** AndrewK has quit IRC | 19:18 | |
*** thansen has joined #airshipit | 19:25 | |
openstackgerrit | Vladimir Maliaev proposed airship/promenade master: Updated resiliency gate https://review.opendev.org/708545 | 19:45 |
openstackgerrit | Sean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating https://review.opendev.org/713729 | 20:04 |
openstackgerrit | Vamsi Savaram proposed airship/images master: [#89] Gather container logs in check pipeline https://review.opendev.org/713733 | 20:07 |
openstackgerrit | Sean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating https://review.opendev.org/713729 | 20:09 |
openstackgerrit | Craig Anderson proposed airship/maas master: Add ability to configure system account password https://review.opendev.org/713734 | 20:25 |
openstackgerrit | Alan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth https://review.opendev.org/713711 | 20:31 |
openstackgerrit | Alan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth https://review.opendev.org/713711 | 20:33 |
openstackgerrit | Sean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating https://review.opendev.org/713729 | 21:01 |
openstackgerrit | Merged airship/go-redfish master: Regenerated code using openapi-generator 4.2.2 https://review.opendev.org/701811 | 21:02 |
openstackgerrit | Merged airship/go-redfish master: Wrap On/Off values with quotes https://review.opendev.org/713622 | 21:04 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: Increase test coverage https://review.opendev.org/713740 | 21:08 |
*** openstackstatus has joined #airshipit | 21:15 | |
*** ChanServ sets mode: +v openstackstatus | 21:15 | |
openstackgerrit | Ian Howell proposed airship/airshipctl master: WIP: Cluster Status library tools https://review.opendev.org/713319 | 21:19 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: Add the dynamic kubernetes client https://review.opendev.org/712963 | 21:20 |
openstackgerrit | Ian Howell proposed airship/airshipctl master: WIP: Cluster Status library tools https://review.opendev.org/713319 | 21:22 |
openstackgerrit | Alan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth https://review.opendev.org/713711 | 21:24 |
openstackgerrit | Sean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating https://review.opendev.org/713729 | 21:26 |
openstackgerrit | Andrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI https://review.opendev.org/712788 | 21:29 |
openstackgerrit | Sean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating https://review.opendev.org/713729 | 21:35 |
openstackgerrit | Sean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating https://review.opendev.org/713729 | 21:56 |
*** roman_g has quit IRC | 21:57 | |
openstackgerrit | Sean Eagan proposed airship/airshipctl master: [WIP][#95] Add Argo workflow initinfra manifests https://review.opendev.org/713746 | 22:05 |
openstackgerrit | Sean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating https://review.opendev.org/713729 | 22:15 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: Increase test coverage https://review.opendev.org/713740 | 22:33 |
*** thansen0 has joined #airshipit | 23:13 | |
*** thansen has quit IRC | 23:14 | |
*** thansen0 is now known as thansen | 23:14 | |
*** mfuller has quit IRC | 23:22 | |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: [#43-WIP] - organize CLI helper functions https://review.opendev.org/713755 | 23:23 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: [#43-WIP] - organize CLI helper functions https://review.opendev.org/713755 | 23:29 |
*** mfuller has joined #airshipit | 23:42 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!