Wednesday, 2020-03-18

*** rezroo has quit IRC03:39
openstackgerritMerged airship/airshipctl master: Refactor Redfish ClientError  https://review.opendev.org/71347305:32
*** evrardjp has quit IRC05:35
*** evrardjp has joined #airshipit05:36
openstackgerritMerged airship/airshipctl master: [#52] Provide Redfish feedback in RemoteDirect  https://review.opendev.org/71199205:46
*** mfuller has quit IRC06:02
*** mfuller_ has quit IRC06:39
*** dpawlik has joined #airshipit07:10
*** dpawlik has quit IRC07:26
*** rezroo has joined #airshipit07:36
*** rezroo has quit IRC07:47
*** dpawlik has joined #airshipit07:58
openstackgerritVladimir Maliaev proposed airship/promenade master: Updated resiliency gate  https://review.opendev.org/70854508:20
openstackgerritDmitry Ukov proposed airship/airshipctl master: Ensure node power state ON/OFF for Reset command  https://review.opendev.org/71320109:00
*** dpawlik has quit IRC09:03
*** dpawlik has joined #airshipit09:03
*** dpawlik has quit IRC09:08
*** zogger has quit IRC09:57
openstackgerritDmitry Ukov proposed airship/go-redfish master: Wrap On/Off values with quotes  https://review.opendev.org/71362210:39
openstackgerritDmitry Ukov proposed airship/airshipctl master: Ensure node power state ON/OFF for Reset command  https://review.opendev.org/71320110:47
openstackgerritDmitry Ukov proposed airship/airshipctl master: Ensure node power state ON/OFF for Reset command  https://review.opendev.org/71320110:49
*** zogger has joined #airshipit11:06
*** nishantkr has quit IRC11:13
*** roman_g has joined #airshipit12:01
openstackgerritRoman Gorshunov proposed airship/governance master: Add missing contribution guidelines document  https://review.opendev.org/71249912:43
*** roman_g has quit IRC13:06
*** roman_g has joined #airshipit13:07
*** rezroo has joined #airshipit13:10
openstackgerritDmitry Ukov proposed airship/airshipctl master: [WIP] Implement Ephemeral cluster readiness probe  https://review.opendev.org/71365713:56
*** ak3216 is now known as AndrewK14:14
*** dwalt has joined #airshipit14:23
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI  https://review.opendev.org/71278814:55
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI  https://review.opendev.org/71278815:02
airship-irc-bot<sreejith.punnapuzha> Can i get some reviews on this ps? https://review.opendev.org/#/c/711540/15:35
openstackgerritDmitry Ukov proposed airship/airshipctl master: [WIP] Implement Ephemeral cluster readiness probe  https://review.opendev.org/71365715:41
openstackgerritDmitry Ukov proposed airship/airshipctl master: [WIP] Implement Ephemeral cluster readiness probe  https://review.opendev.org/71365715:55
*** mfuller has joined #airshipit16:23
airship-irc-bot<dwalt> Hey @dukov. I'm trying to understand this PR you submitted to the Open API generator to make a follow-up issue to my change that merged yesterday https://github.com/OpenAPITools/openapi-generator/pull/4546/commits/246b8f9799288a230bbd602f26104511ca5e87d616:28
airship-irc-bot<dwalt> Does this mean that there we will not receive an `http.Response` object when there is no body?16:29
airship-irc-bot<dwalt> "we" as in `airshipctl` using the `go-redfish` client16:29
airship-irc-bot<dukov> pr adjusts template used for golang code generation16:31
airship-irc-bot<dukov> Response object still be create with all appropriate fields (status code in particular)16:32
airship-irc-bot<dukov> de-serialised body will be nil in this case16:33
airship-irc-bot<dukov> this fix was to template embedded into openapi-generator binary16:34
airship-irc-bot<dukov> so we need to regenerate redfish lib using new version of binary16:35
airship-irc-bot<dukov> see https://opendev.org/airship/go-redfish/src/branch/master/client/api_default.go#L94416:40
airship-irc-bot<dwalt> I see that the fix made it's way here: https://review.opendev.org/#/c/701811/6/client/client.go16:40
airship-irc-bot<dukov> yes16:41
airship-irc-bot<dwalt> I just remember a discussion about the HTTP error code being in the range of [300, 200]16:41
airship-irc-bot<dwalt> But for instance, I still see that the `http.Response` object gets returned, even if the status code is out of that range https://review.opendev.org/#/c/701811/6/client/api_default.go16:43
airship-irc-bot<dwalt> That's where I am struggling to make the connection of why we don't have to check if the status code is in the success range with this change16:43
airship-irc-bot<dukov> hm...16:46
airship-irc-bot<dukov> looks like you're right16:46
airship-irc-bot<dukov> i had strong impression that error returned along with http err16:47
airship-irc-bot<dukov> disregard my comment then... sorry for confusion :(16:49
airship-irc-bot<dwalt> No worries! Thanks for the explanation16:52
openstackgerritSirajudeen proposed airship/airshipctl master: [#21] - prompt for config init options  https://review.opendev.org/71018017:06
*** evrardjp has quit IRC17:36
*** evrardjp has joined #airshipit17:36
openstackgerritdiwakar thyagaraj proposed airship/promenade master: [WIP] Fix apparmor for Promenade Containers  https://review.opendev.org/71013218:06
*** dwalt has quit IRC18:12
openstackgerritAlan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth  https://review.opendev.org/71371118:15
openstackgerritAlan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth  https://review.opendev.org/71371118:15
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI  https://review.opendev.org/71278818:40
*** thansen has quit IRC18:58
*** AndrewK has quit IRC19:18
*** thansen has joined #airshipit19:25
openstackgerritVladimir Maliaev proposed airship/promenade master: Updated resiliency gate  https://review.opendev.org/70854519:45
openstackgerritSean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating  https://review.opendev.org/71372920:04
openstackgerritVamsi Savaram proposed airship/images master: [#89] Gather container logs in check pipeline  https://review.opendev.org/71373320:07
openstackgerritSean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating  https://review.opendev.org/71372920:09
openstackgerritCraig Anderson proposed airship/maas master: Add ability to configure system account password  https://review.opendev.org/71373420:25
openstackgerritAlan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth  https://review.opendev.org/71371120:31
openstackgerritAlan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth  https://review.opendev.org/71371120:33
openstackgerritSean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating  https://review.opendev.org/71372921:01
openstackgerritMerged airship/go-redfish master: Regenerated code using openapi-generator 4.2.2  https://review.opendev.org/70181121:02
openstackgerritMerged airship/go-redfish master: Wrap On/Off values with quotes  https://review.opendev.org/71362221:04
openstackgerritSirajudeen proposed airship/airshipctl master: Increase test coverage  https://review.opendev.org/71374021:08
*** openstackstatus has joined #airshipit21:15
*** ChanServ sets mode: +v openstackstatus21:15
openstackgerritIan Howell proposed airship/airshipctl master: WIP: Cluster Status library tools  https://review.opendev.org/71331921:19
openstackgerritIan Howell proposed airship/airshipctl master: Add the dynamic kubernetes client  https://review.opendev.org/71296321:20
openstackgerritIan Howell proposed airship/airshipctl master: WIP: Cluster Status library tools  https://review.opendev.org/71331921:22
openstackgerritAlan Meadows proposed airship/airshipctl master: [WIP] Support Redfish Auth  https://review.opendev.org/71371121:24
openstackgerritSean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating  https://review.opendev.org/71372921:26
openstackgerritAndrew Schiefelbein proposed airship/airshipui master: [WIP] This adds a plugin for OpenStack to the Airship UI  https://review.opendev.org/71278821:29
openstackgerritSean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating  https://review.opendev.org/71372921:35
openstackgerritSean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating  https://review.opendev.org/71372921:56
*** roman_g has quit IRC21:57
openstackgerritSean Eagan proposed airship/airshipctl master: [WIP][#95] Add Argo workflow initinfra manifests  https://review.opendev.org/71374622:05
openstackgerritSean Eagan proposed airship/armada master: [WIP] Airship 2 integration gating  https://review.opendev.org/71372922:15
openstackgerritSirajudeen proposed airship/airshipctl master: Increase test coverage  https://review.opendev.org/71374022:33
*** thansen0 has joined #airshipit23:13
*** thansen has quit IRC23:14
*** thansen0 is now known as thansen23:14
*** mfuller has quit IRC23:22
openstackgerritSirajudeen proposed airship/airshipctl master: [#43-WIP] - organize CLI helper functions  https://review.opendev.org/71375523:23
openstackgerritSirajudeen proposed airship/airshipctl master: [#43-WIP] - organize CLI helper functions  https://review.opendev.org/71375523:29
*** mfuller has joined #airshipit23:42

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!