openstackgerrit | diwakar thyagaraj proposed airship/promenade master: [WIP] Fix apparmor for Promenade Containers https://review.opendev.org/710132 | 00:12 |
---|---|---|
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 00:19 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 00:38 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 00:44 |
*** airshipbot has quit IRC | 00:50 | |
*** airshipbot has joined #airshipit | 00:58 | |
*** airshipbot has quit IRC | 00:59 | |
*** airshipbot has joined #airshipit | 01:01 | |
*** airshipbot has joined #airshipit | 01:02 | |
*** dwalt has quit IRC | 01:04 | |
*** airshipbot has quit IRC | 01:04 | |
*** airshipbot has joined #airshipit | 01:05 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 01:09 |
*** airshipbot has quit IRC | 01:15 | |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [WIP] Resolve kubectl gate errors https://review.opendev.org/710845 | 01:41 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [#58] Update types for golint https://review.opendev.org/710469 | 01:41 |
*** siraj_ has quit IRC | 01:55 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 02:10 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [WIP] Resolve kubectl gate errors https://review.opendev.org/710845 | 02:26 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 02:31 |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: [WIP]: for test only https://review.opendev.org/709223 | 03:58 |
openstackgerrit | Prateek Dodda proposed airship/divingbell master: [WIP] Implement Security Context for Divingbell https://review.opendev.org/707885 | 04:09 |
openstackgerrit | Stas Egorov proposed airship/airshipctl master: Added job for testing roles https://review.opendev.org/709007 | 04:26 |
*** rezroo has quit IRC | 05:03 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 05:10 |
*** evrardjp has quit IRC | 05:35 | |
*** evrardjp has joined #airshipit | 05:35 | |
*** GoldenBear has quit IRC | 05:35 | |
*** GoldenBear has joined #airshipit | 05:37 | |
openstackgerrit | Prateek Dodda proposed airship/divingbell master: [WIP] Implement Security Context for Divingbell https://review.opendev.org/707885 | 05:59 |
openstackgerrit | Prateek Dodda proposed airship/divingbell master: [WIP] Implement Security Context for Divingbell https://review.opendev.org/707885 | 06:08 |
*** toabctl has quit IRC | 06:18 | |
*** toabctl has joined #airshipit | 06:22 | |
openstackgerrit | Prateek Dodda proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Worker https://review.opendev.org/692224 | 06:49 |
openstackgerrit | Prateek Dodda proposed airship/divingbell master: [WIP] Implement Security Context for Divingbell https://review.opendev.org/707885 | 07:02 |
openstackgerrit | Ahmad Mahmoudi proposed airship/shipyard master: (fix) Address image build issues, bionic https://review.opendev.org/709056 | 07:32 |
*** arijit has quit IRC | 07:46 | |
*** happyhemant has joined #airshipit | 07:50 | |
*** rezroo has joined #airshipit | 08:13 | |
*** Connoreika has joined #airshipit | 08:15 | |
openstackgerrit | Prateek Dodda proposed airship/divingbell master: [WIP] Implement Security Context for Divingbell https://review.opendev.org/707885 | 08:15 |
Connoreika | Colleagues, can someone suggest me, how i can put trusted root ca in pods of airsloop installation? I have MITM when i trying to download something from internet, and git doesn't want to clone repos. | 08:15 |
openstackgerrit | Prateek Dodda proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Worker https://review.opendev.org/692224 | 08:22 |
*** roman_g has joined #airshipit | 08:25 | |
*** roman_g has quit IRC | 08:35 | |
*** Connoreika has quit IRC | 08:49 | |
*** roman_g has joined #airshipit | 10:06 | |
*** openstackstatus has quit IRC | 10:59 | |
*** roman_g has quit IRC | 11:05 | |
*** zogger has quit IRC | 11:16 | |
*** zogger has joined #airshipit | 11:16 | |
*** zogger has quit IRC | 11:21 | |
*** rezroo has quit IRC | 11:26 | |
*** rezroo has joined #airshipit | 11:26 | |
*** Connoreika has joined #airshipit | 11:35 | |
Connoreika | Colleagues, can someone suggest me, how i can put trusted root ca in pods of airsloop installation? I have MITM when i trying to download something from internet, and git doesn't want to clone repos. | 11:35 |
*** Connoreika has quit IRC | 11:37 | |
*** rezroo has quit IRC | 12:17 | |
openstackgerrit | Dmitry Ukov proposed airship/airshipctl master: Fix go get for airshipctl module https://review.opendev.org/710400 | 12:29 |
*** Connoreika has joined #airshipit | 12:31 | |
*** Connoreika has quit IRC | 12:42 | |
*** Connoreika has joined #airshipit | 13:03 | |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: [WIP] Add Bare Metal Operator resources https://review.opendev.org/706533 | 13:08 |
*** Connoreika has quit IRC | 13:14 | |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: [WIP] Add Bare Metal Operator Ironic config files https://review.opendev.org/706736 | 13:15 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: [WIP] Add Bare Metal Operator Ironic entrypoints https://review.opendev.org/706737 | 13:15 |
openstackgerrit | Nikolay Fedorov proposed airship/airshipctl master: [WIP] Add Bare Metal Operator Ironic entrypoints https://review.opendev.org/706737 | 13:21 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [#70] Resolve kubectl gate errors https://review.opendev.org/710845 | 13:31 |
openstackgerrit | diwakar thyagaraj proposed airship/porthole master: Fix helm Installation Script in Apparmor Scripts https://review.opendev.org/710178 | 13:51 |
*** SRao has joined #airshipit | 13:59 | |
*** rezroo has joined #airshipit | 14:06 | |
*** aaronsheffield has joined #airshipit | 14:06 | |
*** jamesgu has quit IRC | 14:10 | |
*** airshipbot has joined #airshipit | 14:10 | |
openstackgerrit | Alexander Hughes proposed airship/drydock master: [WIP] Uplift pyyaml and requests https://review.opendev.org/711019 | 14:16 |
*** airshipbot has quit IRC | 14:18 | |
openstackgerrit | Alexander Hughes proposed airship/drydock master: [WIP] Uplift pyyaml and requests https://review.opendev.org/711019 | 14:18 |
*** jamesgu has joined #airshipit | 14:19 | |
*** ab2434_ has joined #airshipit | 14:37 | |
mattmceuen | o/ everyone -- for our meeting in 15min here's the agenda: https://etherpad.openstack.org/p/airship-meeting-2020-03-03 | 14:45 |
mattmceuen | please add anything you'd like to discuss | 14:45 |
openstackgerrit | Alexander Hughes proposed airship/drydock master: Uplift pyyaml and requests https://review.opendev.org/711019 | 14:48 |
*** siraj_ has joined #airshipit | 14:49 | |
*** airshipbot has joined #airshipit | 14:50 | |
*** nishantkr has joined #airshipit | 14:53 | |
*** michael-beaver has joined #airshipit | 14:53 | |
*** dwalt has joined #airshipit | 14:55 | |
*** Connoreika has joined #airshipit | 14:55 | |
Connoreika | Colleagues, can someone suggest me, how i can put trusted root ca in pods of airsloop installation? I have MITM when i trying to download something from internet, and git doesn't want to clone repos. | 14:56 |
mattmceuen | Hey Connoreika | 14:57 |
Connoreika | Hi Matt! | 14:57 |
mattmceuen | Let me add that as an item in our meeting so we can get everyone's eyes ton i | 14:57 |
mattmceuen | and make sure we get an answer for you | 14:57 |
mattmceuen | It starts in 2 min :) | 14:58 |
Connoreika | Would be grate! | 14:58 |
Connoreika | Tu | 14:58 |
Connoreika | Matt, i saw that in future, you plan to do an iso image to deploy genesis node and whole cluster. Is it true? | 14:59 |
mattmceuen | Yep - the plan is for the CLI to create a boot iso for the ephemeral node (replaces the role of genesis), and then boot it remotely via redfish (optional step), and then that ephemeral node sets up a k8s instance that drives provisioning of the rest of the nodes | 15:00 |
mattmceuen | #startmeeting airship | 15:00 |
openstack | Meeting started Tue Mar 3 15:00:54 2020 UTC and is due to finish in 60 minutes. The chair is mattmceuen. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
*** openstack changes topic to " (Meeting topic: airship)" | 15:00 | |
openstack | The meeting name has been set to 'airship' | 15:00 |
mattmceuen | #topic Rollcall | 15:01 |
*** openstack changes topic to "Rollcall (Meeting topic: airship)" | 15:01 | |
Connoreika | o/ | 15:01 |
aaronsheffield | o/ | 15:01 |
howell | o/ | 15:01 |
mattmceuen | o/ everyone and good morning/evening! | 15:01 |
seaneagan | o/ | 15:01 |
nishantkr | o/ | 15:01 |
michael-beaver | o/ | 15:01 |
mattmceuen | Here's our agenda: https://etherpad.openstack.org/p/airship-meeting-2020-03-03 | 15:01 |
dwalt | o/ | 15:01 |
alexanderhughes | o/ | 15:01 |
jamesgu | o/ | 15:01 |
*** nasirkamal has joined #airshipit | 15:01 | |
airshipbot | <alex.bailey.1> o/ | 15:02 |
mattmceuen | Ok, let's get started: | 15:02 |
mattmceuen | #topic KubeCon update | 15:02 |
*** openstack changes topic to "KubeCon update (Meeting topic: airship)" | 15:02 | |
mattmceuen | First, a follow-up to kubecon discussion last week | 15:02 |
*** roman_g has joined #airshipit | 15:03 | |
mattmceuen | Unfortunately, AT&T yesterday announced a hold on all international travel, so it joins Ericsson in that boat | 15:03 |
jemangs | o/ | 15:03 |
mattmceuen | And others will probably follow suit | 15:03 |
Connoreika | %( | 15:03 |
roman_g | o/ | 15:03 |
mattmceuen | So we will be forgoing the in-person meeting at KubeCon, sadly | 15:03 |
Connoreika | We dont follow. | 15:03 |
mattmceuen | We were planning on having an Airship Meetup in KubeCon during the summit | 15:04 |
mattmceuen | to hash through some design topics etc face to face | 15:04 |
Connoreika | i saw that | 15:04 |
mattmceuen | ok cool :) | 15:04 |
mattmceuen | We do still plan to have a strong PTG session at the open infra / PTG conference in Vancouver | 15:05 |
*** pramchan63 has joined #airshipit | 15:05 | |
mattmceuen | In addition, we'd like to set up a "virtual meetup" for Airship around the same time as KubeCon, so we can have the same discussion we would have had, over telepresense | 15:05 |
*** uzumaki has joined #airshipit | 15:05 | |
mattmceuen | so please stay tuned for more info on that! | 15:05 |
Connoreika | Thats cool! | 15:05 |
mattmceuen | Yeah agree :) | 15:06 |
Connoreika | Zoom? | 15:06 |
mattmceuen | good question; zoom or webex or something similar | 15:06 |
roman_g | Zoom, WebEx, whatever. | 15:06 |
Connoreika | Cool | 15:06 |
*** ashferg has joined #airshipit | 15:07 | |
mattmceuen | Anything else on this one before moving on? | 15:07 |
pramchan63 | link #https://etherpad.openstack.org/p/airship-kubecon-amsterdam | 15:07 |
mattmceuen | let's deprecate that link please | 15:07 |
Connoreika | So we are not going on kubecon? | 15:07 |
*** zainub_wahid has joined #airshipit | 15:07 | |
pramchan63 | OK | 15:07 |
mattmceuen | since airship will not be at kubecon in amsterdam | 15:07 |
mattmceuen | Connoreika: AT&T and E/// will not be, but I can't speak for all corporations -- last I heard the conference is still going to happen | 15:08 |
Connoreika | Vancouver is much more expensive than Amsterdam %) | 15:08 |
mattmceuen | I was looking forward to seeing amsterdam too, never been there. Oh well, can't complain given the global situation | 15:09 |
Connoreika | Ok, sorry that interrupted, lets move on. | 15:09 |
mattmceuen | Ok, next topic: | 15:09 |
mattmceuen | no worries :) | 15:09 |
mattmceuen | #topic Slack<-> IRC sync'ing | 15:09 |
*** openstack changes topic to "Slack<-> IRC sync'ing (Meeting topic: airship)" | 15:09 | |
mattmceuen | Another follow up from last week | 15:09 |
Connoreika | Why do we need it to be synced? | 15:10 |
mattmceuen | There are some folks who are interested in joining through slack instead of the IRC client, and slack is the norm in the CNCF world | 15:10 |
mattmceuen | on the other hand, IRC has a lot of benefits too | 15:11 |
mattmceuen | so I was going to look into ways to use both and mirror the conversation | 15:11 |
mattmceuen | I put together a rough helm chart for one of them and am currently running it off my laptop | 15:11 |
mattmceuen | o/ airshipbot | 15:11 |
roman_g | We have had Slack previously, it didn't work out. Conversation sync could help, though. | 15:12 |
mattmceuen | My scrum master has joined from slack world as well | 15:12 |
airshipbot | <aw442m> I exist in both worlds | 15:12 |
mattmceuen | Yeah, I think the reason it didn't work out was that it was run kind of ad-hoc; that's why I wanted to have dependable k8s orchestration of it | 15:12 |
pramchan63 | which workspace in slack with which github - the sync? | 15:12 |
airshipbot | <aw442m> this is dwalt btw | 15:12 |
howell | which slack channel is that? | 15:12 |
mattmceuen | pramchan63: it's the "airshipproject" workspace in slack | 15:13 |
mattmceuen | I haven't made a push to invite everyone because I'm waiting to get it running somewhere besides my laptop :) | 15:13 |
mattmceuen | as it is not open 24 hours a day | 15:13 |
mattmceuen | Once we have a lab up and running (there are a couple in progress) then we can home the bot there permanently, otherwise I'll plan get it running on my home machine as a stopgap | 15:14 |
mattmceuen | Here's the chart, which links to the tool itself: https://github.com/mattmceuen/slack-irc-chart | 15:15 |
mattmceuen | That's all I had on this one. Any questions? | 15:15 |
roman_g | Nope. Thanks, Matt. | 15:15 |
Connoreika | Dont like slack. I like discord and telegram %) | 15:15 |
*** KeithMnemonic has quit IRC | 15:16 | |
mattmceuen | That's fair | 15:16 |
dwalt | Thanks for working on this Matt | 15:16 |
Connoreika | :) | 15:16 |
mattmceuen | If you'd like to integrate with those tools as well, that would be great Connoreika :) the more bots the merrier | 15:16 |
mattmceuen | #topic airshipctl non-descriptive variables | 15:17 |
*** openstack changes topic to "airshipctl non-descriptive variables (Meeting topic: airship)" | 15:17 | |
Connoreika | Im too stupid to write asuch a bot :) | 15:17 |
mattmceuen | (ie: https://opendev.org/airship/airshipctl/src/branch/master/pkg/config/cmds.go#L26) use of single letter, or two letter variables | 15:17 |
mattmceuen | it may already exist, who knows! | 15:17 |
mattmceuen | alexanderhughes: I think this one is yours! | 15:17 |
alexanderhughes | just a gentle suggestion, we have more and more developers joining the project daily. as they try to get up to speed making code easy to read I think is valuable. when we are initializing variables as things like "o" or "fo" it makes code more difficult to read, resulting in more frequent tracebacks to where the variable was initialized and what it is supposed to mean | 15:18 |
howell | so this is something that's pretty typical in go code | 15:19 |
howell | the rule in general is that the longer a variable is in use, the longer its name should be | 15:19 |
howell | but, | 15:19 |
mattmceuen | I mean the language is called "go" ;-) | 15:19 |
howell | I agree that it could get confusing | 15:19 |
mattmceuen | that's only one g better than o | 15:19 |
mattmceuen | that's - an interesting convention - I'd never heard it before, and kinda like the philosophy | 15:20 |
howell | I have no issue with disregarding the above rule. It's a bit weird anyway | 15:20 |
mattmceuen | yeah, "options" wouldn't be that many more keystrokes | 15:21 |
howell | mattmceuen: it makes sense at first | 15:21 |
alexanderhughes | there's no line limit length in go, so extra characters to make things clear would be helpful - especially for things we're passing in like func RunGetAuthInfo(o *AuthInfoOptions, out io.Writer, airconfig *Config) error { | 15:21 |
alexanderhughes | o here, to me should be something like authOptions | 15:21 |
alexanderhughes | throw away variables like when looping for i:=0, but things that are important to the function would be nice to be more legible | 15:21 |
mattmceuen | I think that's a very fair public service announcement, and a good thing to keep in mind as developers | 15:22 |
howell | ^This makes a lot of sense to me | 15:22 |
howell | specifically for function parameters | 15:22 |
howell | that will appear in documentation | 15:22 |
mattmceuen | ++ | 15:22 |
Connoreika | + with Alexander | 15:22 |
alexanderhughes | in any case that's my rant, I want to make things as easy as they can get for code reviewers, and for onboarding new developers. you may see a patchset from me here soon acting on that rant if the community is okay with more verbose variables | 15:23 |
mattmceuen | lol | 15:23 |
mattmceuen | no objections here, as long as we don't go to the other extreme | 15:23 |
howell | I think we can be a bit lax with variables declared within a functoin, but certainly any variable that is exposed should be more descriptive | 15:23 |
* mattmceuen shudders and remembers iphone programming APIs | 15:24 | |
alexanderhughes | yeah I'm not implementing authInfoOptionsForFunctionXonLineNumberTwentySevenUsedOnlyOneTime | 15:24 |
howell | lol or java. Get yourself a JavaBeanFactoryFactory | 15:24 |
alexanderhughes | but I think just a few more chars on most of these vars would be helpful | 15:24 |
roman_g | alexanderhughes: would you submit a patch to coding conventions in docs repo? Then we can add devs who do Go development work to +2/+1 it and collect feedback. | 15:24 |
alexanderhughes | roman_g: | 15:24 |
alexanderhughes | yeah I can take this action | 15:25 |
mattmceuen | only thing I'd caution is, I'd suggest we call it a guideline instead of a rule | 15:25 |
roman_g | alexanderhughes: that would be very good. Thank you. | 15:25 |
mattmceuen | as I'm sure there are exceptions | 15:25 |
mattmceuen | yeah, thanks for bringing up alexanderhughes, good discussion | 15:25 |
mattmceuen | next topic: | 15:25 |
mattmceuen | #topic gate enhancement idea (alexanderhughes) | 15:26 |
*** openstack changes topic to "gate enhancement idea (alexanderhughes) (Meeting topic: airship)" | 15:26 | |
mattmceuen | "make update-golden" to ensure tests are updated with test modifying changeset before code merges | 15:26 |
mattmceuen | https://review.opendev.org/#/c/710085/ for example does not modify config cmd "set-context" but when running make update-golden for new test addition unused test was removed | 15:26 |
roman_g | mattmceuen: Yes, coding guidelines, of course. Native exceptions are i,j,k,n,x,y,z in cycles, for an example. | 15:26 |
mattmceuen | roman_g: yep exactly | 15:26 |
alexanderhughes | so this was me as well. in our python projects such as Pegleg we implemented YAPF as a gate. basically ensuring that the code being submitted matched the formatting we expected with YAPF. I think a gate that did something similar ensuring that the test cases present in patch match what make update-golden would do (which updates the golden test data for each test) | 15:27 |
*** jtwill98 has joined #airshipit | 15:28 | |
alexanderhughes | so that we don't have missing, or inaccurate tests for a future patchset. our tests are only valuable if they are up to date and accurate | 15:28 |
howell | I'm not sure I understand | 15:28 |
mattmceuen | alexanderhughes: we should be wary of things that use codebase to generate the expected output of the current codebase -- do we avoid a "the code does what the code does" scenario? | 15:28 |
howell | golden files are just the "expected" output from unit tests | 15:28 |
dwalt | Shouldn't the unit tests fail if the golden files are not updated? | 15:29 |
dwalt | In this case, it just appeared that we had an extra one | 15:29 |
alexanderhughes | so from the example patch here, https://review.opendev.org/#/c/710085/ there was no change to config command "set-context" but I did update a new unit test. when I ran make update-golden it modified set-context | 15:29 |
mattmceuen | Agree, I think golden output changes need to be intentional, to guard against output changes that are accidental (bugs) | 15:29 |
alexanderhughes | this should have happened in a previous patchset | 15:29 |
howell | the above PS is unique in that it is the first time that we have /removed/ a golden file | 15:29 |
pramchan63 | Does removal of kubectl impact CI in Zuul? for testing | 15:29 |
howell | we should implement something to make sure there are no unused files | 15:30 |
alexanderhughes | I don't want to automatically update our codebase using zuul, I want to ensure that the tools we have to update are being run locally by devs and match expected results before merging | 15:30 |
dwalt | I think that's what howell is suggesting. Adding that check to the unit tests command | 15:31 |
alexanderhughes | that's fair, as the unit tests command is present in the gates | 15:31 |
alexanderhughes | any other opinions on this? | 15:33 |
Connoreika | nope | 15:33 |
howell | any idea on how to implement? | 15:33 |
howell | that's a detail, we can take that offline | 15:34 |
pramchan63 | May be bring it to design call? | 15:34 |
alexanderhughes | at a high level sounds like we run make unit-tests to ensure current code matches test cases, then make update-golden to see if anything gets deleted after the tests have passed. if there is a deletion fail the make command and advise user to run make update-golden | 15:34 |
jtwill98 | Unit test can be used to expose abandoned files in a report, but the team should take action to remove them with a PR. | 15:35 |
howell | alexanderhughes: that sounds like it should work | 15:35 |
mattmceuen | alexanderhughes: agree with that | 15:35 |
dwalt | that's a good idea | 15:36 |
dwalt | but then we need to add gate logic, right? | 15:36 |
*** zainub_wahid has quit IRC | 15:36 | |
dwalt | Since someone could unknowingly push without the updated golden files | 15:36 |
mattmceuen | pramchan63: sure, feel free to add to the design call agenda | 15:36 |
alexanderhughes | yes, the gate would have to run the logic above | 15:36 |
howell | dwalt: we could probably cram it all into the `unit-tests` target | 15:36 |
mattmceuen | but I think we can hash through it here (hopefully) | 15:36 |
dwalt | gotcha. So if some golden files get deleted, it just fails the test command? | 15:37 |
howell | that's what I would think | 15:37 |
alexanderhughes | we could move this into a new make command: test-and-update or similar. runs make unit-tests, runs make update-golden, searches for deletions, if present alert. update gate to use the new make target | 15:37 |
dwalt | Ok. That may be confusing to someone running locally, but it's better than having extra files. | 15:37 |
dwalt | Oh I like the new target idea alexanderhughes | 15:38 |
dwalt | That one gets run in the gate; dev can run make tests locally | 15:38 |
alexanderhughes | yes, gives granularity locally but achieves same end goal at the gate | 15:38 |
*** rpocase has joined #airshipit | 15:39 | |
dwalt | awesome. Good idea | 15:39 |
alexanderhughes | +/- votes on implementation? would like to get an issue created to summarize our thoughts and track the work | 15:39 |
dwalt | +1 | 15:40 |
mattmceuen | +1 | 15:40 |
Connoreika | + | 15:40 |
alexanderhughes | great thanks all, I'll get an issue created shortly | 15:40 |
pramchan63 | +1 | 15:40 |
mattmceuen | awesome - ty alex | 15:41 |
alexanderhughes | if there's more discussion needed on this we can followup @ flight plan call tomorrow | 15:41 |
pramchan63 | so I don't need this to be brought to design call? | 15:41 |
pramchan63 | Ok | 15:41 |
mattmceuen | I think we reached consensus here, probably no need to bring it up there | 15:41 |
mattmceuen | Ok, moving on: | 15:41 |
mattmceuen | #topic baremetal renaming changes merging tomorrow (04-March) (alexanderhughes) | 15:41 |
*** openstack changes topic to "baremetal renaming changes merging tomorrow (04-March) (alexanderhughes) (Meeting topic: airship)" | 15:41 | |
mattmceuen | per Jaakko Kuuskoski during 03-March Airship design call | 15:42 |
mattmceuen | https://github.com/metal3-io/cluster-api-provider-baremetal/pull/268 | 15:42 |
mattmceuen | https://github.com/metal3-io/metal3-dev-env/pull/239 | 15:42 |
mattmceuen | https://github.com/metal3-io/metal3-io.github.io/pull/153 | 15:42 |
alexanderhughes | just a quick announcement, Jaakko mentioned these are merging tomorrow during design call. just want to make sure anyone who wasn't present on that call has an opportunity to see it here | 15:42 |
mattmceuen | good idea. | 15:42 |
mattmceuen | The gist is that all the references to a generic "bare metal provider" are being renamed more specifically to "metal3 provider"-related naming | 15:43 |
mattmceuen | that will allow for the existance multiple bare metal providers | 15:43 |
pramchan63 | namesapce change in capi from CAPBM to CAPM3 - noted | 15:44 |
howell | I think it's more clear too. this is a good change | 15:44 |
Connoreika | + | 15:44 |
mattmceuen | Alright, moving on unless there's anything else on this topic? | 15:45 |
mattmceuen | #topic: how i can put trusted root ca in pods of airsloop installation? (Connoreika) | 15:45 |
*** openstack changes topic to ": how i can put trusted root ca in pods of airsloop installation? (Connoreika) (Meeting topic: airship)" | 15:45 | |
Connoreika | Yep | 15:45 |
mattmceuen | Connoreika's asked this a couple times in the chat, let's get him on the right direction: | 15:45 |
mattmceuen | I have MITM when i trying to download something from internet, and git doesn't want to clone repos. | 15:45 |
pramchan63 | on metal3.io side it's still on hold? | 15:46 |
*** timClicks has joined #airshipit | 15:46 | |
mattmceuen | This one is an airship 1 topic | 15:46 |
mattmceuen | Does anyone have a good reference at their fingertips for adding custom CAs to a deployment? | 15:46 |
dwalt | can you elaborate on what the man-in-the-middle is? A proxy server? | 15:46 |
pramchan63 | you mean airsloop of airship 1.x | 15:47 |
Connoreika | No, its security team, they listen all the traffic in company. | 15:47 |
uzumaki | dwalt, yeah, the proxy server, sort of | 15:48 |
dwalt | Do you still have a direct connection to the internet? | 15:48 |
Connoreika | Yes, direct connection. But they change certs on fly. | 15:48 |
dwalt | Uzumaki: if it's a proxy server, do you know its address? And does it require a certificate? | 15:49 |
uzumaki | well, the thing with MITM is, it's principally hidden from the client and server | 15:49 |
Connoreika | No, its not proxy. | 15:49 |
uzumaki | It's like Server <... SSLA...> MITM <...SSLB...> Client | 15:49 |
mattmceuen | Have you seen this example doc, Connoreika?: https://github.com/airshipit/treasuremap/blob/master/site/seaworthy/secrets/certificates/certificates.yaml | 15:50 |
Connoreika | Yes. exactly. | 15:50 |
mattmceuen | That one defines the certs, CAs for the seaworthy site | 15:50 |
mattmceuen | That might not apply for the "armada reaching out" case though | 15:51 |
Connoreika | But im not shure what to put in that example and where? | 15:51 |
pramchan63 | what does MITM mean ? #link https://airship-treasuremap.readthedocs.io/en/latest/airsloop.html | 15:51 |
mattmceuen | yeah, I retract that one | 15:51 |
uzumaki | pramchan63, Man-In-The-Middle, a way to snoop on SSL traffic | 15:51 |
Connoreika | And first problem is with armada :( | 15:51 |
pramchan63 | thanks so question of avoiding attacks through proxy is causing issues | 15:52 |
Connoreika | No. | 15:52 |
Connoreika | I have a root ca cert. | 15:53 |
*** arijit has joined #airshipit | 15:53 | |
Connoreika | Usually, i put it into the host system, and cert, that security team become signed. | 15:53 |
Connoreika | And trusted | 15:53 |
Connoreika | Althow it's selfsigned. | 15:54 |
uzumaki | yeah, just like server BMC https certs | 15:54 |
Connoreika | But, when we setup airship, it's startind armada in pod, and in that pod, it's doing git clone. | 15:55 |
Connoreika | That pod, doesnt know anything about my selfsignet cert. | 15:55 |
pramchan63 | i see | 15:55 |
Connoreika | So git clone - failed. Coz of fake cert. | 15:55 |
mattmceuen | is there any chance you can use a non-self-signed CA, e.g. letsencrypt? | 15:56 |
mattmceuen | I'm not sure this has been solved for within Airship unfortunately | 15:56 |
Connoreika | It's not me. Im in bank, and it's bank security team. | 15:56 |
mattmceuen | yeah, makes sense | 15:56 |
mattmceuen | hmm | 15:56 |
Connoreika | They listen that way alll the trafic from and to our bank. | 15:57 |
*** rezroo has quit IRC | 15:57 | |
mattmceuen | lol I guess SSL is working as designed.. now I understand the MITM reference | 15:58 |
uzumaki | haha | 15:58 |
uzumaki | is there a way to force local git client to accept self-signed certs? | 15:58 |
mattmceuen | can the MITM use a CA that's has a chain of trust back to the root CAs maybe? I know that's probably outside your control | 15:59 |
dwalt | #link https://stackoverflow.com/questions/11621768/how-can-i-make-git-accept-a-self-signed-certificate | 15:59 |
dwalt | it appears so | 15:59 |
mattmceuen | We're out of time for the meeting, but let's please keep the conversation going here... | 15:59 |
mattmceuen | Requests for review: | 15:59 |
mattmceuen | https://review.opendev.org/#/c/711019/ - drydock, security alert for 2 CVEs relating to old packages | 15:59 |
mattmceuen | https://review.opendev.org/#/c/710085/ - remove kubectl subcommand from airshipctl | 15:59 |
mattmceuen | https://review.opendev.org/#/c/710469/ - refactor of airshipctl types to be golint compliant | 15:59 |
uzumaki | it can actually, but the thing is, going back to root ca might cost you a license | 15:59 |
Connoreika | What i do usually | 15:59 |
mattmceuen | Review on those please :) ^^ | 15:59 |
uzumaki | and on the flip side, that will make the MITM even more sneaky | 15:59 |
mattmceuen | #endmeeting | 16:00 |
*** openstack changes topic to "https://opendev.org/airship || https://wiki.openstack.org/wiki/Airship || https://review.opendev.org/#/q/projects:airship+status:open+NOT+label:Verified%253D-1+NOT+label:Workflow%253D-1+NOT+message:DNM+NOT+message:WIP" | 16:00 | |
openstack | Meeting ended Tue Mar 3 16:00:02 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/airship/2020/airship.2020-03-03-15.00.html | 16:00 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/airship/2020/airship.2020-03-03-15.00.txt | 16:00 |
openstack | Log: http://eavesdrop.openstack.org/meetings/airship/2020/airship.2020-03-03-15.00.log.html | 16:00 |
Connoreika | Uploaded file: https://uploads.kiwiirc.com/files/3cbe9ffb64f03d02c75342556640d448/pasted.txt | 16:00 |
Connoreika | Uploaded file: https://uploads.kiwiirc.com/files/b6745ece81baf7e27517e2ba972fc51a/image.png | 16:00 |
Connoreika | Uploaded file: https://uploads.kiwiirc.com/files/ea4243400bb4b6c312873ceb58acb9cd/image.png | 16:00 |
alexanderhughes | thanks all | 16:00 |
dwalt | I imagine that getting your cert in the pod would fix this | 16:00 |
Connoreika | Yes. | 16:00 |
mattmceuen | yeah | 16:00 |
mattmceuen | building a custom image | 16:00 |
dwalt | ++ | 16:00 |
mattmceuen | and then passing that image in as a helm values override | 16:00 |
uzumaki | yeah, or somehow 'convince' git everywhere to use self-signed certs (which now sounds like a bad idea) | 16:00 |
mattmceuen | you could just base an image off the existing image and add your CA in? | 16:01 |
mattmceuen | lol uzumaki | 16:01 |
Connoreika | Thats bad way. | 16:01 |
uzumaki | very bad indeed :-) | 16:01 |
Connoreika | Coz i think, i need to do that with all the images. | 16:01 |
Connoreika | https://medium.com/@paraspatidar/add-ssl-tls-certificate-or-pem-file-to-kubernetes-pod-s-trusted-root-ca-store-7bed5cd683d | 16:02 |
jtwill98 | Does the bank have a signing server where you can submit cert that they sign? | 16:02 |
Connoreika | https://medium.com/@paraspatidar/add-self-signed-or-ca-root-certificate-in-kubernetes-pod-ca-root-certificate-store-cb7863cb3f87 | 16:02 |
Connoreika | I have a cert that submit fake cert as valid. | 16:03 |
Connoreika | That 2 links is how people usually do. | 16:04 |
Connoreika | But i thought that you have in airship some standart way to do this. | 16:04 |
mattmceuen | unfortunately I don't think so :( | 16:05 |
mattmceuen | But hopefully the dockerfile approach will be pretty straightforward | 16:05 |
Connoreika | Coz you are doing something with certs during instalation | 16:05 |
Connoreika | Thats how i do on regular host: https://uploads.kiwiirc.com/files/3cbe9ffb64f03d02c75342556640d448/pasted.txt | 16:07 |
*** nasirkamal has quit IRC | 16:07 | |
*** uzumaki has quit IRC | 16:07 | |
Connoreika | Well any idea? | 16:08 |
mattmceuen | Best idea I have is just use a small dockerfile, FROM the upstream armada image, that adds in your CA per that doc | 16:08 |
mattmceuen | you'd need to host the image in a docker registry that's accessible from the cluster | 16:09 |
mattmceuen | and then you can change your versions.yaml file to use your image instead of the default upstream one | 16:09 |
jtwill98 | Did the k8 (Method 3— Kubernets Deployment Yaml / Helm changes) approach not work for you? | 16:10 |
Connoreika | Thats a bit overhead, docker registry, patching. | 16:11 |
Connoreika | jtwill98 dont know. Will it? | 16:11 |
rpocase | Is there an equivalent set of FQDN names (from https://airship-treasuremap.readthedocs.io/en/latest/authoring_and_deployment.html#register-dns-names) to define for an architecture initially based on airsloop? I'm getting back around to building a small cluster and was hoping to start with something airsloop based for simplicity and add nodes as the initial authoring is proved out. Or perhaps thats a | 16:14 |
rpocase | flawed plan and I should start with seaworthy with less nodes? I'll ultimately have 2 controllers/2 workers with each node having very different hardware | 16:14 |
jtwill98 | Just reading that seems like the best approach and entirely script-able. Although if kuebctl is not available ... it won't be possible. | 16:15 |
mattmceuen | rpocase: I think airsloop is probably an easier place to start; you can always add in bits and pieces of seaworthy as you need them | 16:16 |
mattmceuen | airsloop and seaworthy are just different example manifest sets -- you can adjust them to fit your needs | 16:16 |
mattmceuen | (i.e. something "in between" the two of them) | 16:16 |
Connoreika | jtwill98 ? | 16:16 |
*** pramchan63 has quit IRC | 16:17 | |
*** ab2434_ has quit IRC | 16:17 | |
Connoreika | Well guys? What i need to do? | 16:18 |
Connoreika | Docker registry and custom images? | 16:19 |
dwalt | I would personally try the custom images approach first, in order to make sure it works. Then, we can formulate a long-term solution. | 16:19 |
dwalt | You can push your custom images to dockerhub or quay.io | 16:20 |
Connoreika | I also think to do something with proxy. Set up a local proxy, that have root certs, and try to download everything through it. What do you think? | 16:22 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#11] Implement selector kustomize primitive https://review.opendev.org/709252 | 16:23 |
Connoreika | ? | 16:26 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [#81][WIP] makefile to check for unused test data https://review.opendev.org/711050 | 16:27 |
dwalt | Connoreika: Sorry, I'm not familiar enough to know if that would work. If it's less effort, it may be worth a try. | 16:30 |
dwalt | Though the base images approach seems easiest. For our deployments, we always build custom images using known, scanned base images. That's very standard and something you'll probably want to do if you run Airship in a production environment. | 16:30 |
Connoreika | Is there any automation on building images? | 16:32 |
rpocase | mattmceuen: Thanks! Sounds like start with airsloop, ignore fqdn for now, and merge in manifest sets as I have use cases for htenm | 16:32 |
rpocase | s/htenm/them | 16:32 |
dwalt | Yes, you can use the Makefile in each project. Just run `make images FROM=<your base image>` | 16:32 |
dwalt | Where your base image is a base Ubuntu image that has your certificate | 16:32 |
dwalt | Then, you can push your custom image and change the chart values like mattmceuen suggested :) | 16:34 |
Connoreika | Ok. Tu very much. Will try some cases. | 16:34 |
Connoreika | Firs will try with proxy. | 16:35 |
Connoreika | Seems easyest way. | 16:35 |
dwalt | Connoreika: Sure thing. Let us know if anything comes up :) | 16:35 |
Connoreika | Also question, in future, when there will be image to upload and it will make all jobs, will it contain in itself all needed git/apt/docker/pyp stuff so other nodes wont need to go in internet and downoad anything? | 16:37 |
*** timClicks has quit IRC | 16:38 | |
dwalt | Everything gets downloaded during the build process https://opendev.org/airship/armada/src/branch/master/images/armada/Dockerfile.ubuntu_bionic | 16:39 |
dwalt | When deploying the Helm chart + image into K8s, everything is already contained within the image. | 16:39 |
Connoreika | dwalt, no, you didnt understand. In airship2.0, there will be deploy image. | 16:41 |
Connoreika | Will it contain all that needed for other nodes, and those nodes will download everything from "genesis" node | 16:42 |
*** Connoreika has quit IRC | 16:46 | |
AlexNoskov | Hi, could please someone review/merge the following PS: https://review.opendev.org/#/c/690392/ https://review.opendev.org/#/c/680495/ https://review.opendev.org/709638, two of them already have +2 | 17:03 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#11] Implement selector kustomize primitive https://review.opendev.org/709252 | 17:07 |
openstackgerrit | Prateek Dodda proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Worker https://review.opendev.org/692224 | 17:12 |
*** SRao has quit IRC | 17:18 | |
*** jojensen has joined #airshipit | 17:20 | |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [#81][WIP] makefile to check for unused test data https://review.opendev.org/711050 | 17:23 |
*** rpocase has quit IRC | 17:29 | |
*** jojensen has quit IRC | 17:31 | |
*** evrardjp has quit IRC | 17:35 | |
*** evrardjp has joined #airshipit | 17:35 | |
airshipbot | <andrew.schiefelbein> Hail and well met | 17:37 |
roman_g | Hi. | 17:38 |
*** mfuller has joined #airshipit | 17:39 | |
*** jojensen has joined #airshipit | 17:40 | |
*** jojensen has quit IRC | 17:40 | |
airshipbot | <kk6740> hey hey! | 17:45 |
dwalt | o/ | 17:46 |
*** nasir has joined #airshipit | 17:48 | |
openstackgerrit | Merged airship/porthole master: Fix helm Installation Script in Apparmor Scripts https://review.opendev.org/710178 | 17:49 |
openstackgerrit | Merged airship/deckhand master: (fix) Address uwsgi and other gating issues https://review.opendev.org/708958 | 17:55 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 18:01 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 18:09 |
openstackgerrit | Ian Pittwood proposed airship/airshipctl master: [WIP][#35] Refactor config package https://review.opendev.org/710097 | 18:09 |
openstackgerrit | sai battina proposed airship/airshipctl master: Add proxy to systemwide-executable roles https://review.opendev.org/711079 | 18:15 |
openstackgerrit | sai battina proposed airship/airshipctl master: Add proxy to systemwide-executable roles https://review.opendev.org/711079 | 18:16 |
*** SRao has joined #airshipit | 18:21 | |
openstackgerrit | Merged airship/treasuremap master: Extend VM's configuration with NUMA/CPU/Memory/NIC changes https://review.opendev.org/690392 | 18:22 |
*** rezroo has joined #airshipit | 18:23 | |
roman_g | AlexNoskov: done. | 18:23 |
AlexNoskov | Thanks | 18:24 |
openstackgerrit | sai battina proposed airship/airshipctl master: Add proxy to systemwide-executable roles https://review.opendev.org/711079 | 18:38 |
airshipbot | <lindsey.durway> This is my first slack message. Today I am a man! | 18:39 |
airshipbot | <andrew.schiefelbein> Welcome! | 18:40 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [#81][WIP] makefile to check for unused test data https://review.opendev.org/711050 | 18:40 |
airshipbot | <lindsey.durway> Thank you, mon frere. | 18:40 |
openstackgerrit | Alexander Hughes proposed airship/airshipctl master: [#81][WIP] makefile to check for unused test data https://review.opendev.org/711050 | 18:41 |
*** gagehugo has joined #airshipit | 18:43 | |
*** michael-beaver has quit IRC | 19:13 | |
openstackgerrit | Prateek Dodda proposed airship/shipyard master: [WIP] Implement Security Context for Airflow_Worker https://review.opendev.org/692224 | 19:21 |
*** SRao has quit IRC | 19:39 | |
openstackgerrit | sai battina proposed airship/airshipctl master: Add proxy to systemwide-executable roles https://review.opendev.org/711079 | 19:46 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] [WIP] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 19:47 |
openstackgerrit | Matthew Fuller proposed airship/treasuremap master: Add support for modifying genesis kernel parameters for OVS-DPDK https://review.opendev.org/709638 | 20:14 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: Enable Docker default AppArmor profile to maas https://review.opendev.org/705136 | 20:19 |
openstackgerrit | Ahmad Mahmoudi proposed airship/shipyard master: WIP: (fix) Address image build issues, bionic https://review.opendev.org/709056 | 20:20 |
openstackgerrit | diwakar thyagaraj proposed airship/maas master: [WIP] Enable Logs Append for maas https://review.opendev.org/709763 | 20:30 |
openstackgerrit | Alexander Noskov proposed airship/treasuremap master: Add unsafe profile for disk VM's https://review.opendev.org/710480 | 20:53 |
*** aaronsheffield has quit IRC | 20:55 | |
openstackgerrit | eric welch proposed airship/deckhand master: deleting extra comments https://review.opendev.org/693935 | 21:10 |
openstackgerrit | Prateek Dodda proposed airship/divingbell master: Implement Security Context for Divingbell https://review.opendev.org/707885 | 21:16 |
*** ashferg has quit IRC | 21:16 | |
openstackgerrit | Merged airship/airshipctl master: [#58] Update types for golint https://review.opendev.org/710469 | 21:18 |
*** SRao has joined #airshipit | 21:20 | |
*** happyhemant has quit IRC | 21:29 | |
*** rezroo has quit IRC | 21:32 | |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#75] Add functionality to set libvirt sec driver https://review.opendev.org/710889 | 21:36 |
*** SRao has quit IRC | 21:40 | |
*** dpawlik has quit IRC | 22:00 | |
openstackgerrit | Jordan Kramer proposed airship/armada master: [WIP] Added Password Rotation Gate https://review.opendev.org/708538 | 22:07 |
openstackgerrit | Ahmad Mahmoudi proposed airship/shipyard master: WIP: (fix) Address image build issues, bionic https://review.opendev.org/709056 | 22:08 |
*** segorov has joined #airshipit | 22:26 | |
openstackgerrit | Jordan Kramer proposed airship/armada master: [WIP] Added Password Rotation Gate https://review.opendev.org/708538 | 22:26 |
openstackgerrit | Kostyantyn Kalynovskyi proposed airship/airshipctl master: [#11] Implement selector kustomize primitive https://review.opendev.org/709252 | 22:31 |
openstackgerrit | Ahmad Mahmoudi proposed airship/shipyard master: WIP: (fix) Address image build issues, bionic https://review.opendev.org/709056 | 22:32 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: [#21] - prompt for config init options https://review.opendev.org/710180 | 22:33 |
openstackgerrit | Ahmad Mahmoudi proposed airship/shipyard master: (fix) Address image build issues, bionic https://review.opendev.org/709056 | 22:34 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: [#21] - prompt for config init options https://review.opendev.org/710180 | 22:41 |
openstackgerrit | Jagan Mohan Kavva proposed airship/maas master: Enable Docker default AppArmor profile to maas https://review.opendev.org/705136 | 22:42 |
openstackgerrit | Jagan Mohan Kavva proposed airship/maas master: Enable Docker default AppArmor profile to maas https://review.opendev.org/705136 | 22:42 |
openstackgerrit | Sirajudeen proposed airship/airshipctl master: [#21] - prompt for config init options https://review.opendev.org/710180 | 22:43 |
openstackgerrit | Jordan Kramer proposed airship/armada master: [WIP] Added Password Rotation Gate https://review.opendev.org/708538 | 22:56 |
openstackgerrit | Prateek Dodda proposed airship/divingbell master: Implement Security Context for Divingbell https://review.opendev.org/707885 | 23:00 |
airshipbot | <mattmceuen> Review on this would be appreciated: https://review.opendev.org/#/c/708132/5 | 23:03 |
*** airshipbot has quit IRC | 23:33 | |
openstackgerrit | Krishna Venkata proposed airship/airshipctl master: [lint]: Fix indentation https://review.opendev.org/711128 | 23:43 |
*** dwalt has quit IRC | 23:44 | |
openstackgerrit | sai battina proposed airship/airshipctl master: Add proxy to systemwide-executable roles https://review.opendev.org/711079 | 23:56 |
*** segorov has quit IRC | 23:56 | |
*** segorov has joined #airshipit | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!